login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
feed
»
Unknown
»
from
Re: [PATCH] alsa: riptide: don't use own hex_to_bin() method
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Takashi Iwai
Subject:
Re: [PATCH] alsa: riptide: don't use own hex_to_bin() method
Date: Thursday, June 17, 2010 - 12:43 am
At Tue, 15 Jun 2010 17:26:28 +0300, Andy Shevchenko wrote:
quoted text
> > From: Andy Shevchenko <ext-andriy.shevchenko@nokia.com> > > Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com> > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: Takashi Iwai <tiwai@suse.de> > Cc:
alsa-devel@alsa-project.org
Applied now. Thanks. Takashi
quoted text
> --- > sound/pci/riptide/riptide.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c > index ad44626..59d7996 100644 > --- a/sound/pci/riptide/riptide.c > +++ b/sound/pci/riptide/riptide.c > @@ -97,6 +97,7 @@ > #include <linux/gameport.h> > #include <linux/device.h> > #include <linux/firmware.h> > +#include <linux/kernel.h> > #include <asm/io.h> > #include <sound/core.h> > #include <sound/info.h> > @@ -667,13 +668,12 @@ static u32 atoh(const unsigned char *in, unsigned int len) > unsigned char c; > > while (len) { > + int value; > + > c = in[len - 1]; > - if ((c >= '0') && (c <= '9')) > - sum += mult * (c - '0'); > - else if ((c >= 'A') && (c <= 'F')) > - sum += mult * (c - ('A' - 10)); > - else if ((c >= 'a') && (c <= 'f')) > - sum += mult * (c - ('a' - 10)); > + value = hex_to_bin(c); > + if (value >= 0) > + sum += mult * value; > mult *= 16; > --len; > } > -- > 1.6.6.1 >
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] alsa: riptide: don't use own hex_to_bin() method
, Andy Shevchenko
, (Tue Jun 15, 7:26 am)
Re: [PATCH] alsa: riptide: don't use own hex_to_bin() method
, Takashi Iwai
, (Thu Jun 17, 12:43 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Og dreams of kernels
Jens Axboe
[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann
Re: finding your own dead "CONFIG_" variables
Mark Brown
[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds
[LGUEST] Look in object dir for .config
git
:
Brian Downing
Re: Git in a Nutshell guide
John Benes
Re: master has some toys
Matthias Lederhofer
[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian
[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano
Re: Rss produced by git is not valid xml?
git-commits-head
:
Linux Kernel Mailing List
iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List
ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List
ixgbe: fix several counter register errata
Linux Kernel Mailing List
b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List
9p: block-based virtio client
linux-netdev
:
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
David Daney
[PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI.
Wolfgang Grandegger
[PATCH net-next v4 1/3] can: mscan: fix improper return if dlc < 8 in start_xmi...
Amit Kumar Salecha
[PATCHv3 NEXT 2/2] NET: Add Qlogic ethernet driver for CNA devices
openbsd-misc
:
Theo de Raadt
Re: Old IPSEC bug
Tomáš Bodžár
Problem with vpnc connection - check group password !
Insan Praja SW
Mandoc Compiling Error
Carl Roberso
Re: Cannot change MTU of carp interface?
Richard Daemon
Re: booting openbsd on eee without cd-rom
Colocation donated by:
Syndicate