Home » Mailing list archives » linux-kernel » 2011 » January » 4

Re: [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe()

Previous thread: [PATCH] crypto: dont return PTR_ERR() of wrong pointer by roel kluin on Friday, December 31, 2010 - 8:21 am. (2 messages)

Next thread: [PATCH 1/7] dma/shdma.c Typo change desciptor to descriptor. by Justin P. Mattock on Friday, December 31, 2010 - 10:38 am. (1 message)
[view original message]
From: roel kluin
Subject: [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe()
Date: Friday, December 31, 2010 - 8:26 am

The index is missing so the return is wrong.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
 drivers/regulator/isl6271a-regulator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/isl6271a-regulator.c b/drivers/regulator/isl6271a-regulator.c
index b8cc638..13e2073 100644
--- a/drivers/regulator/isl6271a-regulator.c
+++ b/drivers/regulator/isl6271a-regulator.c
@@ -169,7 +169,7 @@ static int __devinit isl6271a_probe(struct i2c_client *i2c,
 						init_data, pmic);
 		if (IS_ERR(pmic->rdev[i])) {
 			dev_err(&i2c->dev, "failed to register %s\n", id->name);
-			err = PTR_ERR(pmic->rdev);
+			err = PTR_ERR(pmic->rdev[i]);
 			goto error;
 		}
 	}
--


[ message continues ]
[view original message]
From: Mark Brown
Subject: Re: [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe()
Date: Sunday, January 2, 2011 - 5:37 am

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
--


[ message continues ]
[view original message]
From: Liam Girdwood
Subject: Re: [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe()
Date: Tuesday, January 4, 2011 - 1:51 pm

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--


[ message continues ]
Previous thread: [PATCH] crypto: dont return PTR_ERR() of wrong pointer by roel kluin on Friday, December 31, 2010 - 8:21 am. (2 messages)

Next thread: [PATCH 1/7] dma/shdma.c Typo change desciptor to descriptor. by Justin P. Mattock on Friday, December 31, 2010 - 10:38 am. (1 message)