Re: [patch] xenfb: fix xenfb suspend/resume race

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ian Campbell
Date: Tuesday, January 4, 2011 - 4:15 am

On Thu, 2010-12-30 at 16:40 +0000, Konrad Rzeszutek Wilk wrote:

I also don't see how the patch relates to the stack trace.

Is the issue is that xenfb_send_event is called between xenfb_resume
(which tears down the state, including evtchn->irq binding) and the
probe/connect of the new fb?

I suspect xenfb_resume should set info->update_wanted to 0. This will
defer updates until we have successfully reconnected.

Otherwise, since xenfb_resume also calls xenfb_connect I presume the
call of xenfb_send_event is asynchronous. Which would suggest that some
other locking is missing.

Ian.




--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] xenfb: fix xenfb suspend/resume race, Joe Jin, (Thu Dec 30, 5:56 am)
Re: [patch] xenfb: fix xenfb suspend/resume race, Konrad Rzeszutek Wilk, (Thu Dec 30, 9:40 am)
Re: [patch] xenfb: fix xenfb suspend/resume race, Joe Jin, (Thu Dec 30, 5:56 pm)
Re: [Xen-devel] Re: [patch] xenfb: fix xenfb suspend/resum ..., Konrad Rzeszutek Wilk, (Mon Jan 3, 9:34 am)
Re: [patch] xenfb: fix xenfb suspend/resume race, Ian Campbell, (Tue Jan 4, 4:15 am)