Home » Mailing list archives » linux-kernel » 2011 » January » 3

Re: [PATCH] smsc-ircc2: Fix section mismatch derived from smsc_ircc_pnp_driver variable

Previous thread: [PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable by Sedat Dilek on Sunday, January 2, 2011 - 7:01 pm. (3 messages)

Next thread: [PATCH] depca: Fix section mismatch derived from depca_isa_driver variable by Sedat Dilek on Sunday, January 2, 2011 - 7:33 pm. (3 messages)
[view original message]
From: Sedat Dilek
Subject: [PATCH] smsc-ircc2: Fix section mismatch derived from smsc_ircc_pnp_driver variable
Date: Sunday, January 2, 2011 - 7:28 pm

From my build.log:

drivers/net/irda/smsc-ircc2.o(.data+0x18): Section mismatch in reference from the variable smsc_ircc_pnp_driver to the function .init.text:smsc_ircc_pnp_probe()
The variable smsc_ircc_pnp_driver references
the function __init smsc_ircc_pnp_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,

This patch fixes the warning.

Tested with linux-next (next-20101231)

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 drivers/net/irda/smsc-ircc2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/irda/smsc-ircc2.c b/drivers/net/irda/smsc-ircc2.c
index 8c57bfb..0ebd4a8 100644
--- a/drivers/net/irda/smsc-ircc2.c
+++ b/drivers/net/irda/smsc-ircc2.c
@@ -397,7 +397,7 @@ static int __init smsc_ircc_pnp_probe(struct pnp_dev *dev,
 	return 0;
 }
 
-static struct pnp_driver smsc_ircc_pnp_driver = {
+static struct pnp_driver smsc_ircc_pnp_driver __refdata = {
 	.name		= "smsc-ircc2",
 	.id_table	= smsc_ircc_pnp_table,
 	.probe		= smsc_ircc_pnp_probe,
-- 
1.7.4.rc0

--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH] smsc-ircc2: Fix section mismatch derived from smsc_ircc_pnp_driver variable
Date: Monday, January 3, 2011 - 12:53 pm

From: Sedat Dilek <sedat.dilek@googlemail.com>

Just like your other patch, this fix is not correct.

Mark smsc_ircc_pbp_probe() as __devinit instead of __init to fix
this bug.
--


[ message continues ]
[view original message]
From: Sedat Dilek
Subject: Re: [PATCH] smsc-ircc2: Fix section mismatch derived from smsc_ircc_pnp_driver variable
Date: Monday, January 3, 2011 - 2:16 pm

I have sent a new fixed version.

- Sedat -
--


[ message continues ]
Previous thread: [PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable by Sedat Dilek on Sunday, January 2, 2011 - 7:01 pm. (3 messages)

Next thread: [PATCH] depca: Fix section mismatch derived from depca_isa_driver variable by Sedat Dilek on Sunday, January 2, 2011 - 7:33 pm. (3 messages)