Home » Mailing list archives » linux-kernel » 2011 » January » 3

Re: [PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable

Previous thread: [PATCH] gx1fb: Fix section mismatch derived from gx1fb_driver variable by Sedat Dilek on Sunday, January 2, 2011 - 6:31 pm. (1 message)

Next thread: [PATCH] smsc-ircc2: Fix section mismatch derived from smsc_ircc_pnp_driver variable by Sedat Dilek on Sunday, January 2, 2011 - 7:28 pm. (3 messages)
[view original message]
From: Sedat Dilek
Subject: [PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable
Date: Sunday, January 2, 2011 - 7:01 pm

WARNING: drivers/net/ksz884x.o(.data+0x18): Section mismatch in reference from the variable pci_device_driver to the function .init.text:pcidev_init()
The variable pci_device_driver references
the function __init pcidev_init()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,

This patch fixes the warning.

Tested with linux-next (next-20101231)

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 drivers/net/ksz884x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c
index 49ea870..515b0d7 100644
--- a/drivers/net/ksz884x.c
+++ b/drivers/net/ksz884x.c
@@ -7277,7 +7277,7 @@ static struct pci_device_id pcidev_table[] = {
 
 MODULE_DEVICE_TABLE(pci, pcidev_table);
 
-static struct pci_driver pci_device_driver = {
+static struct pci_driver pci_device_driver __refdata = {
 #ifdef CONFIG_PM
 	.suspend	= pcidev_suspend,
 	.resume		= pcidev_resume,
-- 
1.7.4.rc0

--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable
Date: Monday, January 3, 2011 - 12:52 pm

From: Sedat Dilek <sedat.dilek@googlemail.com>

pcidev_init() should be marked __devinit instead of __init to fix this
bug.
--


[ message continues ]
[view original message]
From: Sedat Dilek
Subject: Re: [PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable
Date: Monday, January 3, 2011 - 2:07 pm

I have sent a new fixed version.

- Sedat -
--


[ message continues ]
Previous thread: [PATCH] gx1fb: Fix section mismatch derived from gx1fb_driver variable by Sedat Dilek on Sunday, January 2, 2011 - 6:31 pm. (1 message)

Next thread: [PATCH] smsc-ircc2: Fix section mismatch derived from smsc_ircc_pnp_driver variable by Sedat Dilek on Sunday, January 2, 2011 - 7:28 pm. (3 messages)