> From:
johnstul.lkml@gmail.com [mailto:johnstul.lkml@gmail.com] On Behalf Of john stultz
> Sent: Tuesday, December 28, 2010 5:27 AM
> To: Guan Xuetao
> Cc: linux-arch@vger.kernel.org;
linux-kernel@vger.kernel.org
> Subject: Re: [PATCHv1 09/12] unicore32 core architecture: timer and time
>
> 2010/12/25 Guan Xuetao <guanxuetao@mprc.pku.edu.cn>:
> > From: Guan Xuetao <guanxuetao@mprc.pku.edu.cn>
> >
> > Patch 9 implements timer and time. RTC and PWM device drivers are also here.
> >
> > Signed-off-by: Guan Xuetao <guanxuetao@mprc.pku.edu.cn>
>
> Just a small request:
>
> > +static struct clocksource cksrc_puv3_oscr = {
> > + .name = "oscr",
> > + .rating = 200,
> > + .read = puv3_read_oscr,
> > + .mask = CLOCKSOURCE_MASK(32),
> > + .shift = 18,
>
> Drop the shift assignment here.
>
> > + cksrc_puv3_oscr.mult =
> > + clocksource_hz2mult(CLOCK_TICK_RATE, cksrc_puv3_oscr.shift);
> > +
> Drop the mult assignment here.
>
>
> > + clocksource_register(&cksrc_puv3_oscr);
>
> Use "clocksource_register_hz(&cksrc_puv3_oscr, CLOCK_TICK_RATE );" and
> the kernel will fill in mult/shift appropriately.
>
> If you have any troubles after doing so, let me know.
