login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
September
»
22
Re: [PATCH] avoid second smp_processor_id() call in __touch_watchdog
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Peter Zijlstra
Subject:
Re: [PATCH] avoid second smp_processor_id() call in __touch_watchdog
Date: Wednesday, September 22, 2010 - 9:39 am
On Wed, 2010-09-22 at 18:27 +0200, Frederic Weisbecker wrote:
quoted text
> > I'm not sure we want this. This is called by the watchdog internally, > from the timer or the cpu bound thread, so we probably should better > keep __get_cpu_var() because it checks that we are not in a preemptable > section.
The smp_processor_id() right at the start already does that. That said, I doubt it really matter one way or the other, compilers have been known to do CSE for quite a while. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
fix BUG: using smp_processor_id() in touch_nmi_watchdog an ...
, Sergey Senozhatsky
, (Fri Aug 13, 3:21 am)
Re: fix BUG: using smp_processor_id() in touch_nmi_watchdo ...
, Peter Zijlstra
, (Mon Aug 16, 1:22 am)
Re: fix BUG: using smp_processor_id() in touch_nmi_watchdo ...
, Don Zickus
, (Mon Aug 16, 6:34 am)
Re: fix BUG: using smp_processor_id() in touch_nmi_watchdo ...
, Peter Zijlstra
, (Mon Aug 16, 6:46 am)
Re: fix BUG: using smp_processor_id() in touch_nmi_watchdo ...
, Yong Zhang
, (Mon Aug 16, 7:06 am)
[PATCH] fix BUG using smp_processor_id() in touch_nmi_watc ...
, Sergey Senozhatsky
, (Mon Aug 16, 7:08 am)
Re: fix BUG: using smp_processor_id() in touch_nmi_watchdo ...
, Don Zickus
, (Mon Aug 16, 7:12 am)
Re: fix BUG: using smp_processor_id() in touch_nmi_watchdo ...
, Peter Zijlstra
, (Mon Aug 16, 7:29 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Don Zickus
, (Mon Aug 16, 7:30 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Frederic Weisbecker
, (Mon Aug 16, 7:59 pm)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Yong Zhang
, (Mon Aug 16, 8:16 pm)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Yong Zhang
, (Mon Aug 16, 9:27 pm)
[PATCH] fix BUG using smp_processor_id() in touch_nmi_watc ...
, Sergey Senozhatsky
, (Tue Aug 17, 12:56 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Sergey Senozhatsky
, (Tue Aug 17, 1:39 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Yong Zhang
, (Tue Aug 17, 2:05 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Sergey Senozhatsky
, (Tue Aug 17, 2:24 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Yong Zhang
, (Tue Aug 17, 2:37 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Sergey Senozhatsky
, (Tue Aug 17, 3:28 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Sergey Senozhatsky
, (Tue Aug 17, 3:39 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Yong Zhang
, (Tue Aug 17, 5:48 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Yong Zhang
, (Tue Aug 17, 5:56 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Don Zickus
, (Tue Aug 17, 6:13 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Frederic Weisbecker
, (Tue Aug 17, 7:48 pm)
Re: fix BUG: using smp_processor_id() in touch_nmi_watchdo ...
, Andrew Morton
, (Wed Aug 18, 12:33 pm)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Andrew Morton
, (Wed Aug 18, 1:01 pm)
Re: fix BUG: using smp_processor_id() in touch_nmi_watchdo ...
, Cyrill Gorcunov
, (Wed Aug 18, 2:44 pm)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Don Zickus
, (Wed Aug 18, 7:27 pm)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Don Zickus
, (Thu Aug 19, 7:57 pm)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Andrew Morton
, (Thu Aug 19, 8:42 pm)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Don Zickus
, (Fri Aug 20, 5:34 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Yong Zhang
, (Fri Aug 20, 8:02 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Maxim Levitsky
, (Thu Aug 26, 3:14 am)
Re: [PATCH] fix BUG using smp_processor_id() in touch_nmi_ ...
, Don Zickus
, (Thu Aug 26, 7:40 am)
acpi_os_stall() and touch_nmi_watchdog() (was Re: [PATCH] ...
, Len Brown
, (Thu Aug 26, 10:17 am)
[PATCH] avoid second smp_processor_id() call in __touch_wa ...
, Sergey Senozhatsky
, (Wed Sep 22, 2:00 am)
Re: [PATCH] avoid second smp_processor_id() call in __touc ...
, Don Zickus
, (Wed Sep 22, 7:41 am)
Re: [PATCH] avoid second smp_processor_id() call in __touc ...
, Frederic Weisbecker
, (Wed Sep 22, 9:27 am)
Re: [PATCH] avoid second smp_processor_id() call in __touc ...
, Peter Zijlstra
, (Wed Sep 22, 9:39 am)
Re: [PATCH] avoid second smp_processor_id() call in __touc ...
, Frederic Weisbecker
, (Wed Sep 22, 9:47 am)
Re: [PATCH] avoid second smp_processor_id() call in __touc ...
, Don Zickus
, (Fri Sep 24, 12:34 pm)
Re: [PATCH] avoid second smp_processor_id() call in __touc ...
, Sergey Senozhatsky
, (Sat Sep 25, 10:43 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ingo Molnar
Re: [PATCH 0/3] v2 Make hierarchical RCU less IPI-happy and add more tracing
Jeremy Fitzhardinge
Re: Linux 2.6.28.10 and Linux 2.6.29.6 XEN Guest Support Broken x86_64 in BUILD
Nick Piggin
Re: [patch] CFS (Completely Fair Scheduler), v2
Gary Hade
Re: [PATCH 0/5][RFC] Physical PCI slot objects
Dave Johnson
Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?
linux-netdev
:
Arnd Bergmann
Re: 64-bit net_device_stats
Stephens, Allan
RE: [PATCH]: tipc: Fix oops on send prior to entering networked mode
frank.blaschka
[patch 3/5] [PATCH] qeth: support z/VM VSWITCH Port Isolation
Wu Fengguang
Re: [PATCH] dm9601: handle corrupt mac address
David Miller
Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()
git
:
Junio C Hamano
Re: [PATCH] [RFC] add Message-ID field to log on git-am operation
Junio C Hamano
Re: Handling large files with GIT
Karl
Re: [ANNOUNCE] pg - A patch porcelain for GIT
Josh Triplett
Re: [RFC][PATCH 00/10] Sparse: Git's "make check" target
Pierre Habouzit
Re: [PATCH] git-daemon: more powerful base-path/user-path settings, using formats.
git-commits-head
:
Linux Kernel Mailing List
MIPS: RBTX4939: Fix IOC pin-enable register updating
Linux Kernel Mailing List
regulator: update email address for Liam Girdwood
Linux Kernel Mailing List
[SCSI] ipr: add message to error table
Linux Kernel Mailing List
powerpc/32: Wire up the trampoline code for kdump
Linux Kernel Mailing List
USB: omap_udc: sync with OMAP tree
openbsd-misc
:
Josh Grosse
Re: error : pkg add phpMyAdmin
Brian Candler
Re: OBSD's perspective on SELinux
Jacob Meuser
Re: /dev/audio: Device busy
David Vasek
Re: Inexpensive, low power, "wall wart" computer
William Boshuck
Re: Richard Stallman...
Colocation donated by:
Syndicate