Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Heiko Carstens

Subject: Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks

Date: Tuesday, September 14, 2010 - 7:18 am

On Tue, Sep 14, 2010 at 03:10:43PM +0200, Arnd Bergmann wrote:
quoted text> On Tuesday 14 September 2010, Heiko Carstens wrote:
> > On Mon, Sep 13, 2010 at 08:07:52PM -0700, Stephen Boyd wrote:
> > > Changing the buf_size variable from an int to a size_t makes the warning
> > > go away. Perhaps this is because gcc can't reliably eliminate the else
> > > case when the lower bound isn't 0? Overflow? I'm not really sure. Does
> > > the kernel/kprobes.c part of this patch work for you?
> > 
> > Yes, the warning goes away on s390 as well.
> 
> Ok, great!
> 
> In that case, I think we should just apply this patch to fix all these
> warnings for good. There are probably some more in an x86_64 allyesconfig
> build, but this should make s390 build cleanly again.

Nah, that would be too easy.
allyesconfig with gcc 4.5.2 and both patches applied:

In file included from /home2/heicarst/linux-2.6/arch/s390/include/asm/mmu_context.h:13:0,
                 from /home2/heicarst/linux-2.6/arch/s390/include/asm/elf.h:133,
                 from include/linux/elf.h:7,
                 from include/linux/module.h:14,
                 from net/core/pktgen.c:123:
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:881:20:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1144:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1251:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1273:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1297:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1320:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1343:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1364:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1385:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1406:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1433:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_if_write' at net/core/pktgen.c:1469:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In file included from /home2/heicarst/linux-2.6/arch/s390/include/asm/mmu_context.h:13:0,
                 from /home2/heicarst/linux-2.6/arch/s390/include/asm/elf.h:133,
                 from include/linux/elf.h:7,
                 from include/linux/module.h:14,
                 from net/core/pktgen.c:123:
In function 'copy_from_user',
    inlined from 'pktgen_thread_write' at net/core/pktgen.c:1793:20:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
    inlined from 'pktgen_thread_write' at net/core/pktgen.c:1824:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In file included from /home2/heicarst/linux-2.6/arch/s390/include/asm/mmu_context.h:13:0,
                 from /home2/heicarst/linux-2.6/arch/s390/include/asm/elf.h:133,
                 from include/linux/elf.h:7,
                 from include/linux/module.h:14,
                 from drivers/net/tun.c:42:
In function 'copy_from_user',
    inlined from '__tun_chr_ioctl' at drivers/net/tun.c:1200:21:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In file included from /home2/heicarst/linux-2.6/arch/s390/include/asm/mmu_context.h:13:0,
                 from /home2/heicarst/linux-2.6/arch/s390/include/asm/elf.h:133,
                 from include/linux/elf.h:7,
                 from include/linux/module.h:14,
                 from include/linux/sysdev.h:25,
                 from include/linux/cpu.h:22,
                 from kernel/perf_event.c:14:
In function 'copy_from_user',
    inlined from 'perf_copy_attr' at kernel/perf_event.c:5006:22,
    inlined from 'SYSC_perf_event_open' at kernel/perf_event.c:5110:6,
    inlined from 'SyS_perf_event_open' at kernel/perf_event.c:5095:1:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In file included from /home2/heicarst/linux-2.6/arch/s390/include/asm/mmu_context.h:13:0,
                 from /home2/heicarst/linux-2.6/arch/s390/include/asm/elf.h:133,
                 from include/linux/elf.h:7,
                 from include/linux/module.h:14,
                 from drivers/scsi/sg.c:31:
In function 'copy_from_user',
    inlined from 'sg_proc_write_adio' at drivers/scsi/sg.c:2373:20:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In file included from /home2/heicarst/linux-2.6/arch/s390/include/asm/mmu_context.h:13:0,
                 from /home2/heicarst/linux-2.6/arch/s390/include/asm/elf.h:133,
                 from include/linux/elf.h:7,
                 from include/linux/module.h:14,
                 from include/linux/textsearch.h:7,
                 from include/linux/skbuff.h:27,
                 from include/linux/icmpv6.h:82,
                 from net/compat.c:19:
In function 'copy_from_user',
    inlined from 'compat_sys_socketcall' at net/compat.c:783:20:
/home2/heicarst/linux-2.6/arch/s390/include/asm/uaccess.h:297:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] ARM: uaccess: Implement strict user copy checks, Stephen Boyd, (Tue Aug 3, 8:02 pm)

Re: [PATCH] ARM: uaccess: Implement strict user copy checks, Stephen Boyd, (Tue Aug 10, 3:46 pm)

Re: [PATCH] ARM: uaccess: Implement strict user copy checks, Russell King - ARM Linux, (Tue Aug 10, 3:55 pm)

Re: [PATCH] ARM: uaccess: Implement strict user copy checks, Stephen Boyd, (Tue Aug 10, 5:27 pm)

Re: [PATCH] ARM: uaccess: Implement strict user copy checks, Arnd Bergmann, (Tue Aug 10, 8:04 pm)

Re: [PATCH] ARM: uaccess: Implement strict user copy checks, Stephen Boyd, (Wed Aug 11, 11:46 am)

Re: [PATCH] ARM: uaccess: Implement strict user copy checks, Arnd Bergmann, (Thu Aug 12, 8:00 am)

[PATCH v2] ARM: uaccess: Implement strict user copy checks, Stephen Boyd, (Tue Aug 17, 6:29 pm)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Arnd Bergmann, (Wed Aug 18, 5:28 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Stephen Boyd, (Wed Aug 18, 12:48 pm)

[PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS, Stephen Boyd, (Wed Aug 18, 7:28 pm)

Re: [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COP ..., Arjan van de Ven, (Wed Aug 18, 9:38 pm)

Re: [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COP ..., Stephen Rothwell, (Wed Aug 18, 9:47 pm)

Re: [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COP ..., Arnd Bergmann, (Thu Aug 19, 4:04 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Arnd Bergmann, (Thu Aug 19, 4:09 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Heiko Carstens, (Tue Aug 24, 8:06 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Arnd Bergmann, (Tue Aug 24, 8:26 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Heiko Carstens, (Tue Aug 24, 8:47 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Arnd Bergmann, (Wed Aug 25, 5:14 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Heiko Carstens, (Wed Aug 25, 5:54 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Arnd Bergmann, (Wed Aug 25, 6:55 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Heiko Carstens, (Wed Aug 25, 7:40 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Stephen Boyd, (Fri Aug 27, 6:35 pm)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Heiko Carstens, (Sat Aug 28, 12:43 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Arnd Bergmann, (Sat Aug 28, 2:56 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Stephen Boyd, (Fri Sep 3, 9:49 pm)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Stephen Boyd, (Mon Sep 13, 8:07 pm)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Heiko Carstens, (Tue Sep 14, 1:25 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Arnd Bergmann, (Tue Sep 14, 6:10 am)

Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks, Heiko Carstens, (Tue Sep 14, 7:18 am)


linux-kernel:
David Howells	[PATCH] KEYS: Use the variable 'key' in keyctl_describe_key()
Greg Kroah-Hartman	[PATCH 17/36] sysdev: detect multiple driver registrations
Greg Kroah-Hartman	[PATCH 09/36] driver core: register_memory/unregister_memory clean ups and bugfix
Greg Kroah-Hartman	[PATCH 08/36] driver core: memory: semaphore to mutex
Pierre Ossman	Re: sdio: enhance IO_RW_EXTENDED support
git:
Mark Junker	git on MacOSX and files with decomposed utf-8 file names
Johannes Schindelin	Re: error: cannot lock ref 'refs/remotes/origin/*'
Pat Thoyts	[PATCH] git-gui: use themed tk widgets with Tk 8.5
Michael Witten	Re: 'git gc --aggressive' effectively unusable
Johannes Schindelin	Re: [PATCH 2/2] git-svn: support fetch with autocrlf on
linux-netdev:
David Miller	Re: [PATCH 32/53] netns xfrm: finding policy in netns
Jean-Louis Dupond	Re: tg3 driver not advertising 1000mbit
Jan Engelhardt	[PATCH 1/3] net: tcp: make hybla selectable as default congestion module
Daniel Schaffrath	Re: tcp bw in 2.6
Matt Mackall	Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
git-commits-head:
Linux Kernel Mailing List	ipv6: fix an oops when force unload ipv6 module
Linux Kernel Mailing List	tracing: protect reader of cmdline output
Linux Kernel Mailing List	KVM: VMX: Clear CR4.VMXE in hardware_disable
Linux Kernel Mailing List	imxfb: Fix margin settings
Linux Kernel Mailing List	USB: set correct configuration in probe of ti_usb_3410_5052
openbsd-misc:
Stas Miasnikou	Re: Another question: device naming convention
Darrin Chandler	Re: That whole "Linux stealing our code" thing
Community First Financial	Teacher A+ Loan
Jan Stary	Re: audio recording levels
Andrej Elizarov	Re: Web Browsers