[PATCH -next,-tip ] kprobes: Fix Kconfig dependency

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Masami Hiramatsu
Date: Monday, September 13, 2010 - 3:25 am

Fix Kconfig dependency among Kprobes, optprobe and kallsyms.

Kprobes uses kallsyms_lookup for finding target function and checking
instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS.

Optprobe is an optional feature which is supported on x86 arch, and
it also uses kallsyms_lookup for checking instructions in the target
function. Since KALLSYMS_ALL just adds symbols of kernel variables,
it doesn't need to select KALLSYMS_ALL.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Cc: linux-kernel@vger.kernel.org,
Cc: linux-next@vger.kernel.org,
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Cc: "David S. Miller" <davem@davemloft.net>,
Cc: akpm <akpm@linux-foundation.org>
---

 arch/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index 4877a8c..fe48fc7 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -32,8 +32,9 @@ config HAVE_OPROFILE
 
 config KPROBES
 	bool "Kprobes"
-	depends on KALLSYMS && MODULES
+	depends on MODULES
 	depends on HAVE_KPROBES
+	select KALLSYMS
 	help
 	  Kprobes allows you to trap at almost any kernel address and
 	  execute a callback function.  register_kprobe() establishes
@@ -45,7 +46,6 @@ config OPTPROBES
 	def_bool y
 	depends on KPROBES && HAVE_OPTPROBES
 	depends on !PREEMPT
-	select KALLSYMS_ALL
 
 config HAVE_EFFICIENT_UNALIGNED_ACCESS
 	bool

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -next] optprobes: fix kconfig depends/selects, Randy Dunlap, (Thu Aug 12, 12:26 pm)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Masami Hiramatsu, (Tue Aug 17, 7:55 am)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Masami Hiramatsu, (Tue Aug 17, 8:03 am)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Felipe Contreras, (Sun Sep 12, 3:49 am)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Randy Dunlap, (Sun Sep 12, 11:34 am)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Felipe Contreras, (Sun Sep 12, 11:41 am)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Randy Dunlap, (Sun Sep 12, 11:46 am)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Masami Hiramatsu, (Sun Sep 12, 6:06 pm)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Masami Hiramatsu, (Mon Sep 13, 12:15 am)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Felipe Contreras, (Mon Sep 13, 2:41 am)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Masami Hiramatsu, (Mon Sep 13, 3:14 am)
[PATCH -next,-tip ] kprobes: Fix Kconfig dependency, Masami Hiramatsu, (Mon Sep 13, 3:25 am)
Re: [PATCH -next] optprobes: fix kconfig depends/selects, Felipe Contreras, (Mon Sep 13, 4:11 am)
Re: [PATCH -next,-tip ] kprobes: Fix Kconfig dependency, Randy Dunlap, (Mon Sep 13, 9:33 am)
[tip:perf/urgent] kprobes: Fix Kconfig dependency, tip-bot for Masami H ..., (Mon Sep 13, 12:54 pm)