On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
quoted text > From: Randy Dunlap <randy.dunlap@oracle.com>
>
> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>
> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> ---
> arch/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20100810.orig/arch/Kconfig
> +++ linux-next-20100810/arch/Kconfig
> @@ -45,6 +45,8 @@ config OPTPROBES
> def_bool y
> depends on KPROBES && HAVE_OPTPROBES
> depends on !PREEMPT
> + depends on DEBUG_KERNEL
> + select KALLSYMS
> select KALLSYMS_ALL
>
> config HAVE_EFFICIENT_UNALIGNED_ACCESS
> --
This causes another problem:
arch/Kconfig:33:error: recursive dependency detected!
arch/Kconfig:33: symbol KPROBES depends on KALLSYMS
init/Kconfig:825: symbol KALLSYMS is selected by OPTPROBES
arch/Kconfig:44: symbol OPTPROBES depends on KPROBES
The 'select KALLSYMS' is redundant.
Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
--
Felipe Contreras
--
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [PATCH -next] optprobes: fix kconfig depends/selects , Felipe Contreras , (Sun Sep 12, 3:49 am)