Re: #2 (Re: More modaliases + patchtool)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rusty Russell
Date: Friday, September 10, 2010 - 7:14 pm

On Thu, 19 Aug 2010 10:12:36 pm Dzianis Kahanovich wrote:

Hi Dzianis,

   Sorry it took me so long to reply.  It looks very much like some of
these cannot be modules anyway.  aml_nfw can't be (the Kconfig is a bool).
Strange that it has an exit function!


These seem valid at a glance, but should go through the PowerPC maintainer.
  

This seems very logical.  Jeremy?


Do we really need all these #ifdef CONFIG_OF wrappers?


Hmm, Dmitry?  Do we want this auto-loaded?


This one, too, seems to make sense.

[ Remaining 2/3 of patch cut here ].

I think the best way to split this patch is by bus type.  Drop the #ifdef's
if you think it's a good idea, do some compile testing, then forward to the
specific maintainers for each type.  I'm happy to do that for you if you
want (though these kind of patches are Morton-worthy IMHO).

Cheers,
Rusty.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: More modaliases + patchtool, Rusty Russell, (Wed Aug 18, 5:50 pm)
#3 (Re: More modaliases + patchtool), Dzianis Kahanovich, (Thu Aug 19, 7:58 am)
Re: #2 (Re: More modaliases + patchtool), Rusty Russell, (Fri Sep 10, 7:14 pm)
Re: #2 (Re: More modaliases + patchtool), Jeremy Fitzhardinge, (Fri Sep 10, 8:36 pm)
Re: #2 (Re: More modaliases + patchtool), Dmitry Torokhov, (Sat Sep 11, 10:51 am)
Re: #2 (Re: More modaliases + patchtool), Rusty Russell, (Sun Sep 12, 8:03 pm)
Re: #2 (Re: More modaliases + patchtool), Rusty Russell, (Sun Sep 12, 8:24 pm)
pci: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 3:55 am)
pci: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:11 am)
xenbus: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:26 am)
usb: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:27 am)
serio: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:29 am)
pnp: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:29 am)
of: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:32 am)
i2c: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:35 am)
hid: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:36 am)
dio: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:36 am)
ccw: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:37 am)
acpi: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:38 am)
spi Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:38 am)
RapidIO: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:39 am)
platform: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 6:42 am)
Re: i2c: Re: #2 (Re: More modaliases + patchtool)), Mark Brown, (Fri Sep 17, 7:06 am)
Re: i2c: Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 8:47 am)
Re: i2c: Re: #2 (Re: More modaliases + patchtool)), Mark Brown, (Fri Sep 17, 8:54 am)
acpi (signed): Re: #2 (Re: More modaliases + patchtool)), Dzianis Kahanovich, (Fri Sep 17, 8:55 am)
Re: xenbus: Re: #2 (Re: More modaliases + patchtool)), Jeremy Fitzhardinge, (Fri Sep 17, 11:09 am)