Home » Mailing list archives » linux-kernel » 2010 » August » 9

[patch -NEXT] usb/gadget/webcam: fix Kconfig depends again

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Randy Dunlap
Subject: [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again
Date: Monday, August 9, 2010 - 10:55 am

From: Randy Dunlap <randy.dunlap@oracle.com>

The USB gadget webcam driver uses V4L2 interfaces, so it should depend
on VIDEO_V4L2 instead of VIDEO_DEV.  This fixes a lot of build errors
when V4L2 is not enabled:

ERROR: "v4l2_event_unsubscribe" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_queue" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_device_release" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_usercopy" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_dequeue" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_register_device" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_device_alloc" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_subscribe" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_unregister_device" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_fh_init" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_pending" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_init" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_devdata" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_alloc" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_fh_add" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_fh_del" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_fh_exit" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_ctrl_fill" [drivers/media/video/v4l2-common.ko] undefined!
ERROR: "v4l2_ctrl_get_menu" [drivers/media/video/v4l2-common.ko] undefined!
ERROR: "v4l2_device_unregister_subdev" [drivers/media/video/v4l2-common.ko] undefined!
ERROR: "v4l2_device_register_subdev" [drivers/media/video/v4l2-common.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
---
 drivers/usb/gadget/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20100809.orig/drivers/usb/gadget/Kconfig
+++ linux-next-20100809/drivers/usb/gadget/Kconfig
@@ -947,7 +947,7 @@ endif
 # or video class gadget drivers), or specific hardware, here.
 config USB_G_WEBCAM
 	tristate "USB Webcam Gadget"
-	depends on VIDEO_DEV
+	depends on VIDEO_V4L2
 	help
 	  The Webcam Gadget acts as a composite USB Audio and Video Class
 	  device. It provides a userspace API to process UVC control requests
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
linux-next: Tree for August 9, Stephen Rothwell, (Sun Aug 8, 8:23 pm)
Re: linux-next: Tree for August 9 (nfs), Randy Dunlap, (Mon Aug 9, 10:08 am)
[patch -NEXT] usb/gadget/webcam: fix Kconfig depends again, Randy Dunlap, (Mon Aug 9, 10:55 am)
[PATCH -next] v4l2-ctrls.c: needs to include slab.h, Randy Dunlap, (Mon Aug 9, 10:56 am)
Re: [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again, Laurent Pinchart, (Tue Aug 10, 5:16 am)
Re: [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again, Randy Dunlap, (Tue Aug 10, 7:48 am)
Re: [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again, Laurent Pinchart, (Tue Aug 10, 7:53 am)
Re: [PATCH -next] v4l2-ctrls.c: needs to include slab.h, Tony Vroon, (Wed Aug 11, 11:45 am)
Re: linux-next: Tree for August 9 (nfs), Randy Dunlap, (Thu Aug 12, 9:18 am)
Re: linux-next: Tree for August 9 (nfs), Trond Myklebust, (Thu Aug 12, 10:31 am)
Re: linux-next: Tree for August 9 (nfs), Randy Dunlap, (Thu Aug 12, 10:36 am)
Re: [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again, Randy Dunlap, (Tue Aug 17, 11:03 am)
Re: linux-next: Tree for August 9 (nfs), Trond Myklebust, (Tue Aug 17, 2:23 pm)
Re: linux-next: Tree for August 9 (nfs), Randy Dunlap, (Tue Aug 17, 2:39 pm)