Re: [GIT PULL] ext4 update for 2.6.36

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Saturday, August 7, 2010 - 1:17 pm

On Thu, Aug 5, 2010 at 9:23 PM, Theodore Ts'o <tytso@mit.edu> wrote:

I did that just to see what it looked like.

One annoyance: I now get

  fs/jbd2/transaction.c: In function ‘start_this_handle’:
  fs/jbd2/transaction.c:98: warning: unused variable ‘ts’

due to that 'ts' thing only being used for the CONFIG_JBD2_DEBUG case.
Please fix. I'd suggest putting that CONFIG_JBD2_DEBUG code in a
helper function of its own, and declaring 'ts' there instead.
Suggested patch (but with a horrible helper function name) attached.

               Linus
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PULL] ext4 update for 2.6.36, Theodore Ts'o, (Thu Aug 5, 9:23 pm)
Re: [GIT PULL] ext4 update for 2.6.36, Linus Torvalds, (Sat Aug 7, 1:17 pm)
Re: [GIT PULL] ext4 update for 2.6.36, Ted Ts'o, (Mon Aug 9, 2:48 pm)