[PATCH 01/43] memblock: Fix memblock_is_region_reserved() to return a boolean

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Benjamin Herrenschmidt
Date: Thursday, August 5, 2010 - 10:14 pm

All callers expect a boolean result which is true if the region
overlaps a reserved region. However, the implementation actually
returns -1 if there is no overlap, and a region index (0 based)
if there is.

Make it behave as callers (and common sense) expect.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 mm/memblock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/memblock.c b/mm/memblock.c
index 3024eb3..43840b3 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -504,7 +504,7 @@ int __init memblock_is_reserved(u64 addr)
 
 int memblock_is_region_reserved(u64 base, u64 size)
 {
-	return memblock_overlaps_region(&memblock.reserved, base, size);
+	return memblock_overlaps_region(&memblock.reserved, base, size) >= 0;
 }
 
 /*
-- 
1.7.0.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
memblock updates, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 01/43] memblock: Fix memblock_is_region_reserved() ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 02/43] memblock: Rename memblock_region to memblock ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 04/43] memblock: Implement memblock_is_memory and m ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 05/43] memblock/arm: pfn_valid uses memblock_is_mem ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 06/43] memblock/arm: Use memblock_region_is_memory( ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 08/43] memblock/microblaze: Use new accessors, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 09/43] memblock/sh: Use new accessors, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 11/43] memblock/powerpc: Use new accessors, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 12/43] memblock/arm: Use new accessors, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 13/43] memblock: Remove obsolete accessors, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 14/43] memblock: Remove memblock_find(), Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 15/43] memblock: Remove nid_range argument, arch pr ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 16/43] memblock: Factor the lowest level alloc function, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 17/43] memblock: Expose MEMBLOCK_ALLOC_ANYWHERE, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 21/43] memblock: Remove unused memblock.debug struc ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:15 pm)
Re: [PATCH 08/43] memblock/microblaze: Use new accessors, Benjamin Herrenschmidt, (Fri Aug 6, 3:50 pm)
Re: [PATCH 12/43] memblock/arm: Use new accessors, Russell King - ARM Linux, (Tue Aug 10, 12:11 am)
Re: [PATCH 08/43] memblock/microblaze: Use new accessors, Stephen Rothwell, (Thu Sep 9, 4:06 am)
Re: [PATCH 08/43] memblock/microblaze: Use new accessors, Benjamin Herrenschmidt, (Fri Sep 10, 1:17 am)
Re: [PATCH 08/43] memblock/microblaze: Use new accessors, Benjamin Herrenschmidt, (Fri Sep 10, 1:18 am)
[PATCH] microblaze, memblock: fix compiling, Yinghai Lu, (Sat Sep 11, 12:07 am)
[PATCH] powerpc, memblock: fix will memblock reference, Yinghai Lu, (Sat Sep 11, 12:08 am)
[tip:core/memblock] memblock, microblaze: Fix memblock API ..., tip-bot for Yinghai Lu, (Sat Sep 11, 12:34 am)
[tip:core/memblock] powerpc, memblock: Fix memblock API ch ..., tip-bot for Yinghai Lu, (Sat Sep 11, 12:34 am)
[tip:core/memblock] memblock, microblaze: Fix memblock API ..., tip-bot for Michal Simek, (Sat Sep 11, 1:34 am)
[tip:core/memblock] powerpc, memblock: Fix memblock API ch ..., tip-bot for Yinghai Lu, (Sat Sep 11, 1:34 am)