[PATCH 04/43] memblock: Implement memblock_is_memory and memblock_is_region_memory

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Benjamin Herrenschmidt
Date: Thursday, August 5, 2010 - 10:14 pm

To make it fast, we steal ARM's binary search for memblock_is_memory()
and we use that to also the replace existing implementation of
memblock_is_reserved().

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 include/linux/memblock.h |    2 ++
 mm/memblock.c            |   42 ++++++++++++++++++++++++++++++++++--------
 2 files changed, 36 insertions(+), 8 deletions(-)

diff --git a/include/linux/memblock.h b/include/linux/memblock.h
index 4b69313..47bceb1 100644
--- a/include/linux/memblock.h
+++ b/include/linux/memblock.h
@@ -56,6 +56,8 @@ extern u64 __init __memblock_alloc_base(u64 size,
 extern u64 __init memblock_phys_mem_size(void);
 extern u64 memblock_end_of_DRAM(void);
 extern void __init memblock_enforce_memory_limit(u64 memory_limit);
+extern int memblock_is_memory(u64 addr);
+extern int memblock_is_region_memory(u64 base, u64 size);
 extern int __init memblock_is_reserved(u64 addr);
 extern int memblock_is_region_reserved(u64 base, u64 size);
 extern int memblock_find(struct memblock_region *res);
diff --git a/mm/memblock.c b/mm/memblock.c
index 6f407cc..aa88c62 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -487,17 +487,43 @@ void __init memblock_enforce_memory_limit(u64 memory_limit)
 	}
 }
 
+static int memblock_search(struct memblock_type *type, u64 addr)
+{
+	unsigned int left = 0, right = type->cnt;
+
+	do {
+		unsigned int mid = (right + left) / 2;
+
+		if (addr < type->regions[mid].base)
+			right = mid;
+		else if (addr >= (type->regions[mid].base +
+				  type->regions[mid].size))
+			left = mid + 1;
+		else
+			return mid;
+	} while (left < right);
+	return -1;
+}
+
 int __init memblock_is_reserved(u64 addr)
 {
-	int i;
+	return memblock_search(&memblock.reserved, addr) != -1;
+}
 
-	for (i = 0; i < memblock.reserved.cnt; i++) {
-		u64 upper = memblock.reserved.regions[i].base +
-			memblock.reserved.regions[i].size - 1;
-		if ((addr >= memblock.reserved.regions[i].base) && (addr <= upper))
-			return 1;
-	}
-	return 0;
+int memblock_is_memory(u64 addr)
+{
+	return memblock_search(&memblock.memory, addr) != -1;
+}
+
+int memblock_is_region_memory(u64 base, u64 size)
+{
+	int idx = memblock_search(&memblock.reserved, base);
+
+	if (idx == -1)
+		return 0;
+	return memblock.reserved.regions[idx].base <= base &&
+		(memblock.reserved.regions[idx].base +
+		 memblock.reserved.regions[idx].size) >= (base + size);
 }
 
 int memblock_is_region_reserved(u64 base, u64 size)
-- 
1.7.0.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
memblock updates, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 01/43] memblock: Fix memblock_is_region_reserved() ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 02/43] memblock: Rename memblock_region to memblock ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 04/43] memblock: Implement memblock_is_memory and m ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 05/43] memblock/arm: pfn_valid uses memblock_is_mem ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 06/43] memblock/arm: Use memblock_region_is_memory( ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 08/43] memblock/microblaze: Use new accessors, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 09/43] memblock/sh: Use new accessors, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 11/43] memblock/powerpc: Use new accessors, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 12/43] memblock/arm: Use new accessors, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 13/43] memblock: Remove obsolete accessors, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 14/43] memblock: Remove memblock_find(), Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 15/43] memblock: Remove nid_range argument, arch pr ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 16/43] memblock: Factor the lowest level alloc function, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 17/43] memblock: Expose MEMBLOCK_ALLOC_ANYWHERE, Benjamin Herrenschmidt, (Thu Aug 5, 10:14 pm)
[PATCH 21/43] memblock: Remove unused memblock.debug struc ..., Benjamin Herrenschmidt, (Thu Aug 5, 10:15 pm)
Re: [PATCH 08/43] memblock/microblaze: Use new accessors, Benjamin Herrenschmidt, (Fri Aug 6, 3:50 pm)
Re: [PATCH 12/43] memblock/arm: Use new accessors, Russell King - ARM Linux, (Tue Aug 10, 12:11 am)
Re: [PATCH 08/43] memblock/microblaze: Use new accessors, Stephen Rothwell, (Thu Sep 9, 4:06 am)
Re: [PATCH 08/43] memblock/microblaze: Use new accessors, Benjamin Herrenschmidt, (Fri Sep 10, 1:17 am)
Re: [PATCH 08/43] memblock/microblaze: Use new accessors, Benjamin Herrenschmidt, (Fri Sep 10, 1:18 am)
[PATCH] microblaze, memblock: fix compiling, Yinghai Lu, (Sat Sep 11, 12:07 am)
[PATCH] powerpc, memblock: fix will memblock reference, Yinghai Lu, (Sat Sep 11, 12:08 am)
[tip:core/memblock] memblock, microblaze: Fix memblock API ..., tip-bot for Yinghai Lu, (Sat Sep 11, 12:34 am)
[tip:core/memblock] powerpc, memblock: Fix memblock API ch ..., tip-bot for Yinghai Lu, (Sat Sep 11, 12:34 am)
[tip:core/memblock] memblock, microblaze: Fix memblock API ..., tip-bot for Michal Simek, (Sat Sep 11, 1:34 am)
[tip:core/memblock] powerpc, memblock: Fix memblock API ch ..., tip-bot for Yinghai Lu, (Sat Sep 11, 1:34 am)