[PATCH 56/67] serial: MMIO32 support for 8250_early.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Thursday, August 5, 2010 - 3:23 pm

From: Samium Gromoff <_deepfire@feelingofgreen.ru>

Provide MMIO32 support in 8250_early (aka earlycon)

[randy.dunlap@oracle.com: fix printk format warnings]
[akpm@linux-foundation.org: fix printk args some more]
Signed-off-by: Samium Gromoff <_deepfire@feelingofgreen.ru>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 Documentation/kernel-parameters.txt |    3 ++
 drivers/serial/8250_early.c         |   57 +++++++++++++++++++++++++---------
 2 files changed, 45 insertions(+), 15 deletions(-)

diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index d9239d5..f77ed13 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -687,8 +687,11 @@ and is between 256 and 4096 characters. It is defined in the file
 	earlycon=	[KNL] Output early console device and options.
 		uart[8250],io,<addr>[,options]
 		uart[8250],mmio,<addr>[,options]
+		uart[8250],mmio32,<addr>[,options]
 			Start an early, polled-mode console on the 8250/16550
 			UART at the specified I/O port or MMIO address.
+			MMIO inter-register address stride is either 8bit (mmio)
+                        or 32bit (mmio32).
 			The options are the same as for ttyS, above.
 
 	earlyprintk=	[X86,SH,BLACKFIN]
diff --git a/drivers/serial/8250_early.c b/drivers/serial/8250_early.c
index f279745..b745792 100644
--- a/drivers/serial/8250_early.c
+++ b/drivers/serial/8250_early.c
@@ -19,9 +19,11 @@
  * The user can specify the device directly, e.g.,
  *	earlycon=uart8250,io,0x3f8,9600n8
  *	earlycon=uart8250,mmio,0xff5e0000,115200n8
+ *	earlycon=uart8250,mmio32,0xff5e0000,115200n8
  * or
  *	console=uart8250,io,0x3f8,9600n8
  *	console=uart8250,mmio,0xff5e0000,115200n8
+ *	console=uart8250,mmio32,0xff5e0000,115200n8
  */
 
 #include <linux/tty.h>
@@ -48,18 +50,31 @@ static struct early_serial8250_device early_device;
 
 static unsigned int __init serial_in(struct uart_port *port, int offset)
 {
-	if (port->iotype == UPIO_MEM)
+	switch (port->iotype) {
+	case UPIO_MEM:
 		return readb(port->membase + offset);
-	else
+	case UPIO_MEM32:
+		return readl(port->membase + (offset << 2));
+	case UPIO_PORT:
 		return inb(port->iobase + offset);
+	default:
+		return 0;
+	}
 }
 
 static void __init serial_out(struct uart_port *port, int offset, int value)
 {
-	if (port->iotype == UPIO_MEM)
+	switch (port->iotype) {
+	case UPIO_MEM:
 		writeb(value, port->membase + offset);
-	else
+		break;
+	case UPIO_MEM32:
+		writel(value, port->membase + (offset << 2));
+		break;
+	case UPIO_PORT:
 		outb(value, port->iobase + offset);
+		break;
+	}
 }
 
 #define BOTH_EMPTY (UART_LSR_TEMT | UART_LSR_THRE)
@@ -137,15 +152,21 @@ static int __init parse_options(struct early_serial8250_device *device,
 								char *options)
 {
 	struct uart_port *port = &device->port;
-	int mmio, length;
+	int mmio, mmio32, length;
 
 	if (!options)
 		return -ENODEV;
 
 	port->uartclk = BASE_BAUD * 16;
-	if (!strncmp(options, "mmio,", 5)) {
-		port->iotype = UPIO_MEM;
-		port->mapbase = simple_strtoul(options + 5, &options, 0);
+
+	mmio = !strncmp(options, "mmio,", 5);
+	mmio32 = !strncmp(options, "mmio32,", 7);
+	if (mmio || mmio32) {
+		port->iotype = (mmio ? UPIO_MEM : UPIO_MEM32);
+		port->mapbase = simple_strtoul(options + (mmio ? 5 : 7),
+					       &options, 0);
+		if (mmio32)
+			port->regshift = 2;
 #ifdef CONFIG_FIX_EARLYCON_MEM
 		set_fixmap_nocache(FIX_EARLYCON_MEM_BASE,
 					port->mapbase & PAGE_MASK);
@@ -157,11 +178,10 @@ static int __init parse_options(struct early_serial8250_device *device,
 		if (!port->membase) {
 			printk(KERN_ERR "%s: Couldn't ioremap 0x%llx\n",
 				__func__,
-			       (unsigned long long)port->mapbase);
+			       (unsigned long long) port->mapbase);
 			return -ENOMEM;
 		}
 #endif
-		mmio = 1;
 	} else if (!strncmp(options, "io,", 3)) {
 		port->iotype = UPIO_PORT;
 		port->iobase = simple_strtoul(options + 3, &options, 0);
@@ -181,11 +201,18 @@ static int __init parse_options(struct early_serial8250_device *device,
 			device->baud);
 	}
 
-	printk(KERN_INFO "Early serial console at %s 0x%llx (options '%s')\n",
-		mmio ? "MMIO" : "I/O port",
-		mmio ? (unsigned long long) port->mapbase
-		     : (unsigned long long) port->iobase,
-		device->options);
+	if (mmio || mmio32)
+		printk(KERN_INFO
+		       "Early serial console at MMIO%s 0x%llu (options '%s')\n",
+			mmio32 ? "32" : "",
+			(unsigned long long)port->mapbase,
+			device->options);
+	else
+		printk(KERN_INFO
+		      "Early serial console at I/O port 0x%lu (options '%s')\n",
+			port->iobase,
+			device->options);
+
 	return 0;
 }
 
-- 
1.7.2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCH] TTY patches for 2.6.36, Greg KH, (Thu Aug 5, 2:35 pm)
[PATCH 01/67] n_gsm.c: removed duplicated #includes, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 02/67] serial: There's no config CONSOLE, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 03/67] vt: clean up the code - use kernel library, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 04/67] serial: add UART_CAP_EFR and UART_CAP_SLEEP ..., Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 05/67] mrst_max3110: add UART driver for Max3110 on ..., Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 06/67] max3110 sanity check a register, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 07/67] serial: replace open coded mutex with a real ..., Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 08/67] serial: fix wakup races in the mrst_max3110 ..., Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 09/67] tty: Remove Hayes ESP ioctls, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 10/67] tty: remove remaining Hayes ESP ioctls, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 11/67] tty: Add EXTPROC support for LINEMODE, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 12/67] vt/console: try harder to print output when ..., Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 13/67] stallion: prune lock_kernel calls, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 14/67] istallion: use bit ops for the board flags, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 15/67] riscom8: kill use of lock_kernel, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 16/67] isicom: kill off the BKL, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 17/67] rocket: kill BKL, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 18/67] synclink: kill the big kernel lock, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 19/67] cyclades: Kill off BKL usage, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 20/67] epca: Kill the big kernel lock, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 21/67] specialix: Kill the BKL, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 22/67] tty: Fix the digi acceleport driver NULL checks, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 23/67] synclink: reworking locking a bit, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 24/67] tty: serial - fix various misuses/mishandlin ..., Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 25/67] tty: serial - fix tty back references in termios, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 26/67] tty: serial - fix tty referencing in set_ldisc, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 27/67] vc: Locking clean up, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 28/67] tty: Make vt's have a tty_port, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 29/67] tty: Move the vt_tty field from the vc_data ..., Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 30/67] serial: Change the wait for carrier locking, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 31/67] serial: add port helpers, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 32/67] serial: trim locking on the helpers, Greg Kroah-Hartman, (Thu Aug 5, 3:22 pm)
[PATCH 33/67] serial: Use block_til_ready helper, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 34/67] serial: fix termios settings in open, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 35/67] tty: replace BKL with a new tty_lock, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 36/67] tty: never hold BTM while getting tty_mutex, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 37/67] tty: fix console_sem lock order, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 38/67] cdc-acm: remove dead code, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 39/67] tty: introduce wait_event_interruptible_tty, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 40/67] tty: reorder ldisc locking, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 41/67] tty: untangle locking of wait_until_sent, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 42/67] tty: remove tty_lock_nested, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 43/67] tty: implement BTM as mutex instead of BKL, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 44/67] tty: release BTM while sleeping in block_til ..., Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 45/67] 8250: fix set_ldisc operation, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 46/67] tty: avoid recursive BTM in pty_close, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 47/67] serial: max3107: introduce a max3107 driver, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 48/67] serial: max3107: Abstract out the platform s ..., Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 49/67] tty_io: remove casts from void*, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 50/67] vt: Fix warning: statement with no effect du ..., Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 51/67] serial: crisv10: formatting of pointers in p ..., Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 53/67] serial: fix missing bit coverage of ASYNC_FLAGS, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 54/67] serial: general fixes in the serial_rs485 st ..., Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 55/67] serial: mcf: don't take spinlocks in already ..., Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 56/67] serial: MMIO32 support for 8250_early.c, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 57/67] timbuart: use __devinit and __devexit macros ..., Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 58/67] serial: 68328serial.c: remove dead (ALMA_ANS ..., Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 59/67] serial: add support for OX16PCI958 card, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 60/67] mxser: remove unnesesary NULL check, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 61/67] hsu: driver for Medfield High Speed UART device, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 62/67] hsu: add a periodic timer to check dma rx ch ..., Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 63/67] hsu: some code cleanup, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 64/67] hsu: call PCI pm hooks in suspend/resume fun ..., Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
[PATCH 65/67] serial: max3107: Fix gpiolib support, Greg Kroah-Hartman, (Thu Aug 5, 3:23 pm)
Re: [GIT PATCH] TTY patches for 2.6.36, Linus Torvalds, (Fri Aug 6, 11:40 am)
Re: [GIT PATCH] TTY patches for 2.6.36, Greg KH, (Fri Aug 6, 11:51 am)
Re: [GIT PATCH] TTY patches for 2.6.36, Greg KH, (Fri Aug 6, 12:37 pm)
Re: [GIT PATCH] TTY patches for 2.6.36, Linus Torvalds, (Fri Aug 6, 12:38 pm)
[PATCH retry] tty: implement BTM as mutex instead of BKL, Arnd Bergmann, (Fri Aug 6, 12:40 pm)
Re: [GIT PATCH] TTY patches for 2.6.36, Arnd Bergmann, (Fri Aug 6, 12:40 pm)
Re: [GIT PATCH] TTY patches for 2.6.36, Alan Cox, (Fri Aug 6, 12:45 pm)
Re: [GIT PATCH] TTY patches for 2.6.36, Arnd Bergmann, (Fri Aug 6, 12:58 pm)
Re: [GIT PATCH] TTY patches for 2.6.36, Linus Torvalds, (Fri Aug 6, 1:11 pm)
Re: [GIT PATCH] TTY patches for 2.6.36, Arnd Bergmann, (Fri Aug 6, 1:19 pm)
Re: [GIT PATCH] TTY patches for 2.6.36, Greg KH, (Fri Aug 6, 1:22 pm)
Re: [GIT PATCH] TTY patches for 2.6.36, Andy Whitcroft, (Mon Aug 9, 9:06 am)
Re: [GIT PATCH] TTY patches for 2.6.36, Arnd Bergmann, (Mon Aug 9, 11:38 am)
Re: [GIT PATCH] TTY patches for 2.6.36, Alan Cox, (Mon Aug 9, 12:24 pm)
Re: [GIT PATCH] TTY patches for 2.6.36, Andy Whitcroft, (Tue Aug 10, 12:31 am)