[PATCH 1/2] x86, acpi: merge two register_lapic_address()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Wednesday, August 4, 2010 - 2:58 pm

They are the same, move it to apic.c

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/include/asm/apic.h |    1 +
 arch/x86/kernel/acpi/boot.c |   16 ++--------------
 arch/x86/kernel/apic/apic.c |   12 ++++++++++++
 arch/x86/kernel/mpparse.c   |   12 ------------
 4 files changed, 15 insertions(+), 26 deletions(-)

Index: linux-2.6/arch/x86/include/asm/apic.h
===================================================================
--- linux-2.6.orig/arch/x86/include/asm/apic.h
+++ linux-2.6/arch/x86/include/asm/apic.h
@@ -234,6 +234,7 @@ extern void init_bsp_APIC(void);
 extern void setup_local_APIC(void);
 extern void end_local_APIC_setup(void);
 extern void init_apic_mappings(void);
+void smp_register_lapic_address(unsigned long address);
 extern void setup_boot_APIC_clock(void);
 extern void setup_secondary_APIC_clock(void);
 extern int APIC_init_uniprocessor(void);
Index: linux-2.6/arch/x86/kernel/acpi/boot.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/acpi/boot.c
+++ linux-2.6/arch/x86/kernel/acpi/boot.c
@@ -820,18 +820,6 @@ static int __init acpi_parse_fadt(struct
  * returns 0 on success, < 0 on error
  */
 
-static void __init acpi_register_lapic_address(unsigned long address)
-{
-	mp_lapic_addr = address;
-
-	set_fixmap_nocache(FIX_APIC_BASE, address);
-	if (boot_cpu_physical_apicid == -1U) {
-		boot_cpu_physical_apicid  = read_apic_id();
-		apic_version[boot_cpu_physical_apicid] =
-			 GET_APIC_VERSION(apic_read(APIC_LVR));
-	}
-}
-
 static int __init early_acpi_parse_madt_lapic_addr_ovr(void)
 {
 	int count;
@@ -853,7 +841,7 @@ static int __init early_acpi_parse_madt_
 		return count;
 	}
 
-	acpi_register_lapic_address(acpi_lapic_addr);
+	smp_register_lapic_address(acpi_lapic_addr);
 
 	return count;
 }
@@ -880,7 +868,7 @@ static int __init acpi_parse_madt_lapic_
 		return count;
 	}
 
-	acpi_register_lapic_address(acpi_lapic_addr);
+	smp_register_lapic_address(acpi_lapic_addr);
 
 	count = acpi_table_parse_madt(ACPI_MADT_TYPE_LOCAL_SAPIC,
 				      acpi_parse_sapic, MAX_APICS);
Index: linux-2.6/arch/x86/kernel/apic/apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/apic/apic.c
+++ linux-2.6/arch/x86/kernel/apic/apic.c
@@ -1632,6 +1632,18 @@ void __init init_apic_mappings(void)
 	}
 }
 
+void __init smp_register_lapic_address(unsigned long address)
+{
+	mp_lapic_addr = address;
+
+	set_fixmap_nocache(FIX_APIC_BASE, address);
+	if (boot_cpu_physical_apicid == -1U) {
+		boot_cpu_physical_apicid  = read_apic_id();
+		apic_version[boot_cpu_physical_apicid] =
+			 GET_APIC_VERSION(apic_read(APIC_LVR));
+	}
+}
+
 /*
  * This initializes the IO-APIC and APIC hardware if this is
  * a UP kernel.
Index: linux-2.6/arch/x86/kernel/mpparse.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/mpparse.c
+++ linux-2.6/arch/x86/kernel/mpparse.c
@@ -274,18 +274,6 @@ static void __init smp_dump_mptable(stru
 
 void __init default_smp_read_mpc_oem(struct mpc_table *mpc) { }
 
-static void __init smp_register_lapic_address(unsigned long address)
-{
-	mp_lapic_addr = address;
-
-	set_fixmap_nocache(FIX_APIC_BASE, address);
-	if (boot_cpu_physical_apicid == -1U) {
-		boot_cpu_physical_apicid  = read_apic_id();
-		apic_version[boot_cpu_physical_apicid] =
-			 GET_APIC_VERSION(apic_read(APIC_LVR));
-	}
-}
-
 static int __init smp_read_mpc(struct mpc_table *mpc, unsigned early)
 {
 	char str[16];
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Tue Aug 3, 2:28 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Tue Aug 3, 2:45 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Tue Aug 3, 6:53 am)
Re: 2.6.35 hangs on early boot in KVM, Avi Kivity, (Tue Aug 3, 7:51 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Tue Aug 3, 7:57 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Tue Aug 3, 8:17 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Tue Aug 3, 8:31 am)
Re: 2.6.35 hangs on early boot in KVM, Borislav Petkov, (Tue Aug 3, 8:49 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Tue Aug 3, 8:59 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Tue Aug 3, 9:01 am)
Re: 2.6.35 hangs on early boot in KVM, Eric W. Biederman, (Tue Aug 3, 1:37 pm)
Re: 2.6.35 hangs on early boot in KVM, Yinghai Lu, (Tue Aug 3, 1:57 pm)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Wed Aug 4, 1:09 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Wed Aug 4, 1:18 am)
Re: 2.6.35 hangs on early boot in KVM, Yinghai Lu, (Wed Aug 4, 2:05 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Wed Aug 4, 2:16 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Wed Aug 4, 2:19 am)
Re: 2.6.35 hangs on early boot in KVM, Yinghai Lu, (Wed Aug 4, 2:34 am)
Re: 2.6.35 hangs on early boot in KVM, Gleb Natapov, (Wed Aug 4, 2:36 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Wed Aug 4, 2:44 am)
Re: 2.6.35 hangs on early boot in KVM, Eric W. Biederman, (Wed Aug 4, 3:37 am)
Re: 2.6.35 hangs on early boot in KVM, Tvrtko Ursulin, (Wed Aug 4, 3:46 am)
[PATCH 1/2] x86, acpi: merge two register_lapic_address(), Yinghai Lu, (Wed Aug 4, 2:58 pm)
[PATCH 2/2] x86: remove early_init_lapic_mapping, Yinghai Lu, (Wed Aug 4, 3:00 pm)
[tip:x86/urgent] x86, apic: Map the local apic when parsin ..., tip-bot for Eric W. ..., (Thu Aug 5, 5:15 pm)