Re: [PATCH 14/38] fallthru: ext2 fallthru support

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Miklos Szeredi
Date: Wednesday, August 4, 2010 - 7:44 am

On Tue, 15 Jun 2010, Valerie Aurora wrote:

If a previously used ext2 filesystem with is mounted again then
fallthroughs don't appear to work as expected.  Stat returns ENOENT
for these entries.

Can't see anything obviously wrong with the code.


That's an idea, but I guess it won't make everyone happy since it
wastes both disk space and memory.

One of the key differentiators for union mounts concept was that it
doesn't duplicate inodes and dentries from the layers.  With the
directory copyup on lookup that's already partially lost, but that can
be justified by the fact that non-directories usually far outnumber
directories.

Another idea is to use an internal inode and make all fallthroughs be
hard links to that.

I think the same would work for whiteouts as well.  I don't like the
fact that whiteouts are invisible even when not mounted as part of a
union.

Miklos
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/38] Union mounts - union stack as linked list, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 01/38] VFS: Comment follow_mount() and friends, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 02/38] VFS: Make lookup_hash() return a struct path, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 03/38] VFS: Add read-only users count to superblock, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 09/38] whiteout: tmpfs whiteout support, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 11/38] whiteout: ext2 whiteout support, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 12/38] whiteout: jffs2 whiteout support, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 14/38] fallthru: ext2 fallthru support, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 16/38] fallthru: tmpfs fallthru support, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 17/38] union-mount: Union mounts documentation, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 22/38] union-mount: Implement union lookup, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 27/38] union-mount: In-kernel file copyup routines, Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 29/38] union-mount: Implement union-aware link(), Valerie Aurora, (Tue Jun 15, 11:39 am)
[PATCH 30/38] union-mount: Implement union-aware rename(), Valerie Aurora, (Tue Jun 15, 11:40 am)
[PATCH 32/38] union-mount: Implement union-aware chown(), Valerie Aurora, (Tue Jun 15, 11:40 am)
[PATCH 33/38] union-mount: Implement union-aware truncate(), Valerie Aurora, (Tue Jun 15, 11:40 am)
[PATCH 35/38] union-mount: Implement union-aware lchown(), Valerie Aurora, (Tue Jun 15, 11:40 am)
[PATCH 36/38] union-mount: Implement union-aware utimensat(), Valerie Aurora, (Tue Jun 15, 11:40 am)
[PATCH 37/38] union-mount: Implement union-aware setxattr(), Valerie Aurora, (Tue Jun 15, 11:40 am)
[PATCH 38/38] union-mount: Implement union-aware lsetxattr(), Valerie Aurora, (Tue Jun 15, 11:40 am)
Re: [PATCH 17/38] union-mount: Union mounts documentation, Valerie Aurora, (Thu Jun 17, 11:39 am)
Re: [PATCH 17/38] union-mount: Union mounts documentation, Valerie Aurora, (Fri Jun 18, 2:06 pm)
Re: [PATCH 17/38] union-mount: Union mounts documentation, Miklos Szeredi, (Mon Jun 21, 6:14 am)
Re: [PATCH 17/38] union-mount: Union mounts documentation, Valerie Aurora, (Mon Jun 21, 4:17 pm)
Re: [PATCH 11/38] whiteout: ext2 whiteout support, Ian Kent, (Mon Jul 12, 9:24 pm)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Ian Kent, (Mon Jul 12, 9:30 pm)
Re: [PATCH 22/38] union-mount: Implement union lookup, Valerie Aurora, (Mon Jul 19, 2:58 pm)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Miklos Szeredi, (Wed Aug 4, 7:44 am)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Valerie Aurora, (Wed Aug 4, 3:48 pm)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Miklos Szeredi, (Thu Aug 5, 3:36 am)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Miklos Szeredi, (Thu Aug 5, 4:13 am)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Valerie Aurora, (Thu Aug 5, 4:30 pm)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Valerie Aurora, (Fri Aug 6, 10:12 am)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Valerie Aurora, (Fri Aug 6, 10:16 am)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Miklos Szeredi, (Fri Aug 6, 10:44 am)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Valerie Aurora, (Tue Aug 17, 3:27 pm)
Re: [PATCH 14/38] fallthru: ext2 fallthru support, Miklos Szeredi, (Wed Aug 18, 1:26 am)