| From | Subject | Date |
|---|---|---|
| Stephane Eranian | [RFC PATCH 2/2] perf_events: add support for per-cpu per ...
This perf tool patch adds the ability to filter monitoring based on container
groups (cgroups) for both perf stat and perf record. The cgroup to monitor are
passed via a new -G option followed by a list of cgroups.
The cgroup filesystem has to be mounted. The tool will find it automatically,
open the right file and pass the descriptor to perf_events.
Example:
$ perf stat -B -a -e cycles:u,cycles:u,cycles:u -G test1,,test2 -- sleep 1
Performance counter stats for 'sleep 1':
...
| Aug 31, 8:25 am 2010 |
| Hank Janssen | Re: [PATCH 2/5] staging: hv: Fixed lockup problem with b ...
I will resubmit this patch and clean up the whitespace error.
When change the code I normally also change the indentation to the
correct format for that area of the code. That is how the whitespace
snuck in there.
Thanks,
Hank.
--
| Aug 31, 1:03 pm 2010 |
| Oxfam GB | Oxfam gb -uk Cash\Grant Donation 2010.
You have been officially chosen by the Board of Trustees of the Oxfam GB (NGO UK) as one of the final
Recipients of a Cash Grant/Donation of £850,000.00 grant entitlements,Contact email
enquiry_terrywilliams0210001@live.co.uk,Qualification Number(OG/N231/E101/BDB)
--
| Aug 31, 2:59 pm 2010 |
| Ondrej Zary | [PATCH v2] [RFC] isofs: work-around for Rock Ridge+Jolie ...
If a CD has both Rock Ridge and Joliet extensions and the ISO root directory
is empty, no files are visible. Disable Rock Ridge extensions in this case and
use Joliet root directory instead.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
This is v2 with variable initialization.
--- linux-2.6.35-rc2/fs/isofs/inode.c 2010-06-06 05:43:24.000000000 +0200
+++ linux-2.6.35-rc3/fs/isofs/inode.c 2010-08-31 23:43:46.000000000 +0200
@@ -549,6 +549,34 @@ static unsigned int ...
| Aug 31, 2:51 pm 2010 |
| Ondrej Zary | Re: [PATCH] [RFC] [resend] isofs: work-around for Rock R ...
Oops... I tested it and it seemed to work fine. Even gcc did not complain...
--
Ondrej Zary
--
| Aug 31, 2:49 pm 2010 |
| Mark Davidson | Re Reply Urgent Message
I have a confidential business for you;I need you to execute this proposal involving GBP£60,000,000.00(Sixty Million Pounds Sterling's)Provide me,
Full Name
Tel: Number
Contact Address
M Davidson
--
| Aug 31, 2:46 pm 2010 |
| Peter Hsiang | [PATCH] ASoC: Add max98088 CODEC driver
This patch adds the MAX98088 CODEC driver.
Signed-off-by: Peter Hsiang <peter.hsiang at maxim-ic.com>
---
include/sound/max98088.h | 87 ++
sound/soc/codecs/Kconfig | 4 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/max98088.c | 2871 +++++++++++++++++++++++++++++++++++++++++++
sound/soc/codecs/max98088.h | 161 +++
5 files changed, 3125 insertions(+), 0 deletions(-)
create mode 100644 include/sound/max98088.h
create mode 100644 sound/soc/codecs/max98088.c
create ...
| Aug 31, 2:08 pm 2010 |
| Simon Arlott | Re: cxacru: USB ethernet port of CX82310-based ADSL routers?
Support for this shouldn't really go into the cxacru driver, as that's
for an USB ATM interface (it depends on usbatm for actual ATM traffic)
not ethernet.
Unfortunately it doesn't look like a trivial task to auto-detect which
driver should handle it... your device itself claims to be an "ADSL
Modem".
You'd need to know what type of device it was before loading the
firmware, which would further complicate auto-detection as some custom
firmware may be required that attempts to probe the ...
| Aug 31, 3:15 pm 2010 |
| Ondrej Zary | Re: cxacru: USB ethernet port of CX82310-based ADSL routers?
In fact, it does not. The idProduct text is from usb.ids file (which is often
incorrect). The device says that it's "USB NET CARD" (iProduct). But I don't
Maybe ignoring the device if class is 255 and iProduct is "USB NET CARD" (or
This is from usb.ids ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
All these devices seem to use bDeviceClass 0 and iProduct "ADSL USB MODEM".
--
Ondrej Zary
--
| Aug 31, 3:48 pm 2010 |
| Ondrej Zary | cxacru: USB ethernet port of CX82310-based ADSL routers?
Hello,
I have an ADSL router based on Conexant CX82310 chip. This chip provides both
ethernet and USB interfaces. The ethernet interface is often internally
connected to a 5-port switch (in my case too). The USB interface works as an
ethernet card in Windows (using proprietary driver). In Linux, the cxacru
driver binds to the device but does not work (no wonder - it's doing firmware
things in an attempt to bring an ADSL modem up).
I captured a log from Windows (device connect, DHCP and ...
| Aug 31, 2:13 pm 2010 |
| Steven Rostedt | [PATCH][GIT PULL] tracing/lockdep: Fix dependency of TRA ...
Ingo,
This only fixes a build warning, so I'm guessing that it can wait till
2.6.37. If you think otherwise, I could add it to my tip/perf/urgent
branch instead.
Please pull the latest tip/perf/core tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
tip/perf/core
Steven Rostedt (1):
tracing/lockdep: Fix dependency of TRACE_IRQFLAGS
----
lib/Kconfig.debug | 8 ++++----
1 files changed, 4 insertions(+), 4 ...
| Aug 31, 1:53 pm 2010 |
| Ingo Molnar | Re: [PATCH][GIT PULL] tracing/lockdep: Fix dependency of ...
Pulled, thanks Steve!
Ingo
--
| Aug 31, 2:10 pm 2010 |
| Athanasius | NF_QUEUE: nfq_bind_pf() fails - solution
In the hope that this will make it into Google and help others, and
maybe someone will clarify the Kconfig....
I've just spent a gew hours trying to figure out why simple code
attempting to use Netfilter Queues has been failing to even do the nice
simple nfq_bind_pf(h, AF_INET). I eventually spotted some /proc code
that lead me to find /proc/net/netfilter/nf_queue which contained:
0 NONE
1 NONE
2 ip_queue
3 NONE
4 NONE
5 NONE
6 NONE
7 NONE
8 NONE
9 NONE
10 NONE
11 ...
| Aug 31, 1:15 pm 2010 |
| David Brownell | Re: [PATCH v5] gpio: Add driver for basic memory-mapped ...
Here -EINVAL is more correct there than 0 ...
--
| Aug 31, 1:32 pm 2010 |
| Thomas Meyer | 2.6.36-rc3: WARNING: at net/mac80211/scan.c:269 ieee8021 ...
Hi.
Very rarely I get this warning in my kernel log:
[ 9224.980599] ------------[ cut here ]------------
[ 9224.980622] WARNING: at net/mac80211/scan.c:269 ieee80211_scan_completed+0x19e/0x1a0 [mac80211]()
[ 9224.980627] Hardware name: Aspire 1810T
[ 9224.980630] Modules linked in: fuse coretemp hwmon cpufreq_ondemand acpi_cpufreq mperf ip6t_REJECT nf_conntrack_ipv6 ip6table_filter ip6_tables ipv6 kvm_intel kvm uinput snd_hda_codec_intelhdmi snd_hda_codec_realtek arc4 snd_hda_intel ecb ...
| Aug 31, 1:14 pm 2010 |
| Martin Steigerwald | help with git bisecting a bug 16376: random - possibly R ...
Hi!
I am seeking help with encircling the cause of:
[Bug 16376] random - possibly Radeon DRM KMS related - freezes
https://bugzilla.kernel.org/show_bug.cgi?id=16376
I started a bisection as described in which has been painful for me - at
least for a first time bisection -, but after the second skip of a non-
booting kernel git points me to a kernel that is outside of the initial
range between good and back.
good is: [60b341b778cc2929df16c0a504c91621b3c6a4ad] Linux 2.6.33
bad is: ...
| Aug 31, 12:53 pm 2010 |
| Ken Moffat | Re: help with git bisecting a bug 16376: random - possib ...
While you are bisecting, don't believe the version in Makefile. I
got similarly freaked out a couple of years ago - if I understood
correctly, it's something to do with when a change was created.
The key point is that during bisection the apparent version *can*
go back to a version that appears to be before the initial "good"
kernel.
ken
--
das eine Mal als Tragödie, das andere Mal als Farce
--
| Aug 31, 3:39 pm 2010 |
| Tim Bird | Re: [RFC] Kernel 'boot cache' to reduce boot time
For my part, I think this sounds like a great idea. I have
considered such a mechanism in the past, but never gotten around
to actually designing a solution.
Here are some random thoughts on this idea:
My experience is that we've made good progress on boot time
probing, for fixed hardware. The big problems in the kernel
boot time appear to be with busses that require discovery of
devices, with long timeouts specified in the bus standard and
arbitrary bus connection architecture (I'm ...
| Aug 31, 12:52 pm 2010 |
| Andrew Murray | Re: [RFC] Kernel 'boot cache' to reduce boot time
Hello,
Yes I wanted to see if the community was interested in the general
idea before I considered the implementation in too much detail. Though
the two obvious choices spring to mind. 1) Simply serialise and print
any suitable values to the console - these can be parsed with a
bootscript much like the way you parse initcall_debug. 2) Output these
values to a proc file which the use can extract.
The difficult part as I see it - is passing it back to the kernel - as
you suggested they may be ...
| Aug 31, 1:15 pm 2010 |
| Peter Zijlstra | [RFC][PATCH 0/5] mm, highmem: kmap_atomic rework -v2
Next version of the kmap_atomic rework using Andrew's fancy CPP trickery to
avoid having to convert the whole tree at once.
This is compile tested for i386-allmodconfig, frv, mips-sb1250-swarm,
powerpc-ppc6xx_defconfig, sparc32_defconfig, arm-omap3 (all with
HIGHEM=y).
Boot-tested with: i386-defconfig.
Not tested with:
- tile, stock toolchain doesn't build tile targets
- nm10300, the arch doesn't build with highmem to begin with
Is this something we can live with?
--
| Aug 31, 12:26 pm 2010 |
| Peter Zijlstra | [RFC][PATCH 3/5] mm: Remove pte_*map_nested()
Since we no longer need to provide KM_type, the whole pte_*map_nested()
API is now redundant, remove it.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
arch/alpha/include/asm/pgtable.h | 2 --
arch/arm/include/asm/pgtable.h | 6 ++----
arch/arm/mm/fault-armv.c | 4 ++--
arch/arm/mm/pgd.c | 4 ++--
arch/avr32/include/asm/pgtable.h | 2 --
arch/cris/include/asm/pgtable.h | 2 --
...
| Aug 31, 12:26 pm 2010 |
| Peter Zijlstra | [RFC][PATCH 1/5] mm: strictly nested kmap_atomic
Ensure kmap_atomic usage is strictly nested
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Reviewed-by: Rik van Riel <riel@redhat.com>
---
crypto/async_tx/async_memcpy.c | 2 +-
crypto/blkcipher.c | 2 +-
drivers/block/loop.c | 4 ++--
include/linux/highmem.h | 4 ++--
kernel/power/snapshot.c | 4 ++--
5 files changed, 8 insertions(+), 8 deletions(-)
Index: ...
| Aug 31, 12:26 pm 2010 |
| Peter Zijlstra | [RFC][PATCH 4/5] perf, x86: Fix up kmap_atomic type
Now that the KM_type stuff is history, clean up the compiler warning.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
arch/x86/kernel/cpu/perf_event.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: linux-2.6/arch/x86/kernel/cpu/perf_event.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/cpu/perf_event.c
+++ linux-2.6/arch/x86/kernel/cpu/perf_event.c
@@ -49,7 +49,6 @@ static unsigned long
...
| Aug 31, 12:26 pm 2010 |
| Peter Zijlstra | [RFC][PATCH 5/5] mm: highmem documentation
David asked if I could make a start at documenting some of the highmem issues.
Requested-by: David Howells <dhowells@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
Documentation/vm/highmem.txt | 99 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
Index: linux-2.6/Documentation/vm/highmem.txt
===================================================================
--- /dev/null
+++ linux-2.6/Documentation/vm/highmem.txt
@@ -0,0 +1,99 ...
| Aug 31, 12:26 pm 2010 |
| Peter Zijlstra | [RFC][PATCH 2/5] mm: stack based kmap_atomic
Keep the current interface but ignore the KM_type and use a stack
based approach.
The advantage is that we get rid of crappy code like:
#define __KM_PTE \
(in_nmi() ? KM_NMI_PTE : \
in_irq() ? KM_IRQ_PTE : \
KM_PTE0)
and in general can stop worrying about what context we're in and what
kmap slots might be appropriate for that.
The down-side is that FRV kmap_atomic gets more expensive.
For now we use a CPP trick suggested by Andrew:
#define kmap_atomic(page, args...) ...
| Aug 31, 12:26 pm 2010 |
| Ingo Molnar | Re: [PATCH][GIT PULL][v2.6.36] tracing: Fix a race in fu ...
Pulled, thanks a lot Steve!
Ingo
--
| Aug 31, 2:07 pm 2010 |
| Steven Rostedt | [PATCH v2][GIT PULL][v2.6.36] tracing: Fix a race in fun ...
Ingo,
Please pull this version instead. The only difference is that I Cc'd the
stable list.
Thanks,
-- Steve
Please pull the latest tip/perf/urgent-2 tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
tip/perf/urgent-2
Li Zefan (1):
tracing: Fix a race in function profile
----
kernel/trace/ftrace.c | 15 +++++++++++----
1 files changed, 11 insertions(+), 4 deletions(-)
---------------------------
commit ...
| Aug 31, 1:49 pm 2010 |
| Steven Rostedt | [PATCH][GIT PULL][v2.6.36] tracing: Fix a race in functi ...
Ingo,
I was able to reproduce the bug and also confirmed that this fixed it.
Please pull the latest tip/perf/urgent tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
tip/perf/urgent
Li Zefan (1):
tracing: Fix a race in function profile
----
kernel/trace/ftrace.c | 15 +++++++++++----
1 files changed, 11 insertions(+), 4 deletions(-)
---------------------------
commit 7294923e53b229603c893cbdaeba0c388276ec36
Author: ...
| Aug 31, 12:25 pm 2010 |
| Dave Ludlow | [PATCH] usb: serial: mos7840: Add USB ID to support the ...
Add the USB ID needed to support B&B Electronic's 2-port, optically-isolated,
powered, USB to RS485 converter.
Signed-off-by: Dave Ludlow <dave.ludlow@bay.ws>
---
drivers/usb/serial/mos7840.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 585b7e6..9a5ea9d 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -129,6 +129,7 @@
#define BANDB_DEVICE_ID_USOPTL4_2 0xAC42
...
| Aug 31, 11:26 am 2010 |
| Chase Douglas | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
Yes, but we're only interested in the kernel driver when reviewing this
patch. Leaving the fuzz in as it is has no effect right now on ABS_MT_*
axes. On the other axes, such as the touch orientation, it's probably
I would agree, if there was any jitter to measure. However, I can hold
my fingers on the device and not see any extra events due to jitter.
Simple inspection via evtest has convinced me.
-- Chase
--
| Aug 31, 2:16 pm 2010 |
| Michael Poole | Re: [PATCH 1/6 v2] HID: magicmouse: don't allow hidinput ...
Thanks, this approach makes sense to me.
--
| Aug 31, 4:45 pm 2010 |
| Chase Douglas | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
Because in-kernel defuzzing is turned off for ABS_MT_* axes on
non-slotted MT devices, there will be no change in the number of events
sent to the userspace due to this patch.
Maybe I'm missing something more fundamental. In which case, I'll need
more details to get it through my dense skull :).
-- Chase
--
| Aug 31, 2:27 pm 2010 |
| Henrik Rydberg | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
For type A devices, the filtering is performed in userspace, in mtdev, in the
same manner as it would have been performed in the kernel in the MT slot case.
Therefore, knowing the amount of messages coming out of mtdev is a direct
The jitter is better measured by the actual amount of events.
Henrik
--
| Aug 31, 2:06 pm 2010 |
| Chase Douglas | [PATCH 1/6 v2] HID: magicmouse: don't allow hidinput to ...
From: Chase Douglas <chase.douglas@ubuntu.com>
The driver listens only for raw events from the device. If we allow
the hidinput layer to initialize, we can hit NULL pointer dereferences
in the hidinput layer because disconnecting only removes the hidinput
devices from the hid device while leaving the hid fields configured.
Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
Note that this mimics what the hid-picolcd module does.
drivers/hid/hid-magicmouse.c | 13 ...
| Aug 31, 11:41 am 2010 |
| Chase Douglas | [PATCH 2/6 v2] HID: magicmouse: move features reports to ...
From: Chase Douglas <chase.douglas@ubuntu.com>
By moving the feature reports to an array, we can easily support
more products with different initialization reports. This will be
useful for enabling the Apple Magic Trackpad.
Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
Acked-by: Michael Poole <mdpoole@troilus.org>
---
drivers/hid/hid-magicmouse.c | 35 ++++++++++++++++++++---------------
1 files changed, 20 insertions(+), 15 deletions(-)
diff --git ...
| Aug 31, 11:41 am 2010 |
| Chase Douglas | [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
The Magic Mouse device is very precise. No driver filtering of input
data needs to be performed.
Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
Acked-by: Michael Poole <mdpoole@troilus.org>
---
drivers/hid/hid-magicmouse.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index 98bbc53..0fe2464 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c
@@ -357,11 ...
| Aug 31, 11:41 am 2010 |
| Chase Douglas | [PATCH 5/6 v2] HID: magicmouse: enable Magic Trackpad support
The trackpad speaks a similar, but different, protocol from the magic
mouse. However, only small code tweaks here and there are needed to make
basic multitouch work.
Extra logic is required for single-touch emulation of the touchpad. The
changes made here take the approach that only one finger may emulate the
single pointer when multiple fingers have touched the screen. Once that
finger is raised, all touches must be raised before any further single
touch events can be sent.
Sometimes the ...
| Aug 31, 11:41 am 2010 |
| Chase Douglas | [PATCH 6/6 v2] HID: magicmouse: Adjust major / minor axe ...
From: Henrik Rydberg <rydberg@euromail.se>
By visual inspection, the reported touch_major and touch_minor axes
are roughly a factor of four too small. The factor is approximate,
since the protocol is not known and the HID report encodes touch size
with fewer bits than positions. This patch scales the reported values
by a factor of four.
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
Acked-by: Michael Poole ...
| Aug 31, 11:41 am 2010 |
| Chase Douglas | [PATCH 3/6 v2] HID: magicmouse: simplify touch data bit ...
The new format should be easier to read to determine which bits
correspond to which data. It also brings all the manipulation logic to
the top of the function. This makes size and orientation reading more
clear.
Note that the impetus for this change is the forthcoming support for the
Magic Trackpad, which has a different touch data protocol.
Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
Acked-by: Michael Poole <mdpoole@troilus.org>
---
drivers/hid/hid-magicmouse.c | 25 ...
| Aug 31, 11:41 am 2010 |
| Henrik Rydberg | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
I am still not sure this is a good idea. Bandwidth from MT devices is a big
deal. A statement roughly how much data comes out of mtdev (which does the
filtering for type A devices) before and after this change would be reassuring.
Cheers,
--
| Aug 31, 1:34 pm 2010 |
| Chase Douglas | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
As it is right now, hid-magicmouse doesn't support MT slots. I think all
the fuzz code ends up comparing in the MT case is between one touch and
another touch, not between one touch's current location and its previous
location. If I'm correct, then it means a fuzz > 0 is incorrect for
non-slotted MT devices.
In fact, the code in drivers/input/input.c around line 194 looks like it
discards defuzzing in this case, so one could say this patch is making
things more correct :).
Now a fuzz > 0 ...
| Aug 31, 1:58 pm 2010 |
| Henrik Rydberg | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
All events passes through to mtdev, yes, but mtdev filters a considerable amount
of events from passing through to X drivers like evdev. Thus, the fuzz values
reported in the kernel driver impacts the performance in userspace, even if
filtering is not done in the kernel.
Henrik
--
| Aug 31, 2:39 pm 2010 |
| Henrik Rydberg | Re: [PATCH 5/6 v2] HID: magicmouse: enable Magic Trackpa ...
Thanks for this driver. Comments inline.
The logic using single_touch_id seems complicated. Any chance you could get by
The tracking id reported by the macpad is not ideal; it works more like a slot
that a MT protocol tracking id. Perhaps it is a slot? I would recommend looking
at the recent submissions for bamboo touch, 3m-pct and w8001 to see how the
If the pointer emulation was handled differently, and the above was replaced
with something like
if ...
| Aug 31, 3:00 pm 2010 |
| Henrik Rydberg | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
Per-driver data is more precise than a generic value for all devices. This
thread has documented the details of why there is an interest in the fuzz
values. Skipping the patch until MT slots are implemented or measurements can be
done might be the most sensible thing to do.
Thanks,
Henrik
--
| Aug 31, 3:05 pm 2010 |
| Chase Douglas | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
Yes, there's still per-driver fuzz data. If a device is jittery it makes
sense to set the in-kernel fuzz factor to a reasonable value. If a
device is not jittery, I don't see a need to do any defuzzing of the
values in the driver itself. If we think it's necessary to reduce
bandwidth, then the kernel should be defuzzing uniformly across devices
to compensate. mtdev could do this defuzzing for bandwidth uniformly
too.
As it is, this driver just has an arbitrary value that is not used in
the ...
| Aug 31, 3:29 pm 2010 |
| Chase Douglas | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
My disconnect was that I didn't understand that the fuzz value in the
kernel is exported to userspace. I thought the defuzzing in mtdev was
independent of the defuzzing in the kernel.
Basically, I don't feel I have the time to do the analysis you want
right now. If you really want, I can just remove this change.
-- Chase
--
| Aug 31, 2:51 pm 2010 |
| Chase Douglas | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
On second thought, if there's no jitter from the device, the only reason
to filter is to save bandwidth. The magicmouse devices are very verbose
strictly because they have a higher resolution than most devices. If
that's an issue for userspace, then the filtering should be based on the
resolution. In fact, I see that's what you do in mtdev when the
in-kernel fuzz is 0.
This separates the kernel fuzz into a removal of jitter, and the mtdev
fuzz into a dampening of the number of events passed ...
| Aug 31, 2:56 pm 2010 |
| Henrik Rydberg | Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering
"We" are interested in knowing if this patch makes any sense, given that
filtering is in actuality performed in userspace, and thus modifying this code
changes the stream rate into userspace applications, thank you.
Henrik
--
| Aug 31, 2:18 pm 2010 |
| Ondrej Zary | [PATCH] [resend] savagefb: fix DDC for Savage 4
Hello,
I tested savagefb on 3 different Savage 4 cards:
Diamond Stealth III S520
Number Nine SR9
Datapath Horizon 2S (two savage chips on a PCI card)
it worked except the DDC which did not work on any of them.
Looking at the BIOS code, it does not use MMIO register 0xff20 but CRT
register 0xa0 or 0xb1 - depending on the chip revision and something in
register 0xa6. With this patch, DDC works fine on all 3 cards (even on the
second head of Horizon 2S - although it does not display anything ...
| Aug 31, 11:09 am 2010 |
| Christoph Lameter | Re: [PATCH 2/3] mm: page allocator: Calculate a better e ...
Reviewed-by: Christoph Lameter <cl@linux.com>
--
| Aug 31, 11:20 am 2010 |
| Christoph Lameter | Re: [PATCH 3/3] mm: page allocator: Drain per-cpu lists ...
Reviewed-by: Christoph Lameter <cl@linux.com>
--
| Aug 31, 11:26 am 2010 |
| Christoph Lameter | Re: [PATCH 1/3] mm: page allocator: Update free page cou ...
I already did a
Reviewed-by: Christoph Lameter <cl@linux.com>
I believe?
--
| Aug 31, 11:17 am 2010 |
| Mel Gorman | [PATCH 2/3] mm: page allocator: Calculate a better estim ...
Ordinarily watermark checks are based on the vmstat NR_FREE_PAGES as
it is cheaper than scanning a number of lists. To avoid synchronization
overhead, counter deltas are maintained on a per-cpu basis and drained both
periodically and when the delta is above a threshold. On large CPU systems,
the difference between the estimated and real value of NR_FREE_PAGES can be
very high. If NR_FREE_PAGES is much higher than number of real free page
in buddy, the VM can allocate pages below min watermark, at ...
| Aug 31, 10:37 am 2010 |
| Mel Gorman | [PATCH 0/3] Reduce watermark-related problems with the p ...
Changelog since V3
o Minor clarifications
o Rebase to 2.6.36-rc3
Changelog since V1
o Fix for !CONFIG_SMP
o Correct spelling mistakes
o Clarify a ChangeLog
o Only check for counter drift on machines large enough for the counter
drift to breach the min watermark when NR_FREE_PAGES report the low
watermark is fine
Internal IBM test teams beta testing distribution kernels have reported
problems on machines with a large number of CPUs whereby page allocator
failure ...
| Aug 31, 10:37 am 2010 |
| Mel Gorman | [PATCH 3/3] mm: page allocator: Drain per-cpu lists afte ...
When under significant memory pressure, a process enters direct reclaim
and immediately afterwards tries to allocate a page. If it fails and no
further progress is made, it's possible the system will go OOM. However,
on systems with large amounts of memory, it's possible that a significant
number of pages are on per-cpu lists and inaccessible to the calling
process. This leads to a process entering direct reclaim more often than
it should increasing the pressure on the system and compounding the ...
| Aug 31, 10:37 am 2010 |
| KOSAKI Motohiro | Re: [PATCH 2/3] mm: page allocator: Calculate a better e ...
If my understanding is correct, we have no lock when reading pset->vm_stat_diff.
It mean nr_free_pages can reach negative value at very rarely race. boundary
check is necessary?
--
| Aug 31, 4:37 pm 2010 |
| Mel Gorman | [PATCH 1/3] mm: page allocator: Update free page counter ...
When allocating a page, the system uses NR_FREE_PAGES counters to determine
if watermarks would remain intact after the allocation was made. This
check is made without interrupts disabled or the zone lock held and so is
race-prone by nature. Unfortunately, when pages are being freed in batch,
the counters are updated before the pages are added on the list. During this
window, the counters are misleading as the pages do not exist yet. When
under significant pressure on systems with large numbers of ...
| Aug 31, 10:37 am 2010 |
| KOSAKI Motohiro | Re: [PATCH 1/3] mm: page allocator: Update free page cou ...
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
| Aug 31, 4:27 pm 2010 |
| Justin P. Mattock | [PATCH]Bluetooth:net/bluetooth/hci_core.c Fix system cra ...
When using bluetooth-applet adding my apple magic mouse I'm getting a total system freeze.
I used firescope to grab the crash data(below) The results of the bisect pointed to here:
Bluetooth: Implemented HCI frame reassembly from RX stream
commit:9981151086385eecc2febf4ba95a14593f834b3d
after looking through, and at the crash log, I couldn't help but notice something in there
with IRQ, then after looking at hci_h4.c /* H4 receiver States */ #58 I noticed
#define H4_W4_PACKET_TYPE 0 is at zero ...
| Aug 31, 10:13 am 2010 |
| David Howells | [PATCH 1/3] h8300: IRQ flags should be stored in an unsi ...
Fix h8300's asm/atomic.h to store the IRQ flags in an unsigned long to deal
with warnings of the following type:
/warthog/nfs/linux-2.6-fscache/arch/h8300/include/asm/atomic.h: In function 'atomic_add_return':
/warthog/nfs/linux-2.6-fscache/arch/h8300/include/asm/atomic.h:22: warning: comparison of distinct pointer types lacks a cast
/warthog/nfs/linux-2.6-fscache/arch/h8300/include/asm/atomic.h:24: warning: comparison of distinct pointer types lacks a cast
Signed-off-by: David Howells ...
| Aug 31, 8:52 am 2010 |
| David Howells | [PATCH 3/3] h8300: Fix missing consts in kernel_execve()
Fix missing consts in h8300's kernel_execve():
arch/h8300/kernel/sys_h8300.c: In function 'kernel_execve':
arch/h8300/kernel/sys_h8300.c:59: warning: initialization from incompatible pointer type
arch/h8300/kernel/sys_h8300.c:60: warning: initialization from incompatible pointer type
Signed-off-by: David Howells <dhowells@redhat.com>
---
arch/h8300/kernel/sys_h8300.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/h8300/kernel/sys_h8300.c ...
| Aug 31, 8:52 am 2010 |
| David Howells | [PATCH 2/3] h8300: Fix die()
Fix h8300's die() to take care of a number of problems:
CC arch/h8300/kernel/traps.o
In file included from /warthog/nfs/linux-2.6-fscache/arch/h8300/include/asm/bitops.h:10,
from include/linux/bitops.h:22,
from include/linux/kernel.h:17,
from include/linux/sched.h:54,
from arch/h8300/kernel/traps.c:18:
/warthog/nfs/linux-2.6-fscache/arch/h8300/include/asm/system.h:136: warning: 'struct pt_regs' declared inside parameter ...
| Aug 31, 8:52 am 2010 |
| Jesse Barnes | [git pull] PCI fixes
The following changes since commit
502adf5778f4151dcba3f64dd6ed322151f3712c:
Merge branch 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip (2010-08-24 12:21:49 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6 for-linus
As promised, here are the changes from Rafael and Kenji-san that fix up
our OSC handling to conform much better to what platforms expect. The
patchset does include some ...
| Aug 31, 8:49 am 2010 |
| Julia Lawall | [PATCH 0/4] Add of_node_put to avoid memory leak
These patches introduce calls to of_node_put after various functions that
call of_node_get.
--
| Aug 31, 8:48 am 2010 |
| Wolfram Sang | Re: [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add ...
Hmm, the function you change returns -ENODEV if a clock cannot be found, but
the return type is u32. This should better be 0. Can you take care of this as
well? You could then add my
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
| Aug 31, 9:51 am 2010 |
| Julia Lawall | [PATCH 1/4] drivers/serial/ucc_uart.c: Add of_node_put t ...
Add a call to of_node_put in the error handling code following a call to
of_find_compatible_node or of_find_node_by_type.
This patch also substantially reorganizes the error handling code in the
function, to that it is possible first to jump to code that frees qe_port
and then to jump to code that also puts np.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
local idexpression x;
expression E,E1,E2;
statement S;
@@
*x = ...
| Aug 31, 8:48 am 2010 |
| Wolfgang Grandegger | Re: [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add ...
Acked-by: Wolfgang Grandegger <wg@grandegger.com>
--
| Aug 31, 12:22 pm 2010 |
| Julia Lawall | Re: [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add ...
Add a call to of_node_put in the error handling code following a call to
of_find_matching_node.
This patch also moves the existing call to of_node_put after the call to
iounmap in the error handling code, to make it possible to jump to
of_node_put without doing iounmap. These appear to be disjoint operations,
so the ordering doesn't matter.
This patch furthermore changes the -ENODEV result in the error handling
code for of_find_matching_node to a return of 0, as found in the error
handling ...
| Aug 31, 10:44 am 2010 |
| Julia Lawall | [PATCH 4/4] arch/powerpc/platforms/chrp/nvram.c: Add of_ ...
Add a call to of_node_put in the error handling code following a call to
of_find_node_by_type.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
local idexpression x;
expression E,E1,E2;
statement S;
@@
*x = ...
| Aug 31, 8:48 am 2010 |
| Julia Lawall | [PATCH 2/4] sound/soc/fsl/p1022_ds.c: Add of_node_put to ...
Add a call to of_node_put in the error handling code following a call to
of_parse_phandle.
This patch also moves the existing call to of_node_put tothe end of the
error handling code, to make it possible to jump to of_node_put without
doing the other cleanup operations. These appear to be disjoint
operations, so the ordering doesn't matter.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
local idexpression x;
expression ...
| Aug 31, 8:48 am 2010 |
| Stephane Eranian | [RFC PATCH 2/2] perf_events: add support for per-cpu per ...
This perf tool patch adds the ability to filter monitoring based on container
groups (cgroups) for both perf stat and perf record. The cgroup to monitor are
passed via a new -G option followed by a list of cgroups.
The cgroup filesystem has to be mounted. The tool will find it automatically,
open the right file and pass the descriptor to perf_events.
Example:
$ perf stat -a -e cycles:u -G test1 -- sleep 1
Performance counter stats for 'sleep 1':
9528573157 cycles test1 ...
| Aug 31, 8:25 am 2010 |
| Stephane Eranian | [RFC PATCH 1/2] perf_events: add support for per-cpu per ...
This kernel patch adds the ability to filter monitoring based on
container groups (cgroups). This is for use in per-cpu mode only.
The patch adds perf_event_attr.cgroup, a boolean, to activate
the mode. The cgroup is designated by passing, perf_event_attr.cgroup_fd,
on opened file descriptor to the <mnt>/<cgroup>/perf_event.perf file.
Signed-off-by: Stephane Eranian <eranian@google.com>
--
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 3cb7d04..ed76357 ...
| Aug 31, 8:25 am 2010 |
| Stephane Eranian | [RFC PATCH 0/2] perf_events: add support for per-cpu per ...
This series of patches adds per-container (cgroup) filtering capability
to per-cpu monitoring. In other words, we can monitor all threads belonging
to a specific cgroup and running on a specific CPU.
This is useful to measure what is going on inside a cgroup. Something that
cannot easily and cheaply be achieved with either per-thread or per-cpu mode.
Cgroups can span multiple CPUs. CPUs can be shared between cgroups. Cgroups
can have lots of threads. Threads can come and go during a ...
| Aug 31, 8:25 am 2010 |
| Namhyung Kim | [PATCH v4 2/2] init: use kern_sys_* wrappers instead of ...
replace direct syscall invocations to its wrapper functions defined
in init/sys-wrapper.h. This can remove following sparse warnings:
init/main.c:896:23: warning: cast adds address space to expression (<asn:1>)
...
init/do_mounts.c:220:29: warning: incorrect type in argument 1 (different address spaces)
init/do_mounts.c:220:29: expected char [noderef] <asn:1>*dev_name
init/do_mounts.c:220:29: got char *name
...
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
...
| Aug 31, 8:30 am 2010 |
| Namhyung Kim | [PATCH v4 0/2] init cleanups
Hello,
This patchset tries to cleanup init/initramfs code especially for syscall
invocation which produces many warnings from sparse because of address
space change. This can be done by wrapping each syscall invocation and
doing such conversions in it using kernel_sys_call() macro suggested by
Arnd Bergmann.
This patchset depends on my previous patch "init: mark __user address space
on string literals" [1] now contained in -mm tree. Actually now it can be
replaced by these patches. Andrew, I ...
| Aug 31, 8:30 am 2010 |
| Namhyung Kim | [PATCH v4 1/2] init: add sys-wrapper.h
sys-wrapper.h contains wrapper functions for various syscalls used in init
code. This wrappers handle proper address space conversion so that it can
remove a lot of warnings from sparse.
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
init/sys-wrapper.h | 216 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 216 insertions(+), 0 deletions(-)
create mode 100644 init/sys-wrapper.h
diff --git a/init/sys-wrapper.h ...
| Aug 31, 8:30 am 2010 |
| Linus Walleij | [PATCH] MMC: move regulator handling closer to core v2
After discovering a problem in regulator reference counting I
took Mark Brown's advice to move the reference count into the
MMC core by making the regulator status a member of
struct mmc_host.
I took this opportunity to also implement NULL versions of
the regulator functions so as to rid the driver code from
some ugly #ifdef CONFIG_REGULATOR clauses.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: ...
| Aug 31, 8:26 am 2010 |
| Alan Stern | Re: [PATCH] USB: output an error message when the pipe t ...
This is okay with me. If you're serious about not changing the
behavior merely because debugging is enabled, you could move this test
out of the debug-only region and possibly change the dev_err to
dev_dbg. However doing so might break some devices that are currently
working.
Alan Stern
--
| Aug 31, 7:16 am 2010 |
| Alan Stern | Re: [PATCH] USB: output an error message when the pipe t ...
When the kernel sees those invalid low-speed bulk endpoint descriptors,
it changes its internal copy of the descriptor to interrupt. Hence
when the driver submits interrupt URBs, they work correctly.
Alan Stern
--
| Aug 31, 6:52 am 2010 |
| Xiaofan Chen | Re: [PATCH] USB: output an error message when the pipe t ...
Interesting.
FYI: even though XP/Win2k allow low-speed bulk endpoints, Vista
and Win7 do not allow that.
There are hacks to get around that.
http://www.recursion.jp/avrcdc/lowbulk.html
I took a look at the libusb-win32 source and indeed the author
is using the same trick of submit interrupt URBs.
--
Xiaofan
--
| Aug 31, 7:04 am 2010 |
| Linus Torvalds | Re: [PATCH] mm: Fix hiding the stack guard page in proc
Yes, I think it would be a good idea to try to abstract it out a bit...
Linus
--
| Aug 31, 6:33 am 2010 |
| Stefan Bader | Re: [PATCH] mm: Fix hiding the stack guard page in proc
Quick and dirty (and very untested)
Stefan
| Aug 31, 6:55 am 2010 |
| Stefan Bader | [PATCH] mm: Fix hiding the stack guard page in proc
Looking at the other changes I believe that the logic for proc also needs to
look at the previous vma to decide whether to hide the first page of it or not.
The following patch against current head should fix that (only compile tested here .
I only made the change to task_mmu.c here. But basically its the same check as
in mlock.c. Maybe its would be worth moving the inlines to mm.h.
-Stefan
Current output before:
...
b778e000-b7790000 rw-p 00000000 00:00 0
bfdc8000-bfddd000 rw-p 00000000 ...
| Aug 31, 5:59 am 2010 |
| Linus Walleij | [00/12] DMAENGINE: PL08X driver updates
Hi Dan,
This updates the PL08X driver in the async_tx next branch with
a number of fixes and features, each one pretty self-describing.
This has been tested with the PrimeCell DMA series on the
RealView PB11MPCore and works flawlessly, multiplexing
several virtual clients, both devices (slaves) and memcpy
channels, across only two (!) available physical channels.
If you prefer you can squash these into the initial driver
submission, I don't mind.
Yours,
Linus Walleij
--
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 03/12] DMAENGINE: fetch tasklet struct for PL08X ...
The PL08X include file is using struct tasklet so let us bring this
in apropriately.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
include/linux/amba/pl08x.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/amba/pl08x.h b/include/linux/amba/pl08x.h
index 8435f4a..2bb7ac4 100644
--- a/include/linux/amba/pl08x.h
+++ b/include/linux/amba/pl08x.h
@@ -20,6 +20,7 @@
/* We need sizes of structs from this header */
#include ...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 05/12] DMAENGINE: terminate transfers on PL08X me ...
We need to terminate pending tasklets and be sure to disable not
only the channel but it's IRQ:s when we terminate all work on
a PL08X channel.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/dma/amba-pl08x.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index d1a4813..65f595c 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -312,6 +312,8 @@ static void ...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 10/12] DMAENGINE: move the PL08X to full runtime ...
This change makes the PL08X not being a singleton anymore, this
piece was missing earlier: we move the struct dma_device entries
into the driver state holder. Also flag channels as slaves and
fix up the channel freeing code.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/dma/amba-pl08x.c | 112 +++++++++++++++++++++++++-------------------
include/linux/amba/pl08x.h | 2 +
2 files changed, 66 insertions(+), 48 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c ...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 02/12] DMAENGINE: safeguard PL08X from missing pl ...
The PL08X needs some platform data with channel assignments etc to
work properly, bail out of this is not supplied.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/dma/amba-pl08x.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 2afb4f6..506749b 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -1819,6 +1819,13 @@ static int pl08x_probe(struct ...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 04/12] DMAENGINE: use GFP_NOWAIT for PL08X allocations
Since DMA jobs can be prepared and fired in IRQ context, request
GFP_NOWAIT memory for the structs.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/dma/amba-pl08x.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 506749b..d1a4813 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -628,7 +628,7 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data ...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 12/12] DMAENGINE: define channel states for the PL08X
Instead of strange things like a bool indicating paused state for
channels, let's define a proper channel state and use that. Also
print it out in the debugfs so we get a nice overview of the
channels and states.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/dma/amba-pl08x.c | 70 ++++++++++++++++++++++++++++++++++----------
include/linux/amba/pl08x.h | 22 ++++++++++++-
2 files changed, 74 insertions(+), 18 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c ...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 06/12] DMAENGINE: free txd list if submission fai ...
Sometimes oversubscribed channels fail to mux in a signal line for
the transmission, and we bail out. Make sure we also clean out any
pending txd lists when this happens.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/dma/amba-pl08x.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 65f595c..65892d5 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -1270,6 ...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 01/12] DMAENGINE: remove clock code from PL08X driver
With the introduction of the pclk infrastructure the block clock
is handled by the AMBA PrimeCell bus core, and we can remove the
local references to any clocks.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/dma/amba-pl08x.c | 18 ------------------
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index fc5aaeb..2afb4f6 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ ...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 11/12] DMAENGINE: let PL08X memcpy TXDs wait
This change makes the memcpy transfers wait for a physical channel
to become available if no free channel is available when the job
is submitted. When the first physical channel fires its tasklet,
it will spin over the memcpy channels to see if one of these is
waiting.
This is necessary to get the memcpy semantics right: the generic
memcpy API assume transfers never fail, and with our oversubscribed
physical channels this becomes a problem: sometimes submit would
fail. This fixes it by letting ...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 09/12] DMAENGINE: remove pointless module safegua ...
The PL08X driver safeguards itself from being compiled as a module
for no reason: the Kconfig option is a bool anyway.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/dma/amba-pl08x.c | 12 ------------
1 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index a7ce08e..f80fc4b 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -130,18 +130,6 @@ struct pl08x_driver_data {
...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 07/12] DMAENGINE: add debugfs file for PL08X
This adds a debugfs file for the PL08X showing the current allocation
of physical to virtual channels.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/dma/amba-pl08x.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 57 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 65892d5..a99ad19 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -68,6 +68,8 @@
#include ...
| Aug 31, 5:12 am 2010 |
| Linus Walleij | [PATCH 08/12] DMAENGINE: be more explicit when freeing P ...
The signals connected to the PL08X physical channels shall not
be tangled up with the physical channels themselves. This gets
some reference counting right.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/dma/amba-pl08x.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index a99ad19..a7ce08e 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -449,7 +449,6 @@ ...
| Aug 31, 5:12 am 2010 |
| Alexander Shishkin | [PATCH 1/7] [RFCv4] notify userspace about time changes
Changes since v3:
- broken out separate patches adding time_change_notify syscall to
arm, powerpc, x86, ia64, s390 and blackfin
Changes since v2:
- replaced sysfs interface with a syscall
- added sysctl/procfs handle to set a limit to the number of users
- fixed issues pointed out by Greg.
Changes since v1:
- updated against 2.6.36-rc1,
- added notification/filtering options,
- added Documentation/ABI/sysfs-kernel-time-notify interface description.
Certain userspace applications ...
| Aug 31, 4:45 am 2010 |
| Alexander Shishkin | [PATCH 7/7] wire up sys_time_change_notify() on s390
Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
CC: Heiko Carstens <heiko.carstens@de.ibm.com>
CC: linux390@de.ibm.com
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Jesper Nilsson <jesper.nilsson@axis.com>
CC: David Howells <dhowells@redhat.com>
CC: Christian Borntraeger <borntraeger@de.ibm.com>
CC: "Eric W. Biederman" <ebiederm@xmission.com>
CC: Christoph Hellwig <hch@lst.de>
CC: linux-s390@vger.kernel.org
CC: ...
| Aug 31, 4:45 am 2010 |
| Martin Schwidefsky | Re: [PATCH 7/7] wire up sys_time_change_notify() on s390
On Tue, 31 Aug 2010 14:45:51 +0300
System-call wiring for s390 looks good.
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
--
| Aug 31, 4:53 am 2010 |
| Heiko Carstens | Re: [PATCH 7/7] wire up sys_time_change_notify() on s390
Please add the missing newline. Thanks.
--
| Aug 31, 5:49 am 2010 |
| Alexander Shishkin | Re: [PATCH 7/7] wire up sys_time_change_notify() on s390
Oops. Will do.
--
| Aug 31, 5:53 am 2010 |
| Alexander Shishkin | [PATCH 2/7] wire up sys_time_change_notify() on ARM
sys_time_change_notify() is a new syscall with number and types of
parameters such that no ARM-specific processing is needed.
Tested with 2.6.36-rc3 using Documentation/time-change-notify-example.c.
Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
CC: Russell King <linux@arm.linux.org.uk>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: David Howells <dhowells@redhat.com>
CC: Christoph Hellwig <hch@lst.de>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: ...
| Aug 31, 4:45 am 2010 |
| Mikael Pettersson | Re: [PATCH 2/7] wire up sys_time_change_notify() on ARM
Alexander Shishkin writes:
> sys_time_change_notify() is a new syscall with number and types of
> parameters such that no ARM-specific processing is needed.
>
> Tested with 2.6.36-rc3 using Documentation/time-change-notify-example.c.
>
> Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
> CC: Russell King <linux@arm.linux.org.uk>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: David Howells <dhowells@redhat.com>
> CC: Christoph Hellwig <hch@lst.de>
> CC: "H. Peter ...
| Aug 31, 5:37 am 2010 |
| Alexander Shishkin | Re: [PATCH 2/7] wire up sys_time_change_notify() on ARM
I'm aware of that, but I don't know how to synchronize this with Russell's
devel branch. This patchset applies against 2.6.36-rc3. I guess, when it
comes to merging it, I'll update it against Russell's tree.
Regards,
--
Alex
--
| Aug 31, 5:42 am 2010 |
| Alexander Shishkin | [PATCH 6/7] wire up sys_time_change_notify() on ia64
Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
CC: Tony Luck <tony.luck@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: Arnaldo Carvalho de Melo <acme@redhat.com>
CC: David Howells <dhowells@redhat.com>
CC: Alexander Shishkin <virtuoso@slind.org>
CC: linux-ia64@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
arch/ia64/include/asm/unistd.h | 3 ++-
arch/ia64/kernel/entry.S | 1 +
2 files changed, 3 insertions(+), 1 ...
| Aug 31, 4:45 am 2010 |
| Minkyu Kang | [PATCH] misc: adds support the FSA9480 USB Switch
The FSA9480 is a USB port accessory detector and switch.
This patch adds support the FSA9480 USB Switch.
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/misc/Kconfig | 9 +
drivers/misc/Makefile | 1 +
drivers/misc/fsa9480.c | 556 +++++++++++++++++++++++++++++++++++++++++++++++
include/linux/fsa9480.h | 40 ++++
4 files changed, 606 insertions(+), 0 deletions(-)
create mode 100644 ...
| Aug 31, 3:28 am 2010 |
| Shmulik Ladkani | [PATCH] MIPS: Calculate VMLINUZ_LOAD_ADDRESS based on th ...
Fix VMLINUZ_LOAD_ADDRESS calculation to be based on the length of vmlinux.bin,
the actual uncompressed kernel binary.
Previously it was based on the length of KBUILD_IMAGE (the unstripped ELF
vmlinux), which is bigger than vmlinux.bin.
As a result, vmlinuz was loaded into a memory address higher then actually
needed - a problem for small memory platforms.
Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
---
diff --git a/arch/mips/boot/compressed/Makefile ...
| Aug 31, 3:24 am 2010 |
| wu zhangjin | Re: [PATCH] MIPS: Calculate VMLINUZ_LOAD_ADDRESS based o ...
Hi,
This is a very good fix:
$ ls -sh arch/mips/boot/compressed/vmlinux.bin vmlinux
5.4M arch/mips/boot/compressed/vmlinux.bin 6.9M vmlinux
Thanks very much.
Acked-by: Wu Zhangjin <wuzhangjin@gmail.com>
Regards,
Wu Zhangjin
--
| Aug 31, 8:11 am 2010 |
| Tejun Heo | [GIT PULL] percpu: fixes for v2.6.36-rc3
Hello, Linus.
Please pull from the following branch to receive percpu fixes for
v2.6.36-rc3.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git for-linus
The branch contains four patches. A memory leak in
pcpu_extend_area_map() is fixed. The other three are sparse
annotation and comment update.
Thanks.
Huang Shijie (1):
percpu: fix a memory leak in pcpu_extend_area_map()
Namhyung Kim (3):
percpu: handle __percpu notations in UP accessors
percpu: ...
| Aug 31, 2:46 am 2010 |
| Tejun Heo | [GIT PULL] workqueue: fixes for v2.6.36-rc3
Hello, Linus.
Please pull from the following branch to receive workqueue fixes for
v2.6.36-rc3.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-linus
The branch contains eight patches making the following changes.
* cwq->nr_active could underflow, which could lead to BUG_ON()
triggering on workqueue destruction and other work scheduling
oddities. The fix adds one bit to work struct flags enlarging the
alignment requirement for cpu_workqueues to 256 bytes. This will ...
| Aug 31, 2:38 am 2010 |
| KOSAKI Motohiro | [BUGFIX for 2.6.36][RESEND][PATCH 1/2] oom: remove total ...
ok, this one got no objection except original patch author.
then, I'll push it to mainline. I'm glad that I who stabilization
developer have finished this work.
If you think this patch is slightly large, please run,
% git diff a63d83f42^ mm/oom_kill.c
you'll understand this is minimal revert of unnecessary change.
Thanks.
===================================================================
From 938ce3a7aa79ae4a6cbc275259d586086c41eb87 Mon Sep 17 00:00:00 2001
From: KOSAKI Motohiro ...
| Aug 31, 2:29 am 2010 |
| KOSAKI Motohiro | [BUGFIX for 2.6.36][RESEND][PATCH 2/2] Revert "oom: depr ...
oom_adj is not only used for kernel knob, but also used for
application interface.
Then, adding new knob is no good reason to deprecate it.
Also, after former patch, oom_score_adj can't be used for setting
OOM_DISABLE. We need "echo -17 > /proc/<pid>/oom_adj" thing.
This reverts commit 51b1bd2ace1595b72956224deda349efa880b693.
---
Documentation/feature-removal-schedule.txt | 25 -------------------------
Documentation/filesystems/proc.txt | 3 ---
fs/proc/base.c ...
| Aug 31, 2:30 am 2010 |
| Satoru Takeuchi | [RFC][PATCH] make file's timestamp more accurate
Hi,
linux has supported nanosecond order file's timestamp since 2.5.48.
However current file timestamp is got by current_fs_time() and
is only updated once a tick. It can't say true nanosecond accuracy.
In addition, gettimeofday() before a file operation updating
{a,c,m}time would outstrip file's timestamp because of the difference
about time source between gettimeofday() and file's timestamp.
A certain kind of application would corrupted by this problem.
I attached a most simple patch ...
| Aug 31, 1:42 am 2010 |
| Hendrik Brueckner | [PATCH 2/2] initramfs: Fix initramfs size calculation
The size of a built-in initramfs is calculated in init/initramfs.c by
"__initramfs_end - __initramfs_start". Those symbols are defined in the
linker script include/asm-generic/vmlinux.lds.h:
#define INIT_RAM_FS \
. = ALIGN(PAGE_SIZE); \
VMLINUX_SYMBOL(__initramfs_start) = .; \
*(.init.ramfs) \
...
| Aug 31, 1:23 am 2010 |
| Hendrik Brueckner | [PATCH 0/2] initramfs: Cleanup and fix initramfs size ca ...
Hello Michal, Sam,
I did not see any further comments on the patch series about the
initramfs cleanup and new size calculation.
This is a resend and now I am asking you for your review and ack.
Please let me know if you have questions or comments.
Thanks and kind regards,
Hendrik
--
| Aug 31, 1:23 am 2010 |
| Michal Marek | Re: [PATCH 0/2] initramfs: Cleanup and fix initramfs siz ...
Sorry about that, I don't always have as much time for kbuild as I would
I like the cleanup patch and the thing still survives (very basic)
testing, so
Acked-by: Michal Marek <mmarek@suse.cz>
I'm wondering which tree should these patches go through... Peter, will
you apply them to some branch of tip.git or should I apply them to
kbuild-2.6.git?
Michal
--
| Aug 31, 7:08 am 2010 |
| Hendrik Brueckner | [PATCH 1/2] initramfs: Generalize initramfs_data.xxx.S v ...
Remove initramfs_data.{lzo,lzma,gz,bz2}.S variants and use a common
implementation in initramfs_data.S. The common implementation expects
the file name of the initramfs to be defined in INITRAMFS_IMAGE.
Change the Makefile to set the INITRAMFS_IMAGE define symbol according
to the selected compression method.
Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
---
usr/Makefile | 6 ++++--
usr/initramfs_data.S | 5 +++--
usr/initramfs_data.bz2.S | 29 ...
| Aug 31, 1:23 am 2010 |
| Heiko Carstens | [PATCH V2 4/4] topology: add z11 cpu topology support
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Use the extended cpu topology information that z11 machines provide
to improve the scheduler's decision making.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
arch/s390/Kconfig | 7 +
arch/s390/include/asm/topology.h | 27 +++++--
arch/s390/kernel/topology.c | 150 ++++++++++++++++++++++++---------------
3 files changed, 123 insertions(+), 61 deletions(-)
--- ...
| Aug 31, 1:28 am 2010 |
| Heiko Carstens | [PATCH V2 0/4] sched: add new 'book' scheduling domain
This patch set adds (yet) another scheduling domain to the scheduler. The
reason for this is that the recent (s390) z196 architecture has four cache
levels and uniform memory access (sort of -- see below).
The cpu/cache/memory hierarchy is as follows:
Each cpu has its private L1 (64KB I-cache + 128KB D-cache) and L2 (1.5MB)
cache.
A core consists of four cpus with a 24MB shared L3 cache.
A book consists of six cores with a 192MB shared L4 cache.
The z196 architecture has no SMT.
Also the ...
| Aug 31, 1:28 am 2010 |
| Heiko Carstens | [PATCH V2 1/4] sched: merge cpu_to_core_group functions
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Merge and simplify the two cpu_to_core_group variants so that the
resulting function follows the same pattern like cpu_to_phys_group.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
kernel/sched.c | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff -urpN linux-2.6/kernel/sched.c linux-2.6-patched/kernel/sched.c
--- linux-2.6/kernel/sched.c 2010-08-30 11:21:32.000000000 +0200
+++ ...
| Aug 31, 1:28 am 2010 |
| Heiko Carstens | [PATCH V2 3/4] topology/sysfs: provide book id and sibli ...
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Create attributes
/sys/devices/system/cpu/cpuX/topology/book_id
/sys/devices/system/cpu/cpuX/topology/book_siblings
which show the book id and the book siblings of a cpu.
Unlike the attributes for SMT and MC these attributes are only present if
CONFIG_SCHED_BOOK is set. There is no reason to pollute sysfs for every
architecture with unused attributes.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
...
| Aug 31, 1:28 am 2010 |
| Heiko Carstens | [PATCH V2 2/4] sched: add book scheduling domain
From: Heiko Carstens <heiko.carstens@de.ibm.com>
On top of the SMT and MC scheduling domains this adds the BOOK scheduling
domain. This is useful for NUMA like machines which do not have an interface
which tells which piece of memory is attached to which node or where the
hardware performs striping.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
include/linux/sched.h | 1
include/linux/topology.h | 6 +++
kernel/sched.c | 77 ...
| Aug 31, 1:28 am 2010 |
| Xing Wei | [PATCH v3] input: Add support for Hanwang tablet
From: Xing Wei <weixing@hanwang.com.cn>
Add support for Art Master III tablet of BeiJing HanwangTechnology Co, Ltd.
Signed-off-by: Xing Wei <weixing@hanwang.com.cn>
---
Thanks for dmitry's comment & advice.
And I removed the part -- "Make sure to say Y to 'Mouse support(CONFIG_INPUT_MOUSEDEV)' and/or 'Event interface support'
(CONFIG_INPUT_EVDEV) as well" in the Kconfig.
diff -uprN -X linux-2.6.35.3-vanilla/Documentation/dontdiff linux-2.6.35.3-vanilla/drivers/hid/hid-core.c ...
| Aug 31, 1:14 am 2010 |
| Ingo Molnar | Re: vhost_dev_cleanup() crash: BUG: unable to handle ker ...
This seems to have done the trick, thanks Eric.
s/illegal/invalid
Thanks,
Ingo
--
| Aug 31, 12:19 pm 2010 |
| Ingo Molnar | vhost_dev_cleanup() crash: BUG: unable to handle kernel ...
FYI, there's a new crash in the vnet driver that occasionally triggers
on ordinary host bootups as well, when (non-virtualized) networking
initializes:
[ 86.563889] [<ffffffff81b05655>] page_fault+0x25/0x30
[ 86.569065] [<ffffffff8186d899>] ? vhost_poll_flush+0x11a/0x156
[ 86.575119] [<ffffffff8105f511>] ? kthread_stop+0xa/0x57
[ 86.580544] [<ffffffff8186e535>] vhost_dev_cleanup+0x269/0x271
[ 86.586528] [<ffffffff8186e974>] vhost_net_release+0x48/0x7f
[ 86.592359] ...
| Aug 31, 12:57 am 2010 |
| Eric Dumazet | Re: vhost_dev_cleanup() crash: BUG: unable to handle ker ...
Hi Ingo
Seems to be commit c23f3445e68e1
(vhost: replace vhost_workqueue with per-vhost kthread)
following patch should cure it ?
Thanks
[PATCH] vhost: stop worker only if created
Its illegal to call kthread_stop(NULL)
Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index e05557d..0a00121 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -323,7 +323,8 ...
| Aug 31, 3:50 am 2010 |
| Eric Dumazet | Re: vhost_dev_cleanup() crash: BUG: unable to handle ker ...
Sure !
Just in case, I resubmit the patch, clearing dev->worker, because I am
not sure if vhost_dev_cleanup() can be run several times on same struct
vhost_dev. Patch is needed even if you add this check in kthread_stop()
[PATCH v2] vhost: stop worker only if created
Its currently illegal to call kthread_stop(NULL)
Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
drivers/vhost/vhost.c | 5 ++++-
1 file changed, 4 insertions(+), 1 ...
| Aug 31, 5:05 am 2010 |
| Tejun Heo | Re: vhost_dev_cleanup() crash: BUG: unable to handle ker ...
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
--
| Aug 31, 5:20 am 2010 |
| Ingo Molnar | Re: vhost_dev_cleanup() crash: BUG: unable to handle ker ...
Btw., i think this check should be pushed into kthread_stop() instead -
just like kfree(NULL) is possible as well - it simplifies cleanup
sequences.
Thanks,
Ingo
--
| Aug 31, 4:14 am 2010 |
| Andreas Herrmann | [PATCH] x86, amd: Remove superfluous CPU family/model check
From: Andreas Herrmann <andreas.herrmann3@amd.com>
amd_fixup_dcm() already checks for existence of a CPUID flag, so there
is no point in further restricting this function to run only on
specific CPUs.
In particular this prevents amd_fixup_dcm() to be executed on future
AMD CPU families which might also be available as multi-node
processors. (IMHO this is good reason to tag this patch for stable
trees.)
Cc: stable@kernel.org [.32.x .34.x, .35.x]
Signed-off-by: Andreas Herrmann ...
| Aug 31, 12:33 am 2010 |
| Jiri Slaby | Re: increasing memory alloted for 'init' during kernel boot.
The bad loader probably loads the image wrong (incorrect data or not
whole image).
regards,
--
js
--
| Aug 31, 5:51 am 2010 |
| Sam Ravnborg | Re: increasing memory alloted for 'init' during kernel boot.
Shmulik just posted a patch that may be related.
See: "MIPS: Calculate VMLINUZ_LOAD_ADDRESS based on the length of vmlinux.bin"
Looks like a bug I have introduced btw :-(
Sam
--
| Aug 31, 5:58 am 2010 |
| Jiri Slaby | Re: increasing memory alloted for 'init' during kernel boot.
Nope. It's code and data inside .init, .exit and similar sections. Those
are marked by __init, __exit etc. in the code. This memory is freed
after the kernel is up and running, since this memory (code and data) is
not needed anymore.
regards,
--
js
--
| Aug 31, 1:22 am 2010 |
| Prabhu Chawandi | Re: increasing memory alloted for 'init' during kernel boot.
Hi ,
Thanks for the info...
Problem I am facing is, I have two bootloaders, when I boot from one
loader booting happens properly.
but when I try to load from other loader, kernel does not boot, it
crashes. When i saw the boot logs, I saw that I memory allocated to
'init' section in case of crash is short by almost 5MB to the normal
boot log.
I am using mips processor.
Any idea, why this might be happening ?
thanks,
Prabhu
--
| Aug 31, 1:43 am 2010 |
| Prabhu Chawandi | increasing memory alloted for 'init' during kernel boot.
Hi all,
Whenever the kernel starts booting, I am getting the bellow log :
Memory: 110080k/262144k available (2566k kernel code, 151952k
reserved, 561k data, 15328k init, 0k highmem).
For 'init' on what bases this amount of memory is decided ?
Anyways I can alter it?
Thanks in advance,
Prabhu
--
| Aug 30, 11:49 pm 2010 |
| Yong Wang | [PATCH] spi/dw_spi: Enable Intel Moorestown SPI controller 1
Enable Intel Moorestown SPI controller 1
Signed-off-by: Yong Wang <yong.y.wang@intel.com>
---
drivers/spi/dw_spi_pci.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/dw_spi_pci.c b/drivers/spi/dw_spi_pci.c
index 1f52755..eec9d0b 100644
--- a/drivers/spi/dw_spi_pci.c
+++ b/drivers/spi/dw_spi_pci.c
@@ -142,6 +142,8 @@ static int spi_resume(struct pci_dev *pdev)
static const struct pci_device_id pci_ids[] __devinitdata = {
/* Intel Moorestown ...
| Aug 30, 11:14 pm 2010 |
| Feng Tang | Re: [PATCH] spi/dw_spi: Enable Intel Moorestown SPI cont ...
NAK.
We should not export SPI1 has x86 core has no way to access its register.
though the device physically exists.
Thanks,
Feng
On Tue, 31 Aug 2010 14:14:16 +0800
--
| Aug 31, 12:39 am 2010 |
| Benjamin Herrenschmidt | [git pull] Please pull powerpc.git merge branch
Hi Linus !
Here's a few small fixes, one is an important fix for a nasty regression
breaking pseries machine running under hypervisor... oops !
Cheers,
Ben.
The following changes since commit 2bfc96a127bc1cc94d26bfaa40159966064f9c8c:
Linus Torvalds (1):
Linux 2.6.36-rc3
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git merge
Matthew McClintock (1):
powerpc/kexec: Adds correct calling convention for kexec ...
| Aug 30, 10:56 pm 2010 |
| Wolfram Sang | Re: [PATCH] stmpe-gpio: Handle platform data with no gpio base
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
| Aug 31, 2:24 am 2010 |
| Virupax Sadashivpetimath | [PATCH] stmpe-gpio: Handle platform data with no gpio base
This patch removes the requirement that gpio base be supplied in
platform data.
Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/gpio/stmpe-gpio.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/stmpe-gpio.c b/drivers/gpio/stmpe-gpio.c
index 65b9960..932759d 100644
--- a/drivers/gpio/stmpe-gpio.c
+++ b/drivers/gpio/stmpe-gpio.c
@@ -291,8 +291,6 @@ ...
| Aug 30, 9:34 pm 2010 |
| Stephen Rothwell | linux-next: Tree for August 31
Hi all,
Changes since 20100830:
My fixes tree contains:
powerpc: don't use kernel stack with translation off
The kvm tree lost its build failure.
The net tree lost its build failure but gained another so I reverted a
commit.
I still have a patch to the drivers-x86 tree to remove a Kconfig warning.
----------------------------------------------------------------------------
I have created today's linux-next tree ...
| Aug 30, 8:33 pm 2010 |
| Stephen Rothwell | linux-next: build failure after merge of the final tree ...
Hi ,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/net/starfire.c: In function 'starfire_init':
drivers/net/starfire.c:2081: error: negative width in bit-field '<anonymous>'
This is:
BUILD_BUG_ON(sizeof(dma_addr_t) != sizeof(netdrv_addr_t));
in starfire_init().
Immediate cause is commit 56543af9563d91c1c5596a7980b416389bdea071
("starfire: use BUILD_BUG_ON for netdrv_addr_t").
The real cause is the complete mess at the start ...
| Aug 30, 8:18 pm 2010 |
| David Miller | Re: linux-next: build failure after merge of the final t ...
From: Stephen Rothwell <sfr@canb.auug.org.au>
I anticipated this and Fujita is working on a solution involving
adding a CONFIG_DMA_ADDR_T_64BIT that the starfire can check
instead of that ugly CPP test.
--
| Aug 30, 9:43 pm 2010 |
| Haojian Zhuang | Re: [PATCH 4/5] ARM: pxa168: added special case handler ...
Why should you clear wakeup event status in IRQ handler? If system is
resumed by keypad event, you should clear this wakeup source in resume
code. I think that IRQ code should not be binded with wakeup event at
--
| Aug 30, 9:53 pm 2010 |
| Eric Miao | Re: [PATCH 1/5] ARM: pxa27x/pxa3xx: moved pxa27x_keypad. ...
Good move. I'm actually very inclined to move this into include/linux/input/.
And you may try '-M' when generating patches with 'git format-patch', and
--
| Aug 30, 9:13 pm 2010 |
| Mark F. Brown | Re: [PATCH 4/5] ARM: pxa168: added special case handler ...
Ok if you are fine with that I will make that change and resubmit!
Regards,
-- Mark
--
| Aug 31, 12:13 am 2010 |
| Eric Miao | Re: [PATCH 4/5] ARM: pxa168: added special case handler ...
I'd rather the irq handler not being changed and use platform_data instead.
How about something below:
diff --git a/arch/arm/mach-mmp/include/mach/pxa168.h
b/arch/arm/mach-mmp/include/mach/pxa168.h
index 27e1bc7..d2b7946 100644
--- a/arch/arm/mach-mmp/include/mach/pxa168.h
+++ b/arch/arm/mach-mmp/include/mach/pxa168.h
@@ -5,6 +5,7 @@ struct sys_timer;
extern struct sys_timer pxa168_timer;
extern void __init pxa168_init_irq(void);
+extern void pxa168_clear_keypad_wakeup(void);
...
| Aug 31, 12:05 am 2010 |
| Eric Miao | Aug 31, 12:15 am 2010 | |
| Haojian Zhuang | Re: [PATCH 2/5] ARM: pxa168: added keypad support
It seems good. Acked
--
| Aug 30, 9:56 pm 2010 |
| Haojian Zhuang | Aug 30, 10:00 pm 2010 | |
| Mark F. Brown | Re: [PATCH 4/5] ARM: pxa168: added special case handler ...
On Tue, Aug 31, 2010 at 12:53 AM, Haojian Zhuang
Haojian, this is an usual case, but without that clear wake event you
will not be able to clear the keypad interrupt. For my push to open
source I re-wrote the workaround code and added it as a special case
IRQ handler. In the Marvell pxa168 code base it is actually located in
the keypad interrupt handler as the function clear_wakeup(). I felt it
was better to isolate this code in the mmp common code base instead.
Regards,
-- Mark
--
| Aug 30, 11:28 pm 2010 |
| Eric Miao | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
Not sure if this correct. But normally reset jump happens after we turn
--
| Aug 30, 10:48 pm 2010 |
| Mark F. Brown | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
Eric, the boot-rom for pxa168 starts at 0xffff_0000. I am pretty sure
about that! If you set the reset vector to 0x0 it will crash during
reboot. I will send you xdb snapshots if you need me to.
Regards,
-- Mark
--
| Aug 30, 11:02 pm 2010 |
| Eric Miao | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
OK, you are expert on this :-)
Applied to 'fix'.
--
| Aug 30, 11:04 pm 2010 |
| Haojian Zhuang | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
The reset code is in below.
.align 5
ENTRY(cpu_mohawk_reset)
mov ip, #0
mcr p15, 0, ip, c7, c7, 0 @ invalidate I,D caches
mcr p15, 0, ip, c7, c10, 4 @ drain WB
mcr p15, 0, ip, c8, c7, 0 @ invalidate I & D TLBs
mrc p15, 0, ip, c1, c0, 0 @ ctrl register
bic ip, ip, #0x0007 @ .............cam
bic ip, ip, #0x1100 @ ...i...s........
mcr p15, 0, ip, c1, c0, 0 @ ctrl register
mov pc, r0
MMU is disabled at here and replace PC with r0 value. I doubt code
executed correctly at ...
| Aug 30, 11:26 pm 2010 |
| Mark F. Brown | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
That will work!
-- Mark
--
| Aug 31, 12:24 am 2010 |
| Haojian Zhuang | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
In early boot code, 1:1 (physical:virtual) mapping is used. It means
that physical address is same as virtual address. So you can operature
mmu as you wish.
By the way, I don't suggest to reset CPU by this way. Reset is not
only make code running from the head, it should also clear registers
and RTL logic in CPU.
--
| Aug 31, 12:02 am 2010 |
| Haojian Zhuang | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
Yes, it depends on reset signal. Watchdog timer is built in pxa168. So
I think that watchdog reset could be better.
--
| Aug 31, 12:21 am 2010 |
| Eric Miao | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
On Tue, Aug 31, 2010 at 3:02 PM, Haojian Zhuang
Depends on if pxa168 has a reset signal asserted from internal or from
external GPIO, which is controllable from the CPU itself. That's what
pxa is doing at this moment.
--
| Aug 31, 12:08 am 2010 |
| Eric Miao | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
On Tue, Aug 31, 2010 at 3:21 PM, Haojian Zhuang
Haojian, note we have a reboot mode, so possibly will have to implement
all of them if capable.
--
| Aug 31, 12:27 am 2010 |
| Mark F. Brown | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
On Tue, Aug 31, 2010 at 3:21 AM, Haojian Zhuang
Haojian,
That is true, I am planning to send an update to support watchdog
timer reset soon. The problem is I need to test pxa910 and mmp2 as
well and determine if the watchdog reset code is consistent. It was
simpler for me to just fix this at the moment.
--
| Aug 31, 12:28 am 2010 |
| Eric Miao | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
This fix can go ahead in my POV.
--
| Aug 31, 12:28 am 2010 |
| Eric Miao | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
It does depend on the prefetch unit for that. So the branch instruction
--
| Aug 30, 11:54 pm 2010 |
| Eric Miao | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
One moment. Since this is really global to pxa910 and mmp2, so I
suggest this being fixed for pxa168 only first. How about this:
ARM: pxa168: fix corrected reset vector
Reset vector for pxa168 is 0xffff_0000 not 0x0. This fix allows
reboot to work
Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
diff --git a/arch/arm/mach-mmp/include/mach/system.h
b/arch/arm/mach-mmp/include/mach/system.h
index 4f5b0e0..1a8a25e 100644
--- ...
| Aug 30, 11:08 pm 2010 |
| Mark F. Brown | Re: [PATCH 1/1] ARM: pxa168: fix corrected reset vector
On Tue, Aug 31, 2010 at 2:26 AM, Haojian Zhuang
Haojian,
I think there is a pipeline execution of the mov pc, r0 instruction.
If I remember correctly you need to do a similar jump when you turn
the MMU on in early boot code. If it makes any difference I did test
this code on pxa168 before submitting it. I will double check the mmp2
and the pxa910 reset vectors with the Boot ROM developers.
--
| Aug 30, 11:48 pm 2010 |
| Haojian Zhuang | Re: [PATCH] ARM: pxa3xx: fix build error when CONFIG_MTD ...
Hi Mark,
Don't forget to cc maintainer of mtd tree. I loop them now.
Thanks
Haojian
--
| Aug 30, 10:51 pm 2010 |
| Artem Bityutskiy | Re: [PATCH] ARM: pxa3xx: fix build error when CONFIG_MTD ...
FYI, the MTD maintainer id dwmw2, I'm just helping him sometimes.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
--
| Aug 31, 4:31 pm 2010 |
| Stephen Rothwell | linux-next: build warnings after merge of the net tree
Hi all,
After merging the net tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:
In file included from drivers/net/stmmac/stmmac_ethtool.c:30:
drivers/net/stmmac/stmmac.h:111: warning: 'struct platform_device' declared inside parameter list
drivers/net/stmmac/stmmac.h:111: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/net/stmmac/stmmac_main.c: In function ...
| Aug 30, 6:55 pm 2010 |
| David Miller | Re: linux-next: build warnings after merge of the net tree
From: Stephen Rothwell <sfr@canb.auug.org.au>
...
I've checked the following into net-next-2.6 to combat-this (see,
proactively fixing warnings in code I'm more or less responsible for
instead of letting the issue rot for 2 months :-):
--------------------
stmmac: Fix build warnings.
In file included from drivers/net/stmmac/stmmac_ethtool.c:30:
drivers/net/stmmac/stmmac.h:111: warning: 'struct platform_device' declared inside parameter list
drivers/net/stmmac/stmmac.h:111: warning: its ...
| Aug 30, 9:56 pm 2010 |
| Dan Magenheimer | RE: [PATCH V4 5/8] Cleancache: ext3 hook for cleancache
IIRC, I think I was trying to stay away from including
fs.h in cleancache.h (or one of its predecessors). I
agree that that no longer makes sense and it is cleaner
as you suggest. Will change.
Thanks,
Dan
--
| Aug 30, 5:57 pm 2010 |
| caiqian | Re: kdump regression compared to v2.6.35
Unable to reproduce it any more after applied the patch,
NET: Registered protocol family 16
ACPI FADT declares the system doesn't support PCIe ASPM, so disable it
ACPI: bus type pci registered
PCI: MMCONFIG for domain 0000 [bus 00-ff] at [mem 0x80000000-0x8fffffff] (base 0x80000000)
PCI: MMCONFIG at [mem 0x80000000-0x8fffffff] reserved in E820
PCI: Using configuration type 1 for base access
bio: create slab <bio-0> at 0
XXX kintegrityd: rescuer dispatching to cpu0
XXX kintegrityd: rescuer ...
| Aug 30, 5:53 pm 2010 |
| Tejun Heo | Re: kdump regression compared to v2.6.35
Hello,
Thanks for verifyiing. Can you please apply this patch on top and
check that those debug messages go away?
Thanks.
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index c8183b2..7855429 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -196,7 +196,7 @@ typedef cpumask_var_t mayday_mask_t;
cpumask_test_and_set_cpu((cpu), (mask))
#define mayday_clear_cpu(cpu, mask) cpumask_clear_cpu((cpu), (mask))
#define for_each_mayday_cpu(cpu, mask) for_each_cpu((cpu), ...
| Aug 31, 2:22 am 2010 |
| Dan Magenheimer | RE: [PATCH V4 4/8] Cleancache: VFS hooks for cleancache
If there are any inodes in the page cache that point to
this superblock, a cleancache_put_page may happen asynchronously
that grabs from page->...->i_sb->cleancache_poolid.
If the cleancache_flush_fs races with it and another
cleancache_init_fs happens after the cleancache_put_page
gets the poolid, the poolid could be stale.
Yeah, I decided to defer to Chris Mason's wisdom and left it. :-)
--
| Aug 30, 5:48 pm 2010 |
| Dan Magenheimer | RE: [PATCH V4 3/8] Cleancache: core ops functions and co ...
OK, will do.
Thanks for the feedback!
Dan
--
| Aug 30, 5:40 pm 2010 |
| Greg KH | Re: [PATCH] West Bridge Astoria Driver 2.6.35
I get a build error when I try to build this driver:
drivers/staging/westbridge/astoria/block/../include/linux/westbridge/cyasmisc.h:521:2: error: expected declaration specifiers or ‘...’ before ‘cy_as_hal_device_tag’
It looks like the #include mess isn't working quite properly.
Also note that this driver is building on an x86-64 platform, which is
something that you probably don't want :)
So, for now, I'll just mark the driver as CONFIG_BROKEN and can you send
me some Kconfig patches ...
| Aug 30, 5:27 pm 2010 |
| David Cross | RE: [PATCH] West Bridge Astoria Driver 2.6.35
drivers/staging/westbridge/astoria/block/../include/linux/westbridge/c>
yasmisc.h:521:2: error: expected declaration specifiers or '...' before >
Sure, I can do that. I have since changed the Kconfig structure a bit. It
actually will build properly with the correct .config as it is though. I can
send you the .config if you would like.
Thanks,
David
---------------------------------------------------------------
This message and any attachments may contain Cypress (or its
subsidiaries) ...
| Aug 31, 9:17 am 2010 |
| Greg KH | Re: [PATCH] West Bridge Astoria Driver 2.6.35
It's up to the Kconfig rules to ensure that there can never be a
"non-correct" .config file, so that needs to be fixed so that the build
will never be broken no matter what type of options are selected.
Care to send a patch for that?
thanks,
greg k-h
--
| Aug 31, 9:32 am 2010 |
| Daniel Walker | Re: [PATCH 1/2] msm: Install the Google-Android gpio driver.
Macro please.
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
| Aug 31, 9:46 am 2010 |
| Daniel Walker | Re: [PATCH 1/2] msm: Install the Google-Android gpio driver.
Arve, Are you planning to move this forward or is Greg going to? I've
asked Greg (or you) for some changes to this.. If you have a problem
with the changes please speak up ..
The signed-off is wrong on this commit also, You need to sign off on the
commit (and Greg if needed).
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
| Aug 31, 2:50 pm 2010 |
| Gregory Bean | [PATCH 1/2] msm: Install the Google-Android gpio driver.
From: Arve Hjønnevåg <arve@android.com>
As part of the ongoing effort to converge on a common code base,
adopt the Google-Android msmgpio driver, as it has a stronger pedigree
than the previous submission from codeaurora.
Cc: Arve Hjønnevåg <arve@android.com>
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
---
arch/arm/mach-msm/Makefile | 3 +
arch/arm/mach-msm/gpio.c | 627 +++++++++++++++++++++++++++++++++++++++++++
arch/arm/mach-msm/gpio_hw.h | 277 +++++++++++++++++++
3 ...
| Aug 30, 5:18 pm 2010 |
| Daniel Walker | Re: [PATCH 1/2] msm: Install the Google-Android gpio driver.
Can you drop everything that's un-used .. There's also the enter/exit
sleep functions, which I'm pretty sure aren't used. Also break this into
two patches one for gpio and another for the interrupt component ..
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
| Aug 31, 9:50 am 2010 |
| Gregory Bean | [PATCH 2/2] msm: gpio: Add gpiomux calls to request and free.
Add gpiomux get and put calls to msmgpio request and free,
in order to allow gpio lines to be properly reference-counted
and power-managed.
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
---
arch/arm/mach-msm/gpio.c | 27 +++++++++++++++++++++++++++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-msm/gpio.c b/arch/arm/mach-msm/gpio.c
index fd899a1..ea93ecb 100644
--- a/arch/arm/mach-msm/gpio.c
+++ b/arch/arm/mach-msm/gpio.c
@@ -21,6 +21,7 @@
#include ...
| Aug 30, 5:18 pm 2010 |
| Florian Fainelli | Re: [PATCH v2] GPIO: add support for 74HC164 serial-in/p ...
Hi David,
Allright, I will respin with those changes. Note that I chose to prefix the
data structures with gen_ (for obvious C language reasons), I hope this is
The board this driver is being used on had no SPI signals left I think, so it
was hooked up on separate GPIO lines (which cannot be muxed to the GPIO pad).
--
Florian
--
| Aug 31, 1:17 am 2010 |
| Florian Fainelli | [PATCH v3] GPIO: add support for 74x164 serial-in/parall ...
From: Miguel Gaio <miguel.gaio@efixo.com>
This patch adds support for generic 74x164 serial-in/parallel-out 8-bits
shift register. This driver can be used as a GPIO output expander.
Signed-off-by: Miguel Gaio <miguel.gaio@efixo.com>
Signed-off-by: Juhos Gabor <juhosg@openwrt.org>
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
Changes since v1:
- renamed nxp_ to gen_ since this driver is generic to all 74HC164 chips
- added comment on this driver not handling the 74HC164 ...
| Aug 31, 3:44 am 2010 |
| Simon Arlott | Re: [PATCH] cxacru: Use a bulk URB to access the command ...
Please drop this patch, I'll make a version that detects which type of
endpoint it is and uses an interrupt or bulk URB as appropriate. Some
devices which may/may not be compatible appear to have interrupt
command endpoints as referenced in the original comment.
--
Simon Arlott
--
| Aug 31, 3:06 pm 2010 |
| Simon Arlott | Re: [PATCH] USB: output an error message when the pipe t ...
If the transfer type doesn't match the pipe type then yes, but only when
CONFIG_USB_DEBUG is enabled.
Perhaps these need to be moved to a CONFIG_USB_STRICT. Having a "debug" mode
change the behaviour is not a good idea, but some of the code in that ifdef
has been there since the import to git.
Regardless of which configuration option enables it, the pipe type
check needs an error message to explain why the driver received -EPIPE.
--
Simon Arlott
--
| Aug 31, 4:31 am 2010 |
| Clemens Ladisch | Re: [PATCH] USB: output an error message when the pipe t ...
I didn't see that commit last year, but wouldn't it break devices like
the ESI MIDI Mate whose descriptors want to have low-speed bulk transfers
and where the driver has to submit interrupt transfers instead to get it
to work at all?
Regards,
Clemens
--
| Aug 30, 11:41 pm 2010 |
| Herbert Xu | Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB ...
I don't quite understand the problem. Does the packet actually
have IP options? If not why is it trying to look at IP options?
If it does have options, then we should parse options in the
bridge driver before passing it to the IP stack (or just drop
the packet).
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
| Aug 31, 1:24 am 2010 |
| Eric Dumazet | Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB ...
Reading this stuff again, I wonder if we should not revert commit
17762060c25590bfddd and use a different trick
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon Jul 5 21:29:28 2010 +0000
bridge: Clear IPCB before possible entry into IP stack
The bridge protocol lives dangerously by having incestuous relations
with the IP stack. In this instance an abomination has been created
where a bogus IPCB area from a bridged packet leads to a crash in
the IP ...
| Aug 30, 10:20 pm 2010 |
| Herbert Xu | Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB ...
OK, so we're talking about a locally transmitted packet, with
IP options leaving the IP stack, entering bridging, and then
reentering the IP stack?
In that case the packet should no longer be treated as an IP
packet when it enters the bridge. So if it did have options
and we want to support that in bridging then we need to parse
IP options there as my comment suggested.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: ...
| Aug 31, 5:36 am 2010 |
| Eric Dumazet | Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB ...
Once again, the IP stack -> bridge -> IP stack flow bites us,
because bridge likes to dirty IPCB.
We can correct every bug we find once in a while (you did in commit
17762060c255 for a particular bug), or just make bridge not touch IPCB.
--
| Aug 31, 2:17 am 2010 |
| Bandan Das | Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB ...
That flow is correct. Sorry about the stack trace, it's now pasted
below. But I am still wondering : Why not make sure in ip_fragment()
that we do not have a corrupt CB ? Today, it's the bridge, tomorrow it will be
someone else that would be doing this.
08-31 09:38:23 [root@kvm ~]# Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: ffffffff8146dd13
08-31 09:38:32
08-31 09:38:32 Pid: 3209, comm: qemu-kvm Not tainted 2.6.32-63.el6.bdas.x86_64 #1
08-31 09:38:32 Call ...
| Aug 31, 6:50 am 2010 |
| Eric Dumazet | Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB ...
Bandan did not provide a full stack trace,
but I believe the problem was :
br_nf_dev_queue_xmit() -> ip_fragment -> icmp_send() ->
ip_options_echo() : crash, because ip_options_echo take bridge CB as
IPCB data.
http://www.spinics.net/lists/netdev/msg139370.html
--
| Aug 31, 6:13 am 2010 |
| Anton Vorontsov | [PATCH v5] gpio: Add driver for basic memory-mapped GPIO ...
The basic GPIO controllers may be found in various on-board FPGA
and ASIC solutions that are used to control board's switches, LEDs,
chip-selects, Ethernet/USB PHY power, etc.
Usually these controllers do not privide any means of pin setup
(in/out/open drain).
The driver provides:
- Support for 8/16/32/64 bits registers;
- Support for GPIO controllers with clear/set registers;
- Support for GPIO controllers with a single "data" register;
- Support for big endian bits/GPIOs ordering (mostly ...
| Aug 31, 10:58 am 2010 |
| Mark Brown | Re: [PATCH v5] gpio: Add driver for basic memory-mapped ...
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
--
| Aug 31, 11:21 am 2010 |
| Namhyung Kim | Re: [PATCH v3 1/2] init: add sys-wrapper.h
I see. Will change it.
Thanks.
--
Regards,
Namhyung Kim
--
| Aug 31, 7:34 am 2010 |
| Sam Ravnborg | Re: [PATCH v3 1/2] init: add sys-wrapper.h
Good.
Except that we usually recommend to include files from include/linux
if thye exist rather than asm/xxx
I asked git:
$ git grep kern_ | wc -l
962
$ git grep kernel_ | wc -l
6361
There seems to be preference for kernel_
Sam
--
| Aug 31, 7:30 am 2010 |
| Namhyung Kim | Re: [PATCH v3 1/2] init: add sys-wrapper.h
Hi,
OK. Then, how about this?
(I added <asm/uaccess.h> and removed <linux/fcntl.h> because I think it is
more appropriate.)
/*
* wrappers for various syscalls for use in the init code
*
* Copyright (C) 2010 Namhyung Kim <namhyung@gmail.com>
*
* This file is released under the GPLv2.
*/
#include <linux/syscalls.h>
#include <linux/dirent.h>
#include <linux/types.h>
#include <linux/fs.h>
No, usual strings are in kernel space but syscall requires its arguments
to be ...
| Aug 31, 7:16 am 2010 |
| David Howells | Re: [PATCH RFC] pid: make setpgid() system call use RCU ...
I would generally put the rcu lock outside the IRQ disabled section on the
basis that it's better to keep the amount of time we have interrupts disabled
'Reported-by' might be more consistent with what others use.
David
--
| Aug 31, 6:02 am 2010 |
| David Howells | Re: [PATCH RFC] pid: make setpgid() system call use RCU ...
Acked-by: David Howells <dhowells@redhat.com>
--
| Aug 31, 8:31 am 2010 |
| Paul E. McKenney | Re: [PATCH RFC] pid: make setpgid() system call use RCU ...
Good points, how about the following?
Thanx, Paul
------------------------------------------------------------------------
pid: make setpgid() system call use RCU read-side critical section
[ 23.584719]
[ 23.584720] ===================================================
[ 23.585059] [ INFO: suspicious rcu_dereference_check() usage. ]
[ 23.585176] ---------------------------------------------------
[ 23.585176] kernel/pid.c:419 invoked rcu_dereference_check() without ...
| Aug 31, 8:12 am 2010 |
| Tejun Heo | Re: [PATCH 2/2] idr: describe how nextidp works in idr_g ...
Hello,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
--
| Aug 31, 12:41 am 2010 |
| Naohiro Aota | Re: [PATCH 2/2] idr: describe how nextidp works in idr_g ...
Thanks, the fixed patch below.
==
From 6c61c97b5b85a350e3f195309b70a271457208ca Mon Sep 17 00:00:00 2001
From: Naohiro Aota <naota@elisp.net>
Date: Fri, 27 Aug 2010 17:43:46 +0900
Subject: [PATCH 2/2] idr: describe how nextidp works in idr_get_next().
It was unclear in original kernel-doc how nextidp worked in
idr_get_next(). Let's describe it.
Signed-off-by: Naohiro Aota <naota@elisp.net>
---
lib/idr.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git ...
| Aug 30, 9:02 pm 2010 |
| Jiri Kosina | Re: [PATCH 1/2] idr: fix kernel-doc warnings.
Applied, thanks.
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
| Aug 31, 12:32 am 2010 |
| Jiri Kosina | Re: [PATCH 2/2] idr: describe how nextidp works in idr_g ...
Applied, thanks.
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
| Aug 31, 12:44 am 2010 |
| Alexander Graf | Re: hv block drivers
It's basically the same as the VMware PV SCSI driver, no? And that one is in drivers/scsi/vmw_pvscsi.c.
Alex
--
| Aug 31, 3:46 am 2010 |
| Frederic Weisbecker | Aug 31, 8:21 am 2010 | |
| Matt Fleming | Re: [RFC][PATCH 1/5] perf: Check if we should exclude id ...
This patch isn't really worth it on its own, I only grouped the idle
check into perf_exclude_event() because patch 3/5 introduced a new
caller. As you've said, the semantics at the various callsites are
quite complex. It's probably best to wait for your patchset :)
--
| Aug 31, 8:20 am 2010 |
| Frederic Weisbecker | Re: [RFC][PATCH 1/5] perf: Check if we should exclude id ...
Right.
But one of the problems people have reported is that they can miss
interrupts samples if they happen in idle. Hence we have decided
that exclude_idle should exclude events that happen in idle process
context but not in interrupts interrupting idle.
So adding an in_interrupt() check would perhaps be better.
I plan to do this exclusion using the per context exclusion, which is
But yeah if we add an in_interrupt() check in perf_exclude_event(), it
won't work here. This one ...
| Aug 31, 7:54 am 2010 |
| Kukjin Kim | RE: [PATCH 3/3] ARM: Samsung S3C: Move/use the S3C commo ...
I think that we dont need to change for it.
I don't think so, I meant that it is used for external interrupt not gpio.
And it used currently for external interrupt.
So, I said that no need to change it now.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
| Aug 31, 4:49 pm 2010 |
| Arun MURTHY | Aug 31, 2:29 am 2010 | |
| Tejun Heo | Re: [PATCH 4/5] dm: implement REQ_FLUSH/FUA support for ...
Can you please try this one instead?
Thanks.
---
block/blk-flush.c | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
Index: block/block/blk-flush.c
===================================================================
--- block.orig/block/blk-flush.c
+++ block/block/blk-flush.c
@@ -56,22 +56,38 @@ static struct request *blk_flush_complet
return next_rq;
}
+static void blk_flush_complete_seq_end_io(struct request_queue *q,
+ unsigned seq, int ...
| Aug 31, 3:29 am 2010 |
| Mike Snitzer | Re: [PATCH 4/5] dm: implement REQ_FLUSH/FUA support for ...
On Tue, Aug 31 2010 at 6:29am -0400,
Still hit the hang on the 5th iteration of my test:
while true ; do ./test_dm_discard_mpath.sh && sleep 1 ; done
Would you like me to (re)send my test script offlist?
INFO: task vgcreate:2617 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
vgcreate D ffff88007bf7ba00 4688 2617 2479 0x00000080
ffff88007bf7b998 0000000000000046 ffff880000000000 ffff88007bf7bfd8
ffff88005542a430 ...
| Aug 31, 6:02 am 2010 |
| Paul Menage | Re: hello, Is there any documentation about CFS and cgroup??
Try Documentation/cgroups/cgroups.txt and Documentation/scheduler/*
Paul
--
| Aug 31, 2:43 pm 2010 |
| Lai Jiangshan | Re: [PATCH, RFC] RCU: New scalable, multi-GP and preempt ...
Only in x86(32bit and 64bit) system.
Did you patch it in power and test it? It' need more test for different archs,
but I have no other arch.
correct. A GP is also controled by a set ring counters in
(domain's done_complete, this GP's complete], this GP is only completed
until all these conters become zero.
No.
any rcu read site has a locked_complete, if a cpu hold a locked_complete,
the counter of this locked_complete will not become zero.
Any quiescent states will release its ...
| Aug 30, 8:03 pm 2010 |
| Jean Delvare | Re: [Patch-next -v2]therm_throt.c: Trival fix for a unsu ...
--
Jean Delvare
--
| Aug 30, 11:56 pm 2010 |
| Jin Dongming | [Patch-next -v2]therm_throt.c: Trival fix for a unsuitab ...
In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
in error message.
I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a ...
| Aug 30, 5:13 pm 2010 |
| Fenghua Yu | Aug 31, 10:30 am 2010 | |
| Gui Jianfeng | Re: [RFC] [PATCH] cfq-iosched: add cfq group hierarchica ...
Hi Vivek,
This patch doesn't break the original sheduling logic. That is cfqg => st => cfqq.
If q1 and q2 in root group, I treat q1 and q2 bundle as a queue sched entity, and
it will schedule on root group service with G1, as following:
root group
/ \
qse(q1,q2) gse(G1)
Thanks,
--
| Aug 30, 5:29 pm 2010 |
| Gui Jianfeng | Re: [RFC] [PATCH] cfq-iosched: add cfq group hierarchica ...
Thanks for reviewing Chad.
I will modify the name.
Thanks,
--
| Aug 30, 5:35 pm 2010 |
| Vivek Goyal | Re: [RFC] [PATCH] cfq-iosched: add cfq group hierarchica ...
Ok. That's interesting. That raises another question that how hierarchy
should look like. IOW, how queue and groups should be treated in
hierarchy.
CFS cpu scheduler treats queues and group at the same level. That is as
follows.
root
/ | \
q1 q2 G1
In the past I had raised this question and Jens and corrado liked treating
queues and group at same level.
Logically, q1, q2 and G1 are all children of root, so it makes sense to
treat them at same level and not group q1 ...
| Aug 31, 5:57 am 2010 |
| Nauman Rafique | Re: [RFC] [PATCH] cfq-iosched: add cfq group hierarchica ...
Vivek, may be I am reading you wrong here. But you are first
suggesting to add more complexity to treat queues and group at the
same level. Then you are suggesting add even more complexity to fix
the problems caused by that approach.
Why do we need to treat queues and group at the same level? "CFS does
it" is not a good argument. Please suggest cases in which it would be
--
| Aug 31, 8:40 am 2010 |
| Vivek Goyal | Re: [RFC] [PATCH] cfq-iosched: add cfq group hierarchica ...
Sure it is not a very good argument but at the same time one would need
a very good argument that why we should do things differently.
- If a user has mounted cpu and blkio controller together and both the
controllers are viewing the same hierarchy differently, then it is
odd. We need a good reason that why different arrangement makes sense.
- To me, both group and cfq queue are children of root group and it
makes sense to treat them independent childrens instead of putting
all the ...
| Aug 31, 12:25 pm 2010 |
| Kan-Ru Chen | Re: [Bug #16307] i915 in kernel 2.6.35-rc3, high number ...
Same with v2.6.36-rc3
$ sudo powertop -d -t 20
...
Wakeups-from-idle per second : 196.2 interval: 20.0s
no ACPI power usage estimate available
Top causes for wakeups:
25.4% ( 59.6) [i915@pci:0000:00:02.0] <interrupt>
...
- Kanru
--
| Aug 30, 7:19 pm 2010 |
| M. Vefa Bicakci | Re: [Bug #16771] [Bisected Regression in 2.6.35] A full ...
Dear Rafael Wysocki,
This regression still exists in 2.6.35.4. (I haven't tested 2.6.36-rcX
series.) Kosaki Motohiro has kindly helped me with this issue and found
a fix for the regression. Today I have successfully tested his patch,
but I don't know whether the patch needs to be further refined and tested.
Regards,
M. Vefa Bicakci
--
| Aug 31, 7:40 am 2010 |
| Enrico Bandiello | Re: [Bug #16307] i915 in kernel 2.6.35-rc3, high number ...
I can confir this behaviour until 2.6.32-rc2. Couldn't try with -rc3
because compilation exited with error on my laptop...
--
| Aug 31, 12:38 am 2010 |
| Rafael J. Wysocki | Re: [Bug #16771] [Bisected Regression in 2.6.35] A full ...
Thanks for the information. Do you have a pointer to the patch?
Rafael
--
| Aug 31, 1:19 pm 2010 |
| Jarek Poplawski | Re: [Bug #16626] Machine hangs with EIP at skb_copy_and_ ...
If/since it's on by default it should work and it definitely can't be
your mistake. (Unless we can't find the real reason... ;-)
Jarek P.
--
| Aug 31, 12:26 pm 2010 |
| Alan Cox | Re: [RFC 0/5] tty: move stuff around
On Tue, 31 Aug 2010 08:08:57 +0200
There certainly were people using it, which suggests maybe it needs
looking at not binning.
Alan
--
| Aug 31, 2:33 am 2010 |
| Mike Frysinger | Re: [RFC 0/5] tty: move stuff around
right ... as long as it isnt hvc, it should be .../tty/hw/. when/if
it is converted to hvc, i'll also take care of moving it to the hvc/
subdir.
ive opened a tracker item for the issue, but no promise as to when
i'll look into it :p.
-mike
--
| Aug 31, 8:53 am 2010 |
| Joe Perches | Re: [PATCH 1/1] MAINTAINERS: remove isicom
Perhaps it's better to remove your name
and set the status to Orphan instead.
--
| Aug 31, 8:03 am 2010 |
| Jiri Slaby | Re: [RFC 0/5] tty: move stuff around
Ok, thanks. Anyway I'll remove myself as a maintainer, since I'm not
anymore.
--
js
suse labs
--
| Aug 31, 2:19 am 2010 |
| Jiri Slaby | Re: [RFC 0/5] tty: move stuff around
Are you sure about isicom:
https://bugzilla.kernel.org/show_bug.cgi?id=11067
? The last kernel he tried was 2.6.28 and there isicom sleeps forever in
isicom_open.
thanks,
--
js
suse labs
--
| Aug 30, 11:08 pm 2010 |
| Greg KH | Re: [RFC 0/5] tty: move stuff around
Sounds great, thanks for doing this.
greg k-h
--
| Aug 30, 9:11 pm 2010 |
| Alan Cox | Re: [RFC 0/5] tty: move stuff around
Mostly locking - it's not a trivial entry point thing. The gs layer for
example was full of races and needed rewriting so just got declared
Did that several years ago. I think you still need to use the ioctl
because several years is apparently a bit short for glibc to get with it
Mostly done. See tty_port_*
Alan
--
| Aug 31, 4:23 am 2010 |
| Jiri Slaby | [PATCH 1/1] MAINTAINERS: remove isicom
I do not maintain isicom anymore...
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
MAINTAINERS | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e24eb2d..8bab6f3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3923,12 +3923,6 @@ S: Maintained
F: Documentation/sound/oss/MultiSound
F: sound/oss/msnd*
-MULTITECH MULTIPORT CARD (ISICOM)
-M: Jiri Slaby ...
| Aug 31, 2:19 am 2010 |
| Arnd Bergmann | Re: [RFC 0/5] tty: move stuff around
The most important question is whether you think that there are people
somewhere in the world that are using the device drivers on machines
with recent kernels.
If you still get bug reports for the drivers, that would be a clear
indication to make them stay, while if you haven't heard from a user
during the last five years, it's probably obsolete enough that it
can be removed (after a few kernels of grace period in drivers/staging).
Arnd
--
| Aug 31, 4:54 am 2010 |
| Rogier Wolff | Re: [RFC 0/5] tty: move stuff around
Hi,
The question is whether I want the drivers I wrote to stay or to
go away?
I was paid years ago to make Linux support the Specialix cards. It
started with one card from their line of "solutions", but the others
followed.
I personally don't use "serial" very much anymore. If I do, I end up
getting an USB-serial converter for $3 in China (includes shipping).
But my personal interest in the serial protocol is that I interface
with microcontrollers. The mess of the +/- 12V levels is a ...
| Aug 31, 3:42 am 2010 |
| Greg KH | Re: [RFC 0/5] tty: move stuff around
And it is always possible to revert a removal at a later time and fix up
a driver if someone does show up in a few years asking where the driver
went.
thanks,
greg k-h
--
| Aug 31, 6:32 am 2010 |
| Jiri Slaby | [PATCH 1/1] MAINTAINERS: orphan isicom
I do not maintain isicom anymore...
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
MAINTAINERS | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e24eb2d..8313ce3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3924,8 +3924,7 @@ F: Documentation/sound/oss/MultiSound
F: sound/oss/msnd*
MULTITECH MULTIPORT CARD (ISICOM)
-M: Jiri Slaby <jirislaby@gmail.com>
-S: Maintained
+S: Orphan
F: drivers/char/isicom.c
...
| Aug 31, 8:08 am 2010 |
| Arnd Bergmann | Re: [RFC 0/5] tty: move stuff around
Geert, can you comment on the 68k serial drivers? Which
I'll leave isicom then.
Specialix is marked in MAINTAINERS as supported by Roger, ip2
is maintained by Michael, maybe they have a preference for their
drivers.
Both drivers have a web page that is ~10 years old, which hints
Not yet ;-)
You didn't reply to my question why it couldn't be. I'll let Mike
judge this one when he has looked at the hvc infrastructure.
I wouldn't move it to that directory unless the code gets ...
| Aug 31, 2:26 am 2010 |
| Kumar Gala | Re: [PATCH] arch/powerpc/platforms/83xx/mpc837x_mds.c: A ...
applied to merge
- k
--
| Aug 31, 2:39 pm 2010 |
| K. Richard Pixley | Re: BTRFS: Unbelievably slow with kvm/qemu
On 20100831 14:46, Mike Fedyk wrote:
> There is little reason not to use duplicate metadata. Only small
> files (less than 2kb) get stored in the tree, so there should be no
> worries about images being duplicated without data duplication set at
> mkfs time.
My benchmarks show that for my kinds of data, btrfs is somewhat slower
than ext4, (which is slightly slower than ext3 which is somewhat slower
than ext2), when using the defaults, (ie, duplicate metadata).
It's a hair faster than ...
| Aug 31, 3:01 pm 2010 |
| Mike Fedyk | Re: BTRFS: Unbelievably slow with kvm/qemu
There is little reason not to use duplicate metadata. Only small
files (less than 2kb) get stored in the tree, so there should be no
worries about images being duplicated without data duplication set at
mkfs time.
--
| Aug 31, 2:46 pm 2010 |
| Robert Richter | Re: [PATCH 0/3] stop OProfile calling arch_exit when arc ...
I have applied patch #1 and #2 to
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git core
with some small modifications:
Patch #1: Commit message, x86 removed.
Patch #2: Order of freeing memory:
+out:
+ if (ret) {
+ for_each_possible_cpu(cpu)
+ kfree(perf_events[cpu]);
+ kfree(counter_config);
+ }
+
There is also the patch below on top of it.
Thanks Will,
-Robert
--
From ...
| Aug 31, 4:01 am 2010 |
| Robert Richter | Re: [PATCH 3/3] x86: oprofile: fix oprofile_arch_init be ...
For x86 wont change the code (actually I found a bug in the init_sysfs
error handler for which I will send a fix). Just wanted to get your
confirmation in case I was missing something that x86 is not affected.
I will apply the first 2 patches, no need to resubmit.
Thanks Will.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
--
| Aug 31, 2:05 am 2010 |
| Robert Richter | Re: [PATCH 3/3] x86: oprofile: fix oprofile_arch_init be ...
Ok, will change this.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
--
| Aug 31, 2:47 am 2010 |
| Will Deacon | Re: [PATCH 3/3] x86: oprofile: fix oprofile_arch_init be ...
Robert,
The original code called op_nmi_exit() from oprofile_arch_exit()
regardless of whether or not op_nmi_init() had succeeded. Actually, it
turns out that this is ok because of this guy:
/* in order to get sysfs right */
static int using_nmi;
which is set by the nmi_init function and checked by nmi_exit.
Do you think it would be better to rework this patch so that the static
using_nmi variable is set explicitly by init.c, or shall I just drop
this patch altogether (and resubmit ...
| Aug 31, 1:54 am 2010 |
| Robert Richter | [PATCH] oprofile, x86: fix init_sysfs error handling
This is the patch, applied to:
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
-Robert
--
From 10f0412f57f2a76a90eff4376f59cbb0a39e4e18 Mon Sep 17 00:00:00 2001
From: Robert Richter <robert.richter@amd.com>
Date: Mon, 30 Aug 2010 10:56:18 +0200
Subject: [PATCH] oprofile, x86: fix init_sysfs error handling
On failure init_sysfs() might not properly free resources. The error
code of the function is not checked. And, when reinitializing the exit
function might ...
| Aug 31, 3:30 am 2010 |
| Will Deacon | Re: [PATCH 3/3] x86: oprofile: fix oprofile_arch_init be ...
Ok, great. The commit comment might need tweaking for the first
patch now that the x86 code remains unchanged.
Cheers,
Will
--
| Aug 31, 2:31 am 2010 |
| tip-bot for Konrad R ... | [tip:x86/iommu] x86, iommu: Fix IOMMU_INIT alignment rules
Commit-ID: 7ac41ccf47d82569d26f34beab1dec92cc3b6347
Gitweb: http://git.kernel.org/tip/7ac41ccf47d82569d26f34beab1dec92cc3b6347
Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
AuthorDate: Mon, 30 Aug 2010 14:10:02 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 31 Aug 2010 08:06:10 +0200
x86, iommu: Fix IOMMU_INIT alignment rules
This boot crash was observed:
DMA-API: preallocated 32768 debug entries
DMA-API: debugging enabled by kernel config
BUG: unable ...
| Aug 31, 12:27 am 2010 |
| Mark Brown | Re: [PATCH] MMC: move regulator handling closer to core
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
It'd be nice to display the error code as well. I do tend to agree with
Adrian that it might be nice to have the noop functions in the header to
allow the optimiser to play with them as well but it's unlikely to be a
big deal.
--
| Aug 31, 5:22 am 2010 |
| Linus Walleij | Re: [PATCH] MMC: move regulator handling closer to core
Yeah I know. This bit was to increase readability, explicitly showing
the power state like this makes it more clear what is happening I think.
The rest of the comments are fixed, new patch soon.
Yours,
Linus Walleij
--
| Aug 31, 7:35 am 2010 |
| KOSAKI Motohiro | Re: [PATCH] vmscan: prevent background aging of anon pag ...
To be honest, I don't mind the difference between you and Ying's version. because
_practically_ swap full occur mean the application has a bug. so, proper page aging
doesn't help so much. That's the reason why I said I prefer simper. I don't have
Yes, It makes embedded happy :)
--
| Aug 30, 6:38 pm 2010 |
| KOSAKI Motohiro | Re: [PATCH] vmscan: prevent background aging of anon pag ...
Do you really check it on your gcc? nr_swap_pages is not file scope variable, it's
global variable. afaik, current gcc's link time optimization is not so cool.
Do you have a disassemble list?
--
| Aug 30, 6:18 pm 2010 |
| KOSAKI Motohiro | Aug 30, 5:56 pm 2010 | |
| Minchan Kim | Re: [PATCH] vmscan: prevent background aging of anon pag ...
On Tue, Aug 31, 2010 at 11:09 AM, KOSAKI Motohiro
Thanks.
--
Kind regards,
Minchan Kim
--
| Aug 30, 8:47 pm 2010 |
| KOSAKI Motohiro | Re: [PATCH] vmscan: prevent background aging of anon pag ...
Yup. I prefer this explicit #ifdef :)
--
| Aug 30, 7:09 pm 2010 |
| Minchan Kim | Re: [PATCH] vmscan: prevent background aging of anon pag ...
Hi, KOSAKI.
On Tue, Aug 31, 2010 at 9:56 AM, KOSAKI Motohiro
My intention is that smart gcc can compile out inactive_anon_is_low
call in case of non swap configurable system.
--
Kind regards,
Minchan Kim
--
| Aug 30, 6:10 pm 2010 |
| KOSAKI Motohiro | Re: [PATCH] vmscan: prevent background aging of anon pag ...
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
I think both Ying's and Minchan's opnion are right and makes sense. however I _personally_
like Ying version because 1) this version is simpler 2) swap full is very rarely event 3)
no swap mounting is very common on HPC. so this version could have a chance to
improvement hpc workload too.
In the other word, both avoiding unnecessary TLB flush and keeping proper page aging are
performance matter. so when we are talking ...
| Aug 30, 5:56 pm 2010 |
| Rik van Riel | Re: [PATCH] vmscan: prevent background aging of anon pag ...
It may be a good thing, since swap will often be freed again
(when something is swapped in, or exits).
Having some more anonymous pages sit on the inactive list
gives them a chance to get used again, potentially giving
us a better chance of preserving the working set when swap
is full or near full a lot of the time.
--
All rights reversed
--
| Aug 30, 7:30 pm 2010 |
| Minchan Kim | Re: [PATCH] vmscan: prevent background aging of anon pag ...
On Tue, Aug 31, 2010 at 10:18 AM, KOSAKI Motohiro
#else /* CONFIG_SWAP */
#define nr_swap_pages 0L
#define total_swap_pages 0L
environment for test :
gcc : arm-none-linux-gnueabi-gcc (Sourcery G++ Lite 2009q3-67) 4.4.1
kernel : 2.6.28(for test, I used my working kernel version with my patch)
assembled function is shrink_zone.
(Please understand web gmail's contents mangling. Google guys! Please
repair for like me who can't use SMTP in ...
| Aug 30, 6:36 pm 2010 |
| Minchan Kim | Re: [PATCH] vmscan: prevent background aging of anon pag ...
On Tue, Aug 31, 2010 at 9:56 AM, KOSAKI Motohiro
Ying's one and mine both has a same effect.
Only difference happens swap is full. My version maintains old
behavior but Ying's one changes the behavior. I admit swap full is
rare event but I hoped not changed old behavior if we doesn't find any
problem.
If kswapd does aging when swap full happens, is it a problem?
We have been used to it from 2.6.28.
If we regard a code consistency is more important than _unexpected_
result, Okay. I don't ...
| Aug 30, 6:23 pm 2010 |
| Minchan Kim | Re: [PATCH] vmscan: prevent background aging of anon pag ...
On Tue, Aug 31, 2010 at 10:38 AM, KOSAKI Motohiro
How about this?
(Not formal patch. If we agree, I will post it later when I have a SMTP).
Signed-off-by: Ying Han <yinghan@google.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 3109ff7..c3c44a8 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1579,7 +1579,7 @@ static void shrink_active_list(unsigned long
nr_pages, struct zone *zone,
__mod_zone_page_state(zone, ...
| Aug 30, 7:02 pm 2010 |
| KOSAKI Motohiro | Re: [PATCH] vmscan: prevent background aging of anon pag ...
Thanks, I'm convinced.
--
| Aug 30, 6:41 pm 2010 |
| Minchan Kim | Re: [PATCH] vmscan: prevent background aging of anon pag ...
Do you mean we would be better to do background aging when swap is full?
I wanted it. So I used total_swap_pages to protect working set when
swap is full.
But Ying and KOSAKI's don't like it since it makes code inconsistent
or not simply.
And I agree it's rare event as KOSAKI mentioned.
Hmm... What do you think about it?
If you don't mind, I will resend latest version(use nr_swap_page usage
and compile out inactive_anon_is_low in case of !CONFIG_SWAP).
--
Kind regards,
Minchan ...
| Aug 30, 8:46 pm 2010 |
| Kumar Gala | Re: [PATCH 5/7] arch/powerpc/sysdev/qe_lib/qe.c: Add of_ ...
applied to merge
- k
--
| Aug 31, 2:41 pm 2010 |
| Julia Lawall | Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_ ...
Perhaps there are some characters after eg PowerBook that one doesn't want
to compare with?
julia
--
| Aug 31, 9:08 am 2010 |
| Grant Likely | Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_ ...
Model does have \0 at the end. This code is using strncmp to
We use strcmp when parsing the device tree because the the length of
the model property string is unknown and in most cases we *must* match
the exact entire string, such as with this PowerMac7,2 example. Using
strncmp would also happen to match with something like
"PowerMac7,2345" which is not the desired behaviour.
g.
--
| Aug 31, 9:33 am 2010 |
| Grant Likely | Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_ ...
Yes. The model property on powermacs always has the version number. strncmp makes sure that *all* PowerBooks and iBooks are matched.
g.
--
| Aug 31, 9:13 am 2010 |
| Vasiliy Kulikov | Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_ ...
It seems to me that model has no '\0' in the end. If model is got from
the hardware then we should double check it - maybe harware is buggy.
Otherwise we'll overflow model.
But why strcmp(model, "PowerMac7,2")? IMO it should be replaced
with strncmp().
--
Vasiliy
--
| Aug 31, 9:16 am 2010 |
| Benjamin Herrenschmidt | Re: [PATCH 08/20] powerpc: Preemptible mmu_gather
Unfortunately, I think this is broken...
Here, you are coming out of _switch() which will have swapped the
stack and non-volatile registers to the state they were in when the
new task was originally switched-out. Thus "new" which is a local variable
(either on stack or in a non-volatile register) will now refer to whatever
was the next task back then.
I suppose that's what's causing the similar patch you have in -rt to
fail btw. This could be fixed easily by using "current" ...
| Aug 30, 11:26 pm 2010 |
| Benjamin Herrenschmidt | Re: [PATCH 08/20] powerpc: Preemptible mmu_gather
And here's a fix. Using current_thread_info() everywhere is better
anyways, you are not supposed to touch the local_flags within anything
but "current" so we may as well make it explicit.
Feel free to fold that into your -rt patch and this one if you decide
not to drop that whole part.
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 6ee4b09..6e8b6de 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -517,12 +517,12 @@ struct ...
| Aug 30, 11:31 pm 2010 |
| Benjamin Herrenschmidt | Re: [PATCH 01/20] powerpc: Use call_rcu_sched() for pagetables
So as per discussions with Paul Mck, that should be correct,
thus
--
| Aug 30, 11:10 pm 2010 |
| Piotr Hosowicz | Re: [PATCH 00/20] mm: Preemptibility -v4
Now I had done it the second way you described and everything seems to
be working ok.
aapi205:~# uname -r
2.6.36-rc3-20100831-1507-pz+
If there will be any problems I'll write here.
Regards,
Piotr Hosowicz
--
Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach:
- Który aktor amerykański jest mężem Nicole Kidman?
- Forrest Gump.
NP: Peter Green Splinter Group - You'll Be Sorry Someday
NB: 2.6.36-rc3-20100831-1507-pz+
--
| Aug 31, 7:02 am 2010 |
| Piotr Hosowicz | Re: [PATCH 00/20] mm: Preemptibility -v4
Sorry, I made a mistake - I had built it the first way.
Regards and sorry for the noise,
Piotr Hosowicz
--
Janusz Korwin-Mikke:
"Idiota z dyplomem to taki sam idiota,
jak przedtem - tylko z pretensjami."
NP: Peter Green Splinter Group - Tribal Dance
NB: 2.6.36-rc3-20100831-1507-pz+
--
| Aug 31, 7:14 am 2010 |
| Peter Zijlstra | Re: [PATCH 08/20] powerpc: Preemptible mmu_gather
Indeed, those parts are only strictly needed for -rt, I was hoping the
tiny bit of overhead wouldn't be too bad and we could keep it.
If not I guess we should put those two bits in __switch_to() under
Thanks! And yeah I'd prefer to keep it to reduce Thomas' burden if
possible.
--
| Aug 31, 2:14 am 2010 |
| Xiao Guangrong | Re: [PATCH v2 5/5] KVM: MMU: lower the aduit frequency
There is a simply test in the guest if it's not rate limit:
# time ls
anaconda-ks.cfg Documents install.log Music Public Videos
Desktop Downloads install.log.syslog Pictures Templates
real 1m26.053s
user 0m0.311s
sys 0m1.813s
'ls' command cost about 1.5 minute, if we run the memory test program, i think
the time/delay is unacceptable...... :-(
--
| Aug 30, 7:27 pm 2010 |
| Calvin Walton | Re: [Question] How to test (DRAM) memory location.
If you can, it's best to just use code other people have already
written :)
If you can reboot the computer to test the memory, Memtest86+ is a
well-known and very reliable tool which does just what you ask. You can
obtain it from http://www.memtest.org/
There's some work done on an in-kernel memory tester, but testing memory
while Linux is running is somewhat limited as there are sections of
memory that you can't overwrite during testing. Take a look at
CONFIG_MEMTEST and ...
| Aug 30, 5:57 pm 2010 |
| santosh | Fwd: [Question] How to test (DRAM) memory location.
---------- Forwarded message ----------
From: santosh <santosh.iitg@gmail.com>
Date: Tue, Aug 31, 2010 at 4:05 PM
Subject: Re: [Question] How to test (DRAM) memory location.
To: Calvin Walton <calvin.walton@gmail.com>
Thanks Calvin for your response.
I will give a try and let you if I face any issue.
regards
Santosh
--
| Aug 31, 3:36 am 2010 |
| KOSAKI Motohiro | Re: [PATCH 4/4] writeback: Reporting dirty thresholds in ...
For reviewers view, we are reviewing your patch to merge immediately if all issue are fixed.
Then, I'm unhappy if you don't drop merge blocker item even though you merely want asking.
At least, you can make separate thread, no?
Of cource, wen other user also want to expose via /proc interface, we are resume
this discusstion gradly.
--
| Aug 30, 6:07 pm 2010 |
| Wu Fengguang | Re: [PATCH 4/4] writeback: Reporting dirty thresholds in ...
Michael asked promoting the dirty thresholds from debugfs to /proc.
As a developer I'd interpret the question as: will there be enough
applications/admins using it? If not, we'd better keep it as debugfs.
Otherwise it benefits to do the interface promotion now, because it
will hurt to accumulate many end user dependencies on debugfs over
time..
Thanks,
Fengguang
--
| Aug 30, 6:32 pm 2010 |
| Michael Rubin | Re: [PATCH 3/4] writeback: nr_dirtied and nr_cleaned in ...
OK.
May not get patch out today but will incorporate these fixes. Thank you again.
mrubin
--
| Aug 30, 11:09 pm 2010 |
| Wu Fengguang | Re: [PATCH 3/4] writeback: nr_dirtied and nr_cleaned in ...
Thanks. In the same directory you can find a different style example
/sys/devices/system/node/node0/numastat :) If ever the file was named
Thanks. This is kind of nitpick, however here is another name by
Jan Kara: BDI_WRITTEN. BDI_WRITTEN may not be a lot better than
BDI_CLEANED, but here is a patch based on Jan's code. I'm cooking
more patches that make use of this per-bdi counter to estimate the
bdi's write bandwidth, and to further decide the optimal (large)
writeback chunk size as well as ...
| Aug 31, 12:48 am 2010 |
| Ingo Molnar | Re: [tip:core/memblock] memblock: Rename memblock_region ...
Btw., because this is an older base, before we can push this to
linux-next i suspect we'll need fixes for those architectures that did a
memblock conversion in this cycle?
Thanks,
Ingo
--
| Aug 31, 12:29 am 2010 |
| Ingo Molnar | Re: [tip:core/memblock] memblock: Rename memblock_region ...
Here's the current state of things, with the x86 conversion in place and
freshly merged up to v2.6.36-rc3:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86/memblock
Any necessary changes due to new bits in .36-rc3 should be done now,
before we progress any further.
Thanks,
Ingo
--
| Aug 31, 12:49 am 2010 |
| Kay Sievers | Re: selinux vs devtmpfs (vs udev)
I can't access these bugs.
Does that makes sense/work for you?
http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=326c5fc3ea684825629ecca...
Kay
--
| Aug 31, 12:32 pm 2010 |
| Harald Hoyer | Re: selinux vs devtmpfs (vs udev)
The RH udev guy says:
This patch was introduced, because Red Hat engineers requested, that the selinux
context should not be modified, after they set their own custom context (virtual
machine management).
So, either we differentiate between "add" and "change" events, or we should
check against the "kernel default" selinux context, before we call
udev_selinux_lsetfilecon().
--
| Aug 31, 1:44 am 2010 |
| Harald Hoyer | Re: selinux vs devtmpfs (vs udev)
Exactly my patch :)
--
| Aug 31, 2:55 pm 2010 |
| Eric Paris | Re: selinux vs devtmpfs (vs udev)
initial task == /sbin/init
actually I should look if the kernel init_cred (what devtmpfs uses to
make security decisions) is initrc_t or kernel_t. I'm guessing it is
kernel_t but I'm not certain how that gets set.....
-Eric
--
| Aug 31, 8:26 am 2010 |
| Eric Paris | Re: selinux vs devtmpfs (vs udev)
I ask Harald (but he wasn't around and I don't know the answer) if it is
a problem that this changes the behavior of non "add" events.
Previously a non "add" event with an incorrect mask/uid/gid would have
reset the SELinux context but now it will not. It fixes the issue at
hand, my boxes boot with everything labeled nicely, but I'm not sure if
there is some other corner case that expected the old behavior with
change events....
-Eric
--
| Aug 31, 1:51 pm 2010 |
| Daniel J Walsh | Re: selinux vs devtmpfs (vs udev)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
If it only labels on node creation, yes that makes sense to me.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkx9WgAACgkQrlYvE4MpobPoJgCeLTV4TWUi0Mh/m0P783/PPyBa
s2MAnRK5pUSJqVT+mAHtxPyFIEe9hepf
=HDZq
-----END PGP SIGNATURE-----
--
| Aug 31, 12:37 pm 2010 |
| Daniel J Walsh | Re: selinux vs devtmpfs (vs udev)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
NOOOOO
libvirt is going in and changing fixed_disk_device_t:s0 to svirt_t:c0,c124
We do not want udev to see this and ask what label a device should have
I think either figure out if the device is newly created versus modified
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Fedora - ...
| Aug 31, 8:22 am 2010 |
| Harald Hoyer | Re: selinux vs devtmpfs (vs udev)
https://bugzilla.redhat.com/show_bug.cgi?id=575128#c14
https://bugzilla.redhat.com/attachment.cgi?id=442223&format=raw
udev/udev-node.c
+ /* set selinux file context on add events */
+ if (strcmp(udev_device_get_action(dev), "add") == 0)
+ udev_selinux_lsetfilecon(udev, file, mode);
--
| Aug 31, 8:49 am 2010 |
| Harald Hoyer | Re: selinux vs devtmpfs (vs udev)
Is there an easy test to differentiate?
--
| Aug 31, 7:39 am 2010 |
| Daniel J Walsh | Re: selinux vs devtmpfs (vs udev)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Why is the kernel creating the devices versus telling udev to create the
devices?
You could write a hack that says don't relabel devices with MLS != s0.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkx9GDYACgkQrlYvE4MpobMBBACfen8P0i1LJjufe2Gzdi2mn+tM
OdwAn1nHM1M34MGahwS7tNlLLpfmadcC
=hBOX
-----END PGP SIGNATURE-----
--
| Aug 31, 7:56 am 2010 |
| Daniel J Walsh | Re: selinux vs devtmpfs (vs udev)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Another option would be to check the label of the containing directory
and if they match run the lsetfilecon, If they don't then leave it be.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkx9GGgACgkQrlYvE4MpobNwkgCgvzHFWYTZND+xMSukZXc1M+a0
fC4AoNaVap4UfoOoq1U+8X7JWYqktNHy
=TljD
-----END PGP SIGNATURE-----
--
| Aug 31, 7:57 am 2010 |
| Eric Paris | Re: selinux vs devtmpfs (vs udev)
How does udev get notification of add and change events? add vs change
seems like the best medium term solution.
Short term checking for the 'default' and resetting if it is default
seems like a reasonable solution. But of course determining that default
is not as easy as you might like.
Dan has suggested 2 heuristics.
1) do not change if the MLS component is not ":s0"
- this is a terrible hack. don't do it.
2) only change if the label is the same as the parent
- this is a lot ...
| Aug 31, 8:16 am 2010 |
| Daniel J Walsh | Re: selinux vs devtmpfs (vs udev)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
So the problem is happening because the kernel creates the device rather
then udev, and then udev does not change the context because it can not
differentiate between this and libvirt putting down a label.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkx9Da0ACgkQrlYvE4MpobOYKwCeK1IcX1z/B1lqMbkhYRTVNGsc
o3gAn02Q+xVyfmRysEqvLT36ea3EUeHZ
=3H/v
-----END ...
| Aug 31, 7:11 am 2010 |
| David Howells | Re: [PATCH 1/2] Blackfin: punt duplicate SPORT MMR defines
Acked-by: David Howells <dhowells@redhat.com>
--
| Aug 31, 5:45 am 2010 |
| Jean Delvare | Re: [PATCH 1/1] power supply: add driver for TI BQ20Z75 ...
Hi Rhyland,
Following the naming used for other options in this menu, this would be
Please remove, this doesn't add much value and is likely to get
This structure doesn't seem terribly useful. You typically need the
client to get to this information... And storing the device pointer as
-EINVAL doesn't look like the right error code. -ENODEV or -EIO would
seem more appropriate. Same issue several times, please address them
You should pass down the exact error ...
| Aug 31, 1:24 am 2010 |
| Mark Brown | Re: [PATCH 1/1] power supply: add driver for TI BQ20Z75 ...
Rather than using REG_MAX it'd seem safer to use ARRAY_SIZE() to make
Remove unconditional logging like this, make it dev_dbg() if you want to
The standard way to do this is with the suspend/resume functions -
This only makes sense if it's an actual person (or other contact
address); there's already copyright statements on the file, the author
information is more there to help find someone who might know something
about the driver.
--
| Aug 31, 6:13 am 2010 |
| Neil Leeder | Re: [PATCH 0/1] input: keyboard: add qci keyboard driver
Hi Dmitry,
I can assure you that the keyboard is on the 8*18 GPIO matrix on the
Nuvoton EC (only 8*16 being used in the current design). There certainly
are 3 PS/2 ports on the EC, but in the board designs I have only one of
those is used as a PS/2 port, and that is for the touchpad. The other
two ports are muxed with GPIOs and the pins are being used as GPIOs for
other functions, not PS/2 ports.
The firmware on the EC converts keypresses on the GPIO matrix to
scancodes and sends ...
| Aug 31, 1:54 pm 2010 |
| Roland McGrath | Re: [PATCH] exec argument expansion can inappropriately ...
This can't be so. There are already many possibilities for preemption
What "change"? Preemption is already possible, that's nothing new.
The only difference is that we might notice TIF_SIGPENDING having been
set, and bail out either before or after prepare_binprm, and so never
call search_binary_handler at all.
The user-visible effect of this could be that a process taking many signals
way too fast could get stuck permanently running its signal handlers and
never actually really ...
| Aug 30, 5:40 pm 2010 |
| Solar Designer | Re: [PATCH] exec argument expansion can inappropriately ...
Brad, Roland -
Thank you for your comments and your work on this.
Agreed.
Alexander
--
| Aug 31, 4:53 am 2010 |
| Tetsuo Handa | Re: [PATCH] exec argument expansion can inappropriately ...
As far as I know, RHEL >= 5.3 and Asianux >= 3.2 backported this functionality.
--
| Aug 31, 4:56 am 2010 |
| Alexander Graf | Re: [PATCH] powerpc/kvm/e500_tlb: Fix a minor copy-paste ...
Thanks, applied.
Alex
--
| Aug 30, 6:07 pm 2010 |
| Masayuki Ohtake | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver t ...
My answer was not appropriate.
Though the Topcliff is new concept LSI, SPI in Topcliff is not a new design hardware but a reuse from other AMBA-based
products.
Thanks, Ohtake(OKISemi)
----- Original Message -----
From: "Thomas Gleixner" <tglx@linutronix.de>
To: "Masayuki Ohtake" <masa-korg@dsn.okisemi.com>
Cc: "Grant Likely" <grant.likely@secretlab.ca>; <meego-dev@meego.com>; "LKML" <linux-kernel@vger.kernel.org>; "David
Brownell" <dbrownell@users.sourceforge.net>; <qi.wang@intel.com>; ...
| Aug 30, 6:05 pm 2010 |
| Masayuki Ohtake | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver t ...
----- Original Message -----
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Masayuki Ohtake" <masa-korg@dsn.okisemi.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>; <meego-dev@meego.com>; "LKML" <linux-kernel@vger.kernel.org>; "David
Brownell" <dbrownell@users.sourceforge.net>; <qi.wang@intel.com>; <yong.y.wang@intel.com>;
<andrew.chih.howe.khor@intel.com>; <arjan@linux.intel.com>; <gregkh@suse.de>; "Tomoya MORINAGA"
<morinaga526@dsn.okisemi.com>; "David Woodhouse" <dwmw2@infradead.org>; ...
| Aug 30, 11:24 pm 2010 |
| Grant Likely | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver t ...
On Mon, Aug 30, 2010 at 7:45 PM, Masayuki Ohtake
Well, to start with, the registration code currently in
spi_pch_device.c is probably pretty much unusable for any platform
other than the development board that you're working on. Every
machine using the topcliff chip will have a different set of spi
devices attached to the bus. So, you'll need a method for having a
different set of registrations depending on the machine.
Traditionally with ARM systems, there is a separate .c file for ...
| Aug 30, 11:03 pm 2010 |
| Masayuki Ohtake | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver t ...
----- Original Message -----
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Masayuki Ohtake" <masa-korg@dsn.okisemi.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>; <meego-dev@meego.com>; "LKML" <linux-kernel@vger.kernel.org>; "David
Brownell" <dbrownell@users.sourceforge.net>; <qi.wang@intel.com>; <yong.y.wang@intel.com>;
<andrew.chih.howe.khor@intel.com>; <arjan@linux.intel.com>; <gregkh@suse.de>; "Tomoya MORINAGA"
<morinaga526@dsn.okisemi.com>; "David Woodhouse" <dwmw2@infradead.org>; ...
| Aug 30, 11:47 pm 2010 |
| Grant Likely | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver t ...
On Tue, Aug 31, 2010 at 12:47 AM, Masayuki Ohtake
yes.
g.
--
| Aug 30, 11:53 pm 2010 |
| Masayuki Ohtake | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver t ...
Brownell" <dbrownell@users.sourceforge.net>; <qi.wang@intel.com>; <yong.y.wang@intel.com>;
<andrew.chih.howe.khor@intel.com>; <arjan@linux.intel.com>; <gregkh@suse.de>; "Tomoya MORINAGA"
How should we register spi_device information ?
Thanks, Ohtake(OKISemi)
--
| Aug 30, 6:45 pm 2010 |
| Masayuki Ohtake | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver t ...
----- Original Message -----
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Masayuki Ohtake" <masa-korg@dsn.okisemi.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>; <meego-dev@meego.com>; "LKML" <linux-kernel@vger.kernel.org>; "David
Brownell" <dbrownell@users.sourceforge.net>; <qi.wang@intel.com>; <yong.y.wang@intel.com>;
<andrew.chih.howe.khor@intel.com>; <arjan@linux.intel.com>; <gregkh@suse.de>; "Tomoya MORINAGA"
<morinaga526@dsn.okisemi.com>; "David Woodhouse" <dwmw2@infradead.org>; ...
| Aug 30, 11:57 pm 2010 |
| Masayuki Ohtake | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver t ...
----- Original Message -----
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Masayuki Ohtak" <masa-korg@dsn.okisemi.com>
Cc: <meego-dev@meego.com>; "LKML" <linux-kernel@vger.kernel.org>; "David Brownell" <dbrownell@users.sourceforge.net>;
<qi.wang@intel.com>; <yong.y.wang@intel.com>; <andrew.chih.howe.khor@intel.com>; <arjan@linux.intel.com>;
<gregkh@suse.de>; "Tomoya MORINAGA" <morinaga526@dsn.okisemi.com>; "Thomas Gleixner" <tglx@linutronix.de>; "David
Woodhouse" ...
| Aug 31, 5:09 am 2010 |
| Grant Likely | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver t ...
On Mon, Aug 30, 2010 at 7:05 PM, Masayuki Ohtake
Which product? Is that product already supported by Linux?
g.
--
| Aug 30, 10:51 pm 2010 |
| Weidong Han | Re: [patch 1/3] x86, intr-remap: set redirection hint in ...
Thanks for your explanation. It's ok.
Regards,
Weidong
--
| Aug 30, 8:29 pm 2010 |
| Tony Luck | Re: Serious problem with ticket spinlocks on ia64
Answering my own question ... it failed in 47 minutes with the breakit
script on iteration 2812 :-(
So it would appear that the problem isn't related to the ALAT, or weird
compiler optimizations around the inline asm.
-Tony
--
| Aug 31, 3:17 pm 2010 |
| adam radford | Re: 3w-9xxx: scsi0: WARNING: (0x06:0x0037): Character io ...
Justin,
There were no changes in the driver other than to force a 60 second I/O
timeout. You probably have a udev rule that was already giving you 60
second timeouts for all scsi devices, so this patch did absolutely nothing.
More likely is that there is an I/O pattern change between the kernels
that is causing a 3ware firmware issue (or drive firmware issue) on
your configuration.
I have forwarded your case to 3ware firmware support.
-Adam
--
| Aug 31, 11:15 am 2010 |
| Justin Piszcz | Re: 3w-9xxx: scsi0: WARNING: (0x06:0x0037): Character io ...
Latest-- 2.6.34.x seems to fix the issue, no lag whatsoever, the system is
very responsive when running rss2email, again no lag, have run 10-15 tests
without a single incident. I also re-enabled msi and put my optimization
script back in init.d, everything continues to work perfectly.
Will wait for Adam on what went wrong with the 2.6.35 3w-9xxx update.
Justin.
--
| Aug 31, 5:23 am 2010 |
| Justin Piszcz | Re: 3w-9xxx: scsi0: WARNING: (0x06:0x0037): Character io ...
Per my earlier message, both cards were resetting, scsi0 and scsi1 under
kernel 2.6.35(.x), with 2.6.34, the lag problem is gone and my machine is
back to normal again. It is unlikely that both cards would be at fault,
in addition I spent several hours trying different things, removing the BBU
modules for example, but always staying on the 2.6.35 kernel.
I am now able to run rss2email (which ALWAYS caused the machine to lockup
and freeze until one of the controllers reset) without any ...
| Aug 31, 4:36 am 2010 |
| Justin Piszcz | Re: 3w-9xxx: scsi0: WARNING: (0x06:0x0037): Character io ...
Problem persists during heavy I/O, different error this time:
[152904.636062] 3w-9xxx: scsi1: ERROR: (0x06:0x0036): Response queue (large) empty failed during reset sequence.
[152917.721865] 3w-9xxx: scsi1: AEN: INFO (0x04:0x0001): Controller reset occurred:resets=2.
--
syslog:Aug 6 05:58:19 p34 kernel: [ 1.763002] 3w-9xxx: scsi1: AEN: INFO (0x04:0x0001): Controller reset occurred:resets=1.
syslog:Aug 20 07:30:41 p34 kernel: [1171646.371290] 3w-9xxx: scsi0: WARNING: (0x06:0x0037): ...
| Aug 31, 4:21 am 2010 |
| Sundar | Re: [PATCH 1/3] drivers: misc: ak8974 / ami305 magnetome ...
Hi again,
Yes. Something like re-programming the context. but it would make sure that
the module draws no power at all.
Also, would it not be correct to include a cancel_work_sync in case of
return here?
+fail4:
+ misc_deregister(&chip->miscdev);
+fail3:
+ ak8974_regulators_off(chip);
+fail2:
+ regulator_bulk_free(ARRAY_SIZE(chip->regs), chip->regs);
+fail1:
+ kfree(chip);
+ return err;
+}
Cheers!
--
| Aug 31, 12:13 am 2010 |
| Mark Brown | Re: [PATCH 1/3] drivers: misc: ak8974 / ami305 magnetome ...
Not really without knowing more about how the device will be used and
the costs associated with powering it up and down - it's all a question
of tradeoffs depending on things like how fast userspace needs a
response and the expected usage patterns (many accesses in quick
succession, occasional widely spaced accesses...).
--
| Aug 31, 4:11 am 2010 |
| Steven Rostedt | Re: [Patch] ext4: avoid null dereference
Is i_ino == 0 a valid inode number?
If not, then
Acked-by: Steven Rostedt <rostedt@goodmis.org>
--
| Aug 31, 10:43 am 2010 |
| Andreas Herrmann | [PATCH 2/3] x86, k8-gart: Decouple handling of garts and ...
From: Andreas Herrmann <andreas.herrmann3@amd.com>
So far we only provide num_k8_northbridges. This is required in
different areas (e.g. L3 cache index disable, GART). But not all AMD
CPUs provide a GART. Thus it is useful to split off the GART handling
from the generic caching of AMD northbridge misc devices.
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
arch/x86/include/asm/k8.h | 13 +++++---
arch/x86/kernel/cpu/intel_cacheinfo.c | 4 +-
...
| Aug 30, 11:42 pm 2010 |
| Andreas Herrmann | [PATCH 3/3] x86, k8: Rename k8.[ch] to amd_nb.[ch] and C ...
From: Andreas Herrmann <andreas.herrmann3@amd.com>
The file names are somehow misleading as the code is not specific to
AMD K8 CPUs anymore. The files accomodate code for other AMD CPU
northbridges as well.
Same is true for the config option which is valid for AMD CPU
northbridges in general and not specific to K8.
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
arch/x86/Kconfig | 4 +-
arch/x86/include/asm/amd_nb.h | 39 +++++++++
...
| Aug 30, 11:44 pm 2010 |
| Andreas Herrmann | [PATCH 1/3] x86, cacheinfo: Fix dependency of AMD L3 CID
From: Andreas Herrmann <andreas.herrmann3@amd.com>
L3 cache index disable code uses PCI accesses to AMD northbridge functions.
Currently the code is compiled #ifdef CONFIG_CPU_SUP_AMD.
But its real dependency is #if (defined(CONFIG_CPU_SUP_AMD) &&
defined(CONFIG_PCI)) which in the end is a dependency to CONFIG_K8_NB.
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
arch/x86/kernel/cpu/intel_cacheinfo.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff ...
| Aug 30, 11:41 pm 2010 |
| Andreas Herrmann | [PATCH 0/3] x86: misc K8_NB updates
Following patches are against tip/master as of
v2.6.36-rc3-1233-gf3d0a67
Patch 1 sets the correct dependency to K8_NB for L3 cache index disable code
Patch 2 allows separate handling of gart and AMD northbridges
Patch 3 renames k8.[ch] and CONFIG_K8_NB to the more appropriate amd_nb.[ch] and CONFIG_AMD_NB
Please apply.
Thanks,
Andreas
--
| Aug 30, 11:38 pm 2010 |
| Neil Brown | Re: [PATCH 0/5] hybrid union filesystem prototype
On Tue, 31 Aug 2010 13:00:45 +0200
No, I don't have a particular use case in mind that would take advantage of
the layers being directly modifiable. But I know that sys-admins can be very
ingenious and may well come up with something clever.
My point is more that I don't think that is it *possible* to prevent changes
to the underlying filesystem (NFS being the prime example) so if there are
easy steps we can take to make the behaviour of overlayfs more predictable in
those cases, we ...
| Aug 31, 4:24 am 2010 |
| Kyle Moffett | Re: [PATCH 0/5] hybrid union filesystem prototype
There's certainly already weird behaviors you can cause by regular
filesystem over-mounts on NFS. For example, I have an NFS server that
exports a "/srv/git" directory; if I was to do the following actions
on a client:
# mkdir /srv/git
# mount -t nfs myserver:/srv/git /srv/git
# mkdir /srv/git/mnt
# mount -t ext3 /dev/sda3 /srv/git/mnt
And then from the server I were to:
# rmdir /srv/git/mnt
Terrible terrible things would happen... by which I mean I can no
longer access or unmount ...
| Aug 31, 8:05 am 2010 |
| Valerie Aurora | Re: [PATCH 0/5] hybrid union filesystem prototype
I agree: Ask the server to keep it read-only, but also detect if it
lied to prevent kernel bugs on the client.
Is detecting ESTALE and failing the mount sufficient to detect all
cases of a cached directory being altered? I keep trying to trap an
NFS developer and beat the answer out of him but they usually get hung
up on the impossibility of 100% enforcement of the read-only server
option. (Agreed, impossible, just give the sysadmin a mount option so
that it doesn't happen ...
| Aug 31, 12:18 pm 2010 |
| Miklos Szeredi | Re: [PATCH 0/5] hybrid union filesystem prototype
No, I don't think this design will do that. So it might be enough
just to document that online modification of upper or lower
filesystems results in undefined behavior.
But to prevent accidental damage, it's prudent (at least by default)
to enforce the no-modification policy.
Why do you think this feature of allowing modification is important?
Lets take some typical use cases:
- live cd: lower layer is hard r/o, upper layer makes no sense to
modify online
- thin client: lower ...
| Aug 31, 4:00 am 2010 |
| Valerie Aurora | Re: [PATCH 0/5] hybrid union filesystem prototype
Union mounts was named "writable overlays" for one release in an
attempt to get away from the "arbitrary union of file systems" idea.
I think it helped, but went back to union mounts since it was more
familiar and made prettier function names.
The config option for union mounts says:
Union mounts allow you to mount a transparent writable layer over a
read-only file system, for example, an ext3 partition on a hard drive
over a CD-ROM root file system image.
-VAL
--
| Aug 31, 12:29 pm 2010 |
| Trond Myklebust | Re: [PATCH 0/5] hybrid union filesystem prototype
Remind me again why mounting the filesystem '-oro' on the server (and
possibly exporting it 'ro') isn't an option?
Trond
--
| Aug 31, 1:19 pm 2010 |
| Valerie Aurora | Re: [PATCH 0/5] hybrid union filesystem prototype
While this definitely sucks, the concern in this case with unioning
file systems is a deadlock or kernel panic, not just "weird" behavior
or inability to unmount a file system. Although in general I like the
standard for union behavior as "not as bad as NFS." :)
-VAL
--
| Aug 31, 1:36 pm 2010 |
| mark gross | Re: [PATCH] pm_qos: Add system bus performance parameter
Now I get it! For throughput we need to do a sum. Ok, we need sum
comparator/performance aggregaters too!
Do we also need to figure out the max throughput and warn if the pm_qos
requests are going over? I suppose the network stack could register
each device with a max bus bandwidth and pm_qos could warn on exceeding
I need to think on this a bit. You are correct, and it looks like we
thanks for the example! it really helped me to understand the issue
better.
--mark
--
| Aug 31, 11:40 am 2010 |
| Saravana Kannan | Re: [PATCH] pm_qos: Add system bus performance parameter
Kevin, Thanks for explaining exactly what I had in mind. I was caught up
with other work and was glad to see this discussion moved forward.
I pretty much agree with all of Kevin's statements, so here is a
In my opinion, here is where the "best effort" part, if any, comes in.
PM QoS could do it's best to meet the QoS while keeping power low, but
if the h/w can't support it, we let it run at highest performance and
I'm not sure having both interfaces would work. Should a single client ...
| Aug 31, 3:38 pm 2010 |
| David Howells | Re: [PATCH 18/22] Fix M68K irqflags
That's orthogonal to this patch series, however. I'm dealing with IRQ flags
management, not hardirq support.
Out of interest, will the m68knommu arch be integrated into the m68k arch at
some point? It's certainly possible to have an arch that is bimodal in this
aspect (FRV has CONFIG_MMU as a config option).
David
--
| Aug 31, 9:00 am 2010 |
| Geert Uytterhoeven | Re: [PATCH 18/22] Fix M68K irqflags
Indeed, m68k doesn't use generic hardirqs yet, m68knommu does.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
| Aug 31, 12:36 am 2010 |
| Matt Fleming | Re: [PATCH V2 0/4] Generalise ARM perf-events backend fo ...
Sure, will do! Thanks.
--
| Aug 31, 4:25 am 2010 |
| Robert Richter | Re: [PATCH V2 0/4] Generalise ARM perf-events backend fo ...
Matt,
please rebase your next version of this patch set to
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git core
It contains Will's patches.
Thanks,
--
Advanced Micro Devices, Inc.
Operating System Research Center
--
| Aug 31, 4:05 am 2010 |
| Matt Fleming | Re: [PATCH V2 4/4] sh: Use the perf-events backend for o ...
These names are actually the names of types of performance counters,
not a specific cpu. All SH-4 cpus that have performance counters have
7750-style performance counters and all SH-4A cpus have SH-4A-style
counters.
It's unlikely we'd have to update this code in the near future. Paul,
OK, seeing as the two architectures that will use this initially don't
require wrappers I've no problem doing it your way. It can always be
extended later if necessary. And more importantly, with a ...
| Aug 31, 5:23 am 2010 |
| Robert Richter | Re: [PATCH V2 4/4] sh: Use the perf-events backend for o ...
Ok, this shouldn't block this patch series, we still can make a patch
Yes, right. So I am looking forward to your new version.
Thanks,
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
--
| Aug 31, 6:26 am 2010 |
| Robert Richter | Re: [PATCH V2 4/4] sh: Use the perf-events backend for o ...
Ok, we don't need it if we add architectural dependencies to Kconfig
No, but with that implementation we always have to update the cpu
string with each new cpu though nothing else changes. We may keep this
code. But, shouldn't we return a default string "sh/<name>" for all
other cases? We will then need to update only the oprofile userland
I am not sure if we need such wrappers, and if so we could implement
it anyway, e.g.:
oprofile_perf_init(perf_ops, name, num_events);
...
| Aug 31, 4:28 am 2010 |
| Mathieu Desnoyers | Re: [RFC PATCH 00/11] sched: CFS low-latency features
.. but as we discussed in private, this would involve adding extra attribute
fields to what the standard proposes. I think the problem comes from the fact
that POSIX considers the pthread attributes to contain every possible thread
attribute one can imagine, which does not take into account the internal kernel
state set by other interfaces.
So this leaves us with a single-threaded SIGEV_THREAD, which is pretty much
useless. But at least it is not totally impossible for glibc to get it right ...
| Aug 31, 8:02 am 2010 |
| Steven Rostedt | Re: [Ksummit-2010-discuss] [PATCH] MAINTAINERS: add U: f ...
Actually, that would probably happen automatically.
If you are working on a subsystem, you should probably be working
against the git tree for that subsystem. When something is done in the
todo list, the subsystem tree would be updated with the commit that does
said change.
Then, the list is maintained outside of mainline (in the subsystem git
tree) and will automatically update mainline in the next merge window
when the tree is pulled.
-- Steve
--
| Aug 31, 4:17 pm 2010 |
| Paul E. McKenney | Re: [Ksummit-2010-discuss] [PATCH] MAINTAINERS: add U: f ...
I am with Dmitry on this one. I really don't want to be prevented from
updating my todo items outside of the merge window.
Different people have different needs, so we need to accommodate todo
lists both within and outside the kernel source tree.
Thanx, Paul
--
| Aug 31, 4:02 pm 2010 |
| Rafael J. Wysocki | Re: [Ksummit-2010-discuss] [PATCH] MAINTAINERS: add U: f ...
Seriously, given the known history of Documentation/feature-removal-schedule.txt,
I don't think this is going to work.
Thanks,
Rafael
--
| Aug 31, 4:19 pm 2010 |
| Steven Rostedt | Re: [Ksummit-2010-discuss] [PATCH] MAINTAINERS: add U: f ...
We could add a toplevel "todo/" directory, with each project file in it
and a list of things todo. When the todo is done, that same commit could
remove the todo item.
Just a worthless thought ;-)
-- Steve
--
| Aug 31, 10:23 am 2010 |
| Joe Perches | RE: [Ksummit-2010-discuss] [PATCH] MAINTAINERS: add U: f ...
There are already reasonable mechanisms for this.
It's perfectly fine to have multiple T: entries,
one for a current tree, another for a -next tree.
SECTION - name
M: who <email.address>
T: git <url>
T: git <url-next>
F: dir/file_pattern
Linus rarely seems to object to pulling Documentation updates.
Note the Documentation updates after any -rc2
$ for ((i=25 ; i<36 ; i++)) ; do \
cv=v2.6.$i-rc2..v2.6.$i ; \
echo -n "$cv: " ; \
git log --pretty=oneline --no-merges $cv -- ...
| Aug 31, 4:46 pm 2010 |
| Luck, Tony | RE: [Ksummit-2010-discuss] [PATCH] MAINTAINERS: add U: f ...
But this would mean that the version of the todo list in Linus' tree
is usually a release (3 months) out of date. It would be a good idea
for a list maintained this way to include instructions on how to find
the current version, lest some unsuspecting person waste time working
on items that are already fixed and waiting for the next merge.
-Tony
--
| Aug 31, 4:25 pm 2010 |
| Mel Gorman | Re: [PATCH 2/3] writeback: Record if the congestion was ...
Excellent stuff. I didn't look at your vmstat output because it was for
an old patch and you have already highlighted the problems related to
the workload. Chances are, I'd just reach the same conclusions. What is
Ok, well there was some significant feedback on why wholesale changing of
congestion_wait() reached too far and I've incorporated that feedback. I
also integrated your workload into my testsuite (btw, because there is no
license the script has to download it from a google archive. I ...
| Aug 31, 8:02 am 2010 |
| Lin Ming | Re: [tip:perf/urgent] perf_events: Fix time tracking for ...
Hi,
I thought pid != -1 and cpu != -1 is not valid.
# perf top -p 23268 -C 1
WARNING: PID switch overriding CPU
In which case this could be valid?
Thanks,
--
| Aug 30, 6:10 pm 2010 |
| stephane eranian | Re: [tip:perf/urgent] perf_events: Fix time tracking for ...
This is in per-thread mode. This is what happens when you do
perf record foo for instance. This is sampling, but you can do
--
| Aug 31, 1:03 am 2010 |
| Masayuki Ohtake | [PATCH] Gigabit Ethernet driver of Topcliff PCH
Hi Sam, Joe and Stephen
Thank you for your comments.
We have modified this driver for your comment.
---
Gigabit Ethernet driver of Topcliff PCH
Patch created against 2.6.35
Topcliff PCH is the platform controller hub that is going to be used in
Intel's upcoming general embedded platform. All IO peripherals in
Topcliff PCH are actually devices sitting on AMBA bus.
Topcliff PCH has Gigabit Ethernet I/F. Using this I/F, it is able to
access system devices connected to Gigabit ...
| Aug 31, 7:15 am 2010 |
| Randy Dunlap | Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH
This is a gigabit
You aren't going to modify this text after the product is released, are you?
Topcliff PCH is the platform controller hub that is used in Intel's
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
| Aug 31, 8:08 am 2010 |
| Joe Perches | Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH
Some trivial logging message cleanups:
Missing newline
Alignment
Grammar
80 column coalescing
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/pch_gbe/pch_gbe_main.c | 180 ++++++++++++++++-------------------
drivers/net/pch_gbe/pch_gbe_param.c | 36 +++-----
drivers/net/pch_gbe/pch_gbe_phy.c | 2 +-
3 files changed, 94 insertions(+), 124 deletions(-)
diff --git a/drivers/net/pch_gbe/pch_gbe_main.c b/drivers/net/pch_gbe/pch_gbe_main.c
index ce0c38e..264f275 ...
| Aug 31, 9:10 am 2010 |
| Joe Perches | [PATCH] drivers/net/pch_gbe: Use bool not unsigned char
Perhaps this is clearer.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/pch_gbe/pch_gbe.h | 6 +++---
drivers/net/pch_gbe/pch_gbe_main.c | 33 +++++++++++++++++----------------
2 files changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/net/pch_gbe/pch_gbe.h b/drivers/net/pch_gbe/pch_gbe.h
index a615ddc..a2b2c55 100644
--- a/drivers/net/pch_gbe/pch_gbe.h
+++ b/drivers/net/pch_gbe/pch_gbe.h
@@ -638,9 +638,9 @@ struct pch_gbe_adapter {
struct ...
| Aug 31, 10:25 am 2010 |
| Joe Perches | Re: [PATCH] drivers/net/pch_gbe: Cleanup stats use
Use c90 initializers
Use memset
Use FIELD_SIZEOF
Remove stat_ from struct pch_gbe_stats members
Save offset from start of struct pch_gbe_hw_stats
All stat members are u64, so maybe the size field can be removed
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/pch_gbe/pch_gbe_ethtool.c | 32 +++++++++++++++++---------------
drivers/net/pch_gbe/pch_gbe_main.c | 28 +---------------------------
2 files changed, 18 insertions(+), 42 deletions(-)
diff --git ...
| Aug 31, 11:38 am 2010 |
| Eric Dumazet | Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH
I find hard to believe this driver needs to copy all outgoing frames on
pre-allocated skbs.
+ /* [Header:14][payload] ---> [Header:14][paddong:2][payload] */
+ memcpy(tmp_skb->data, skb->data, ETH_HLEN);
+ tmp_skb->data[ETH_HLEN] = 0x00;
+ tmp_skb->data[ETH_HLEN + 1] = 0x00;
+ tmp_skb->len = skb->len;
+ memcpy(&tmp_skb->data[ETH_HLEN + 2], &skb->data[ETH_HLEN],
+ (skb->len - ETH_HLEN));
+ buffer_info->kernel_skb = skb;
+ ...
| Aug 31, 7:51 am 2010 |
| Rafi Rubin | Re: [PATCH 4/4] firmware sysfs node
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The version in input_id is only 16 bits, whereas the ntrig version codes seem to
be 32 bits. Actually I've only mapped 21 bits out of 64, but I figure the first
and last 8 are not actually part of the version, but that's still more than 16.
So, would you prefer that I increase the size of that field, or keep the
firmware version code separate?
Also does it make sense to have a provide a pretty printer in the kernel, or
should that be left ...
| Aug 30, 7:06 pm 2010 |
| Fenghua Yu | Re: [Patch-next] Trival fixes in thermal_throttle_add_dev().
This fix is incorrect. In this patch, a previous error prevents from adding any
further devices. There shouldn't be such dependency among the devices.
Thanks.
-Fenghua
--
| Aug 30, 6:02 pm 2010 |
| Jin Dongming | [Patch-next] Trival fixes in thermal_throttle_add_dev().
This patch fixed the following two problems.
1. When the feature PTS is not supported by CPU, the sysfile
package_power_limit_count for package should not be generated.
2. No matter whether a sysfile is failed to be created or not,
the next one will be created.
As the resolving methods:
1. Add missing { and } after checking PTS feature.
2. Fix the error handling.
Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Reviewed-by: Fenghua Yu ...
| Aug 30, 5:55 pm 2010 |
| Jean Delvare | Re: [Patch-next] Trival fixes in thermal_throttle_add_dev().
Hi Jin
Even though you are lucky that in the end it still works, this check is
misplaced. You should instead have:
if (cpu_has(c, X86_FEATURE_PLN)) {
err = sysfs_add_file_to_group(&sys_dev->kobj,
&attr_package_power_limit_count.attr,
thermal_attr_group.name);
if (err)
goto error;
--
Jean Delvare
--
| Aug 30, 11:55 pm 2010 |
| Jean Delvare | Re: [Patch-next] Trival fixes in thermal_throttle_add_dev().
Hi Fenghua,
I don't quite follow you. Did you mean to write that a previous error
prevents from creating further _attributes_ for the same device? This
would be true.
Now I don't think this is a problem because 1* such errors should never
happen anyway and 2* if they do happen then further attempts to create
the other attributes are unlikely to succeed either.
--
Jean Delvare
--
| Aug 31, 12:07 am 2010 |
| Fenghua Yu | Re: [Patch-next] Trival fixes in thermal_throttle_add_dev().
I don't think there is dependency among the count files, i.e. failure to add a
count file to the group shouldn't impact other files. Other filles can still be
added to the group. In this case, user application only sees part of count
numbers. And kernel may just warn on the failure instead of providing nothing
to user.
In the patch, any failure to add a file will remove the whole group. This is
too strict. Kernel doesn't provide any count number to user application.
Agree with you that such ...
| Aug 31, 10:04 am 2010 |
| Jean Delvare | Re: [Patch-next] Trival fixes in thermal_throttle_add_dev().
Oh, my bad. I missed the call to sysfs_remove_group() when reviewing
The original code works indeed (except for the missing curly braces)
but is confusing for the reader (which is why I raised the point and we
are discussing it now). If you are voluntarily ignoring errors, you
should add a comment saying so. And it is also a good practice to use a
dummy variable to store the error value you'll ignore, so that the
This is an option, yes. Unfortunately this also means that such ...
| Aug 31, 12:30 pm 2010 |
| Boaz Harrosh | Re: [PATCH 26/30] ext4: do not send discards as barriers
I don't know all the specifics of the virtio driver and the KVM backend but
don't the KVM target io is eventually directed to a local file or device?
If so the scsi device has disappeard but the bulk of the data is in host cache
at the backstore (file or bdev). Once all files are closed the data is synced
to disk.
Is it not the same as Ric's problem of disconnecting the sata cable but
Thanks
Boaz
--
| Aug 31, 3:07 am 2010 |
| Boaz Harrosh | Re: [PATCH 26/30] ext4: do not send discards as barriers
Ha, ok you meant that device. So if you have a dedicated physical device
for backstore that would be a very nice scriptable way.
Thanks, that's a much better automated test than pulling drives out of
Boaz
--
| Aug 31, 3:27 am 2010 |
| Tejun Heo | Re: [PATCH 26/30] ext4: do not send discards as barriers
Hello,
There are two layers of caching there.
drive cache - host page cache - guest
When guest issues FLUSH, qemu will translate it into fdatasync which
will flush the host page cache followed by FLUSH to the drive which
will flush the drive cache to the media. If you delete the host disk
device, it will be detached w/o host page cache flushed. So, although
it's not complete, it will lose good part of cache. With out write
out timeout increased and/or with laptop mode enabled, it ...
| Aug 31, 3:13 am 2010 |
| Boaz Harrosh | Re: [PATCH 26/30] ext4: do not send discards as barriers
Still same problem no? the data is still cached on the backing store device
with stgt it's very simple as well. It's a user mode application.
All on the same machine:
- run stgt application
- login + mount a filesystem
- run test
- kill -9 stgt mid flight
But how to throw away the data on the backing store cache?
Boaz
--
| Aug 31, 2:55 am 2010 |
| Tejun Heo | Re: [PATCH 26/30] ext4: do not send discards as barriers
$ echo 1 > /sys/block/sdX/device/delete
$ echo - - - > /sys/class/scsi_host/hostX/scan
should do the trick.
Thanks.
--
tejun
--
| Aug 31, 1:11 am 2010 |
| Balbir Singh | Re: [PATCH 1/5] cgroup: do ID allocation under css allocator.
OK, the patch looks good to me otherwise
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Three Cheers,
Balbir
--
| Aug 30, 11:33 pm 2010 |
| Daisuke Nishimura | Re: [PATCH 5/5] memcg: generic file stat accounting interface
On Wed, 25 Aug 2010 17:11:40 +0900
Reviewed-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
It might be better to update this comment too.
/* Update file-stat data for mem_cgroup */
or something ?
Thanks,
Daisuke Nishimura.
--
| Aug 30, 9:33 pm 2010 |
| Daisuke Nishimura | Re: [PATCH 3/5] memcg: use ID instead of pointer in page ...
On Wed, 25 Aug 2010 17:09:00 +0900
Reviewed-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
--
| Aug 30, 7:14 pm 2010 |
| Daisuke Nishimura | Re: [PATCH 4/5] memcg: lockless update of file stat with ...
On Wed, 25 Aug 2010 17:10:50 +0900
It doesn't cause any problem, but I think it would be better to change this to
"id_to_memcg(..., false)". It's just under rcu_read_lock(), not under page_cgroup
lock anymore.
Otherwise, it looks good to me.
Reviewed-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Thanks,
Daisuke Nishimura.
--
| Aug 30, 8:51 pm 2010 |
| Balbir Singh | Re: [PATCH 2/5] memcg: quick memcg lookup array
Looks good, quick thought - should we expost memcg->id to user space
through a config file? I don't see any reason at this point, unless we
do it for all controllers.
--
Three Cheers,
Balbir
--
| Aug 31, 12:14 am 2010 |
| Catalin Marinas | Re: [PATCH 03/24] arm: mm: add proc info for ScorpionMP
I cc'ed Santosh as well. I'm not sure whether TI are using a Cortex-A9
Maybe __v7_ca9mp_setup. Future MP processors from ARM may not need this
We could restrict it to:
.long 0x410fc090
.long 0xff0ffff0
Otherwise the patch looks fine. Thanks.
--
Catalin
--
| Aug 31, 5:18 am 2010 |
| Daniel Walker | Re: [PATCH 03/24] arm: mm: add proc info for ScorpionMP
Ok, I'll add this.
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
| Aug 31, 9:44 am 2010 |
| Steven Rostedt | Re: [PATCH] tracing/trace_stack: Fix stack trace on ppc64
Thanks, I'll test this to make sure it doesn't break x86, and then push
it into a stable/-rc patch queue.
--
| Aug 30, 6:31 pm 2010 |
| Ingo Molnar | Re: [PATCH] tracing/trace_stack: Fix stack trace on ppc64
indeed - i forwarded this to hpa.
Ingo
--
| Aug 31, 10:36 am 2010 |
| Frederic Weisbecker | Re: [PATCH] tracing/trace_stack: Fix stack trace on ppc64
Ingo has applied it already in perf/urgent.
Thanks.
--
| Aug 31, 7:21 am 2010 |
| Frederic Weisbecker | Re: [PATCH] tracing/trace_stack: Fix stack trace on ppc64
We were in the commit Cc tags but somehow they didn't make it in the email
tags.
Here is the tip-bot email:
---
Commit-ID: 151772dbfad4dbe81721e40f9b3d588ea77bb7aa
Gitweb: http://git.kernel.org/tip/151772dbfad4dbe81721e40f9b3d588ea77bb7aa
Author: Anton Blanchard <anton@samba.org>
AuthorDate: Wed, 25 Aug 2010 11:32:38 +1000
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 25 Aug 2010 13:08:48 +0200
tracing/trace_stack: Fix stack trace on ppc64
save_stack_trace() ...
| Aug 31, 8:14 am 2010 |
| Steven Rostedt | Re: [PATCH] tracing/trace_stack: Fix stack trace on ppc64
Hmm, I never saw the tip-bot reply :-(
I guess it only sends to the Cc tags.
-- Steve
--
| Aug 31, 7:58 am 2010 |
| David Miller | Re: aligned_{u64,be64,le64} defined in #ifdef __KERNEL__
From: Jan Engelhardt <jengelh@medozas.de>
Me too.
--
| Aug 30, 6:42 pm 2010 |
| Minoru Usui | Re: 2.6.32 cgroup regression
Hi, Mike
On Wed, 25 Aug 2010 07:56:01 +0200
I'm interested in this problem, because I hit the same problem in RHEL6 beta2.
(It based on 2.6.32)
Are you writing a patch to solving this problem?
If you are doing, I can test it in RHEL6 beta2 (or latest).
Appendix.
I could reproduce this problem without ltp. See below.(case 1)
But if cpus are not completely busy, it couldn't occure.(case 2)
[case1]
1) Run busy loop process (number of cpu) in same cpu cgroup.
2) attach process to ...
| Aug 31, 12:25 am 2010 |
| Michal Marek | Re: [PATCH 00/18] Add new semantic patches and reorganiz ...
Applied, thanks.
Michal
--
| Aug 31, 3:22 am 2010 |
| Grant Likely | Re: [PATCH] gpiolib: Add 'struct gpio_chip' forward decl ...
This doesn't actually solve the problem, and gpiochip should remain undefined when CONFIG_GPIOLIB=n to catch exactly these build failures. The real problem is that I merged a change into the mpc5200 code that required CONFIG_GPIOLIB be enabled without reflecting that requirement in Kconfig.
--
| Aug 31, 1:03 am 2010 |
| Anton Vorontsov | Re: [PATCH] gpiolib: Add 'struct gpio_chip' forward decl ...
No, look closer. The error is in of_gpio.h, and it's perfectly
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
--
| Aug 31, 1:37 am 2010 |
| Grant Likely | Re: [PATCH] gpiolib: Add 'struct gpio_chip' forward decl ...
Looking even closer, we're both wrong. You're right I didn't look
carefully enough, and the error is in of_gpio.h, not the .c file.
However, it is not okay to get the definitions from of_gpio.h when
CONFIG_GPIOLIB=n. If GPIOLIB, or more specifically OF_GPIO isn't set,
then the of_gpio.h definitions should either not be defined, or should
be defined as empty stubs (where appropriate).
So, instead of adding a forward declarations of the struct, the
correct thing I think to do is to #ifdef ...
| Aug 31, 9:44 am 2010 |
| Anton Vorontsov | Re: [PATCH] gpiolib: Add 'struct gpio_chip' forward decl ...
Grrr. Grant, look again, even closer than you did.
They are stubs!
#else /* CONFIG_OF_GPIO */ <<<<<< !OF_GPIO (or !GPIOLIB) case.
/* Drivers may not strictly depend on the GPIO support, so let them link. */
static inline int of_get_gpio_flags(struct device_node *np, int index,
enum of_gpio_flags *flags)
{
return -ENOSYS;
}
static inline unsigned int of_gpio_count(struct device_node *np)
{
return 0;
}
static inline void ...
| Aug 31, 10:07 am 2010 |
| tip-bot for Li Zefan | [tip:perf/urgent] tracing: Fix a race in function profile
Commit-ID: 3aaba20f26f58843e8f20611e5c0b1c06954310f
Gitweb: http://git.kernel.org/tip/3aaba20f26f58843e8f20611e5c0b1c06954310f
Author: Li Zefan <lizf@cn.fujitsu.com>
AuthorDate: Mon, 23 Aug 2010 16:50:12 +0800
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Tue, 31 Aug 2010 16:46:23 -0400
tracing: Fix a race in function profile
While we are reading trace_stat/functionX and someone just
disabled function_profile at that time, we can trigger this:
divide error: 0000 ...
| Aug 31, 2:11 pm 2010 |
| Mikael Abrahamsson | Re: 2.6.34.1 page allocation failure
I just rebooted and ran a similar load of network+disk load that made the
machine give "swapper allocation failure" messages before, and I couldn't
reproduce it with 2.6.35:
2.6.35-19-generic #25~lucid1-Ubuntu SMP Wed Aug 25 03:50:05 UTC 2010 x86_64 GNU/Linux
Doing "sync" in the middle made sync take more than 5+ minutes to complete
(2 hung-task messages in dmesg), but at least nothing ran out of memory.
Considering the amount of people running 2.6.32 and who will be running it
in the ...
| Aug 31, 1:28 pm 2010 |
| Steven Rostedt | Re: TRACE: config warning for IRQSOFF_TRACER
The TRACE_IRQFLAGS was originally written for lockdep, but it is now
used by Ftrace's irqsoff tracer.
I just compiled and booted with TRACE_IRQFLAGS=y and PROVE_LOCKING not
set, and it worked fine.
I think the correct patch is to remove the dependency of TRACE_IRQFLAGS
on PROVE_LOCKING.
-- Steve
--
| Aug 30, 5:47 pm 2010 |
| Greg KH | Re: [PATCH 1/8] Staging: rtl8187se: r8180: fixed alot ch ...
Your patches are line-wrapped and can't be applied :(
Care to fix your email client and resend them?
thanks,
greg k-h
--
| Aug 31, 3:31 pm 2010 |
| Wu Fengguang | Re: [PATCH] Make is_mem_section_removable more conformab ...
Ah a non-movable page allocation could fall back into the movable
zone. See __rmqueue_fallback() and the fallbacks[][] array. So the
if (type != MIGRATE_MOVABLE && !pageblock_free(page))
check in is_mem_section_removable() is correct. It is
set_migratetype_isolate() that should be fixed to use the same check.
Thanks,
Fengguang
--
| Aug 31, 7:36 am 2010 |
| Michal Hocko | Re: [PATCH] Make is_mem_section_removable more conformab ...
Hi,
--
Michal Hocko
L3 team
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
| Aug 31, 5:30 am 2010 |
| Wu Fengguang | Re: [PATCH] Make is_mem_section_removable more conformab ...
You don't have strong reasons to remove the free pages test, so why
not keep it? We never know what the user will do. He may regretted
immediately after onlining a node, and want to offline it.. Some
hackers may want to offline some 128MB memory blocks (by chance) with
the help of drop_caches.
Thanks,
--
| Aug 31, 7:19 am 2010 |
| Wu Fengguang | Re: [PATCH] Make is_mem_section_removable more conformab ...
Mel, I'm not familiar with the code, but it seems that in
__rmqueue_fallback(), set_pageblock_migratetype() is not always called
after move_freepages_block() successfully moved some pages. Then it's
possible a MIGRATE_MOVABLE page block will end up containing
non-movable pages?
Thanks,
Fengguang
--
| Aug 31, 7:59 am 2010 |
| Greg KH | Re: [PATCH] drivers:staging:ti-st: remove st_get_plat_device
Yes, I will try to do that.
thanks,
greg k-h
--
| Aug 31, 3:42 pm 2010 |
| Savoy, Pavan | RE: [PATCH] drivers:staging:ti-st: remove st_get_plat_device
Gzee Thanks, so since you added the patch now, I guess you will be reviewing
--
| Aug 31, 3:23 pm 2010 |
| Greg KH | Re: [PATCH] drivers:staging:ti-st: remove st_get_plat_device
Nope, sorry. I got sick and combined with vacation requirements from
the family, and my "real job" and other things lately, I hope to get to
it by the end of this week. If not, kick me, I'll have time on a
trans-continent flight next week that should give me plenty of time to
do this...
thanks,
greg k-h
--
| Aug 30, 9:11 pm 2010 |
| Greg KH | Re: Regarding USB-Serial Device driver
I don't even recall what you were trying to do here, sorry. Please
include more context in your emails, we get a lot of them.
Also, what function was this change made in?
I don't think such a quick line control change is going to do what you
think it does as there are delays on the device side for sending the
data out through the uart that don't sync right up with the usb host
side here. So it might be very easy to get out of order things
happening.
You need to make sure the data is ...
| Aug 30, 9:05 pm 2010 |
| Greg KH | Re: [PATCH] Staging: crystalhd: crystalhd_cmds: fixed a ...
This breaks the build, are you sure you tested it after making the
patch?
thanks,
greg k-h
--
| Aug 31, 3:05 pm 2010 |
| Kevin Wells | Re: [PATCH] watchdog: Enable NXP LPC32XX support in Kcon ...
Hi,
It's been a few weeks on this one, can you please get this into the
watchdog tree?
thanks,
--
| Aug 31, 4:00 pm 2010 |
| Andreas Schwab | Re: [PATCH] .gitignore: Ignore generated files in lib/raid6
It's already on its way, see
<http://permalink.gmane.org/gmane.linux.raid/29357>.
Andreas.
--
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E
"And now for something completely different."
--
| Aug 31, 7:01 am 2010 |
| Ævar Arnfjörð Bjarmason | Re: [PATCH] .gitignore: Ignore generated files in lib/raid6
In case this fell through: Could you pick this up Linus. It's still
--
| Aug 31, 5:17 am 2010 |
| Ævar Arnfjörð Bjarmason | Re: [PATCH] .gitignore: Ignore generated files in lib/raid6
Thanks. I didn't spot that since it came after my report and didn't
reference it (so it didn't appear in my searches).
--
| Aug 31, 7:09 am 2010 |
| Richard Hughes | Re: [PATCH] acpi: Update battery information on notifica ...
I've had three reports in upower of this bug (the units changing) so
users are really hitting this in real world usage. As soon as this
kernel fix gets released in a new kernel version I'll remove the
upower workaround. I can't reproduce this myself, so I've not tested
the patch, although the logic is solid in my opinion.
Richard.
--
| Aug 31, 2:06 am 2010 |
| M. Vefa Bicakci | Re: [Bisected Regression in 2.6.35] A full tmpfs filesys ...
Hello!
I have applied the patches you mentioned, and rebuilt and tested the
2.6.35.4 kernel. I am really happy to say that your patches (cumulatively)
fixed the issue!
Unfortunately, because the hibernation is rather quick, I am having a
hard time getting screen-shots with my camera. If you would like, I can
try to put some sleeps around the code so that I can get the output for
you.
For the record, the attached patch is the cumulative version of all of
your patches. It applies cleanly ...
| Aug 31, 4:25 am 2010 |
| KOSAKI Motohiro | Re: [Bisected Regression in 2.6.35] A full tmpfs filesys ...
Oops, please apply attached patch instead 0002-add-gfp_noretry.patch.
Thanks.
| Aug 30, 11:54 pm 2010 |
| KOSAKI Motohiro | Re: [Bisected Regression in 2.6.35] A full tmpfs filesys ...
Great!
I've attached more verbose debug message patch and trial bug fixing patch.
| Aug 30, 11:35 pm 2010 |
| Greg KH | Re: [PATCH 3/3] Staging: comedi: fix no space before tab ...
This patch doesn't apply, can you redo it against the linux-next tree to
verify that you have the latest version of the tree?
thanks,
greg k-h
--
| Aug 31, 3:30 pm 2010 |
| Masayuki Ohtake | Re: [PATCH] Topcliff: Update PCH_SPI driver to 2.6.35
<spi-devel-general@lists.sourceforge.net>; "Wang, Qi" <qi.wang@intel.com>; "Wang, Yong Y" <yong.y.wang@intel.com>;
Topcliff doesn't have register which shows the number of spi bus interfaces.
This multi-channel code is for other IOH device's.
Thus, I think there is not another way except for hard coding.
I understand.
We will move mutex variable into private data structure.
Thanks, Ohtake(OKISEMI)
--
| Aug 30, 11:55 pm 2010 |
| Heiko Carstens | Re: [PATCH/RFC 1/5] [PATCH] sched: merge cpu_to_core_gro ...
Well, if I wouldn't merge this then the upcoming cpu_to_book_group
function would just be horribly long and unreadable. I think merging
this so it looks the same like cpu_to_phys_group is the right thing
to do.
If I wouldn't do that then the cpu_to_book_group function would just
be a real big mess instead of quite simple function.
--
| Aug 31, 1:26 am 2010 |
| Dave Hansen | Re: [PATCH 0/8] v5 De-couple sysfs memory directories fr ...
Even if an arch defines the override for the sysfs dir size, I still
don't think this breaks anything (it shouldn't). We move _all_ of the
directories over, all at once, to a single, uniform size. The only
apparent change to a user moving kernels would be a larger
block_size_bytes (which is certainly not changing the ABI) and a new
sysfs file for the end of the section. The new sysfs file is
_completely_ redundant at this point.
The architecture is only supposed to bump up the directory ...
| Aug 31, 11:12 am 2010 |
| Anton Blanchard | Re: [PATCH 0/8] v5 De-couple sysfs memory directories fr ...
I tested this on a POWER7 with 2TB memory and the boot time improved from
greater than 6 hours (I gave up), to under 5 minutes. Nice!
Tested-by: Anton Blanchard <anton@samba.org>
Anton
--
| Aug 31, 2:57 pm 2010 |
| Dave Hansen | Re: [PATCH 01/10] Replace ioctls with sysfs interface
Maybe I'm just a weirdo, but I don't really use modules much. That
effectively means that I'm stuck at boot with one zram device.
Making it a read-only module param also means that someone can't add a
second at runtime while the first is still in use.
It doesn't seem to be used very pervasively, but there is a
module_param_cb() function so you can register callbacks when the param
gets updated. Might come in handy for this.
-- Dave
--
| Aug 31, 4:06 pm 2010 |
| Greg KH | Re: [PATCH 00/10] zram: various improvements and cleanups
I applied the first 2 and last 2 of these patches and they will show up
in the linux-next tree tomorrow. I stopped there due to Andrew's
complaints about the per-cpu variable stuff. Please resolve this and
redo the patch set and I will be glad to apply them.
thanks,
greg k-h
--
| Aug 31, 3:37 pm 2010 |
| Nitin Gupta | Re: [PATCH 03/10] Use percpu stats
Yes, this_cpu_add() seems sufficient. I can't recall why I used u64_stats_*
but if it's not required for atomic access to 64-bit then why was it added to
the mainline in the first place?
Thanks,
Nitin
--
| Aug 31, 1:31 pm 2010 |
| Christoph Lameter | Re: [PATCH 03/10] Use percpu stats
How about fixing it so that everyone benefits?
--
| Aug 31, 2:35 pm 2010 |
| Eric Dumazet | Re: [PATCH 03/10] Use percpu stats
IMHO, this_cpu_read() is fine as is : a _read_ operation.
Dont pretend it can be used in every context, its not true.
--
| Aug 31, 2:41 pm 2010 |
| Eric Dumazet | Re: [PATCH 03/10] Use percpu stats
Because we wanted to have fast 64bit counters, even on 32bit arches, and
this has litle to do with 'atomic' on one entity, but a group of
counters. (check drivers/net/loopback.c, lines 91-94). No lock prefix
used in fast path.
We also wanted readers to read correct values, not a value being changed
by a writer, with inconsistent 32bit halves. SNMP applications want
monotonically increasing counters.
this_cpu_add()/this_cpu_read() doesnt fit.
Even for single counter, this_cpu_read(64bit) ...
| Aug 31, 2:28 pm 2010 |
| Stefani Seibold | Re: [PATCH] Add quick erase format option
"Pristine" is not a word which non native speaker have in its
vocabulary. Quick-format is the best, because it is exactly what it is
The user never knows what he is doing, believe me that is what live
This did not work in our NSN transport environment. It would take to
much time to explain why, because the PCU software managment server is a
10 year old application which handles a wide range of transport boards
in the same way, including the old JFFS2 systems and the new UBIFS based
Never ...
| Aug 30, 11:42 pm 2010 |
| Greg KH | Re: [PATCH 985/985] Staging: RT2860: Fixed All coding st ...
This patch breaks the build:
drivers/staging/rt2860/sta/rtmp_data.c: In function ‘STASendPackets’:
drivers/staging/rt2860/sta/rtmp_data.c:885:5: error: ‘_p’ undeclared (first use in this function)
drivers/staging/rt2860/sta/rtmp_data.c:885:5: note: each undeclared identifier is reported only once for each function it appears in
drivers/staging/rt2860/sta/rtmp_data.c:885:5: error: ‘_status’ undeclared (first use in this function)
drivers/staging/rt2860/sta/rtmp_data.c:885:5: warning: left-hand ...
| Aug 31, 11:56 am 2010 |
| Michael S. Tsirkin | Re: [PATCH] cgroups: fix API thinko
Yes, I think so. Unless there are objections, I intend to merge this
(with the review fixes) through net-2.6 together with a vhost-net patch
I think it doesn't affect anything except 2.6.36-rcX,
--
| Aug 31, 7:57 am 2010 |
| Greg KH | Re: [PATCH 2/2] Staging: comedi: fix over 80 characters ...
This patch no longer applies to the linux-next tree. Care to redo it so
that I can apply it?
thanks,
greg k-h
--
| Aug 31, 11:49 am 2010 |
| Konrad Rzeszutek Wilk | Re: [PATCH 16/20] x86: Introduce x86_msi_ops
Hey Peter,
I was wondering if you have time to take a look at this?
The patchset introduces a driver which takes care of allowing
pci_conf_read/write in a virtualized environements with PCI
passthrough devices. Unfortunatly for MSI operations that is not
so simple, so this patch alongside with the previous one
(https://patchwork.kernel.org/patch/117105/)
expands the arch_* calls. This makes it possible to register on top
--
| Aug 31, 11:31 am 2010 |
| Will Drewry | [PATCH v4 2/3] genhd, efi: add efi partition metadata to ...
This change extends the partition_meta_info structure to
support EFI GPT-specific metadata and ensures that data
is copied in on partition scanning.
Signed-off-by: Will Drewry <wad@chromium.org>
---
v2: move info assignment after memcpy()s
adds _MAX to the enum after EFI
v3: exports a generic uuid/volname format
v4: no changes
fs/partitions/efi.c | 25 +++++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/fs/partitions/efi.c ...
| Aug 31, 1:47 pm 2010 |
| Will Drewry | [PATCH v4 1/3] block, partition: add partition_meta_info ...
I'm reposting this patch series as v4 since there have been no additional
comments, and I cleaned up one extra bit of unneeded code (in 3/3). The patches
are against Linus's tree: 2bfc96a127bc1cc94d26bfaa40159966064f9c8c
(2.6.36-rc3).
Would this patchset be suitable for inclusion in an mm branch?
This changes adds a partition_meta_info struct which itself contains a
union of structures that provide partition table specific metadata.
This change leaves the union empty. The subsequent patch ...
| Aug 31, 1:47 pm 2010 |
| Will Drewry | [PATCH v4 3/3] init: add support for root devices specif ...
This is the third patch in a series which adds support for
storing partition metadata, optionally, off of the hd_struct.
One major use for that data is being able to resolve partition
by other identities than just the index on a block device. Device
enumeration varies by platform and there's a benefit to being able
to use something like EFI GPT's GUIDs to determine the correct
block device and partition to mount as the root.
This change adds that support to root= by adding support for
the ...
| Aug 31, 1:47 pm 2010 |
| Paul E. McKenney | Re: Attempted summary of suspend-blockers LKML thread, t ...
It does sounds like there is some variety, then. Thank you for the info!
Thanx, Paul
--
| Aug 30, 5:04 pm 2010 |
| Robert Richter | Re: [PATCH] oprofile: fix crash when accessing freed tas ...
I have applied the patch to
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
--
| Aug 31, 3:28 am 2010 |
| Greg KH | Re: [PATCH] Staging: vt6656: Remove the ULONG_PTR and DW ...
That's just horrible, move it to the right like it was, just don't add
the extra spaces where they are not needed. And think, why would you
want to cast from an unsigned long and then to an unsigned int,
something is really wrong with that code, it should be fixed properly.
Care to try again?
thanks,
greg k-h
--
| Aug 31, 11:33 am 2010 |
| Stephen Rothwell | Re: linux-next: build warning after merge of the net tree
Hi Joe,
Yes, but there were comments on that and nothing since. I think that
James would like a minimal patch that just fixes the newly introduced
warnings.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
| Aug 30, 8:58 pm 2010 |
| Joe Perches | Re: linux-next: build warning after merge of the net tree
Hi Stephen.
What I submitted I think reasonable.
He can extract what he wants if he prefers it done that way.
cheers, Joe
--
| Aug 30, 9:03 pm 2010 |
| David Miller | Re: linux-next: build warning after merge of the net tree
From: Stephen Rothwell <sfr@canb.auug.org.au>
See below:
--------------------
Subject: Re: [GIT] Networking
From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Date: Wed, 04 Aug 2010 13:41:15 -0700 (PDT)
X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO)
From: Linus Torvalds <torvalds@linux-foundation.org>
Joe Perches presented patches to fix this (arguably ...
| Aug 30, 9:42 pm 2010 |
| Stephen Rothwell | Re: linux-next: build warning after merge of the net tree
Hi all,
Can we have a fix for these please? They make too much noise in the builds.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
| Aug 30, 7:57 pm 2010 |
| David Miller | Re: linux-next: build warning after merge of the net tree
From: Stephen Rothwell <sfr@canb.auug.org.au>
I think James is being overly difficult, and since it effects his code
you'd think that he might be a bit proactive and maybe spend the 5
freakin' minutes it might take to write the patch that matches his
exact requirements if they are so important.
Or, at least, I'm sure he could find enough time to sort it out in the
past month and a half don't you think?
I may be weird and a moron, but that's what I would do if my subsystem
had a build ...
| Aug 30, 9:45 pm 2010 |
| David Miller | Re: linux-next: build warning after merge of the net tree
From: Joe Perches <joe@perches.com>
Exactly, he's the maintainter so if he wants something fixed a
specific way he can do it as he likes.
--
| Aug 30, 9:46 pm 2010 |
| Grant Likely | Re: [PATCH 9/9] x86: OLPC: add OLPC device-tree support
Hmmm. I wonder if proc_devtree initialization could be deferred to an
initcall. That would make the problem go away.
g.
--
| Aug 30, 10:49 pm 2010 |
| Alexander Stein | [PATCH v4] kconfig qconf: port to QT4
A straight forward port to QT4 using qt3to4 and compiling against
qt3support
* Use pkg-config to detect QT4 which is hopefully portable enough
* If no QT4, QT3 will by tried instead
* Classes renamed using qt3to4
* If build using QT3 renamed to QT3 class names using defines
* ConfigInfoView::menu has to be renamed as QT4 moc strips struct from
struct menu and creates a name conflict
* QT2 support has been dropped
* The hidden options inserted in ...
| Aug 31, 8:34 am 2010 |
| Chris Hudson | RE: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
Hello Dmitry,
Current-generation accelerometers typically have some functions built-in that provide an interrupt signal under certain conditions. For instance, orientation and motion detection can be calculated at the hardware level to reduce the need for constant polling and software to handle the algorithms. Some devices have built-in tap detection, which can require data at several hundred samples per second, something that is certainly not efficiently supported in software.
I have been ...
| Aug 31, 3:21 pm 2010 |
| Felipe Balbi | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
Hi,
On Mon, 30 Aug 2010 15:43:52 -0700, Dmitry Torokhov
I disagree. If the device is used as input and currently
app developers have to find other ways to use such input
data, having a standard interface other than input layer
will just make the mess standardized, but it will still
Why are we trying to overengineer on such simple devices ? Wasn't
it so that we will design and implement solutions when the problem
arrives ? Why are we trying to think of all cases such a simple
it might ...
| Aug 30, 10:15 pm 2010 |
| Alan Cox | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
Is that the right test for some of these devices.
Surely the question is "what devices can be meaningfully represented by
the input API".
The device range is always going to be quite large and people want to use
the API because it means things just work. They can wire their home made
surfboard unit and tilt sensors up to the PC and tuxracer just goes. They
can wire pedals and a current meter to it and use it as the speed input in
bzflag to simulate bicycle tanks etc..
Alan
--
| Aug 31, 2:53 am 2010 |
| Alan Cox | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
> IIO which is currently in staging.
Except we had ALS before that as a layer and Linus vetoed it. So there is
zero faith in IIO ever going anywhere.
Instead we now have about ten different light sensor APIs to the point
developers are writing a toolkit userspace plugin for *each* sensor.
--
| Aug 31, 2:46 am 2010 |
| Jonathan Cameron | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
It isn't. Most of the interest on LKML might be, but that is because all
of those interested in the 'industrial' side of things are keeping
their discussion on linux-iio@vger list. Most of the noise on LKML may
be on the input bridge side, but most of the actual work and current
developers / users are not. The needs we have are not all met by input,
(and nor should they be) hence the reason IIO exists.
Take a look at the work Analog have been doing with it. There are
few devices in their set ...
| Aug 31, 5:35 am 2010 |
| Jonathan Cameron | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
I have more faith - those developing it have limited time, but we will get
there. (another plug for anyone interested to get involved!)
IIRC Linus and others disliked ALS for two reasons...
* It was too specific. They didn't want to fragment sensors types that much.
* Userspace is used to dealing input and in some cases a light sensor can look
like a switch.
The first certainly doesn't apply to IIO, the second will be fixed via an
input bridge.
I agree. This is a big problem. We have in ...
| Aug 31, 5:51 am 2010 |
| Alan Cox | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
I think the fact that most of the interest in IIO is "how do we make an
If non-input uses later need non-input interfaces they can switch to that
with an input bridge when there is one and when it happens, which
In a non-game context take a look at things like the British Museum
application that allows you to view wherever you are and as it was long
ago by fishing out a relevant photograph as you walk around. In a game
context can I suggest the Zombies game is an example ?
Alan
--
| Aug 31, 2:44 am 2010 |
| Alan Cox | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
Probably because most of these devices have nothing to do with industrial
That tends to make little sense where the API is the same and
applications benefit enormously from consistency. I'd rather have an
input->IIO bridge because that is the real world today !
The question is what does the API make *sense* for. Not what can you use
the API for. Unix (and Linux) are enormously powerful because of the use
of common interfaces and APIs.
So a voltmeter really makes no sense. It's not a set ...
| Aug 31, 9:59 am 2010 |
| Dmitry Torokhov | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
Like Jonathan mentioned, we so far only hear from mobile users here on
Would there even be an argument which subsystem to use if IIO->input
bridge existed today? Because if the answer is "no" then push into input
If application does take something as an input it does not make it
necessarily a human interface device. By this reasoning cameras should
be represented as an input devices (why, some applications take input
from it), hwmon should be input as well (detect your move from
Arkhangelsk ...
| Aug 31, 9:17 am 2010 |
| Jonathan Cameron | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
linux-iio cc'd for comments on the code dump at end of email..
Hmm.. The 'industrial' bit is somewhat misleading. Ultimately it was the
best name anyone came up with a while ago. Happy to change it if someone
Really basic proof of concept at bottom of this email...
It's nasty and not remotely general. General version will be a bit
longer. This is just a hack combining the lis3l02dqbuffersimple.c example
and a uinput example googling gave me... I have no idea if I got the uinput
It covered ...
| Aug 31, 11:03 am 2010 |
| Jonathan Cameron | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
Sadly it is no where near as clean a definition as we would like.
There are too many fuzzy regions. Lots of the devices are used for
both consumer devices and for other forms of high end input. A lot
of consumer devices use general purpose ADCs at a tiny percentage of
That's what you get via input (to a certain extent). But a lot of what
people want in applications is derived data and some of the algorithms
to do that are very complex and certainly should not be in the kernel.
Again this may ...
| Aug 31, 11:14 am 2010 |
| Jonathan Cameron | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
One thing I forgot to mention. IIO uses two different paths for what
become events in input. The main data stream (which is predictable)
comes via the buffer interface handled here. Threshold type events
(and all the weird and wonderful variants) come via a second chrdev
if the device supports them. These are trivial to add to the below
and I'll put them in the generalized version (basically a second fd
and a call to select + a big translation table - which may want to
--
| Aug 31, 11:20 am 2010 |
| Dmitry Torokhov | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
OK, so let's say we start moving some of the devices into input. Which
ones we consider suitable for input? I guess some 3-digit
accelerometers, what else? Also, what new event types would we need?
Let's take GPS - I do not think that ABS_X and ABS_Y are the best events
to be used for such devices: I am trying to allow applications being
ignorant of what exact device they are talking to and rather concentrate
on device capabilities (list of events supported). GPS is sufficiently
different ...
| Aug 31, 10:09 am 2010 |
| Mohamed Ikbel Boulabiar | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
IMHO I think sensors no more can be considered as non-input-devices.
Things changed too much in recent years. Input "sources" have now a
very different use as before (smartphones, Tablets and handheld
devices...)
They all have much inputs that come mostly from sensors.
So the definition of an input device is something that the user can
interact on it ?
Maybe we should consider input devices to be made from 1 to N sensors
with some filtering blocks which only expose the useful data.
If we ...
| Aug 31, 10:24 am 2010 |
| Daniel Barkalow | Re: Sensors and the input layer (was Re: [RFC] [PATCH V2 ...
At least some of the time, an accelerometer is more like part of a
joystick. You can have phones with accelerometers at both ends, where the
input events produced depend on the combination of the readings, with each
of the individual accelerometers being a device that is also available by
itself. You can have phones which can be used in various orientations,
where the logical "left" direction depends on the orientation. With a
joystick, the device that the driver is for has the assignment ...
| Aug 31, 11:18 am 2010 |
| Fenghua Yu | Re: [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR
Hi, Maxim,
Could you send out thermal zone info under /proc/acpi/thermal_zone/TZ*?
Thanks.
-Fenghua
--
| Aug 31, 2:01 pm 2010 |
| Daniel Hobi | [PATCH] [ARM] .gitignore: Ignore piggy.gzip, lib1funcs.S ...
Commit e7db7b42 (arm: add support for LZO-compressed kernels) added
intermediate files piggy.gzip and lib1funcs.S without adding them to
.gitignore.
Commit 6db823c (Fix up .gitignore for top-level file patterns) changed
vmlinux to /vmlinux in the top-level .gitignore, thus making
arch/arm/boot/compressed/vmlinux visible.
Signed-off-by: Daniel Hobi <daniel.hobi@schmid-telecom.ch>
---
This patch revives https://patchwork.kernel.org/patch/94654/
([ARM] .gitignore: Ignore piggy.lzo, lib1funcs.S ...
| Aug 31, 5:52 am 2010 |
| Armin Steinhoff | Re: UIO and Fedora 13 (kernel 33.6)
In the attachment is an updated version of uio_jand.
The module uio_jand.ko can be inserted and removed, no messages visible
by dmesg, no kernel oops, no dev/uio* and no class entries available.
There are only entries of uio_jand in /sys/module,
/sys/bus/platform/drivers and /sys/uio/holders ... I'm really confused =:-/
It's completely unclear how to write the initial platform_data of the
platform device in the example uio_smx.c :
regs = platform_get_resource(dev, ...
| Aug 31, 6:23 am 2010 |
| Armin Steinhoff | Re: UIO and Fedora 13 (kernel 33.6)
uio_pdrv.ko was provided unmodified and precompiles by the Fedora
distro.
This example seems more or less incomplete ... it seems also the case
with the uio_pdrv_genirq example
However, it seems so I have to go back 2 steps and restart after
reading more details of the concept of platform devices ...
Thanks
--Armin
--
| Aug 30, 11:57 pm 2010 |
| Hans J. Koch | Re: UIO and Fedora 13 (kernel 33.6)
That doesn't make sense. uio_pdrv/uio_pdrv_genirq both need some help
Yes, of course. It doesn't make sense for distros to ship these modules.
Both are useful only for developers who build there own kernels and add
What you did was in general the right thing. Find the reason for that oops
and fix it.
Thanks,
Hans
--
| Aug 31, 3:35 am 2010 |
| Linus Walleij | Re: [PATCH] mmc: move regulator handling to core
Yeah I figured out what you wanted and sent an updated patch, check
it out. I'll just weave in some comments from Adrian and it'll do things
the way you want it I believe.
Yours,
Linus Walleij
--
| Aug 31, 5:15 am 2010 |
| Mark Brown | Re: [PATCH] mmc: move regulator handling to core
I'm not sure what "the sites where the regulators were actually
enabled/disabled in respective driver" are but my understanding was that
there's a bit of an issue here in that the MMC core does not guarantee
balanced enable/disable calls.
--
| Aug 31, 4:07 am 2010 |
| previous day | today | next day |
|---|---|---|
| August 30, 2010 | August 31, 2010 | September 1, 2010 |
