Re: [PATCH 0/8] v5 De-couple sysfs memory directories from memory sections

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Dave Hansen
Date: Tuesday, August 31, 2010 - 11:12 am

On Mon, 2010-08-16 at 09:34 -0500, Nathan Fontenot wrote:

Even if an arch defines the override for the sysfs dir size, I still
don't think this breaks anything (it shouldn't).  We move _all_ of the
directories over, all at once, to a single, uniform size.  The only
apparent change to a user moving kernels would be a larger
block_size_bytes (which is certainly not changing the ABI) and a new
sysfs file for the end of the section.  The new sysfs file is
_completely_ redundant at this point.

The architecture is only supposed to bump up the directory size when it
*KNOWS* that all operations will be done at the larger section size,
such as if the specific hardware has physical DIMMs which are much
larger than SECTION_SIZE.

Let's say we have a system with 20MB of memory, SECTION_SIZE of 1MB and
a sysfs dir size of 4MB.  

Before the patch, we have 20 directories: one for each section.  After
this patch, we have 5 directories.  

The thing that I think is the next step, but that we _will_ probably
need eventually is this, take the 5 sysfs dirs in the above case:

	0->3, 4->7, 8->11, 12->15, 16->19

and turn that into a single one:

	0->19

*That* will require changing the ABI, but we could certainly have some
bloated and slow, but backward-compatible mode.  

-- Dave

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/8] v5 Move the find_memory_block() routine up, Nathan Fontenot, (Mon Aug 9, 11:35 am)
[PATCH 2/8] v5 Add new phys_index properties, Nathan Fontenot, (Mon Aug 9, 11:36 am)
[PATCH 3/8] v5 Add section count to memory_block, Nathan Fontenot, (Mon Aug 9, 11:37 am)
[PATCH 4/8] v5 Add mutex for add/remove of memory blocks, Nathan Fontenot, (Mon Aug 9, 11:38 am)
[PATCH 6/8] v5 Update the node sysfs code, Nathan Fontenot, (Mon Aug 9, 11:41 am)
[PATCH 8/8] v5 Update memory-hotplug documentation, Nathan Fontenot, (Mon Aug 9, 11:43 am)
Re: [PATCH 8/8] v5 Update memory-hotplug documentation, Nishanth Aravamudan, (Mon Aug 9, 1:44 pm)
Re: [PATCH 8/8] v5 Update memory-hotplug documentation, Nishanth Aravamudan, (Mon Aug 9, 1:48 pm)
Re: [PATCH 8/8] v5 Update memory-hotplug documentation, Nathan Fontenot, (Tue Aug 10, 5:17 am)
Re: [PATCH 0/8] v5 De-couple sysfs memory directories from ..., Dave Hansen, (Tue Aug 31, 11:12 am)