Home » Mailing list archives » linux-kernel » 2010 » August » 30

Re: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type

Previous thread: [PATCH 0/7] PV on HVM: receive interrupts as xen events by Stefano Stabellini on Monday, August 30, 2010 - 4:20 am. (14 messages)

Next thread: [PATCH 0/3] ARM: Samsung: Move/use the S3C/S5P common GPIO IRQ type by Kyungmin Park on Monday, August 30, 2010 - 4:46 am. (1 message)
[view original message]
From: Kyungmin Park
Subject: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type
Date: Monday, August 30, 2010 - 4:47 am

From: Kyungmin Park <kyungmin.park@samsung.com>

Samsung S5P series has common level type. It's different from S3C series.

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/plat-samsung/include/plat/gpio-core.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-samsung/include/plat/gpio-core.h b/arch/arm/plat-samsung/include/plat/gpio-core.h
index e358c7d..c8681e0 100644
--- a/arch/arm/plat-samsung/include/plat/gpio-core.h
+++ b/arch/arm/plat-samsung/include/plat/gpio-core.h
@@ -14,6 +14,12 @@
 #define GPIOCON_OFF	(0x00)
 #define GPIODAT_OFF	(0x04)
 
+#define S5P_GPIO_LEVEL_LOW		(0x00)
+#define S5P_GPIO_LEVEL_HIGH		(0x01)
+#define S5P_GPIO_EDGE_FALLING		(0x02)
+#define S5P_GPIO_EDGE_RISING		(0x03)
+#define S5P_GPIO_EDGE_BOTH		(0x04)
+
 #define con_4bit_shift(__off) ((__off) * 4)
 
 /* Define the core gpiolib support functions that the s3c platforms may
-- 
1.5.3.3

--


[ message continues ]
[view original message]
From: Sergei Shtylyov
Subject: Re: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type
Date: Monday, August 30, 2010 - 4:59 am

Hello.



    The parens are useless here.

WBR, Sergei

--


[ message continues ]
[view original message]
From: Kukjin Kim
Subject: RE: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type
Date: Monday, August 30, 2010 - 5:01 am

Why should we change the name of definition from S5P_EXTINT_XXX?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--


[ message continues ]
[view original message]
From: Kyungmin Park
Subject: Re: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type
Date: Monday, August 30, 2010 - 6:35 am

External interrupt is one of GPIOs. and it's used for GPIO interrupt.
Do you want to use the EXTINT at generic gpio function?

Also change the name format as IRQ_TYPE_* style.

Thank you,
--


[ message continues ]
[view original message]
From: Kukjin Kim
Subject: RE: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type
Date: Tuesday, August 31, 2010 - 5:36 pm

Right, it is one of the GPIO pin's usage.
But it doesn't mean that should be used like/with generic GPIO...
Even though the value of their polarity is same.

(snip)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--


[ message continues ]
Previous thread: [PATCH 0/7] PV on HVM: receive interrupts as xen events by Stefano Stabellini on Monday, August 30, 2010 - 4:20 am. (14 messages)

Next thread: [PATCH 0/3] ARM: Samsung: Move/use the S3C/S5P common GPIO IRQ type by Kyungmin Park on Monday, August 30, 2010 - 4:46 am. (1 message)