[PATCH] x86, setup: fix earlyprintk=serial,0x3f8,115200

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Sunday, August 29, 2010 - 6:13 pm

earlyprintk could take io port.

So we need to handle this case in setup code too, otherwise 0x3f8
will be treated as baud rate.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/boot/early_serial_console.c |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Index: linux-2.6/arch/x86/boot/early_serial_console.c
===================================================================
--- linux-2.6.orig/arch/x86/boot/early_serial_console.c
+++ linux-2.6/arch/x86/boot/early_serial_console.c
@@ -58,7 +58,19 @@ static void parse_earlyprintk(void)
 		if (arg[pos] == ',')
 			pos++;
 
-		if (!strncmp(arg + pos, "ttyS", 4)) {
+		/*
+		 * make sure we have
+		 *	"serial,0x3f8,115200"
+		 *	"serial,ttyS0,115200"
+		 *	"ttyS0,115200"
+		 */
+		if (pos == 7 && !strncmp(arg + pos, "0x", 2)) {
+			port = simple_strtoull(arg + pos, &e, 16);
+			if (port == 0 || arg + pos == e)
+				port = DEFAULT_SERIAL_PORT;
+			else
+				pos = e - arg;
+		} else if (!strncmp(arg + pos, "ttyS", 4)) {
 			static const int bases[] = { 0x3f8, 0x2f8 };
 			int idx = 0;
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.36-rc3, Linus Torvalds, (Sun Aug 29, 10:25 am)
Re: Linux 2.6.36-rc3, Chris Ball, (Sun Aug 29, 12:24 pm)
Re: Linux 2.6.36-rc3, Torsten Kaiser, (Sun Aug 29, 12:24 pm)
Re: Linux 2.6.36-rc3, Yinghai Lu, (Sun Aug 29, 3:27 pm)
Re: Linux 2.6.36-rc3, Yinghai Lu, (Sun Aug 29, 3:36 pm)
Re: Linux 2.6.36-rc3, Jean-Denis Girard, (Sun Aug 29, 3:40 pm)
Re: Linux 2.6.36-rc3, Yinghai Lu, (Sun Aug 29, 3:53 pm)
[PATCH] x86, setup: fix earlyprintk=serial,0x3f8,115200, Yinghai Lu, (Sun Aug 29, 6:13 pm)
Re: Linux 2.6.36-rc3, Torsten Kaiser, (Sun Aug 29, 9:50 pm)
Re: Linux 2.6.36-rc3, Borislav Petkov, (Sun Aug 29, 10:23 pm)
Re: Linux 2.6.36-rc3, Jean-Denis Girard, (Mon Aug 30, 1:00 am)
Re: Linux 2.6.36-rc3, Miguel Calleja, (Mon Aug 30, 1:47 am)
Re: Linux 2.6.36-rc3, Suresh Jayaraman, (Mon Aug 30, 10:00 am)
Re: Linux 2.6.36-rc3, Shirish Pargaonkar, (Mon Aug 30, 10:14 am)
Re: Linux 2.6.36-rc3, Randy Dunlap, (Mon Aug 30, 10:25 am)
Re: Linux 2.6.36-rc3, Piotr Hosowicz, (Mon Aug 30, 12:28 pm)
Re: Linux 2.6.36-rc3, Steve French, (Mon Aug 30, 2:27 pm)
[tip:x86/urgent] x86, setup: Fix earlyprintk=serial,ttyS0, ..., tip-bot for Yinghai Lu, (Tue Sep 21, 12:58 pm)
[tip:x86/urgent] x86, setup: Fix earlyprintk=serial,0x3f8, ..., tip-bot for Yinghai Lu, (Tue Sep 21, 12:58 pm)
Early console confusion, Bjorn Helgaas, (Wed Sep 22, 8:12 am)
Re: Early console confusion, H. Peter Anvin, (Wed Sep 22, 8:56 am)
Re: Early console confusion, Bjorn Helgaas, (Wed Sep 22, 9:44 am)
Re: Early console confusion, H. Peter Anvin, (Wed Sep 22, 9:53 am)
Re: Early console confusion, Bjorn Helgaas, (Wed Sep 22, 11:21 am)
Re: Early console confusion, H. Peter Anvin, (Wed Sep 22, 11:26 am)