[PATCH 1/2]drivers/usb/core/sysfs.c Fix variable 'retval' set but not used

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Justin P. Mattock
Date: Monday, August 2, 2010 - 9:26 pm

The below fixes a warning generated by GCC:
  CC      drivers/usb/core/sysfs.o
drivers/usb/core/sysfs.c: In function 'usb_create_sysfs_intf_files':
drivers/usb/core/sysfs.c:889:6: warning: variable 'retval' set but not used

Let me know if these are totally wrong etc.. And I'll try
my best to resend properly..

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/usb/core/sysfs.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c
index 448f5b4..af56b3e 100644
--- a/drivers/usb/core/sysfs.c
+++ b/drivers/usb/core/sysfs.c
@@ -886,7 +886,6 @@ int usb_create_sysfs_intf_files(struct usb_interface *intf)
 {
 	struct usb_device *udev = interface_to_usbdev(intf);
 	struct usb_host_interface *alt = intf->cur_altsetting;
-	int retval;
 
 	if (intf->sysfs_files_created || intf->unregistering)
 		return 0;
@@ -895,7 +894,7 @@ int usb_create_sysfs_intf_files(struct usb_interface *intf)
 			!(udev->quirks & USB_QUIRK_CONFIG_INTF_STRINGS))
 		alt->string = usb_cache_string(udev, alt->desc.iInterface);
 	if (alt->string)
-		retval = device_create_file(&intf->dev, &dev_attr_interface);
+		device_create_file(&intf->dev, &dev_attr_interface);
 	intf->sysfs_files_created = 1;
 	return 0;
 }
-- 
1.7.1.rc1.21.gf3bd6

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/2]drivers/usb/core/sysfs.c Fix variable 'retval' ..., Justin P. Mattock, (Mon Aug 2, 9:26 pm)