[RFC PATCH 29/43] ptrace, mn10300: cleanup arch_ptrace()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Namhyung Kim
Date: Friday, August 27, 2010 - 2:42 am

use new 'datap' variable in order to remove unnecessary castings.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Koichi Yasutake <yasutake.koichi@jp.panasonic.com>
---
 arch/mn10300/kernel/ptrace.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/arch/mn10300/kernel/ptrace.c b/arch/mn10300/kernel/ptrace.c
index 4261810..5c0b07e 100644
--- a/arch/mn10300/kernel/ptrace.c
+++ b/arch/mn10300/kernel/ptrace.c
@@ -300,6 +300,7 @@ long arch_ptrace(struct task_struct *child, long request,
 {
 	unsigned long tmp;
 	int ret;
+	unsigned long __user *datap = (unsigned long __user *) data;
 
 	switch (request) {
 	/* read the word at location addr in the USER area. */
@@ -312,7 +313,7 @@ long arch_ptrace(struct task_struct *child, long request,
 		if (addr < NR_PTREGS << 2)
 			tmp = get_stack_long(child,
 					     ptrace_regid_to_frame[addr]);
-		ret = put_user(tmp, (unsigned long *) data);
+		ret = put_user(tmp, datap);
 		break;
 
 		/* write the word at location addr in the USER area */
@@ -331,25 +332,25 @@ long arch_ptrace(struct task_struct *child, long request,
 		return copy_regset_to_user(child, &user_mn10300_native_view,
 					   REGSET_GENERAL,
 					   0, NR_PTREGS * sizeof(long),
-					   (void __user *)data);
+					   datap);
 
 	case PTRACE_SETREGS:	/* Set all integer regs in the child. */
 		return copy_regset_from_user(child, &user_mn10300_native_view,
 					     REGSET_GENERAL,
 					     0, NR_PTREGS * sizeof(long),
-					     (const void __user *)data);
+					     datap);
 
 	case PTRACE_GETFPREGS:	/* Get the child FPU state. */
 		return copy_regset_to_user(child, &user_mn10300_native_view,
 					   REGSET_FPU,
 					   0, sizeof(struct fpu_state_struct),
-					   (void __user *)data);
+					   datap);
 
 	case PTRACE_SETFPREGS:	/* Set the child FPU state. */
 		return copy_regset_from_user(child, &user_mn10300_native_view,
 					     REGSET_FPU,
 					     0, sizeof(struct fpu_state_struct),
-					     (const void __user *)data);
+					     datap);
 
 	default:
 		ret = ptrace_request(child, request, addr, data);
-- 
1.7.2.2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC PATCH 00/43] ptrace cleanups, Namhyung Kim, (Fri Aug 27, 2:41 am)
[RFC PATCH 02/43] ptrace: cleanup ptrace_request(), Namhyung Kim, (Fri Aug 27, 2:41 am)
[RFC PATCH 05/43] ptrace, x86: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:41 am)
[RFC PATCH 08/43] ptrace, arm: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:41 am)
[RFC PATCH 10/43] ptrace, avr32: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:41 am)
[RFC PATCH 15/43] ptrace, frv: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 17/43] ptrace, h8300: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 20/43] ptrace, m32r: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 22/43] ptrace, m68k: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 27/43] ptrace, mips: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 29/43] ptrace, mn10300: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 36/43] ptrace, sh: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 38/43] ptrace, sparc: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 41/43] ptrace, um: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 43/43] ptrace, xtensa: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
Re: [RFC PATCH 02/43] ptrace: cleanup ptrace_request(), Arnd Bergmann, (Fri Aug 27, 7:23 am)
Re: [RFC PATCH 02/43] ptrace: cleanup ptrace_request(), Namhyung Kim, (Fri Aug 27, 9:13 am)
Re: [RFC PATCH 00/43] ptrace cleanups, Mike Frysinger, (Fri Aug 27, 9:30 am)
Re: [RFC PATCH 02/43] ptrace: cleanup ptrace_request(), Arnd Bergmann, (Fri Aug 27, 12:26 pm)
Re: [RFC PATCH 00/43] ptrace cleanups, Roland McGrath, (Sun Aug 29, 5:14 pm)
Re: [RFC PATCH 10/43] ptrace, avr32: cleanup arch_ptrace(), Haavard Skinnemoen, (Mon Aug 30, 5:34 am)
Re: [RFC PATCH 00/43] ptrace cleanups, Namhyung Kim, (Mon Aug 30, 7:02 am)