[RFC PATCH 39/43] ptrace, tile: change signature of arch_ptrace()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Namhyung Kim
Date: Friday, August 27, 2010 - 2:42 am

change type of @addr and @data into unsigned long according to commit
f76671df26ef06321480e702770f88f61272be29 [PATCH 03/43]

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>
---
 arch/tile/kernel/ptrace.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/arch/tile/kernel/ptrace.c b/arch/tile/kernel/ptrace.c
index 7161bd0..704bf11 100644
--- a/arch/tile/kernel/ptrace.c
+++ b/arch/tile/kernel/ptrace.c
@@ -64,7 +64,8 @@ void ptrace_disable(struct task_struct *child)
 	clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
 }
 
-long arch_ptrace(struct task_struct *child, long request, long addr, long data)
+long arch_ptrace(struct task_struct *child, long request,
+		 unsigned long addr, unsigned long data)
 {
 	unsigned long __user *datap;
 	unsigned long tmp;
@@ -84,7 +85,7 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
 	case PTRACE_PEEKUSR:  /* Read register from pt_regs. */
 		if (addr & (sizeof(data)-1))
 			break;
-		if (addr < 0 || addr >= PTREGS_SIZE)
+		if (addr >= PTREGS_SIZE)
 			break;
 		tmp = getreg(child, addr);   /* Read register */
 		ret = put_user(tmp, datap);
@@ -93,7 +94,7 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
 	case PTRACE_POKEUSR:  /* Write register in pt_regs. */
 		if (addr & (sizeof(data)-1))
 			break;
-		if (addr < 0 || addr >= PTREGS_SIZE)
+		if (addr >= PTREGS_SIZE)
 			break;
 		putreg(child, addr, data);   /* Write register */
 		ret = 0;
@@ -102,7 +103,7 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
 	case PTRACE_GETREGS:  /* Get all registers from the child. */
 		if (!access_ok(VERIFY_WRITE, datap, PTREGS_SIZE))
 			break;
-		for (i = 0; i < PTREGS_SIZE; i += sizeof(long)) {
+		for (i = 0; i < PTREGS_SIZE; i += sizeof(unsigned long)) {
 			ret = __put_user(getreg(child, i), datap);
 			if (ret != 0)
 				break;
@@ -113,7 +114,7 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
 	case PTRACE_SETREGS:  /* Set all registers in the child. */
 		if (!access_ok(VERIFY_READ, datap, PTREGS_SIZE))
 			break;
-		for (i = 0; i < PTREGS_SIZE; i += sizeof(long)) {
+		for (i = 0; i < PTREGS_SIZE; i += sizeof(unsigned long)) {
 			ret = __get_user(tmp, datap);
 			if (ret != 0)
 				break;
-- 
1.7.2.2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC PATCH 00/43] ptrace cleanups, Namhyung Kim, (Fri Aug 27, 2:41 am)
[RFC PATCH 02/43] ptrace: cleanup ptrace_request(), Namhyung Kim, (Fri Aug 27, 2:41 am)
[RFC PATCH 05/43] ptrace, x86: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:41 am)
[RFC PATCH 08/43] ptrace, arm: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:41 am)
[RFC PATCH 10/43] ptrace, avr32: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:41 am)
[RFC PATCH 15/43] ptrace, frv: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 17/43] ptrace, h8300: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 20/43] ptrace, m32r: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 22/43] ptrace, m68k: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 27/43] ptrace, mips: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 36/43] ptrace, sh: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 38/43] ptrace, sparc: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 39/43] ptrace, tile: change signature of arch_p ..., Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 41/43] ptrace, um: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
[RFC PATCH 43/43] ptrace, xtensa: cleanup arch_ptrace(), Namhyung Kim, (Fri Aug 27, 2:42 am)
Re: [RFC PATCH 02/43] ptrace: cleanup ptrace_request(), Arnd Bergmann, (Fri Aug 27, 7:23 am)
Re: [RFC PATCH 02/43] ptrace: cleanup ptrace_request(), Namhyung Kim, (Fri Aug 27, 9:13 am)
Re: [RFC PATCH 00/43] ptrace cleanups, Mike Frysinger, (Fri Aug 27, 9:30 am)
Re: [RFC PATCH 02/43] ptrace: cleanup ptrace_request(), Arnd Bergmann, (Fri Aug 27, 12:26 pm)
Re: [RFC PATCH 00/43] ptrace cleanups, Roland McGrath, (Sun Aug 29, 5:14 pm)
Re: [RFC PATCH 10/43] ptrace, avr32: cleanup arch_ptrace(), Haavard Skinnemoen, (Mon Aug 30, 5:34 am)
Re: [RFC PATCH 00/43] ptrace cleanups, Namhyung Kim, (Mon Aug 30, 7:02 am)