Re: [PATCH v2] gpio: Add driver for Anton GPIO controllers

Previous thread: [REGRESSION] [2.6.36-rc2] hp-wmi: probe of hp-wmi failed with error -22 by Maciej Rutecki on Thursday, August 26, 2010 - 10:49 am. (3 messages)

Next thread: [PATCH 03/10] x86/iommu: Add proper dependency sort routine (and sanity check). by Konrad Rzeszutek Wilk on Thursday, August 26, 2010 - 10:57 am. (2 messages)
From: David Brownell
Date: Thursday, August 26, 2010 - 10:57 am

I'm not sure about the precedent of putting
developer names in source.c and driver names...
start that, and everyone will want to follow!!

OK, so Linus started that one, arguably...  :)

Not that I want to be naming this, but how
about a tweak to Alan's suggestion, keeping
the name technical?

   "gpio_basic_mmio.c" ... or similar?

--

From: Anton Vorontsov
Date: Thursday, August 26, 2010 - 2:20 pm

On Thu, Aug 26, 2010 at 10:57:33AM -0700, David Brownell wrote:

I would agree yesterday, but now I tend to like
anton_gpio.c. :-D

You seemed to be fine with meaningless amba-9999
or dw_abc names, but now, when I propose such a
marvellous name, you seem to lean to a synonym of
an old one, the one that I used in v1? Wouldn't
it be a step backwards? :-)

Just kiding, of course. basic_mmio.c works for me.

I also think it makes sense to drop gpio_ prefix,
as the driver is already in gpio/ directory.

Thanks!

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
--

Previous thread: [REGRESSION] [2.6.36-rc2] hp-wmi: probe of hp-wmi failed with error -22 by Maciej Rutecki on Thursday, August 26, 2010 - 10:49 am. (3 messages)

Next thread: [PATCH 03/10] x86/iommu: Add proper dependency sort routine (and sanity check). by Konrad Rzeszutek Wilk on Thursday, August 26, 2010 - 10:57 am. (2 messages)