Home » Mailing list archives » linux-kernel » 2010 » August » 26

[Patch 18/25] GRU - contexts must contain cbrs

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: steiner
Subject: [Patch 18/25] GRU - contexts must contain cbrs
Date: Thursday, August 26, 2010 - 6:19 am

From: Jack Steiner <steiner@sgi.com>

Don't allow users to create GRU contexts with 0 CBRs. This does
not make sense & is not allowed by the chiplet. The chiplet will flag this
as an error and fail to allocate the context.

Signed-off-by: Jack Steiner <steiner@sgi.com>

---
 drivers/misc/sgi-gru/grufile.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/misc/sgi-gru/grufile.c
===================================================================
--- linux.orig/drivers/misc/sgi-gru/grufile.c	2010-06-09 08:11:46.261068458 -0500
+++ linux/drivers/misc/sgi-gru/grufile.c	2010-06-09 08:11:47.151963284 -0500
@@ -175,7 +175,7 @@ static int gru_create_new_context(unsign
 
 	if (req.data_segment_bytes > max_user_dsr_bytes)
 		return -EINVAL;
-	if (req.control_blocks > max_user_cbrs || !req.maximum_thread_count)
+	if (req.control_blocks == 0 || req.control_blocks > max_user_cbrs || !req.maximum_thread_count)
 		return -EINVAL;
 
 	if (!(req.options & GRU_OPT_MISS_MASK))

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[Patch 00/25] GRU - GRU Updates - Production Driver, steiner, (Thu Aug 26, 6:19 am)
[Patch 01/25] GRU - delete obsolete gru instruction opcodes, steiner, (Thu Aug 26, 6:19 am)
[Patch 02/25] GRU - skip gru tlb purging of gru contexts:w, steiner, (Thu Aug 26, 6:19 am)
[Patch 03/25] GRU - update gru tlb miss statistics, steiner, (Thu Aug 26, 6:19 am)
[Patch 04/25] GRU - mmap gru contexts using nonlinear, steiner, (Thu Aug 26, 6:19 am)
[Patch 05/25] GRU - cbe cache flush, steiner, (Thu Aug 26, 6:19 am)
[Patch 06/25] GRU - change context stealing, steiner, (Thu Aug 26, 6:19 am)
[Patch 07/25] GRU - add context lock flag to gru status, steiner, (Thu Aug 26, 6:19 am)
[Patch 08/25] GRU - flush gru tlb when driver is loaded, steiner, (Thu Aug 26, 6:19 am)
[Patch 09/25] GRU - add software reserved bits to cbr defi ..., steiner, (Thu Aug 26, 6:19 am)
[Patch 10/25] GRU - eliminate gru contention on mmap_sem, steiner, (Thu Aug 26, 6:19 am)
[Patch 11/25] GRU - interrupt fix for processors without c ..., steiner, (Thu Aug 26, 6:19 am)
[Patch 12/25] GRU - add gru hub number to context status, steiner, (Thu Aug 26, 6:19 am)
[Patch 13/25] GRU - delete obsolete debug code, steiner, (Thu Aug 26, 6:19 am)
[Patch 14/25] GRU - add polling for tlb misses, steiner, (Thu Aug 26, 6:19 am)
[Patch 15/25] GRU - reorder interrupt processing, steiner, (Thu Aug 26, 6:19 am)
[Patch 16/25] GRU - add refcnt to vdata structure, steiner, (Thu Aug 26, 6:19 am)
[Patch 17/25] GRU - no panic on gru malfunction, steiner, (Thu Aug 26, 6:19 am)
[Patch 18/25] GRU - contexts must contain cbrs, steiner, (Thu Aug 26, 6:19 am)
[Patch 19/25] GRU - update debug messages and comments, steiner, (Thu Aug 26, 6:19 am)
[Patch 20/25] GRU - add gsh information to gru dumps, steiner, (Thu Aug 26, 6:19 am)
[Patch 21/25] GRU - delete unused gru statistics structure, steiner, (Thu Aug 26, 6:19 am)
[Patch 22/25] GRU - gru api cleanup, steiner, (Thu Aug 26, 6:19 am)
[Patch 23/25] GRU - update driverr version, steiner, (Thu Aug 26, 6:20 am)
[Patch 24/25] GRU - rename gru pagesize defines, steiner, (Thu Aug 26, 6:20 am)
[Patch 25/25] GRU - update cbrstate definitions, steiner, (Thu Aug 26, 6:20 am)