Re: [PATCH 14/38] fallthru: ext2 fallthru support

Previous thread: [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue by Fenghua Yu on Wednesday, August 18, 2010 - 3:53 pm. (15 messages)

Next thread: [GIT PULL] perf callchains updates by Frederic Weisbecker on Wednesday, August 18, 2010 - 4:46 pm. (13 messages)
From: Bodo Eggert
Date: Wednesday, August 18, 2010 - 4:24 pm

Not knowing the details, I'd suggest to implement a generic function to
create an attributed inode and let the fs override it to create an
unlinked-file-dentry instead.

Benefit: All fs supporting extended attributes will be able to support
whiteout. If the fs has other means of supporting whiteout, they may fake
the attribute.

Possible problems:
- Having two ways of reporting a whiteout? Or can it be reported using a
  (static) fake inode?

Do a hardlink if you can create a hard link, otherwise use a fresh inode
and use that for the next hardlink(s).


--

From: J. R. Okajima
Date: Wednesday, August 18, 2010 - 7:03 pm

Exactly.
That's the approach aufs takes for whiteout and its brothers.


J. R. Okajima
--

From: Valerie Aurora
Date: Tuesday, August 24, 2010 - 10:21 am

The current version of whiteout support always hides DT_WHT dentries
from userspace.  Perhaps a start is to only hide DT_WHT entries when
the file system is union mounted.  Applications usually ignore all
dentries with d_ino == 0 so it might not cause problems.


Bleah!  Then you have a code path that is only tested when you hit
LINK_MAX.  Sounds like a recipe for bugs for me.

-VAL
--

From: Bodo Eggert
Date: Thursday, August 26, 2010 - 2:53 am

You'll also hit it while creating the first whiteout, maybe on creating 
the first whiteout since mounting, and on filesystems not supporting 
hardlinks (are there some that support attributes but not hardlinks?).
Maybe it will be possible to create immutable whiteout inodes, too.
--

Previous thread: [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue by Fenghua Yu on Wednesday, August 18, 2010 - 3:53 pm. (15 messages)

Next thread: [GIT PULL] perf callchains updates by Frederic Weisbecker on Wednesday, August 18, 2010 - 4:46 pm. (13 messages)