Re: RFC: MTU for serving NFS on Infiniband

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alexey Kuznetsov
Date: Wednesday, August 25, 2010 - 5:10 am

Hello!


Hmm, strange, as I remember, it was supposed to work right.

If the device supports SG (which is required to accept non-linear skbs anyway),
then ip_append_* should allocate skbs not rounded up to mtu and we should
allocate small skb with NFS header only. Does not it work?

I can only guess one possible trap: people could do _one_ huge ip_append_data()
(instead of "planned" scenario, when the header is sent with ip_append_data()
and the following payload is appended with ip_append_page()). Huge ip_append_data()
will generate huge skb indeed. Is this the problem?


BTW this issue could be revisited and this "will generate huge" can be reconsidered.
Automatic generation of fragmented skbs was deliberately suppressed, because it was
found that all devices existing at the moment when this code was written
are strongly biased against SG. Current code tries to _avoid_ generating
non-linear skbs, unless it is intended for zero-copy, which compensated
bias against SG. Modern hardware should work better.

Alexey
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RFC: MTU for serving NFS on Infiniband, Marc Aurele La France, (Mon Aug 23, 7:44 am)
Re: RFC: MTU for serving NFS on Infiniband, Stephen Hemminger, (Mon Aug 23, 8:05 am)
Re: RFC: MTU for serving NFS on Infiniband, Ben Hutchings, (Mon Aug 23, 8:12 am)
Re: RFC: MTU for serving NFS on Infiniband, Marc Aurele La France, (Tue Aug 24, 8:14 am)
Re: RFC: MTU for serving NFS on Infiniband, Ben Hutchings, (Tue Aug 24, 10:57 am)
Re: RFC: MTU for serving NFS on Infiniband, Marc Aurele La France, (Tue Aug 24, 1:33 pm)
Re: RFC: MTU for serving NFS on Infiniband, Ben Hutchings, (Tue Aug 24, 3:20 pm)
Re: RFC: MTU for serving NFS on Infiniband, Stephen Hemminger, (Tue Aug 24, 3:39 pm)
Re: RFC: MTU for serving NFS on Infiniband, Eric Dumazet, (Tue Aug 24, 10:54 pm)
Re: RFC: MTU for serving NFS on Infiniband, Alexey Kuznetsov, (Wed Aug 25, 5:10 am)
Re: RFC: MTU for serving NFS on Infiniband, Eric Dumazet, (Wed Aug 25, 5:17 am)
Re: RFC: MTU for serving NFS on Infiniband, Marc Aurele La France, (Thu Aug 26, 4:40 am)
Re: RFC: MTU for serving NFS on Infiniband, Eric Dumazet, (Thu Aug 26, 4:57 am)
Re: RFC: MTU for serving NFS on Infiniband, Chuck Lever, (Thu Aug 26, 7:58 am)
Re: RFC: MTU for serving NFS on Infiniband, Stephen Hemminger, (Thu Aug 26, 4:53 pm)
Re: RFC: MTU for serving NFS on Infiniband, David Miller, (Thu Aug 26, 5:06 pm)
Re: RFC: MTU for serving NFS on Infiniband, Roland Dreier, (Fri Aug 27, 9:20 am)
Re: RFC: MTU for serving NFS on Infiniband, Roland Dreier, (Fri Aug 27, 10:16 am)
Re: RFC: MTU for serving NFS on Infiniband, Marc Aurele La France, (Fri Aug 27, 10:53 am)
Re: RFC: MTU for serving NFS on Infiniband, Marc Aurele La France, (Thu Sep 30, 11:50 am)