Re: [PATCH] s390: Fix prototype for execve

Previous thread: [PATCH] caif: Use asm/unaligned.h by Jeff Mahoney on Tuesday, August 24, 2010 - 9:11 am. (1 message)

Next thread: [PATCH] guard page for stacks that grow upwards by Luck, Tony on Tuesday, August 24, 2010 - 9:31 am. (5 messages)
From: Jeff Mahoney
Date: Tuesday, August 24, 2010 - 9:25 am

Commit d7627467b7a8dd6944885290a03a07ceb28c10eb constified the
 arguments to execve but missed the s390 prototype.

 This patch fixes it up.

Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---

 arch/s390/kernel/entry.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/s390/kernel/entry.h
+++ b/arch/s390/kernel/entry.h
@@ -42,8 +42,8 @@ long sys_clone(unsigned long newsp, unsi
 	       int __user *parent_tidptr, int __user *child_tidptr);
 long sys_vfork(void);
 void execve_tail(void);
-long sys_execve(const char __user *name, char __user * __user *argv,
-		char __user * __user *envp);
+long sys_execve(const char __user *name, const char __user *const __user *argv,
+		const char __user *const __user *envp);
 long sys_sigsuspend(int history0, int history1, old_sigset_t mask);
 long sys_sigaction(int sig, const struct old_sigaction __user *act,
 		   struct old_sigaction __user *oact);
-- 
Jeff Mahoney
SUSE Labs
--

From: David Howells
Date: Tuesday, August 24, 2010 - 12:58 pm

Acked-by: David Howells <dhowells@redhat.com>
--

From: Heiko Carstens
Date: Tuesday, August 24, 2010 - 10:32 pm

A similar patch just got merged. Thanks!
--

Previous thread: [PATCH] caif: Use asm/unaligned.h by Jeff Mahoney on Tuesday, August 24, 2010 - 9:11 am. (1 message)

Next thread: [PATCH] guard page for stacks that grow upwards by Luck, Tony on Tuesday, August 24, 2010 - 9:31 am. (5 messages)