[PATCH] drm/i915/tv: After disabling the pipe, use wait_for_vblank_off()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Chris Wilson
Date: Tuesday, August 24, 2010 - 8:11 am

Hopefully this is a contributing factor to the spurious TV detection
repoted by Ivan Bulatovic and others.

References:

  Bug 16871 - "TV1 connected" with no tv
  https://bugzilla.kernel.org/show_bug.cgi?id=16871

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reported-by: Ivan Bulatovic <combuster@gmx.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_tv.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index f70bc76..f96289d 100644
--- a/drivers/gpu/drm/i915/intel_tv.c
+++ b/drivers/gpu/drm/i915/intel_tv.c
@@ -1171,7 +1171,7 @@ intel_tv_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
 		I915_WRITE(pipeconf_reg, pipeconf & ~PIPEACONF_ENABLE);
 		POSTING_READ(pipeconf_reg);
 		/* Wait for vblank for the disable to take effect. */
-		intel_wait_for_vblank(dev, intel_crtc->pipe);
+		intel_wait_for_vblank_off(dev, intel_crtc->pipe);
 
 		/* Filter ctl must be set before TV_WIN_SIZE */
 		I915_WRITE(TV_FILTER_CTL_1, TV_AUTO_SCALE);
-- 
1.7.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
i915: 2.6.36-rc2 wrong resolution on gdm start, Ivan Bulatovic, (Mon Aug 23, 6:00 pm)
Re: i915: 2.6.36-rc2 wrong resolution on gdm start, Chris Wilson, (Tue Aug 24, 12:49 am)
Re: i915: 2.6.36-rc2 wrong resolution on gdm start, Ivan Bulatovic, (Tue Aug 24, 1:35 am)
Re: i915: 2.6.36-rc2 wrong resolution on gdm start, Chris Wilson, (Tue Aug 24, 1:50 am)
Re: i915: 2.6.36-rc2 wrong resolution on gdm start, Pekka Enberg, (Tue Aug 24, 1:54 am)
Re: i915: 2.6.36-rc2 wrong resolution on gdm start, Ivan Bulatovic, (Tue Aug 24, 2:12 am)
[PATCH] drm/i915/tv: After disabling the pipe, use wait_fo ..., Chris Wilson, (Tue Aug 24, 8:11 am)
Re: i915: 2.6.36-rc2 wrong resolution on gdm start, Pekka Enberg, (Sun Aug 29, 4:29 am)
Re: i915: 2.6.36-rc2 wrong resolution on gdm start, Maciej Rutecki, (Sun Aug 29, 5:59 am)
Re: i915: 2.6.36-rc2 wrong resolution on gdm start, Sitsofe Wheeler, (Sun Aug 29, 6:37 am)