Re: workqueue destruction BUG_ON

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Johannes Berg
Date: Tuesday, August 24, 2010 - 6:17 am

On Tue, 2010-08-24 at 15:07 +0200, Tejun Heo wrote:


Yes:

void destroy_workqueue(struct workqueue_struct *wq)
{
        unsigned int cpu;
   
        wq->flags |= WQ_DYING;
        flush_workqueue(wq);
  
        /*
         * wq list is used to freeze wq, remove from list after
         * flushing is complete in case freeze races us.
         */
        spin_lock(&workqueue_lock);
        list_del(&wq->list);
        spin_unlock(&workqueue_lock);

        /* sanity check */
        for_each_cwq_cpu(cpu, wq) {
                struct cpu_workqueue_struct *cwq = get_cwq(cpu, wq);
                int i;

                for (i = 0; i < WORK_NR_COLORS; i++)
                        BUG_ON(cwq->nr_in_flight[i]);
2849:           BUG_ON(cwq->nr_active);
                BUG_ON(!list_empty(&cwq->delayed_works));


Applying the patch reported some offset, but the kernel is just rc1 +
wireless stuff.

johannes

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
workqueue destruction BUG_ON, Johannes Berg, (Tue Aug 24, 1:55 am)
Re: workqueue destruction BUG_ON, Tejun Heo, (Tue Aug 24, 3:24 am)
Re: workqueue destruction BUG_ON, Johannes Berg, (Tue Aug 24, 3:37 am)
Re: workqueue destruction BUG_ON, Tejun Heo, (Tue Aug 24, 5:35 am)
Re: workqueue destruction BUG_ON, Johannes Berg, (Tue Aug 24, 6:04 am)
Re: workqueue destruction BUG_ON, Tejun Heo, (Tue Aug 24, 6:07 am)
Re: workqueue destruction BUG_ON, Johannes Berg, (Tue Aug 24, 6:10 am)
Re: workqueue destruction BUG_ON, Tejun Heo, (Tue Aug 24, 6:15 am)
Re: workqueue destruction BUG_ON, Johannes Berg, (Tue Aug 24, 6:17 am)
Re: workqueue destruction BUG_ON, Johannes Berg, (Tue Aug 24, 6:19 am)
Re: workqueue destruction BUG_ON, Johannes Berg, (Tue Aug 24, 6:23 am)
Re: workqueue destruction BUG_ON, Tejun Heo, (Tue Aug 24, 7:56 am)
Re: workqueue destruction BUG_ON, Tejun Heo, (Tue Aug 24, 8:47 am)
Re: workqueue destruction BUG_ON, Johannes Berg, (Tue Aug 24, 8:52 am)
Re: workqueue destruction BUG_ON, Johannes Berg, (Tue Aug 24, 8:56 am)