Home » Mailing list archives » linux-kernel » 2010 » August » 24

[PATCH net-next - trivial] drivers/net: Remove address use from assignments of function pointers

Previous thread: [GIT PATCH] STAGING fixes for .36-rc2 by Greg KH on Monday, August 23, 2010 - 9:05 pm. (1 message)

Next thread: [PATCH net-next - trivial] drivers/net: Remove address use from assignments of function pointers by Joe Perches on Monday, August 23, 2010 - 9:20 pm. (1 message)
[view original message]
From: Joe Perches
Subject: [PATCH net-next - trivial] drivers/net: Remove address use from assignments of function pointers
Date: Monday, August 23, 2010 - 9:20 pm

"foo = &function" is more commonly written "foo = function"

Done with coccinelle script:

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

drivers/net/tehuti.c used a function and struct with the
same name, the function was renamed.

Compile tested x86 only.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/3c503.c                |    8 +++---
 drivers/net/3c515.c                |    2 +-
 drivers/net/3c59x.c                |    2 +-
 drivers/net/atl1e/atl1e_main.c     |    2 +-
 drivers/net/atlx/atl1.c            |    2 +-
 drivers/net/atlx/atl2.c            |    4 +-
 drivers/net/atp.c                  |    2 +-
 drivers/net/bcm63xx_enet.c         |    2 +-
 drivers/net/cpmac.c                |    2 +-
 drivers/net/declance.c             |    2 +-
 drivers/net/dl2k.c                 |    2 +-
 drivers/net/e1000/e1000_main.c     |    6 ++--
 drivers/net/e1000e/netdev.c        |    4 +-
 drivers/net/ehea/ehea_main.c       |    6 ++--
 drivers/net/epic100.c              |    2 +-
 drivers/net/fealnx.c               |    4 +-
 drivers/net/forcedeth.c            |    6 ++--
 drivers/net/hamachi.c              |    2 +-
 drivers/net/hp.c                   |    8 +++---
 drivers/net/hydra.c                |    8 +++---
 drivers/net/igb/igb_main.c         |    4 +-
 drivers/net/ioc3-eth.c             |    2 +-
 drivers/net/ixgb/ixgb_main.c       |    2 +-
 drivers/net/ixgbe/ixgbe_main.c     |    4 +-
 drivers/net/ixgbevf/ixgbevf_main.c |    2 +-
 drivers/net/mac8390.c              |   48 ++++++++++++++++++------------------
 drivers/net/natsemi.c              |    2 +-
 drivers/net/pci-skeleton.c         |    2 +-
 drivers/net/pcmcia/3c574_cs.c      |    2 +-
 drivers/net/pcmcia/3c589_cs.c      |    2 +-
 drivers/net/pcmcia/axnet_cs.c      |   10 +++---
 drivers/net/pcmcia/pcnet_cs.c      |   16 ++++++------
 drivers/net/pcmcia/smc91c92_cs.c   |    4 +-
 drivers/net/rrunner.c              |    2 +-
 ...
[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH net-next - trivial] drivers/net: Remove address use from assignments of function pointers
Date: Wednesday, August 25, 2010 - 3:35 pm

From: Joe Perches <joe@perches.com>

Applied, thanks.
--


[ message continues ]
Previous thread: [GIT PATCH] STAGING fixes for .36-rc2 by Greg KH on Monday, August 23, 2010 - 9:05 pm. (1 message)

Next thread: [PATCH net-next - trivial] drivers/net: Remove address use from assignments of function pointers by Joe Perches on Monday, August 23, 2010 - 9:20 pm. (1 message)