Home » Mailing list archives » linux-kernel » 2010 » August » 21

TRACE: config warning for IRQSOFF_TRACER

Previous thread: [PATCH for -tip 0/2] Generic Alignment API by Mathieu Desnoyers on Saturday, August 21, 2010 - 7:17 am. (8 messages)

Next thread: [PATCH] signals: annotate siglock acquirement by Namhyung Kim on Saturday, August 21, 2010 - 8:17 am. (1 message)
[view original message]
From: Richard Kennedy
Subject: TRACE: config warning for IRQSOFF_TRACER
Date: Saturday, August 21, 2010 - 7:52 am

In my config with PROVE_LOCKING=n and FTRACE=y (which defaults
IRQSOFF_TRACER to y), I get the following warning from make oldconfig.

scripts/kconfig/conf --oldconfig arch/x86/Kconfig
warning: (IRQSOFF_TRACER && TRACING_SUPPORT && FTRACE &&
TRACE_IRQFLAGS_SUPPORT && !ARCH_USES_GETTIMEOFFSET) selects
TRACE_IRQFLAGS which has unmet direct dependencies (DEBUG_KERNEL &&
TRACE_IRQFLAGS_SUPPORT && PROVE_LOCKING)

The problem is that TRACE_IRQFLAGS depends on PROVE_LOCKING.
Should it select PROVE_LOCKING instead? or is there a better way to fix
this?

regards

Richard




--


[ message continues ]
[view original message]
From: Steven Rostedt
Subject: Re: TRACE: config warning for IRQSOFF_TRACER
Date: Monday, August 30, 2010 - 5:47 pm

The TRACE_IRQFLAGS was originally written for lockdep, but it is now
used by Ftrace's irqsoff tracer.

I just compiled and booted with TRACE_IRQFLAGS=y and PROVE_LOCKING not
set, and it worked fine.

I think the correct patch is to remove the dependency of TRACE_IRQFLAGS
on PROVE_LOCKING.

-- Steve


--


[ message continues ]
Previous thread: [PATCH for -tip 0/2] Generic Alignment API by Mathieu Desnoyers on Saturday, August 21, 2010 - 7:17 am. (8 messages)

Next thread: [PATCH] signals: annotate siglock acquirement by Namhyung Kim on Saturday, August 21, 2010 - 8:17 am. (1 message)