Re: [PATCH] MFD: Align AB8500 with the abx500.h interface

Previous thread: Re: [PATCH 01/19] User-space API definition by Miloslav Trmac on Saturday, August 21, 2010 - 2:11 am. (1 message)

Next thread: [PATCH -mm V2] fix compilation error with CROSS_COMPILE by Wu Fengguang on Saturday, August 21, 2010 - 2:31 am. (1 message)
From: Linus Walleij
Date: Saturday, August 21, 2010 - 2:20 am

From: Mattias Wallin <mattias.wallin@stericsson.com>

This patch consolidates the ab8500 mixed signal chip to expose the
same interface for register access as the ab3100, ab3550 and ab5500
chips. The ab8500_read() and ab8500_write() are removed and replaced
with abx500_get_register_interruptible() and
abx500_set_register_interruptible() respectively.

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Mattias Wallin <mattias.wallin@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
This patch need be applied across the subsystems so as not to break
bisection. Since it is mainly related to the core, the suggestion
is to bring this in through Sam:s tree.
---
 drivers/mfd/Kconfig        |    4 +-
 drivers/mfd/ab8500-core.c  |  286 ++++++++++++++++++++++++++------------------
 drivers/regulator/ab8500.c |   86 ++++++++------
 drivers/rtc/rtc-ab8500.c   |  103 ++++++++--------
 include/linux/mfd/ab8500.h |   28 ++++-
 include/linux/mfd/abx500.h |    3 +-
 6 files changed, 301 insertions(+), 209 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index db51ea1..c957c3a 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -433,7 +433,7 @@ config PCF50633_GPIO
 
 config ABX500_CORE
 	bool "ST-Ericsson ABX500 Mixed Signal Circuit register functions"
-	default y if ARCH_U300
+	default y if ARCH_U300 || ARCH_U8500
 	help
 	  Say yes here if you have the ABX500 Mixed Signal IC family
 	  chips. This core driver expose register access functions.
@@ -473,7 +473,7 @@ config EZX_PCAP
 
 config AB8500_CORE
 	bool "ST-Ericsson AB8500 Mixed Signal Power Management chip"
-	depends on SPI=y && GENERIC_HARDIRQS
+	depends on SPI=y && GENERIC_HARDIRQS && ABX500_CORE
 	select MFD_CORE
 	help
 	  Select this option to enable access to AB8500 power management
diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index ...
From: Mark Brown
Date: Saturday, August 21, 2010 - 3:12 am

This one looks like it slipped in from a separate change, though?
--

From: Linus WALLEIJ
Date: Monday, August 23, 2010 - 12:30 am

Yeahm,  it doesn't hurt och break git-bisect but if it's disturbing
I can spin it over to the other patch.

Right now I'm just awaiting Sams reply to if he wants per-subsystem
patches or not, so I'll make a final version if there are more
changes required.

Yours,
Linus Walleij
--

From: Linus WALLEIJ
Date: Monday, August 30, 2010 - 1:46 am

Sam,
is this one OK or do I need to spin it around/split it more?

Yours,
Linus Walleij
--

From: Samuel Ortiz
Date: Friday, September 10, 2010 - 8:00 am

Hi Linus,

You're right here, sorry I didnt look at the patch carefully enough.
So this one below is ready to go except for the debugfs slip that Mark pointed
out. Would you mind spinning a new one for me ?

Cheers,
Samuel.

P.S.: And sorry for the delays, I was on holidays.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--

Previous thread: Re: [PATCH 01/19] User-space API definition by Miloslav Trmac on Saturday, August 21, 2010 - 2:11 am. (1 message)

Next thread: [PATCH -mm V2] fix compilation error with CROSS_COMPILE by Wu Fengguang on Saturday, August 21, 2010 - 2:31 am. (1 message)