Re: [PATCH -V18 04/13] vfs: Allow handle based open on symlinks

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Al Viro
Date: Friday, August 20, 2010 - 4:51 am

On Fri, Aug 20, 2010 at 07:53:03PM +1000, Neil Brown wrote:

You are welcome to review the codepaths around pathname resolution for
assumptions of presense of ->follow_link() and friends; there _are_
subtle cases and dumping your "opened symlinks" in there is far from
a trivial change.  Note that it affects more than just the starting
points of lookups; /proc/*/fd/* stuff is also involved.

BTW, speaking of NULL pathname, linkat() variant that allows creating a link
to an opened file is also a very dubious thing; at the very least, you get
non-trivial security implications, since now a process that got an opened
descriptor passed to it by somebody else may create hardlinks to the sucker.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -V18 03/13] vfs: Add open by file handle support, Aneesh Kumar K.V, (Thu Aug 19, 6:51 pm)
[PATCH -V18 04/13] vfs: Allow handle based open on symlinks, Aneesh Kumar K.V, (Thu Aug 19, 6:51 pm)
[PATCH -V18 05/13] vfs: Support null pathname in readlink, Aneesh Kumar K.V, (Thu Aug 19, 6:51 pm)
[PATCH -V18 06/13] vfs: Support null pathname in faccessat, Aneesh Kumar K.V, (Thu Aug 19, 6:51 pm)
[PATCH -V18 07/13] vfs: Support null pathname in linkat, Aneesh Kumar K.V, (Thu Aug 19, 6:51 pm)
[PATCH -V18 08/13] x86: Add new syscalls for x86_32, Aneesh Kumar K.V, (Thu Aug 19, 6:51 pm)
[PATCH -V18 09/13] x86: Add new syscalls for x86_64, Aneesh Kumar K.V, (Thu Aug 19, 6:51 pm)
[PATCH -V18 12/13] ext3: Copy fs UUID to superblock., Aneesh Kumar K.V, (Thu Aug 19, 6:51 pm)
[PATCH -V18 13/13] ext4: Copy fs UUID to superblock, Aneesh Kumar K.V, (Thu Aug 19, 6:51 pm)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Thu Aug 19, 7:13 pm)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Thu Aug 19, 11:53 pm)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Christoph Hellwig, (Fri Aug 20, 1:30 am)
Re: [PATCH -V18 05/13] vfs: Support null pathname in readlink, Christoph Hellwig, (Fri Aug 20, 1:32 am)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Al Viro, (Fri Aug 20, 4:51 am)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Fri Aug 20, 7:38 am)
Re: [PATCH -V18 05/13] vfs: Support null pathname in readlink, Aneesh Kumar K. V, (Fri Aug 20, 7:43 am)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Sat Aug 21, 2:31 am)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Sat Aug 21, 2:32 am)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Sat Aug 21, 2:42 am)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Sat Aug 21, 7:02 pm)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Sun Aug 22, 6:24 pm)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Sun Aug 22, 7:49 pm)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Bastien ROUCARIES, (Tue Aug 24, 2:41 am)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Tue Aug 24, 3:34 am)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Aneesh Kumar K. V, (Tue Aug 24, 3:40 am)
Re: [PATCH -V18 04/13] vfs: Allow handle based open on sym ..., Bastien ROUCARIES, (Wed Aug 25, 2:13 am)