Re: Additional fix : (was [v2]printk: fix delayed messages from CPU hotplug events)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrew Morton
Date: Monday, August 2, 2010 - 3:44 pm

On Tue, 29 Jun 2010 14:22:26 +0530
"Shilimkar, Santosh" <santosh.shilimkar@ti.com> wrote:


The patch lacked a suitable title.  I called it "console: flush log
messages for more cpu-hotplug events".

The patch lacks a Signed-off-by:.  Please send one.

The patch has its tabs replaced with spaces.  I fixed that.  Please
reconfigure your email client for next time.

The code which is being patch has changed.  It now does

                acquire_console_sem();
                release_console_sem();

so the code may no longer work - perhaps it now deadlocks (unlikely). 
Please retest?

Finally, I don't understand the patch :( Who is sending out CPU_DEAD,
CPU_DYING or CPU_DOWN_FAILED events during kernel boot?  I'd have
thought that those events simply aren't occurring, and that the patch
has no effect.  Confused - please explain further.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Additional fix : (was [v2]printk: fix delayed messages fro ..., Shilimkar, Santosh, (Tue Jun 29, 1:52 am)
Re: Additional fix : (was [v2]printk: fix delayed messages ..., Andrew Morton, (Mon Aug 2, 3:44 pm)
RE: Additional fix : (was [v2]printk: fix delayed messages ..., Shilimkar, Santosh, (Tue Aug 3, 12:33 am)
RE: Additional fix : (was [v2]printk: fix delayed messages ..., Shilimkar, Santosh, (Tue Aug 3, 9:53 am)