login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
August
»
19
RE: [PATCH] power_supply: add isp1704 charger detection driver
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Gadiyar, Anand
Subject:
RE: [PATCH] power_supply: add isp1704 charger detection driver
Date: Thursday, August 19, 2010 - 3:59 am
> +static void isp1704_charger_work(struct work_struct *data)
quoted text
> +{ > + struct isp1704_charger *isp = > + container_of(data, struct isp1704_charger, work); > + > + /* FIXME Only supporting dedicated chargers even though isp1704 can > + * detect HUB and HOST chargers. If the device has already been > + * enumerated, the detection will break the connection. > + */
Minor CodingStyle comment (since you're reworking the patch anyway). Preferred style for multi-line comments is: /* * FIXME Only supporting ... * detect HUB ... * enumerated ... */ --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] power_supply: add isp1704 charger detection driver
, Krogerus Heikki (EXT ...
, (Wed Aug 18, 6:01 am)
Re: [PATCH] power_supply: add isp1704 charger detection driver
, Anton Vorontsov
, (Wed Aug 18, 6:42 am)
Re: [PATCH] power_supply: add isp1704 charger detection driver
, Roger Quadros
, (Wed Aug 18, 7:55 am)
Re: [PATCH] power_supply: add isp1704 charger detection driver
, Heikki Krogerus
, (Thu Aug 19, 12:03 am)
Re: [PATCH] power_supply: add isp1704 charger detection driver
, Heikki Krogerus
, (Thu Aug 19, 12:17 am)
RE: [PATCH] power_supply: add isp1704 charger detection driver
, Gadiyar, Anand
, (Thu Aug 19, 3:59 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Christoph Lameter
[PATCH 1/2] Make page->private usable in compound pages V1
Luben Tuikov
Re: Integration of SCST in the mainstream Linux kernel
Alexey Dobriyan
Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Michal Nazarewicz
Re: [PATCH] USB: Gadget: g_multi: added INF file for gadget with multiple configur...
Jesse Barnes
Re: PCI probing changes
git
:
Jakub Narebski
Re: GSoC 2008 - Mentors Wanted!
Jan Harkes
Re: git-svn and huge data and modifying the git-svn-HEAD branch directly
Andy Parkins
git-fetch fails with error code 128
Marcus Griep
Re: [PATCH 1/3] Git.pm: Add faculties to allow temp files to be cached
Junio C Hamano
Re: [JGIT PATCH 2/2] Decrease the fetch pack client buffer to the lower minimum
git-commits-head
:
Linux Kernel Mailing List
ARM: 5970/1: nomadik-gpio: fix spinlock usage
Linux Kernel Mailing List
sh-sci: update receive error handling for muxed irqs
Linux Kernel Mailing List
No need to do lock_super() for exclusion in generic_shutdown_super()
Linux Kernel Mailing List
x86, msr: Export the register-setting MSR functions via /dev/*/msr
Linux Kernel Mailing List
Input: gpio-keys - add support for disabling gpios through sysfs
linux-netdev
:
Eric Dumazet
[PATCH] net: ALIGN/PTR_ALIGN cleanup in alloc_netdev_mq()/netdev_priv()
Patrick McHardy
[NET_SCHED]: sch_ingress: remove netfilter support
Rose, Gregory V
RE: __bad_udelay in network driver breaks build
Patrick McHardy
Re: no reassembly for outgoing packets on RAW socket
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc
:
ropers
Re: Real men don't attack straw men
elitdostlar
Seks partneri arayan bayanlar bu adreste - 8878xs706x6438
Marcus Andree
Re: This is what Linus Torvalds calls openBSD crowd
Lars D. Noodén
Re: sshd.config and AllowUsers
Henning Brauer
Re: Sun Blade 1000?
Colocation donated by:
Syndicate