Re: [PATCH] perf tools: Don't use brace expansion.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Arnaldo Carvalho de Melo
Date: Tuesday, August 17, 2010 - 8:42 am

Em Tue, Aug 17, 2010 at 01:58:00PM +0200, Bernd Petrovitsch escreveu:

Adding $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h there, to have it look:

+# we compile into subdirectories. if the target directory is not the source directory, they might not exists. So
+# we depend the various files onto their directories.
+$(LIB_OBJS) $(BUILTIN_OBJS) $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h: $(sort $(dir $(LIB_OBJS) $(BUILTIN_OBJS)))
+# In the second step, we make a rule to actually create these directories
+$(sort $(dir $(LIB_OBJS) $(BUILTIN_OBJS))):
+       mkdir -p $@ 2>/dev/null
+

As it was failing when I did:

rm -rf ~/build/perf
make -C tools/perf O=~/build/perf

With that it retains the existing functionality,

Thanks,

- Arnaldo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] perf tools: Don't use brace expansion., Kusanagi Kouichi, (Mon Aug 16, 5:41 am)
Re: [PATCH] perf tools: Don't use brace expansion., Peter Zijlstra, (Mon Aug 16, 6:30 am)
Re: [PATCH] perf tools: Don't use brace expansion., Bernd Petrovitsch, (Mon Aug 16, 7:09 am)
Re: [PATCH] perf tools: Don't use brace expansion., Peter Zijlstra, (Mon Aug 16, 7:30 am)
Re: [PATCH] perf tools: Don't use brace expansion., Bernd Petrovitsch, (Mon Aug 16, 7:54 am)
Re: [PATCH] perf tools: Don't use brace expansion., Arnaldo Carvalho de Melo, (Mon Aug 16, 8:24 am)
Re: [PATCH] perf tools: Don't use brace expansion., Arnaldo Carvalho de Melo, (Mon Aug 16, 8:29 am)
Re: [PATCH] perf tools: Don't use brace expansion., Bernd Petrovitsch, (Mon Aug 16, 8:43 am)
Re: [PATCH] perf tools: Don't use brace expansion., Arnaldo Carvalho de Melo, (Mon Aug 16, 8:50 am)
Re: [PATCH] perf tools: Don't use brace expansion., Bernd Petrovitsch, (Tue Aug 17, 4:58 am)
Re: [PATCH] perf tools: Don't use brace expansion., Arnaldo Carvalho de Melo, (Tue Aug 17, 8:42 am)
Re: [PATCH] perf tools: Don't use brace expansion., Bernd Petrovitsch, (Tue Aug 17, 9:09 am)
Re: [PATCH] perf tools: Don't use brace expansion., Arnaldo Carvalho de Melo, (Tue Aug 17, 11:16 am)
[tip:perf/urgent] perf tools: Fix build on POSIX shells, tip-bot for Bernd Pe ..., (Wed Aug 18, 1:18 am)
Re: [PATCH] perf tools: Don't use brace expansion., Bernd Petrovitsch, (Wed Aug 18, 2:47 am)