login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
August
»
17
Re: [PATCH v2] hwmon: (ads7871) Fix ads7871_probe error path
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Jean Delvare
Subject:
Re: [PATCH v2] hwmon: (ads7871) Fix ads7871_probe error path
Date: Tuesday, August 17, 2010 - 7:10 am
On Tue, 17 Aug 2010 20:41:24 +0800, Axel Lin wrote:
quoted text
> This patch moves hwmon_device_register() to the end of ads7871_probe(). > So we can make sure the device exists and is properly initialized > before the device is exposed to user-space. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > drivers/hwmon/ads7871.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c > index b300a20..45f5829 100644 > --- a/drivers/hwmon/ads7871.c > +++ b/drivers/hwmon/ads7871.c > @@ -176,12 +176,6 @@ static int __devinit ads7871_probe(struct spi_device *spi) > if (status < 0) > goto error_free; > > - pdata->hwmon_dev = hwmon_device_register(&spi->dev); > - if (IS_ERR(pdata->hwmon_dev)) { > - err = PTR_ERR(pdata->hwmon_dev); > - goto error_remove; > - } > - > spi_set_drvdata(spi, pdata); > > /* Configure the SPI bus */ > @@ -204,6 +198,12 @@ static int __devinit ads7871_probe(struct spi_device *spi) > goto error_remove; > } > > + pdata->hwmon_dev = hwmon_device_register(&spi->dev); > + if (IS_ERR(pdata->hwmon_dev)) { > + err = PTR_ERR(pdata->hwmon_dev); > + goto error_remove; > + } > + > return 0; > > error_remove:
Applied, thanks. -- Jean Delvare --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH v2] hwmon: (ads7871) Fix ads7871_probe error path
, Axel Lin
, (Tue Aug 17, 5:41 am)
Re: [PATCH v2] hwmon: (ads7871) Fix ads7871_probe error path
, Jean Delvare
, (Tue Aug 17, 7:10 am)
Re: [PATCH v2] hwmon: (ads7871) Fix ads7871_probe error path
, Jean Delvare
, (Sun Aug 22, 4:58 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Fortier,Vincent [Montreal]
2.6.21.5 june 30th to july 1st date hang?
Jeff Dike
[ PATCH 2/6 ] UML - Formatting fixes around os_{read_write}_file callers
Liam Girdwood
[PATCH 07/13] regulator: regulator test harness
Oleg Nesterov
Re: Getting the new RxRPC patches upstream
Stefan Seyfried
Re: 2.6.19-rc5: grub is much slower resuming from suspend-to-disk than in 2.6.18
linux-netdev
:
Arnaud Ebalard
Re: [REGRESSION,BISECTED] MIPv6 support broken by f4f914b58019f0
Jan Engelhardt
Re: [PATCH iptables] extension: add xt_cpu match
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Sebastian Andrzej Siewior
[PATCH 8/8] net/emergency: remove locking from reycling pool if emergncy pools are...
David Miller
Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
git
:
Jakub Narebski
Re: git on MacOSX and files with decomposed utf-8 file names
Brandon Casey
Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the def...
Christian Couder
[PATCH 1/3] rev-parse: add test script for "--verify"
Ramkumar Ramachandra
Re: [GSoC update] git-remote-svn: The final one
Junio C Hamano
Re: git-rm isn't the inverse action of git-add
openbsd-misc
:
Joachim Schipper
Re: UVC Webcams
Florin Andrei
SOLVED [was: firewall is very slow, something's wrong]
Todd Alan Smith
Re: Microsoft gets the Most Secure Operating Systems award
Neal Hogan
Re: Need Advice: Thinkpad T60 or T61?
Sam Fourman Jr.
Re: Real men don't attack straw men
git-commits-head
:
Linux Kernel Mailing List
ACPI: Disable ARB_DISABLE on platforms where it is not needed
Linux Kernel Mailing List
m68knommu: add read_barrier_depends() and irqs_disabled_flags()
Linux Kernel Mailing List
[MTD] Add mtd panic_write function pointer
Linux Kernel Mailing List
[ARM] pxa: remove duplicate select statements from Kconfig
Linux Kernel Mailing List
mlx4_core: Don't read reserved fields in mlx4_QUERY_ADAPTER()
Colocation donated by:
Syndicate