| From | Subject | Date |
|---|---|---|
| Igor M. Liplianin | [PATCH 06/18] cx23885: implement tuner_bus parameter for ...
There is two external I2C buses in cx23885 chip.
Currently, analog tuners supported for second I2C bus only
In NetUP Dual DVB-T/C CI RF card tuners connected to first bus
So, in order to support analog tuners sitting on first bus
we need modifications.
Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
---
drivers/media/video/cx23885/cx23885-cards.c | 5 +++++
drivers/media/video/cx23885/cx23885-core.c | 5 +++--
drivers/media/video/cx23885/cx23885-video.c | 7 ++++---
...
| Aug 16, 11:15 am 2010 |
| Igor M. Liplianin | [PATCH 05/18] Initial commit to support NetUP Dual DVB-T ...
The card based on cx23885 PCI-e brige. Altera FPGA for CI,
multistandard demods stv0367 from STM for QAM & OFDM, Xcieve xc5000 tuners
and additional cx25840 for second analog input.
Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
---
drivers/media/video/cx23885/Kconfig | 3 +-
drivers/media/video/cx23885/cx23885-cards.c | 103 ++++++++++++++++-
drivers/media/video/cx23885/cx23885-core.c | 24 +++--
drivers/media/video/cx23885/cx23885-dvb.c | 172 ...
| Aug 16, 10:06 am 2010 |
| Ivan Bulatovic | 2.6.36-rc1 - iptables inconsistent lock state
I've compiled 2.6.36-rc1 with
CONFIG_DEBUG_SPINLOCK=y
CONFIG_DEBUG_LOCK_ALLOC=y
CONFIG_PROVE_LOCKING=y
CONFIG_LOCKDEP=y
and when I try to load ufw I get this info in dmesg:
[ 30.687708] =================================
[ 30.688013] [ INFO: inconsistent lock state ]
[ 30.688013] 2.6.36-rc1-RC #1
[ 30.688013] ---------------------------------
[ 30.688013] inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage.
[ 30.688013] iptables/1853 [HC0[0]:SC0[0]:HE1:SE1] takes:
[ ...
| Aug 16, 4:43 pm 2010 |
| David Cross | Re: FW: EXPORT_SYMBOL(fat_get_block)
To give you an idea of the performance difference, even for mass storage
class which has less protocol involvement, the native software and
hardware on the platform I am using typically perform at less than 4
MB/s. I am getting this number from benchmarks of the Motorola Droid
phone, which uses a similar software and hardware configuration as the
Understood, I will try to implement it in this way on my setup. I do
have the latest kernel booting on it now and show be able to implement
this ...
| Aug 16, 4:34 pm 2010 |
| Takao Indoh | [PATCH v2][EFI] Run EFI in physical mode
Hi all,
Thanks for many comments. I just changed some variables according to
Huang's comment.
Ok, what I should do next is:
- x86 support
As I wrote, I don't have x86 machine where EFI works. Any
volunteer?
- ia64 support
I'm not sure we should do this, but I'll try if we need.
- Using common page tables instead of EFI own page table
Now I'm checking the thread below...
http://marc.info/?i=1280940316-7966-1-git-send-email-bp@amd64.org
Signed-off-by: Takao ...
| Aug 16, 4:07 pm 2010 |
| Adam Lackorzynski | 2.6.35.2: NFS related Oops
Hi,
with 2.6.35.2 I'm getting this reproducible Oops:
[ 110.825396] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 110.828638] IP: [<ffffffff811247b7>] encode_attrs+0x1a/0x2a4
[ 110.828638] PGD be89f067 PUD bf18f067 PMD 0
[ 110.828638] Oops: 0000 [#1] SMP
[ 110.828638] last sysfs file: /sys/class/net/lo/operstate
[ 110.828638] CPU 2
[ 110.828638] Modules linked in: rtc_cmos rtc_core rtc_lib amd64_edac_mod i2c_amd756 edac_core i2c_core dm_mirror dm_region_hash dm_log ...
| Aug 16, 2:50 pm 2010 |
| Jason Wessel | [GIT PULL] kgdb/kdb fixes for 2.6.36-rc1
Linus, please pull the for_linus branch which contains:
* Fixes for compilation/warning errors since the kdb/kms merge
* 1 run time fix for atomic kms where console_blanked was not saved
git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git for_lin
us
Thanks,
Jason.
---
The following changes since commit da5cabf80e2433131bf0ed8993abc0f7ea618c73:
Linus Torvalds (1):
Linux 2.6.36-rc1
are available in the git repository at:
...
| Aug 16, 2:06 pm 2010 |
| Jason Wessel | [PATCH 2/5] kgdb: add missing __percpu markup in arch/x8 ...
From: Namhyung Kim <namhyung@gmail.com>
breakinfo->pev is a pointer to percpu pointer but was missing __percpu markup.
Add it.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
arch/x86/kernel/kgdb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index ef10940..852b819 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -194,7 +194,7 @@ ...
| Aug 16, 2:06 pm 2010 |
| Jason Wessel | [PATCH 1/5] kdb: fix compile error without CONFIG_KALLSYMS
If CONFIG_KGDB_KDB is set and CONFIG_KALLSYMS is not set the kernel
will fail to build with the error:
kernel/built-in.o: In function `kallsyms_symbol_next':
kernel/debug/kdb/kdb_support.c:237: undefined reference to `kdb_walk_kallsyms'
kernel/built-in.o: In function `kallsyms_symbol_complete':
kernel/debug/kdb/kdb_support.c:193: undefined reference to `kdb_walk_kallsyms'
The kdb_walk_kallsyms needs a #ifdef proper header to match the C
implementation. This patch also fixes the compiler ...
| Aug 16, 2:06 pm 2010 |
| Jason Wessel | [PATCH 5/5] vt,console,kdb: preserve console_blanked whi ...
Commit b45cfba4e9005d64d419718e7ff7f7cab44c1994 (vt,console,kdb:
implement atomic console enter/leave functions) introduced the ability
to atomically change the console mode with kernel mode setting but did
not preserve the state of the console_blanked variable.
The console_blanked variable must be restored when executing the
con_debug_leave() or further kernel mode set changes (such as using
chvt X) will fail to correctly set the state of console.
Signed-off-by: Jason Wessel ...
| Aug 16, 2:06 pm 2010 |
| Jason Wessel | [PATCH 4/5] vt: fix regression warnings from KMS merge
Fix the following new sparse warnings in vt.c introduced by the commit
b45cfba4e9005d64d419718e7ff7f7cab44c1994 (vt,console,kdb: implement
atomic console enter/leave functions):
drivers/char/vt.c:197:5: warning: symbol 'saved_fg_console' was not declared. Should it be static?
drivers/char/vt.c:198:5: warning: symbol 'saved_last_console' was not declared. Should it be static?
drivers/char/vt.c:199:5: warning: symbol 'saved_want_console' was not declared. Should it be ...
| Aug 16, 2:06 pm 2010 |
| Jason Wessel | [PATCH 3/5] arm,kgdb: fix GDB_MAX_REGS no longer used
From: Eric Miao <eric.y.miao@gmail.com>
According to commit 22eeef4bb2a7fd225089c0044060ed1fbf091958
kgdb,arm: Individual register get/set for arm
It's now replaced by DBG_MAX_REG_NUM.
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
arch/arm/kernel/kgdb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/kernel/kgdb.c b/arch/arm/kernel/kgdb.c
index 778c2f7..d6e8b4d 100644
--- ...
| Aug 16, 2:06 pm 2010 |
| Ævar Arnfjörð Bjarmason | BUG: nconfig doesn't preserve case in its menu display
When I do "make nconfig" and go to "General Setup" my "Local version -
append to kernel release" entry appears as:
(-avar-akbar) Local version - append to kernel release
When I use "make menuconfig" it's:
(-Avar-Akbar) Local version - append to kernel release
And my .config agrees:
$ ack -n1 CONFIG_LOCALVERSION .config
CONFIG_LOCALVERSION="-Avar-Akbar"
But when I edit the version string in both menuconfig and nconfig it
retains the correct casing.
I briefly ...
| Aug 16, 2:04 pm 2010 |
| Frederic Weisbecker | [RFC PATCH 3/6] perf: Generalize some arch callchain code
- Most archs use one callchain buffer per cpu, except x86 that needs
to deal with NMIs. Provide a default perf_callchain_buffer()
implementation that x86 overrides.
- Centralize all the kernel/user regs handling and invoke new arch
handlers from there: perf_callchain_user() / perf_callchain_kernel()
That avoid all the user_mode(), current->mm checks and so...
- Invert some parameters in perf_callchain_*() helpers: entry to the
left, regs to the right, following the traditional (src, ...
| Aug 16, 1:48 pm 2010 |
| Frederic Weisbecker | [RFC PATCH 4/6] perf: Factorize callchain context handling
Store the kernel and user contexts from the generic layer instead
of archs, this gathers some repetitive code.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: David Miller <davem@davemloft.net>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Will Deacon <will.deacon@arm.com>
Cc: ...
| Aug 16, 1:48 pm 2010 |
| Frederic Weisbecker | [RFC PATCH 5/6] perf: Fix race in callchains
Now that software events don't have interrupt disabled anymore in
the event path, callchains can nest on any context. So seperating
nmi and others contexts in two buffers has become racy.
Fix this by providing one buffer per nesting level. Given the size
of the callchain entries (2040 bytes * 4), we now need to allocate
them dynamically.
v2: Fixed put_callchain_entry call after recursion.
Fix the type of the recursion, it must be an array.
v3: Use a manual per cpu allocation (temporary ...
| Aug 16, 1:48 pm 2010 |
| Frederic Weisbecker | [RFC PATCH 2/6] perf: Generalize callchain_store()
callchain_store() is the same on every archs, inline it in
perf_event.h and rename it to perf_callchain_store() to avoid
any collision.
This removes repetitive code.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: David Miller <davem@davemloft.net>
Cc: Paul Mundt ...
| Aug 16, 1:48 pm 2010 |
| Frederic Weisbecker | [RFC PATCH 1/6] perf: Drop unappropriate tests on arch c ...
Drop the TASK_RUNNING test on user tasks for callchains as
this check doesn't seem to make any sense.
Also remove the tests for !current that is not supposed to
happen and current->pid as this should be handled at the
generic level, with exclude_idle attribute.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Stephane ...
| Aug 16, 1:48 pm 2010 |
| Frederic Weisbecker | [RFC PATCH 6/6] perf: Humanize the number of contexts
Instead of hardcoding the number of contexts for the recursions
barriers, define a cpp constant to make the code more
self-explanatory.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Stephane Eranian <eranian@google.com>
---
include/linux/perf_event.h | 14 ++++++++------
kernel/perf_event.c | 6 +++---
2 ...
| Aug 16, 1:48 pm 2010 |
| Frederic Weisbecker | [RFC PATCH 0/0 v3] callchain fixes and cleanups
Hi,
This set factorizes a lot of callchain code and fixes concurrent
callchain buffers accesses.
The previous set has revealed we can't decently use the per cpu
allocation api for memory that can be accessed from NMI.
Hence this temporary uses a manual per cpu allocation until that
gets fixed up.
Built-tested on PowerPc, Arm and SuperH (can someone point me to
a ready to use sparc cross compiler, like those that can be found
there for other archs: ...
| Aug 16, 1:48 pm 2010 |
| David Miller | Re: pull request: wireless-2.6 2010-08-16
From: "John W. Linville" <linville@tuxdriver.com>
Pulled, thanks a lot John.
--
| Aug 16, 1:56 pm 2010 |
| John W. Linville | pull request: wireless-2.6 2010-08-16
Dave,
This group of fixes is intended for 2.6.36. This includes a fix for a
warning backtrace related to pm_qos in ipw2100, a packet injection oops
for ath9k_htc, a connectivity regression for ath9k_htc related to HT
capabilities handling, a scanning regression in wl1251,
a firmware loading error in ath9k_htc, and a patch to disable L0s for
all ath5k cards (causes misc wierdness).
Please let me know if there are problems!
Thanks,
John
---
The following changes since commit ...
| Aug 16, 1:34 pm 2010 |
| Matthew Garrett | [PATCH] acpi: Update battery information on notification 0x81
A notification event 0x81 from an ACPI battery device requires us to
re-read the battery information structure. Do so, and if the battery's
reporting units have changed (as is the case on some Thinkpads) destroy
and recreate the battery in order to populate the fields correctly.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
drivers/acpi/battery.c | 22 +++++++++++++++++-----
1 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/acpi/battery.c ...
| Aug 16, 1:32 pm 2010 |
| Ondrej Zary | Re: [PATCH] [RFC] cyber2000fb: avoid palette corruption ...
Thanks, I'll put the cards to sleep and take them out later.
--
Ondrej Zary
--
| Aug 16, 3:02 pm 2010 |
| Ondrej Zary | [PATCH] [RFC] cyber2000fb: avoid palette corruption at h ...
When 1280x1024@75Hz mode is set, console palette is not set properly -
sometimes the background is white, sometimes yellow and text colors are also
messed up. This does not happen at 1280x1024@60Hz and below.
It seems that the HW needs some time before setting the palette - maybe the
PLL needs more time to lock at higher speeds. This patch fixes the problem but
without knowing what register to check for PLL lock(?), the delay might be
excessive.
Signed-off-by: Ondrej Zary ...
| Aug 16, 1:09 pm 2010 |
| Russell King - ARM Linux | Re: [PATCH] [RFC] cyber2000fb: avoid palette corruption ...
I'm not going to have much time to look at your patches, and I
definitely want to test them on the NetWinder to make sure we
don't regress the primary platform that this driver is supporting.
I should have more time to look at them in September.
--
| Aug 16, 2:06 pm 2010 |
| Stefan Richter | Re: [PATCH 2/2] firewire: sbp2: fix stall with "Unsolici ...
PS: This is not only about the stalls. It is also to prevent memory
corruption that may happen when the target writes to SCSI request
buffers after they were unmapped and freed, although this does not
appear likely to me.
--
Stefan Richter
-=====-==-=- =--- =----
http://arcgraph.de/sr/
--
| Aug 16, 2:21 pm 2010 |
| Stefan Richter | [PATCH 1/2] firewire: sbp2: fix memory leak in sbp2_canc ...
When an ORB was canceled (Command ORB i.e. SCSI request timed out, or
Management ORB timed out), or there was a send error in the initial
transaction, we missed to drop one of the ORB's references and thus
leaked memory.
Background:
In total, we hold 3 references to each Operation Request Block:
- 1 during sbp2_scsi_queuecommand() or sbp2_send_management_orb()
respectively,
- 1 for the duration of the write transaction to the ORB_Pointer or
Management_Agent register of the ...
| Aug 16, 12:58 pm 2010 |
| Stefan Richter | [PATCH 2/2] firewire: sbp2: fix stall with "Unsolicited ...
Fix I/O stalls with some 4-bay RAID enclosures which are based on
OXUF936QSE:
- Onnto dataTale RSM4QO, old firmware (not anymore with current
firmware),
- inXtron Hydra Super-S LCM, old as well as current firmware
when used in RAID-5 mode, perhaps also in other RAID modes.
The stalls happen during heavy or moderate disk traffic in periods that
are a multiple of 5 minutes, roughly twice per hour. They are caused
by the target responding too late to an ORB_Pointer register write:
The ...
| Aug 16, 1:13 pm 2010 |
| Oussama El Mfadli | Inotify doesn't detect splice system call?
I'm currently monitoring file open and modification with inotify. The
tool works perfectly went the file is modify by using a write system
call. But now, I'm using the splice system call to benefit from the
zero-copy mechanism.
The files are perfectly modified, but inotify system call doesn't
detect it. In the read_write.c file, the modification is signalled by
calling "fsnotify_modify(...)" in the vfs_write function. In the file
splice.c, the function is not called when a file is ...
| Aug 16, 12:44 pm 2010 |
| Oussama El Mfadli | Inotify doesn't detect splice system call?
I'm currently monitoring file open and modification with inotify. The
tool works perfectly went the file is modify by using a write system
call. But now, I'm using the splice system call to benefit from the
zero-copy mechanism.
The files are perfectly modified, but inotify system call doesn't
detect it. In the read_write.c file, the modification is signalled by
calling "fsnotify_modify(...)" in the vfs_write function. In the file
splice.c, the function is not called when a file is ...
| Aug 16, 12:40 pm 2010 |
| Micheal James | Can I Trust You?
Dear friend,
I do hope my email meet you well, I am Sgt. Scott Brain a U.S. Army in
Iraq . I write you this email to ask for your agreement to receive the sum
of 20 Million dollars on our behalf. My partner and I need a good partner
someone we can trust to actualize this venture. The money is from oil
proceeds and legal. And we are transferring it via the safe passage of a
diplomatic courier. If you agree,
get yourself a deal by replying to:scottbrain46@yahoo.com.hk Once you
receive ...
| Aug 16, 12:28 pm 2010 |
| Mark Brown | [PATCH 2.6.36] mfd: Ignore non-GPIO IRQs when setting wm ...
The driver was originally tested with an additional patch which
made this unneeded but that patch had issuges and got lost on the
way to mainline, causing problems when the errors are reported.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: stable@kernel.org
---
drivers/mfd/wm831x-irq.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/wm831x-irq.c b/drivers/mfd/wm831x-irq.c
index 7dabe4d..294183b 100644
--- ...
| Aug 16, 12:26 pm 2010 |
| Alok Kataria | [Patch] Skip cpu_calibrate for kernel running under hype ...
Hi,
This is a trivial change to fix the cpu_khz value returned when running
on a virtualized environment. We have seen instances when the cpu_khz
value is off by couple of MHz's when running on VMware's platform on AMD
hardware.
--
Since the TSC frequency read from hypervisor is accurate for the guest, and
since the hypervisor will always clock the vcpu at the TSC frequency, there is
no need to calibrate it again. To avoid any calibration errors through
calibrate_cpu this patch skips ...
| Aug 16, 12:25 pm 2010 |
| H. Peter Anvin | Re: [Patch] Skip cpu_calibrate for kernel running under ...
I'm somewhat reluctant to take this one, since it assumes all the
hypervisors act the same. This seems rather inherently wrong. In fact,
the whole statement is fishy as heck... instead of being dependent on
AMD and so on, this should either be a function pointer or a CPU
(mis)feature bit.
Can we do this saner?
-hpa
--
| Aug 16, 4:56 pm 2010 |
| Arundell M. | Your mailbox has exceeded the storage limit
Your mailbox has exceeded the storage limit which is 20GB as set by your administrator,you are currently running on 20.9GB,you may not be able to send or receive new mail until you re-validate your mailbox. To re-validate your mailbox please.Click Here http://mailupdateaccountonline.cogia.net/
--
| Aug 16, 11:18 am 2010 |
| Markus Trippelsdorf | Re: 2.6.36-rc1: WARNING when loading ehci-hcd module
The problem is already fixed:
http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=9c9e54a8df0be48...
I guess the patch will reach mainline in the next days.
--
»A man who doesn't know he is in prison can never escape.«
William S. Burroughs
--
| Aug 16, 12:02 pm 2010 |
| Nick Bowler | Re: 2.6.36-rc1: WARNING when loading ehci-hcd module
Wonderful. I cherry-picked this and things seem to be working now,
thanks.
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
--
| Aug 16, 12:27 pm 2010 |
| Nick Bowler | 2.6.36-rc1: WARNING when loading ehci-hcd module
After installing 2.6.36-rc1, I found a call trace in my dmesg after
boot. Traking it down a bit, it appears to happen when ehci-hcd is
loaded. The log after running 'modprobe ehci-hcd' appended to this
mail. This wasn't a problem in 2.6.35, but I don't have time to bisect
right now.
Now, I see the warning about how ehci should be loaded before uhci. I
also see that this is apparently not a new message. My configuration
has uhci built-in but ehci as a module. If this is not a ...
| Aug 16, 11:45 am 2010 |
| Stefan Richter | lockdep false positive? -- firewire-core transaction tim ...
Hi, I just saw the following (twice, with a reboot in between) with
kernel 2.6.35 plus firewire driver patched to their state in 2.6.36-rc1,
i.e. basically with a kernel according to commit e78483c5.
I suspect it might also happen without firewire patches, as 2.6.35
already contains the change where firewire-core's per-transaction timer
was introduced which shows up in the following log.
It happened while I was testing hotplugging of FireWire disks with
several ones on a bus together with ...
| Aug 16, 11:42 am 2010 |
| Johannes Berg | Re: lockdep false positive? -- firewire-core transaction ...
Err, sorry, no. I do remember that we had long discussions and initially
I had wanted to disable the context checking for these fake locks
completely. I think it was just the minimal thing needed not to make it
warn always. Also, we can't do the same thing in call_timer_fn() since
we need to hold it across fn()? Wouldn't it complain if we held that
lock then while enabling IRQs again? Not sure.
I don't fully understand the scenario above yet though. Why does it
think we could ever take the ...
| Aug 16, 3:09 pm 2010 |
| Peter Zijlstra | Re: lockdep false positive? -- firewire-core transaction ...
It says the locks nest like:
(&(shost->host_lock)->rlock){-.-...}
(&t->split_timeout_timer){+.-...}
...
...
So shost->host_lock->rlock is a lock used in hardirq context but
split_timeout_timer is a !irq-safe lock.
Which means that it now worries the following can happen:
softirq:
spin_lock(&t->split_timeout_timer);
IRQ:
spin_lock(&(shost->host_lock)->rlock);
spin_lock(&t->split_timeout_timer);
Now, the thing is that split_timeout_timer is a fake lock ...
| Aug 16, 2:42 pm 2010 |
| Johannes Berg | Re: lockdep false positive? -- firewire-core transaction ...
Actually, I think it's worried that you could have
CPU 0 CPU 1
softirq: softirq:
spin_lock(timer) spin_lock(rlock)
irq:
spin_lock(rlock)
spin_lock(timer) [still in softirq]
because it has previously seen the nesting that I put on CPU 1, and now
found that the timer "lock" is used with interrupts enabled.
At least that's a scenario I could understand?
I'm convinced it's a false ...
| Aug 16, 3:27 pm 2010 |
| H Hartley Sweeten | RE: [PATCH] fs.h: introduce functions to get/set file->p ...
Not a problem.
It's just a pain trying to figure out where the file 'private_data' is being
used.
$ git grep private_data | wc -w
37272
$ git grep private_data include | wc -w
1068
The following struct's all have a 'void *private_data' symbol in include/linux:
struct ac97_codec
struct c2port_device
struct file
struct gendisk
struct ata_host
struct ata_queued_cmd
struct ata_device
struct ata_port
struct ata_port_info
struct parport
struct rchan
struct rtc_task
struct ...
| Aug 16, 4:36 pm 2010 |
| Christoph Hellwig | Re: [PATCH] fs.h: introduce functions to get/set file->p ...
This just obsfucates the code, NAK.
--
| Aug 16, 4:17 pm 2010 |
| H Hartley Sweeten | [PATCH] fs.h: introduce functions to get/set file->priva ...
The symbol 'private_data' is commonly used and makes grep'ing for
specific uses difficult. Introduce the wrapper functions file_get_privdata
and file_set_privdata to help with the struct file uses.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Matthew Wilcox <matthew@wil.cx>
---
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 9a96b4d..b357a17 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -961,6 +961,16 @@ extern spinlock_t files_lock;
...
| Aug 16, 11:37 am 2010 |
| Salman Qazi | Re: [PATCH] Fixed a mismatch between the users of radix_ ...
You raise a valid concern. I haven't. What would you recommend as a
benchmark/metric to measure this?
(had to resend this. mail client had decided to switch to HTML mode,
which LKML didn't like)
--
| Aug 16, 2:05 pm 2010 |
| Peter Zijlstra | Re: [PATCH] Fixed a mismatch between the users of radix_ ...
(html damaged email alert)
One thing you could try is something like the below on a freshly booted
machine, once without and once with the patch:
cd /usr/src/linux-2.6
echo 1 > /proc/sys/vm/drop_caches
grep radix /proc/slabinfo
make bzImage
echo 1 > /proc/sys/vm/drop_caches
grep radix /proc/slabinfo
--
| Aug 16, 2:06 pm 2010 |
| Salman Qazi | [PATCH] Fixed a mismatch between the users of radix_tree ...
Done.
---
This matters for the lockless page cache, in particular find_get_pages implementation.
In the following case, we get can get a deadlock:
0. The radix tree contains two items, one has the index 0.
1. The reader (in this case find_get_pages) takes the rcu_read_lock.
2. The reader acquires slot(s) for item(s) including the index 0 item.
3. The non-zero index item is deleted, and as a consequence the other item
is moved to the root of the tree. The ...
| Aug 16, 11:30 am 2010 |
| Peter Zijlstra | Re: [PATCH] Fixed a mismatch between the users of radix_ ...
Ah, I through that was what it did. So you basically increase the memory
footprint for tiny files.. have you done any measurements on that?
--
| Aug 16, 12:33 pm 2010 |
| Julia Lawall | Re: [PATCH 15/16] drivers/platform/x86: Use available er ...
Looks ok to me. Thanks.
julia
--
| Aug 16, 1:43 pm 2010 |
| Jonathan Woithe | Re: [PATCH 15/16] drivers/platform/x86: Use available er ...
I've had a quick look at this and the idea behind it is sound. While it
does change the symantics as noted in the original post, the change is only
in an error path and to my eye the error code should be returned in that
case - as the code currently stands a 0 is returned even if ENOMEM has
occurred.
It seems to me that error and result have been (wrongly) used interchangedly
within these two functions (possibly be different authors). I agree that
one of them should be eliminated, and error ...
| Aug 16, 10:11 am 2010 |
| tip-bot for Arnaldo ... | [tip:perf/urgent] perf annotate tui: Fix exit and RIGHT ...
Commit-ID: e91846213241e3c46da8cbe992bceb1697de8d78
Gitweb: http://git.kernel.org/tip/e91846213241e3c46da8cbe992bceb1697de8d78
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Mon, 16 Aug 2010 10:43:54 -0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 16 Aug 2010 10:43:54 -0300
perf annotate tui: Fix exit and RIGHT keys handling
As part of ongoing effort to reduce the coupling with libnewt, browsers
are being changed to return the exit ...
| Aug 16, 10:32 am 2010 |
| Arnaldo Carvalho de Melo | [PATCH 1/1] perf annotate tui: Fix exit and RIGHT keys h ...
From: Arnaldo Carvalho de Melo <acme@redhat.com>
As part of ongoing effort to reduce the coupling with libnewt, browsers
are being changed to return the exit key.
The annotate browser is not returning it as expected by builtin-annotate
when annotating multiple symbols (when 'perf annotate' is called without
specifying a symbol name).
Fix it by returning the exit key and also adding the RIGHT key as a exit
key so that going to the next symbol in the TUI can work again.
Cc: Frederic ...
| Aug 16, 10:10 am 2010 |
| Ingo Molnar | Re: [GIT PULL 0/1] perf/urgent TUI annotate fix
Pulled, thanks Arnaldo!
Ingo
--
| Aug 16, 10:30 am 2010 |
| Arnaldo Carvalho de Melo | [GIT PULL 0/1] perf/urgent TUI annotate fix
From: Arnaldo Carvalho de Melo <infradead.org>
Hi Ingo,
I extracted a fix from the three patch perf/core series I sent,
will rework the other, non critical patches on a new perf/core branch.
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/urgent
Regards,
- Arnaldo
Arnaldo Carvalho de Melo (1):
perf annotate tui: Fix exit and RIGHT keys handling
tools/perf/util/ui/browsers/annotate.c | 3 ++-
1 files changed, 2 insertions(+), 1 ...
| Aug 16, 10:10 am 2010 |
| David Miller | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
From: Steven Rostedt <rostedt@goodmis.org>
He's only accessing the per-cpu counter locks of other cpus.
The per-cpu lock is only locally accessed by a cpu in software
interrupt context.
That is why his transformation is legal.
Lockdep simply hasn't been informed of this invariant and has
to assume the worst.
--
| Aug 16, 12:44 pm 2010 |
| Peter Zijlstra | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
Adding lockdep_off() is just plain wrong, if you cannot describe the
locking there's a fair chance its wrong anyway.
As it stands there's only a single lockdep_off(), and that lives in NTFS
it looks like it could be annotated differently, but then, who cares
about NTFS anyway ;-)
--
| Aug 16, 12:16 pm 2010 |
| Eric Dumazet | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
Interesting.
Care to elaborate ?
--
| Aug 16, 11:48 am 2010 |
| Peter Zijlstra | Aug 16, 11:36 am 2010 | |
| Peter Zijlstra | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
Something like the below will keep lockdep coverage, still going back to
RCU sounds like the best option.
---
include/linux/netfilter/x_tables.h | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h
index 24e5d01..a195feb 100644
--- a/include/linux/netfilter/x_tables.h
+++ b/include/linux/netfilter/x_tables.h
@@ -511,12 +511,21 @@ static inline void xt_info_rdunlock_bh(void)
*/
static ...
| Aug 16, 1:04 pm 2010 |
| Eric Dumazet | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
I see.
I described the fine locking after Steven comment, adding a long
Changelog.
http://patchwork.ozlabs.org/patch/61827/
If someone thinks this locking is buggy, please speak now ;)
--
| Aug 16, 12:35 pm 2010 |
| Steven Rostedt | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
On Mon, 2010-08-16 at 13:55 -0400, Steven Rostedt wrote:
Re-looking at the code, I think I figured it out. But it should really
I left out here:
for_each_possible_cpu(cpu) {
if (cpu == curcpu)
continue;
which means that we are grabbing the lock for other CPUs, and that a
Your patchwork patch has:
@@ -729,8 +729,10 @@ static void get_counters(const struct
xt_table_info *t,
local_bh_enable();
/* Processing counters from other cpus, we can let bottom half enabled,
...
| Aug 16, 11:16 am 2010 |
| Eric Dumazet | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
Please read history of why RCU failed in this context.
I believe I did most of RCU conversions in kernel, you dont need to
shout on me.
And its a bit late in 2.6.36 to even think about it.
I am happy that you volunteer for next RCU conversion, thanks Peter !
In the mean time, we just are going to disable BH again, I'll post a
patch.
--
| Aug 16, 1:17 pm 2010 |
| Steven Rostedt | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
I still do not see how this is a false positive. Per-cpu locks do not
solve the issue.
Please tell me what prevents an interrupt going off after we grab the
xt_info_wrlock(cpu) in get_counters().
IOW, what prevents this:
get_counters() {
xt_info_wrlock(cpu);
<interrupt> --> softirq
xt_info_rblock_bh();
/* which grabs the writer lock */
DEADLOCK!!
-- Steve
--
| Aug 16, 10:55 am 2010 |
| Steven Rostedt | [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
Hi, I hit this when booting 2.6.36-rc1:
=================================
[ INFO: inconsistent lock state ]
2.6.36-rc1 #2937
---------------------------------
inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
ifup-eth/3288 [HC0[0]:SC1[2]:HE1:SE0] takes:
(&(&lock->lock)->rlock){+.?...}, at: [<ffffffffa0166eef>] ip6t_do_table+0x8a/0x3f1 [ip6_tables]
{SOFTIRQ-ON-W} state was registered at:
[<ffffffff8107b08e>] __lock_acquire+0x756/0x93c
[<ffffffff8107b374>] lock_acquire+0x100/0x12d
...
| Aug 16, 10:07 am 2010 |
| Eric Dumazet | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
This is a false positive, and a patch was sent yesterday
http://patchwork.ozlabs.org/patch/61750/
Thanks
--
| Aug 16, 10:31 am 2010 |
| Peter Zijlstra | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
Urgh,.. I think it might be correct, but wtf! Wasn't this originally RCU
code, why not go back to using RCU now that we have
synchronize_rcu_expedited()?
As to the original issue, why not keep that bh stuff disabled for
CONFIG_PROVE_LOCKING instead, that will at least let you keep lock
coverage, adding lockdep_off() will hide any cycles that would involve
this lock (even though its currently a leaf lock, you never know what
creative things the future brings).
This fancy open coded lock ...
| Aug 16, 1:01 pm 2010 |
| Eric Dumazet | Re: [LOCKDEP BUG][2.6.36-rc1] xt_info_wrlock?
You mean duplicating this long comment in three files, or only once in
Changelog ?
My choice was to document the lockdep_off() use (very seldom used in
kernel) in the Changelog. Hopefully, people messing with this code know
about git ;)
I agree I didnt document how netfilter locks work in this Changelog.
And in original commit (24b36f019) I forgot to state that get_counters()
is guarded by a mutex, so that no more than one cpu runs in
get_counters().
What about following ?
[PATCH] ...
| Aug 16, 11:48 am 2010 |
| Vegard Nossum | 2.6.35+vfs-scale: INFO: suspicious rcu_dereference_check ...
Hi,
I was testing your VFS scaling tree*, but I get the following in my dmesg:
===================================================
[ INFO: suspicious rcu_dereference_check() usage. ]
---------------------------------------------------
kernel/exit.c:1387 invoked rcu_dereference_check() without protection!
other info that might help us debug this:
rcu_scheduler_active = 1, debug_locks = 1
2 locks held by bash/2878:
#0: (tasklist_lock){.+.+..}, at: [<ffffffff8103a275>] ...
| Aug 16, 9:57 am 2010 |
| Vegard Nossum | Re: 2.6.35+vfs-scale: INFO: suspicious rcu_dereference_c ...
Nick Piggin might update his git config because the commits in the
vfs-scale tree appear to bear an invalid e-mail address. Please reply
to this e-mail instead. Thanks.
Vegard
---------- Forwarded message ----------
From: Vegard Nossum <vegard.nossum@gmail.com>
Date: 16 August 2010 18:57
Subject: 2.6.35+vfs-scale: INFO: suspicious rcu_dereference_check()
usage (kernel/exit.c:1387)
To: Nick Piggin <npiggin@suse.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, David ...
| Aug 16, 10:01 am 2010 |
| Vegard Nossum | Re: 2.6.35+vfs-scale: INFO: suspicious rcu_dereference_c ...
On the third try it will hopefully work.
Vegard
---------- Forwarded message ----------
From: Vegard Nossum <vegard.nossum@gmail.com>
Date: 16 August 2010 19:01
Subject: Re: 2.6.35+vfs-scale: INFO: suspicious
rcu_dereference_check() usage (kernel/exit.c:1387)
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, David Howells
<dhowells@redhat.com>, "Paul E. McKenney"
<paulmck@linux.vnet.ibm.com>, LKML <linux-kernel@vger.kernel.org>
Nick Piggin might ...
| Aug 16, 10:03 am 2010 |
| Paul E. McKenney | Re: 2.6.35+vfs-scale: INFO: suspicious rcu_dereference_c ...
Thank you for locating this!
OK, so we aren't holding rcu_read_lock(), nor is this task dead, so
something needs some help.
We get from wait_consider_task() as follows: wait_consider_task()
calls security_task_wait(), which calls either selinux_task_wait() or
smack_task_wait(). Let's start with selinux_task_wait(), which calls
task_has_perm(), which does a couple of __task_cred(), but does so
under rcu_read_lock() protection, so presumably we didn't come in
that way.
Dave, am I missing ...
| Aug 16, 1:21 pm 2010 |
| David Howells | Re: 2.6.35+vfs-scale: INFO: suspicious rcu_dereference_c ...
The attached patch should fix this.
David
---
From: Daniel J Blueman <daniel.blueman@gmail.com>
Subject: [PATCH] Fix unprotected access to task credentials in waitid()
Using a program like the following:
#include <stdlib.h>
#include <unistd.h>
#include <sys/types.h>
#include <sys/wait.h>
int main() {
id_t id;
siginfo_t infop;
pid_t res;
id = fork();
if (id == 0) { sleep(1); exit(0); }
kill(id, SIGSTOP);
alarm(1);
waitid(P_PID, id, &infop, ...
| Aug 16, 1:01 pm 2010 |
| Tejun Heo | [PATCH 5/5] dm: implement REQ_FLUSH/FUA support
From: Tejun Heo <tj@kernle.org>
This patch converts dm to support REQ_FLUSH/FUA instead of now
deprecated REQ_HARDBARRIER.
For common parts,
* Barrier retry logic dropped from dm-io.
* Empty WRITE_BARRIERs are replaced with WRITE_FLUSHes.
* It's now guaranteed that all FLUSH bio's which are passed onto dm
targets are zero length. bio_empty_barrier() tests are replaced
with REQ_FLUSH tests.
* Dropped unlikely() around REQ_FLUSH tests. Flushes are not unlikely
enough to be ...
| Aug 16, 9:52 am 2010 |
| Tejun Heo | [RFC PATCHSET block#for-2.6.36-post] block: convert to R ...
Hello,
This patchset contains five patches to convert block drivers
implementing REQ_HARDBARRIER to support REQ_FLUSH/FUA.
0001-block-loop-implement-REQ_FLUSH-FUA-support.patch
0002-virtio_blk-implement-REQ_FLUSH-FUA-support.patch
0003-lguest-replace-VIRTIO_F_BARRIER-support-with-VIRTIO_.patch
0004-md-implment-REQ_FLUSH-FUA-support.patch
0005-dm-implement-REQ_FLUSH-FUA-support.patch
I'm fairly sure about conversions 0001-0003. 0004 should be okay
although multipath wasn't ...
| Aug 16, 9:51 am 2010 |
| Tejun Heo | [PATCH 3/5] lguest: replace VIRTIO_F_BARRIER support wit ...
From: Tejun Heo <tj@kernle.org>
VIRTIO_F_BARRIER is deprecated. Replace it with VIRTIO_F_FLUSH/FUA
support.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
---
Documentation/lguest/lguest.c | 36 ++++++++++++++++--------------------
1 files changed, 16 insertions(+), 20 deletions(-)
diff --git a/Documentation/lguest/lguest.c b/Documentation/lguest/lguest.c
index e9ce3c5..3be47d4 100644
--- a/Documentation/lguest/lguest.c
+++ ...
| Aug 16, 9:52 am 2010 |
| Mike Snitzer | Re: [PATCH 5/5] dm: implement REQ_FLUSH/FUA support
On Mon, Aug 16 2010 at 12:52pm -0400,
What tree does this patch apply to? I know it doesn't apply to
That logic wasn't just about retries (at least not in the latest
kernel). With commit 708e929513502fb0 the -EOPNOTSUPP checking also
serves to optimize the barrier+discard case (when discards aren't
Can you expand on that TODO a bit? What is the mechanism to propagate
FUA down to a DM device's members? I'm only aware of propagating member
devices' features up to the top-level DM device's ...
| Aug 16, 12:02 pm 2010 |
| Tejun Heo | [PATCH 2/5] virtio_blk: implement REQ_FLUSH/FUA support
From: Tejun Heo <tj@kernle.org>
Remove now unused REQ_HARDBARRIER support and implement REQ_FLUSH/FUA
support instead. A new feature flag VIRTIO_BLK_F_FUA is added to
indicate the support for FUA.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Michael S. Tsirkin <mst@redhat.com>
---
drivers/block/virtio_blk.c | 26 ++++++++++++--------------
include/linux/virtio_blk.h | 6 +++++-
2 files changed, 17 insertions(+), 15 deletions(-)
diff --git a/drivers/block/virtio_blk.c ...
| Aug 16, 9:52 am 2010 |
| Christoph Hellwig | Re: [PATCH 2/5] virtio_blk: implement REQ_FLUSH/FUA support
I'm not sure it's worth it. The pure REQ_FLUSH path works not and is
well tested with kvm/qemu. We can still easily add a FUA bit, and
even a pre-flush bit if the protocol roundtrips matter in real life
benchmarking.
--
| Aug 16, 11:33 am 2010 |
| Tejun Heo | [PATCH 1/5] block/loop: implement REQ_FLUSH/FUA support
From: Tejun Heo <tj@kernle.org>
Deprecate REQ_HARDBARRIER and implement REQ_FLUSH/FUA instead. Also,
instead of checking file->f_op->fsync() directly, look at the value of
vfs_fsync() and ignore -EINVAL return.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
drivers/block/loop.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 953d1e1..5d27bc6 100644
--- a/drivers/block/loop.c
+++ ...
| Aug 16, 9:51 am 2010 |
| Tejun Heo | [PATCH 4/5] md: implment REQ_FLUSH/FUA support
From: Tejun Heo <tj@kernle.org>
This patch converts md to support REQ_FLUSH/FUA instead of now
deprecated REQ_HARDBARRIER. In the core part (md.c), the following
changes are notable.
* Unlike REQ_HARDBARRIER, REQ_FLUSH/FUA don't interfere with
processing of other requests and thus there is no reason to mark the
queue congested while FLUSH/FUA is in progress.
* REQ_FLUSH/FUA failures are final and its users don't need retry
logic. Retry logic is removed.
* Preflush needs to be ...
| Aug 16, 9:52 am 2010 |
| "S.ÃaÄlar Onur" | 2.6.27.52-rc2
Hi,
I'm started to get following with 2.6.27.52-rc2 [1]. Just to note, this kernel is linux-vserver enabled but same patchset works fine with 2.6.27.51
BUG: sleeping function called from invalid context at mm/rmap.c:90
in_atomic():1, irqs_disabled():0
Pid: 1, comm: swapper Not tainted 2.6.27.51-22.planetlab #1
[<c0417c16>] __might_sleep+0x97/0x9e
[<c0468576>] anon_vma_prepare+0x1d/0xa8
[<c0464e32>] expand_stack+0x12/0x87
[<c04624c7>] handle_mm_fault+0x193/0x86c
[<c0476343>] ? ...
| Aug 16, 9:38 am 2010 |
| Dan Carpenter | Re: [PATCH 16/16] drivers/net/qlcnic: Use available erro ...
Could you redo this for the latest git? (Sorry, I recently made the
problem slightly worse by adding another "err = -ENOMEM;")...
regards,
dan carpenter
--
| Aug 16, 11:35 am 2010 |
| Julia Lawall | Re: [PATCH 16/16] drivers/net/qlcnic: Use available erro ...
From: Julia Lawall <julia@diku.dk>
The error code is stored in the variable err, but it is the variable ret
that is returned instead. So store the error code in ret. Err is then
useless.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia ...
| Aug 16, 1:23 pm 2010 |
| Julia Lawall | [PATCH 16/16] drivers/net/qlcnic: Use available error codes
From: Julia Lawall <julia@diku.dk>
The error code is stored in the variable err, but it is the variable ret
that is returned instead. So store the error code in ret. Err is then
useless.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia ...
| Aug 16, 9:29 am 2010 |
| Dan Carpenter | Re: [PATCH 15/16] drivers/platform/x86: Use available er ...
Yep. That should be changed to result as well.
regards,
dan carpenter
--
| Aug 16, 11:13 am 2010 |
| Julia Lawall | [PATCH 15/16] drivers/platform/x86: Use available error codes
From: Julia Lawall <julia@diku.dk>
An error code is stored in the variable error, but it is the variable
result that is returned instead. So store the error code in result.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall ...
| Aug 16, 9:28 am 2010 |
| Julia Lawall | [PATCH 14/16] drivers/w1/masters: Use available error codes
From: Julia Lawall <julia@diku.dk>
Error codes are stored in ret, but the return value is always 0. Return
ret instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the semantics of the ...
| Aug 16, 9:28 am 2010 |
| Julia Lawall | [PATCH 13/16] net/ax25: Use available error codes
From: Julia Lawall <julia@diku.dk>
Error codes are stored in err, but the return value is always 0. Return
err instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the semantics of the ...
| Aug 16, 9:28 am 2010 |
| Ralf Baechle | Re: [PATCH 13/16] net/ax25: Use available error codes
It restores the semantics to what they should be and used to be. This
probably happened during the introduction of proper refcounting and
locking into the AX.25 stack. Looks fine to me.
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
--
| Aug 16, 12:31 pm 2010 |
| Julia Lawall | [PATCH 12/16] drivers/platform/x86: Use available error codes
From: Julia Lawall <julia@diku.dk>
An error code is stored in ret, but the return value is always 0. Return
ret instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the semantics of the ...
| Aug 16, 9:28 am 2010 |
| Julia Lawall | [PATCH 11/16] drivers/media/video: Use available error codes
From: Julia Lawall <julia@diku.dk>
Error codes are stored in rc, but the return value is always 0. Return rc
instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the semantics of the ...
| Aug 16, 9:27 am 2010 |
| Julia Lawall | [PATCH 10/16] drivers/net/wireless/wl12xx: Use available ...
From: Julia Lawall <julia@diku.dk>
Error codes are stored in ret, but the return value is always 0. Return
ret instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the semantics and has not ...
| Aug 16, 9:27 am 2010 |
| Julia Lawall | [PATCH 9/16] fs/fscache: Remove unnecessary error code a ...
From: Julia Lawall <julia@diku.dk>
In each case, the value of ret is not used. If an error occurs, -ENOBUFS
is returned explicitly.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
fs/fscache/page.c | 2 ...
| Aug 16, 9:27 am 2010 |
| Julia Lawall | [PATCH 8/16] net/ax25: Use available error codes
From: Julia Lawall <julia@diku.dk>
Error codes are stored in err, but the return value is always 0. Return
err instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the semantics and has not ...
| Aug 16, 9:26 am 2010 |
| Julia Lawall | [PATCH 7/16] drivers/staging: Use available error codes
From: Julia Lawall <julia@diku.dk>
An error code is stored in a variable, but 0 is returned instead. Use the
variable instead of 0.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the semantics ...
| Aug 16, 9:26 am 2010 |
| Julia Lawall | [PATCH 6/16] drivers/media: Use available error codes
From: Julia Lawall <julia@diku.dk>
In each case, error codes are stored in rc, but the return value is always
0. Return rc instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
The changes change the ...
| Aug 16, 9:26 am 2010 |
| Julia Lawall | [PATCH 5/16] fs/btrfs: Use available error codes
From: Julia Lawall <julia@diku.dk>
Error codes are stored in ret, but the return value is always 0. Return
ret instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the semantics and has not ...
| Aug 16, 9:25 am 2010 |
| Julia Lawall | [PATCH 4/16] drivers/media/video/zoran: Use available er ...
From: Julia Lawall <julia@diku.dk>
Error codes are stored in res, but the return value is always 0. Return
res instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the semantics and has not ...
| Aug 16, 9:25 am 2010 |
| Julia Lawall | [PATCH 3/16] drivers/net/wireless/wl12xx: Use available ...
From: Julia Lawall <julia@diku.dk>
In each case, error codes are stored in ret, but the return value is always
0. Return ret instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the ...
| Aug 16, 9:25 am 2010 |
| Kalle Valo | Re: [PATCH 3/16] drivers/net/wireless/wl12xx: Use availa ...
Thanks, looks correct to me.
Acked-by: Kalle Valo <kvalo@adurom.com>
Kalle
--
| Aug 16, 10:47 am 2010 |
| Julia Lawall | [PATCH 1/16] drivers/firewire: Use available error codes
From: Julia Lawall <julia@diku.dk>
Error codes are stored in retval, but the return value is always 0. Return
retval in the error case instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes ...
| Aug 16, 9:24 am 2010 |
| Stefan Richter | Re: [PATCH 1/16] drivers/firewire: Use available error codes
Subject: firewire: net: fix unicast reception RCODE in failure paths
The incoming request hander fwnet_receive_packet() expects subsequent
datagram handling code to return non-zero on errors. However, almost
none of the failure paths did so. Fix them all.
(This error reporting is used to send and RCODE_CONFLICT_ERROR to the
sender node in such failure cases. Two modes of failure exist: Out of
memory, or firewire-net is unaware of any peer node to which a fragment
or an ARP packet belongs. ...
| Aug 16, 2:45 pm 2010 |
| Vladislav Bolkhovitin | Fwd: Re: [Scst-devel] linuxcon 2010...
Hello James,
Could you comment rumors that decision about future Linux SCSI target
subsystem is done as well as other related rumors:
1. What don't you like in the transition path for users from STGT to
SCST, which I proposed:
- The only people which would be affected by replacing of STGT by SCST
would be users of ibmvstgt. Other STGT users would not notice it at all.
Thus, we should update ibmvstgt for SCST. If ibmvstgt updated for SCST,
the update for its users would be just ...
| Aug 16, 9:20 am 2010 |
| Matthew Garrett | [GIT PULL] Minor platform driver updates
Hi Linus,
I know it's post RC1, but these are a couple of potential (if unlikely)
crash fixers, patches to enable rfkill control on a single model of Dell
and some Thinkpad updates that are effectively noops on current hardware
but improve support for machines that aren't out yet. Nothing
heartbreaking if it has to wait for .37.
The following changes since commit da5cabf80e2433131bf0ed8993abc0f7ea618c73:
Linux 2.6.36-rc1 (2010-08-15 17:41:37 -0700)
are available in the git ...
| Aug 16, 9:16 am 2010 |
| Huang Shijie | [PATCH] avoiding the same resource to be inserted
If the same resource is inserted to the resource tree
(maybe not on purpose), a dead loop will be created. In this situation,
The kernel does not report any warning or error :(
The command below will show a endless print.
#cat /proc/iomem
So, adding the check for the same resource is needed for the stability
and reliability of the kernel.
Signed-off-by: Huang Shijie <shijie8@gmail.com>
---
kernel/resource.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff ...
| Aug 16, 8:55 am 2010 |
| Jiri Kosina | [PATCH] KVM: x86: explain 'no-kvmclock' kernel parameter
no-kvmclock kernel parameter is missing its explanation in
Documentation/kernel-parameters.txt. Add it.
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
Documentation/kernel-parameters.txt | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 2c85c06..0f9e299 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1693,6 +1693,8 @@ and is between 256 ...
| Aug 16, 8:51 am 2010 |
| Wolfram Sang | [RFC] gpio/stmpe: add bitmask to block requests to unava ...
GPIOs on these controller are multi-functional. If you decided to use
some of them e.g. as input channels for the ADC, you surely don't want
those pins to be reassigned as simple GPIOs (which may be triggered even
from userspace via 'export'). Same for the touchscreen controller pins.
Since knowledge about the hardware is needed to decide which GPIOs to
reserve, let this bitmask be inside platform_data and provide some
defines to assist potential users.
Signed-off-by: Wolfram Sang ...
| Aug 16, 8:14 am 2010 |
| Mike Snitzer | Re: Switching block device elevators
On Mon, Aug 16 2010 at 10:52am -0400,
Maybe we should look to export elevator_switch() -- rather than
elevator_exit() triggers a call, via kobj, to elevator_release() which
doesn't have access to the request_queue to reset it.
Unfortunately, commit 1abec4fdbb imposes that the elevator_exit() caller
must take care to reset q->elevator to NULL -- like dasd_alloc_queue()
does.
Right, updating drivers/block/mg_disk.c and drivers/s390/block/dasd.c to
use elevator_switch would ...
| Aug 16, 8:44 am 2010 |
| Peter Oberparleiter | [RFC] Switching block device elevators
After commit 1abec4fdbb142e3ccb6ce99832fae42129134a96, "block: make
blk_init_free_list and elevator_init idempotent", we're seeing kernel
panics in our s390 tape block device driver. The panic is triggered
because our driver tries to replace the default elevator with a noop
elevator by calling elevator_exit() directly followed by elevator_init().
Since the commit, elevator_init() returns 0 if request_queue->elevator
is non-null, even though it does not install a new elevator. As a
result, ...
| Aug 16, 7:52 am 2010 |
| Subrata Modak | [ANNOUNCE] LCOV-1.9 Release
Dear All,
Peter has worked hard to release LCOV-1.9 for you. Please pick your
copies directly from:
https://sourceforge.net/projects/ltp/files/Coverage%
20Analysis/LCOV-1.9/lcov-1.9.tar.gz/download,
https://sourceforge.net/projects/ltp/files/Coverage%
20Analysis/LCOV-1.9/lcov-1.9-1.src.rpm/download,
https://sourceforge.net/projects/ltp/files/Coverage%
20Analysis/LCOV-1.9/lcov-1.9-1.noarch.rpm/download
or ...
| Aug 16, 7:02 am 2010 |
| Sage Weil | [GIT PULL] Ceph refactor, and rados block device (rbd) f ...
Hi Linus,
Please pull rbd (the rados block device) for 2.6.36 from
git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus
or, in in leiu of that, the just ceph refactor parts from
git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git libceph
This patchset does two things. First, it moves the non-file system
specific components of Ceph (the communications layer, authentication and
authorization, cluster membership, and object storage) into a ...
| Aug 16, 7:37 am 2010 |
| Borislav Petkov | [PATCH] hid, Kconfig: Complete Kconfig prompt names
Make special HID devices' Kconfig names unambiguous, obviating the need
to enter the help menu of each driver in order to know what hardware
device it actually supports.
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Stephane Chatty <chatty@enac.fr>
Cc: Don Prince <dhprince-devel@yahoo.co.uk>
Cc: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
drivers/hid/Kconfig | 60 ...
| Aug 16, 7:26 am 2010 |
| Stephen M. Cameron | [PATCH] cciss: fix botched tag masking for scsi tape commands
From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
In process_non_indexed_cmd() we were only masking off the
low two bits when comparing tags vs. busaddr, and not taking
into account the fact that in "performant" mode, three bits of
block fetch table indexes were stuffed into the tag, and
needed to be masked out for the comparison to work. This
resulted in spurious "bad tag" messages, and command
completions getting ignored for any scsi tape i/o and any i/o
coming through ...
| Aug 16, 7:32 am 2010 |
| Tejun Heo | [PATCH block#for-2.6.36-post] block: fix incorrect bio/r ...
Commit 74450be1 (block: unify flags for struct bio and struct request)
incorrectly converted @do_sync in md raid1 and raid10 make_requst()
functions.
@do_sync is now supposed to carry the actual flag bit and directly
OR'd into bio->bi_rw but is still a bool and thus carries either 0 or
1 instead of the actual flag bit. This makes REQ_SYNC ignored on
writes and flips the direction of READ_SYNCs to WRITEs.
Fix it by making @do_sync unsigned integers.
Signed-off-by: Tejun Heo ...
| Aug 16, 7:21 am 2010 |
| Lei Wen | RE: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset f ...
I may not have time from 10am to 11am. Except that, any time is ok for me. :-)
Best regards,
Lei
-----Original Message-----
From: Eric Miao [mailto:eric.y.miao@gmail.com]
Sent: 2010年8月16日 22:17
To: Lei Wen
Cc: David Woodhouse; Haojian Zhuang; Axel Lin; linux-kernel; linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8
Please separate the patches into several patch series.
(PS: I'll possibly talk with you on this tomorrow F2F)
| Aug 16, 7:20 am 2010 |
| Lei Wen | RE: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset f ...
Eric,
The first patch is a bit of fundamental. I'm afraid that modify it would bring changes to all latter patches in this series...
So I think I would repost another round of updating patch series and hope that would be merged. How do you think about this?
Thanks,
Lei
-----Original Message-----
From: Eric Miao [mailto:eric.y.miao@gmail.com]
Sent: 2010年8月16日 21:55
To: David Woodhouse
Cc: Haojian Zhuang; Lei Wen; Axel Lin; linux-kernel; linux-mtd@lists.infradead.org
Subject: Re: ...
| Aug 16, 7:03 am 2010 |
| Eric Miao | Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset f ...
Please separate the patches into several patch series.
(PS: I'll possibly talk with you on this tomorrow F2F)
--
| Aug 16, 7:16 am 2010 |
| Kusanagi Kouichi | [PATCH] cx23885: Use enum for board type definitions.
Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
---
drivers/media/video/cx23885/cx23885.h | 62 +++++++++++++++++----------------
1 files changed, 32 insertions(+), 30 deletions(-)
diff --git a/drivers/media/video/cx23885/cx23885.h b/drivers/media/video/cx23885/cx23885.h
index ed94b17..55dc282 100644
--- a/drivers/media/video/cx23885/cx23885.h
+++ b/drivers/media/video/cx23885/cx23885.h
@@ -54,36 +54,38 @@
#define BUFFER_TIMEOUT (HZ) /* 0.5 seconds */
-#define ...
| Aug 16, 5:30 am 2010 |
| Peter Zijlstra | Re: [PATCH] perf tools: Don't use brace expansion.
I think the reason is is that nobody who touched that file really knew
make all that well. Your version looks fine to me.
--
| Aug 16, 7:30 am 2010 |
| Kusanagi Kouichi | [PATCH] perf tools: Don't use brace expansion.
DASH doesn't support brace expansion.
Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
---
tools/perf/Makefile | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 41abb90..8fa851b 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -157,8 +157,10 @@ all::
#
# Define NO_DWARF if you do not want debug-info analysis feature at all.
-$(shell sh -c 'mkdir -p ...
| Aug 16, 5:41 am 2010 |
| Bernd Petrovitsch | Re: [PATCH] perf tools: Don't use brace expansion.
Ah, the reason is that they are not part of a rule but on the top-level
(and thus always executed).
Bernd
--
Bernd Petrovitsch Email : bernd@petrovitsch.priv.at
LUGA : http://www.luga.at
--
| Aug 16, 7:54 am 2010 |
| Peter Zijlstra | Re: [PATCH] perf tools: Don't use brace expansion.
I really hate these second rate shells, but I guess we could do this on
--
| Aug 16, 6:30 am 2010 |
| Arnaldo Carvalho de Melo | Re: [PATCH] perf tools: Don't use brace expansion.
So it worked by luck! /me runs :-P
More seriously, so there is a reason for that to be like that and you're
not aware of any other shorter or more convenient way of achieving that
goal, right?
- Arnaldo
--
| Aug 16, 8:29 am 2010 |
| Arnaldo Carvalho de Melo | Re: [PATCH] perf tools: Don't use brace expansion.
Ok, I guess this one is OK :-) Will merge.
--
| Aug 16, 8:24 am 2010 |
| Bernd Petrovitsch | Re: [PATCH] perf tools: Don't use brace expansion.
The other solution is to use standard-make features like in
mkdir -p $(foreach d,ui/browsers scripting-engines,$(OUTPUT)util/$(d)/) 2> /dev/null
Is there actually a specific reason for the
$(shell sh -c '...')
around?
It looks superflous.
Bernd
--
Bernd Petrovitsch Email : bernd@petrovitsch.priv.at
LUGA : http://www.luga.at
--
| Aug 16, 7:09 am 2010 |
| Bernd Petrovitsch | Re: [PATCH] perf tools: Don't use brace expansion.
One (obvious) alternative is to have rules triggering on the
Hmm, I'm not a "perf person". Which are the sufficient use-cases/tests
that one can do to play around with the Makefile?
`make -C tools/perf` is probably not enough.
Any hints anyone?
Bernd
--
Bernd Petrovitsch Email : bernd@petrovitsch.priv.at
LUGA : http://www.luga.at
--
| Aug 16, 8:43 am 2010 |
| Arnaldo Carvalho de Melo | Re: [PATCH] perf tools: Don't use brace expansion.
Right, not enough, what those mkdir calls were added for was exactly for
a different usecase:
make -C tools/perf -O=~/build/perf/
So that it doesn't pollutes the source code directories with the object
files, behaving in a similar fashion as when using O= in the kernel
proper.
- Arnaldo
--
| Aug 16, 8:50 am 2010 |
| Arnaldo Carvalho de Melo | Re: [PATCH] perf tools: Fix build error on read only source.
Em Mon, Aug 16, 2010 at 09:40:13PM +0900, Kusanagi Kouichi escreveu:
Please read:
f9af3a4c1f59753bdd5a49e3a34263005f96972e
8b2c551f9635bf1c5c2d38de300137998915478f
1703f2c321a8a531c393e137a82602e16c6061cb
To see why we can't use '-o /dev/null' like that.
- Arnaldo
--
| Aug 16, 8:24 am 2010 |
| Kusanagi Kouichi | [PATCH] perf tools: Fix build error on read only source.
Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
---
tools/perf/Makefile | 8 ++++----
tools/perf/feature-tests.mak | 6 ++----
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 41abb90..31b528f 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -935,15 +935,15 @@ $(OUTPUT)common-cmds.h: $(wildcard Documentation/perf-*.txt)
$(QUIET_GEN). util/generate-cmdlist.sh > $@+ && mv $@+ $@
$(patsubst ...
| Aug 16, 5:40 am 2010 |
| Ondrej Zary | Re: unable to mount a CD - iso9660 bug?
Still the same - no files. dmesg contains:
ISOFS: Invalid session number or type of track
ISOFS: Invalid session number
ISO 9660 Extensions: Microsoft Joliet Level 3
ISO 9660 Extensions: RRIP_1991A
--
Ondrej Zary
--
| Aug 16, 7:18 am 2010 |
| Ondrej Zary | unable to mount a CD - iso9660 bug?
Hello,
I have a CD that came with Samsung printer that Linux cannot mount but works
fine in Windows. The CD is physically OK - "dd" made ISO image without any
problems. This ISO image is unmountable too. When I force the filesystem to
iso9660, it mounts but no files are visible:
# mount samsung-bad.iso /mnt/tmp -o loop
mount: you must specify the filesystem type
# mount samsung-bad.iso /mnt/tmp -o loop -t iso9660
# ls -la /mnt/tmp
total 6
dr-xr-xr-x 2 root root 2048 Oct 30 2009 ...
| Aug 16, 5:38 am 2010 |
| Johannes Stezenbach | Re: unable to mount a CD - iso9660 bug?
Maybe it's a multi-session disk where the first session is
HFS with Apple software. Try mounting with -t iso9660 -o session=1.
HTH
Johannes
--
| Aug 16, 6:21 am 2010 |
| Ondrej Zary | Re: unable to mount a CD - iso9660 bug?
Here's the compressed ISO file if anyone wants to examine it:
http://www.rainbow-software.org/linux_files/samsung-bad.rar
--
Ondrej Zary
--
| Aug 16, 9:50 am 2010 |
| Lei Wen | RE: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset f ...
Hi Axel,
I suggest not merge your patch into mainline code. Since I have a large series of patch which reconstruct the nand flash definition, this fix would no longer be needed.
Thanks,
Lei
-----Original Message-----
From: Eric Miao [mailto:eric.y.miao@gmail.com]
Sent: 2010年8月16日 20:22
To: Axel Lin
Cc: linux-kernel; David Woodhouse; linux-mtd@lists.infradead.org; Lei Wen; Haojian Zhuang
Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8
Cc'ed Lei and ...
| Aug 16, 5:34 am 2010 |
| Eric Miao | Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset f ...
Lei, would you please point the URL of the patch series (possibly by
searching linux-mtd archive or some other mailing list archive) so that
Axel can have a reference and be involved?
- eric
--
| Aug 16, 5:44 am 2010 |
| Haojian Zhuang | RE: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset f ...
[Empty message]
| Aug 16, 5:49 am 2010 |
| David Woodhouse | Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset f ...
You had some criticism of patch #1 in the sequence, and some questions.
I didn't look much harder than that, iirc... although looking back now
it seems that the rest of your responses to the sequence were largely
positive.
Are you happy with the first patch, and if so shall I go ahead and
import the whole sequence with your Acked-By:?
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
--
| Aug 16, 6:05 am 2010 |
| Eric Miao | Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset f ...
I've actually reviewed some of the patches and gave my Ack. For those
patches, I think they can be merged early.
And overall, they look good. Yet 29 patch in a whole is still a bit too
much, would be good to see them logically be separated into several
--
| Aug 16, 5:55 am 2010 |
| Eric Miao | Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset f ...
So they need to be addressed. Lei, could you please come up with
I'm generally OK, but still think it would be good to have another around
of review before they can be merged.
--
| Aug 16, 6:55 am 2010 |
| ELECTRICAL COMPANY | (No subject)
You won $950,000.00USD and a brand New BMW X6 car. courtesy DELPHI
ELECTRICAL COMPANY. Send your NAMES, Tel:, Occupation: Age:, Sex:,
ADDRESS and Country to
Name: Dr.Craig Mordred
Email: agent.craigmordred@yahoo.com.hk
Tel: +447045703812
Signed,
Mr. Lee Young (Sec.)
--
| Aug 16, 3:12 am 2010 |
| Angel Tsankov | Kernel 2.6.30.10 hangs at boot time
Why does the kernel hang after printing "ACPI: Core revision 20090320"
(line 147 in this dmesg log: http://pastebin.com/ed0sbSiR) though I pass
"noacpi no-hlt" on the command line?
Regards,
Angel Tsankov
--
| Aug 16, 4:23 am 2010 |
| Richard Cochran | [PATCH v5 0/5] ptp: IEEE 1588 clock support
Now and again there has been talk on the netdev list of adding PTP
support into Linux. One part of the picture is already in place, the
SO_TIMESTAMPING API for hardware time stamping. This patch set offers
the missing second part needed for complete IEEE 1588 support.
* Why all the CCs?
1. IMHO, the patches should go through netdev.
2. A reviewer on netdev said, this should appear on lkml.
3. One driver is for PowerPC, and adds device tree stuff.
4. One driver is for the ARM Xscale ...
| Aug 16, 4:17 am 2010 |
| Richard Cochran | [PATCH 1/5] ptp: Added a brand new class driver for ptp ...
This patch adds an infrastructure for hardware clocks that implement
IEEE 1588, the Precision Time Protocol (PTP). A class driver offers a
registration method to particular hardware clock drivers. Each clock is
exposed to user space as a character device with ioctls that allow tuning
of the PTP clock.
Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
---
Documentation/ptp/ptp.txt | 95 +++++++
Documentation/ptp/testptp.c | 306 ++++++++++++++++++++++
...
| Aug 16, 4:17 am 2010 |
| Richard Cochran | [PATCH 3/5] ptp: Added a clock that uses the eTSEC found ...
The eTSEC includes a PTP clock with quite a few features. This patch adds
support for the basic clock adjustment functions, plus two external time
stamps and one alarm.
Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
---
Documentation/powerpc/dts-bindings/fsl/tsec.txt | 57 +++
arch/powerpc/boot/dts/mpc8313erdb.dts | 14 +
arch/powerpc/boot/dts/mpc8572ds.dts | 14 +
arch/powerpc/boot/dts/p2020ds.dts | 14 +
...
| Aug 16, 4:18 am 2010 |
| Richard Cochran | [PATCH 4/5] ptp: Added a clock driver for the IXP46x.
This patch adds a driver for the hardware time stamping unit found on the
IXP465. The basic clock operations and an external trigger are implemented.
Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
---
arch/arm/mach-ixp4xx/include/mach/ixp46x_ts.h | 78 ++++++
drivers/net/arm/ixp4xx_eth.c | 191 +++++++++++++
drivers/ptp/Kconfig | 13 +
drivers/ptp/Makefile | 1 +
drivers/ptp/ptp_ixp46x.c ...
| Aug 16, 4:18 am 2010 |
| Richard Cochran | [PATCH 5/5] ptp: Added a clock driver for the National S ...
This patch adds support for the PTP clock found on the DP83640.
The basic clock operations and one external time stamp have
been implemented.
Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
---
drivers/net/phy/Kconfig | 29 ++
drivers/net/phy/Makefile | 1 +
drivers/net/phy/dp83640.c | 904 +++++++++++++++++++++++++++++++++++++++++
drivers/net/phy/dp83640_reg.h | 261 ++++++++++++
4 files changed, 1195 insertions(+), 0 deletions(-)
create mode 100644 ...
| Aug 16, 4:19 am 2010 |
| Richard Cochran | Re: [PATCH 1/5] ptp: Added a brand new class driver for ...
You are not the first person to ask about this. See this link for
longer explanation of why I did not go that way:
http://marc.info/?l=linux-netdev&m=127669810232201&w=2
You *could* offer the PTP clock as a Linux clock source/event device,
and I agree that it would be nicer. However, the problem is, what do
you do with the PHY based clocks? Just one 16 bit read from a PHY
clock can take 40 usec, and you need four such read operations just to
get the current time value.
Also, I ...
| Aug 16, 12:00 pm 2010 |
| Richard Cochran | [PATCH 2/5] ptp: Added a clock that uses the Linux syste ...
This PTP clock simply uses the NTP time adjustment system calls. The
driver can be used in systems that lack a special hardware PTP clock.
Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
---
drivers/ptp/Kconfig | 12 ++++
drivers/ptp/Makefile | 1 +
drivers/ptp/ptp_linux.c | 136 +++++++++++++++++++++++++++++++++++++++++++++++
kernel/time/ntp.c | 2 +
4 files changed, 151 insertions(+), 0 deletions(-)
create mode 100644 drivers/ptp/ptp_linux.c
diff --git ...
| Aug 16, 4:18 am 2010 |
| Arnd Bergmann | Re: [PATCH 1/5] ptp: Added a brand new class driver for ...
Have you considered integrating the subsystem into the Posix clock/timer
framework?
I can't really tell from reading the source if this is possible or
not, but my feeling is that if it can be done, that would be a much
nicer interface. We already have clock_gettime/clock_settime/
timer_settime/... system calls, and while you'd need to add another
clockid and some syscalls, my feeling is that it will be more
.ioctl is gone, you have to use .unlocked_ioctl and make sure that
your ptp_ioctl ...
| Aug 16, 7:26 am 2010 |
| john stultz | Re: [PATCH 1/5] ptp: Added a brand new class driver for ...
And maybe just to clarify, as I saw your response to Arnd, I'm not
suggesting using PTP clocks as clocksources for the internal
timekeeping core. Instead I'm trying to understand why PTP clocks need
the equivalent of the existing posix clocks/timer interface. Why would
only having a read-time interface not suffice?
thanks
-john
--
| Aug 16, 12:38 pm 2010 |
| Arnd Bergmann | Re: [PATCH 1/5] ptp: Added a brand new class driver for ...
Why does it matter how long it takes to read the clock? I wasn't thinking
of replacing the system clock with this, just exposing the additional
clock as a new clockid_t value that can be accessed using the existing
Why did you not want to add syscalls? Adding ioctls instead of syscalls
does not make the interface better, just less visible.
Out of the ioctl commands you define, we already seem to have half or more:
PTP_CLOCK_APIVERS -> not needed
PTP_CLOCK_ADJFREQ -> new ...
| Aug 16, 12:59 pm 2010 |
| john stultz | Re: [PATCH 1/5] ptp: Added a brand new class driver for ...
On Mon, Aug 16, 2010 at 4:17 AM, Richard Cochran
Hey Richard!
Its very cool to see this work on lkml! I'm excited to see more
work done on ptp. We had a short private thread discussion earlier (I
got busy and never replied to your last message, my apologies!), but I
wanted to bring up the concerns I have here as well.
As I mentioned earlier, I'm not a huge fan of the char device
interface for abstracted PTP clocks.
If it was just the direct hardware access, similar to RTC, which ...
| Aug 16, 12:24 pm 2010 |
| Peter Zijlstra | Re: [PATCH] tracing, perf: add more power related events
Even though I'm blissfully ignorant on power stuffs, the proposed set of
trace thingies doesn't appear to even start covering x86..
CC'ed people who know more on the subject.
--
| Aug 16, 4:15 am 2010 |
| Jean Pihet | Aug 16, 4:25 am 2010 | |
| Jean Pihet | [PATCH] tracing, perf: add more power related events
Hi,
Here is a patch proposal for adding new trace events for power management.
Comments are welcome on this email address Jean Pihet
<jean.pihet@newoldbits.com>.
Jean
From b1d6df4fb4ebb72dca6660659d7030736c2a5cb2 Mon Sep 17 00:00:00 2001
From: Jean Pihet <jean.pihet@newoldbits.com>
Date: Mon, 16 Aug 2010 12:31:31 +0200
Subject: [PATCH] tracing, perf: add more power related events
This patch adds new generic events for dynamic power management
tracing:
- clock events class: used for ...
| Aug 16, 4:09 am 2010 |
| Linus Walleij | Re: [PATCH 1/3] dmaengine: add possibility for cyclic tr ...
That would be elegant...
The driver will have to detect that the sglist is chained like an
ouroboros to program the DMAC apropriately, is is easy to
detect if an sglist is chained onto itself?
Yours,
Linus Walleij
--
| Aug 16, 5:27 am 2010 |
| Sascha Hauer | [RFC] dmaengine: assorted patches and Freescale SDMA support
Hi all,
This is the first attempt to implement the Freescale i.MX SDMA engine
as part of the dmaengine API.
The first patch adds support for cyclic transfers usable for audio. There
is a similar approach implemented for the dw_dmac, this patch instead adds
the cyclic transfers to the dmaengine API.
Other patches not posted here are necessary to actually make use of the
SDMA engine. Please pull the following branch if you want to test these
patches. The branch includes mxcmmc support for ...
| Aug 16, 4:07 am 2010 |
| Sascha Hauer | [PATCH 3/3] dmaengine: Add Freescale i.MX SDMA support
This patch adds support for the Freescale i.MX SDMA engine.
The SDMA engine is a scatter/gather DMA engine which is implemented
as a seperate coprocessor. SDMA needs its own firmware which is
requested using the standard request_firmware mechanism. The firmware
has different entry points for each peripheral type, so drivers
have to pass the peripheral type to the DMA engine which in turn
picks the correct firmware entry point from a table contained in
the firmware image itself.
The original ...
| Aug 16, 4:07 am 2010 |
| Linus Walleij | Re: [PATCH 3/3] dmaengine: Add Freescale i.MX SDMA support
Quite fun, if the spec for the microcode is open this opens up
for dynamic firmware generation for specific DMA jobs does it
If you want to add memcpy() capability later you're gonna need
The kernel is not really happy about typedefs, can't this be a
Can this be negative and what is the range? I would
suspect something like u8 or u16 would surely be more
All these rely on a fixed sdma_base which makes the driver
a singleton. This is not so good if you imagine the situation with ...
| Aug 16, 5:21 am 2010 |
| Lothar Waßmann | Re: [PATCH 1/3] dmaengine: add possibility for cyclic tr ...
Hi,
Why not implement this feature using cyclic SG lists (created with
sg_chain())? This would give you endless DMA transfers without any
special DMA API extensions.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | ...
| Aug 16, 4:56 am 2010 |
| Sascha Hauer | Re: [PATCH 1/3] dmaengine: add possibility for cyclic tr ...
Been there, done that. In the end it just seemed like adding additional
overhead to create the sg list and using the sg for something for which
it is not really designed. Still you need extensions to the DMA API to
signal that you want to have a callback for every sg entry. Normally you
only need a callback on the end of the list.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ ...
| Aug 16, 5:32 am 2010 |
| Sascha Hauer | Re: [PATCH 3/3] dmaengine: Add Freescale i.MX SDMA support
Hi Linus,
Thank you for the review. Sorry for so many trival mistakes in the code,
but I'm staring at this code in many different variants for some time
now and I'm getting blind on it.
Unfortunately the specs are not open, so we are sticked to the binary
microcode from Freescale. I'm pretty sure though that the SDMA engine
Yes, I left this as an exercise for those who want to have this feature ;)
I think it's better to have tested code in the Kernel than having a
complicated list ...
| Aug 16, 7:15 am 2010 |
| Linus Walleij | Re: [PATCH 1/3] dmaengine: add possibility for cyclic tr ...
Looks good to me.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Yours,
Linus Walleij
--
| Aug 16, 5:22 am 2010 |
| Sascha Hauer | [PATCH 1/3] dmaengine: add possibility for cyclic transfers
Cyclic transfers are useful for audio where a single buffer divided
in periods has to be transfered endlessly until stopped. After being
prepared the transfer is started using the dma_async_descriptor->tx_submit
function. dma_async_descriptor->callback is called after each period.
The transfer is stopped using the DMA_TERMINATE_ALL callback.
While being used for cyclic transfers the channel cannot be used
for other transfer types.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Cc: ...
| Aug 16, 4:07 am 2010 |
| Sascha Hauer | [PATCH 2/3] dmaengine: add wrapper functions for dmaengine
Currently dmaengine users have to explicitely dereference function
pointers in struct dma_device. For the convenience of drivers and
to be more flexible when changing the dmaengine later add static
inline wrapper functions for the dma commands.
This patch is not complete yet. If there's consensus on this patch
I'll provide an updated patch with the missing functions.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
include/linux/dmaengine.h | 41 ...
| Aug 16, 4:07 am 2010 |
| Cyrill Gorcunov | [RFC -tip]
Hi,
please review the approach, I can't test it due to lack
of hw (btw Ming, if you have some spare minutes -- mind to
pass some event as RAW and see how it goes?).
It just unifdef perf_event_p4.h and export it to user space.
Any complains are welcome. I've considered a separate header
file without #ifdef which would consists of definitions user
space may need but in result it become more messy then a few
#ifdefs in shared header.
-- Cyrill
---
perf, x86: Export RAW events ...
| Aug 16, 4:02 am 2010 |
| Jan Beulich | Re: [PATCH] fixes for using make 3.82
Yes, it does (I had observed the same, which prompted the fix).
Jan
--
| Aug 16, 4:53 am 2010 |
| Jan Beulich | [PATCH] fixes for using make 3.82
It doesn't like pattern and explicit rules to be on the same line,
and it seems to be more picky when matching file (or really directory)
names with different numbers of trailing slashes.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
firmware/Makefile | 2 +-
scripts/mkmakefile | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
--- linux-2.6.36-rc1/firmware/Makefile
+++ 2.6.36-rc1-make-3.82-fixes/firmware/Makefile
@@ -142,7 +142,7 @@ fw-shipped-$(CONFIG_YAM) += ...
| Aug 16, 3:58 am 2010 |
| Sam Ravnborg | Re: [PATCH] fixes for using make 3.82
Added: Michael Marek (kbuild maintainer) + linux-kbuild.
I assume this fixes firmware build reported by Andrew Benton (cc:ed).
Sam
--
| Aug 16, 4:41 am 2010 |
| Andrew Benton | Re: [PATCH] fixes for using make 3.82
I can confirm that the patch fixes the problem, I can compile the kernel
with make-3.82.
Many thanks.
Andy
--
| Aug 16, 6:17 am 2010 |
| Dan Carpenter | [patch] tlb_uv: handle large snprintf() returns
snprintf() returns the number of bytes that *would* have been copied if
the buffer was large enough, so it can be larger than the size of the
buffer. In this case it's ok, but let's put a cap on it anyway so it's
easier to audit.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/arch/x86/kernel/tlb_uv.c b/arch/x86/kernel/tlb_uv.c
index 312ef02..5e88b3a 100644
--- a/arch/x86/kernel/tlb_uv.c
+++ b/arch/x86/kernel/tlb_uv.c
@@ -1012,6 +1012,9 @@ static ssize_t tunables_read(struct ...
| Aug 16, 3:55 am 2010 |
| zhou peng | Help: compile the Linux kernel (KVM kernel )on Ubuntu 10 ...
Hi all,
While compiling the kvm linux kernel on my ubuntu 10.04(Linux
xxxx-laptop 2.6.32-24-generic #39-Ubuntu SMP Wed Jul 28 06:07:29 UTC
2010 i686 GNU/Linux), the err below appear, How to figure out please?
=err msg=
In file included from drivers/platform/x86/intel_
scu_ipc.c:26:
kvm/arch/x86/include/asm/mrst.h:14: warning: ‘struct sfi_table_header’
declared inside parameter list
kvm/arch/x86/include/asm/mrst.h:14: warning: its scope is only this
definition or declaration, which is ...
| Aug 16, 3:42 am 2010 |
| Jarek Poplawski | Re: [GIT] Networking
Btw, could you remind us how get_counters() are serialized (I guess
you can't have them on 2 cpus at the same time)?
Thanks,
Jarek P.
--
| Aug 16, 2:53 am 2010 |
| Eric Dumazet | Re: [GIT] Networking
get_counters() is serialized by the xt_find_table_lock() done from
get_entries(). This use a mutex to guard against changes.
You are right that if we ever allow two concurrent "iptables -nvL"
operations in the future (using a read lock on a rwlock instead of a
mutex), then we must disable BH even for summing data from the other
cpus.
Thanks
--
| Aug 16, 3:42 am 2010 |
| Jarek Poplawski | Re: [GIT] Networking
OK, thanks for the explanation,
Jarek P.
--
| Aug 16, 3:48 am 2010 |
| Dan Williams | [GIT PULL] dmaengine: one more driver for 2.6.36
Hi Linus, please consider pulling from:
git://git.kernel.org/pub/scm/linux/kernel/git/djbw/async_tx.git next
...to receive one more driver that was originally posted well in advance
of this window. I had some review comments that were duly resolved, but
I did not handle this updated version in a timely manner. I would
prefer that this driver not wait for 2.6.37 as it was prepared in time
for this window. Two other fixlets are also included.
None of this has seen a -next release, but ...
| Aug 16, 2:14 am 2010 |
| Axel Lin | [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for s ...
This patch adds timing settings for samsung2GbX8 and
fixes the cmdset settings. samsung2GbX8 is large page.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mtd/nand/pxa3xx_nand.c | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index 4d89f37..47c0442 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -227,9 +227,21 @@ static struct ...
| Aug 16, 1:50 am 2010 |
| Eric Miao | Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset f ...
Cc'ed Lei and Haojian.
--
| Aug 16, 5:22 am 2010 |
| Ian Newton | suspend/resume no longer working on kernel 2.6.34 (34 or ...
[1.] One line summary of the problem:
suspend/resume no longer working on kernel 2.6.33 (34 or 35) Via
VX800/VX820 chipset
[2.] Full description of the problem/report:Upgrading from 2.6.31-13
kernel (Mandriva 2010.0) to 2.6.33-5 kernel (Mandriva 2010.1) results
in the final stage of shutdown on suspend (ram or disk) hanging without
putting the laptop (Samsung NC20) to sleep. The network and power leds
and processor remain on though the screen has powered down. Reverting to
2.6.31-13 resolves ...
| Aug 16, 1:34 am 2010 |
| Michal Simek | [PATCH] microblaze: Fixup function of/address cleaning
Commit 22ae782f86b726f9cea752c0f269ff6dcdf2f6e1
anccidentaly removed linux/of_address.h header.
Signed-off-by: Michal Simek <monstr@monstr.eu>
---
arch/microblaze/include/asm/prom.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/microblaze/include/asm/prom.h b/arch/microblaze/include/asm/prom.h
index 5012b22..66894b5 100644
--- a/arch/microblaze/include/asm/prom.h
+++ b/arch/microblaze/include/asm/prom.h
@@ -22,7 +22,6 @@
#include <linux/types.h>
...
| Aug 16, 1:31 am 2010 |
| Grant Likely | Re: [PATCH] microblaze: Fixup function of/address cleaning
As mentioned in my reply to your other email, I'm trying to get
includes of linux/of*.h out of prom.h and into the C files that
actually need them. If you send me the failing .config, then I'll
happily take care of fixing it up. :-)
Cheers,
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
| Aug 16, 1:48 pm 2010 |
| Michal Simek | [PATCH] microblaze: Fix of/address: Merge all of the bus ...
Commit dbbdee94734bf6f1db7af42008a53655e77cab8f removed
of_irq_pci_swizzle but didn't use pci_swizzle_interrupt_pin
instead.
Signed-off-by: Michal Simek <monstr@monstr.eu>
---
arch/microblaze/kernel/prom_parse.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/microblaze/kernel/prom_parse.c b/arch/microblaze/kernel/prom_parse.c
index d33ba17..99d9b61 100644
--- a/arch/microblaze/kernel/prom_parse.c
+++ b/arch/microblaze/kernel/prom_parse.c
@@ -73,7 +73,7 @@ ...
| Aug 16, 1:31 am 2010 |
| Michal Simek | [PATCH] microblaze: Fix of: eliminate of_device->node an ...
Commit 58f9b0b02414062eaff46716bc04b47d7e79add5 should
contain this fix too.
Signed-off-by: Michal Simek <monstr@monstr.eu>
---
arch/microblaze/pci/pci-common.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
index 62f403b..466d410 100644
--- a/arch/microblaze/pci/pci-common.c
+++ b/arch/microblaze/pci/pci-common.c
@@ -1062,7 +1062,7 @@ void __devinit pcibios_setup_bus_devices(struct pci_bus ...
| Aug 16, 1:31 am 2010 |
| Grant Likely | Re: [PATCH] microblaze: Fix of/address: Merge all of the ...
Hi Michal,
Looks good, I'll pick it up. Same of the of_node patch.
Note: when writing commit messages, be friendly to readers who don't
immediately have access to a git tree. It is good to quote the sha1
id, but you should also quote the patch title like so:
Commit "of/address: Merge all of the bus translation code" (sha1 id:
dbbdee94734bf6f1db7af42008a53655e77cab8f) removed of_irq_pci_swizzle
but didn't use pci_swizzle_interrupt_pin instead.
No need to respin this patch, I'll fix it ...
| Aug 16, 1:33 pm 2010 |
| Michal Marek | Re: [PATCH] Kconfig: deleted a word which apeared twice
Your patch is fine, let's just add trivial@kernel.org to Cc.
--
| Aug 16, 10:10 am 2010 |
| Stephan Sperber | [PATCH] Kconfig: deleted a word which apeared twice
Hi all,
please be not too hard on me with this patch. it is my first one.
at least give me input what needs to be better.
thanks in advance
Stephan
From: Stephan Sperber <sperberstephan@googlemail.com>
Date: Wed, 14 Jul 2010 11:23:08 +0200
Subject: [PATCH] Kconfig: deleted a word which apeared twice
Deleted a word which apeared twice.
Signed-off-by: Stephan Sperber <sperberstephan@googlemail.com>
---
init/Kconfig | 2 +-
usr/Kconfig | 2 +-
2 files changed, 2 insertions(+), ...
| Aug 16, 1:22 am 2010 |
| Andreas Sundstrom | kernel Oops with 2.6.35.2 and glxinfo (or other GL programs)
On my laptop X hangs as soon as something uses OpenGL.
Running for example glxinfo or glxgears causes it to freeze.
I have not had any issues like this before, and 2.6.34 works ok but not 2.6.35.2
I have pasted the Oops here: http://codepad.org/t1aVjAzy
I will include it with this email too, but to avoid problems with the formatting
I have provided the link above.
This is on a HP Compaq 6910p laptop running Debian Lenny
I used git bisect for the first time and it took a while but finally ...
| Aug 16, 12:57 am 2010 |
| Michael Cree | [PATCH] alpha: Fix compile error due to typo in call of ...
Typo, i.e., missing comma in argument list of call of do_osf_statfs(),
was introduced by commit ebabe9a9001af0af56c0c2780ca1576246e7a74b.
Signed-off-by: Michael Cree <mcree@orcon.net.nz>
---
arch/alpha/kernel/osf_sys.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
index fb58150..5d1e6d6 100644
--- a/arch/alpha/kernel/osf_sys.c
+++ b/arch/alpha/kernel/osf_sys.c
@@ -252,7 +252,7 @@ ...
| Aug 16, 1:18 am 2010 |
| Matt Turner | Re: [PATCH] alpha: Fix compile error due to typo in call ...
Thanks Michael. Will apply.
--
| Aug 16, 6:06 am 2010 |
| Peter Zijlstra | Re: perf, how to support multiple x86 hw pmus?
Yes, see my patch series http://lkml.org/lkml/2010/7/9/96 reworking the
pmu interface.
After that and some patches adding per pmu contexts adding multiple
hardware pmus should be simple.
uncore should not share any code with the regular pmu, since they're
mostly unrelated.
--
| Aug 16, 1:25 am 2010 |
| Peter Zijlstra | Re: perf, how to support multiple x86 hw pmus?
Yes, although 3 weeks of holidays and a week of LinuxCon didn't help to
finish that work ;-)
Maybe, I'd have to look at the uncore stuff again, I can't remember if
it has much in the way of event scheduling constraints and if the
counter programming is close enough to the regular pmu to make it worth
sharing code over.
--
| Aug 16, 2:12 am 2010 |
| Lin Ming | Re: perf, how to support multiple x86 hw pmus?
I didn't see the per pmu contexts patches, are you still working on
But should they share code like collect_events, schedule_events,
x86_perf_event_set_period(with some modification) etc...?
--
| Aug 16, 1:39 am 2010 |
| Lin Ming | Re: perf, how to support multiple x86 hw pmus?
I looked at the Nehalem uncore stuff and it does not have event
constraints. Each event can be monitored with any uncore counter.
The counter programming is close to regular pmu. It has
PERFEVTSELx/GLOBAL_STATUS/GLOBAL_OVF_CTRL/FIXED_CTR_CTRL like regular
pmu.
--
| Aug 16, 2:33 am 2010 |
| Lin Ming | perf, how to support multiple x86 hw pmus?
Hi, all
Here multiple x86 hw pmus means, for example, Intel "core" and "uncore"
pmu. "core" pmu is to collect per cpu data, cpu-cycles, branch-misses,
etc. "uncore" pmu is to collect per package data, L3 cache, Intel QPI,
integrated memory controller, etc.
I am going to add Intel uncore pmu support to perf. To reduce code
duplicate, "uncore" pmu should reuse most of the "core" pmu code. But
currently, the x86 core pmu code(arch/x86/kernel/cpu/perf_event.c) only
supports one pmu, with a ...
| Aug 16, 1:09 am 2010 |
| Jon Masters | [PATCH] modules: don't call depmod when overriding exter ...
Recent kernels include an additional call to depmod during the installation
of external kernel modules as a convenience, in order to ensure that those
modules are picked up by the module loading tools/initramfs scripts, etc.
Although this call is potentially of some value, it should not be made
when explicitly setting INSTALL_MOD_PATH to a different location. This
avoids creating extraneous modules.* files that will never be used.
Signed-off-by: Jon Masters <jcm@jonmasters.org>
---
Makefile | ...
| Aug 16, 1:03 am 2010 |
| Rusty Russell | Re: [PATCH] modules: don't call depmod when overriding e ...
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks,
Rusty.
--
| Aug 16, 3:43 am 2010 |
| Jon Masters | Re: [PATCH] modules: don't call depmod when overriding e ...
Hey, thanks for forwarding. I figured I would do that, but I see you
already did. And yea, next time I'll ping the Kbuild folks directly.
Jon.
--
| Aug 16, 3:26 pm 2010 |
| David Woodhouse | Re: [PATCH] [MTD] [NAND] pxa3xx: fix ns2cycle equation
Looks sane to me; thanks. Wants to go to stable@ too, yes?
Can I have an Acked-By: from Matt and/or Eric?
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
--
| Aug 16, 3:32 am 2010 |
| Axel Lin | [PATCH] [MTD] [NAND] pxa3xx: fix ns2cycle equation
Test on a PXA310 platform with Samsung K9F2G08X0B NAND flash,
with tCH=5 and clk is 156MHz, ns2cycle(5, 156000000) returns -1.
ns2cycle returns negtive value will break NDTR0_tXX macros.
After checking the commit log, I found the problem is introduced by
commit 5b0d4d7c8a67c5ba3d35e6ceb0c5530cc6846db7
"[MTD] [NAND] pxa3xx: convert from ns to clock ticks more accurately"
To get num of clock cycles, we use below equation:
num of clock cycles = time (ns) / one clock cycle (ns) + 1
We need to ...
| Aug 16, 1:09 am 2010 |
| Eric Miao | Re: [PATCH] [MTD] [NAND] pxa3xx: fix ns2cycle equation
Acked-by: Eric Miao <eric.y.miao@gmail.com>
--
| Aug 16, 5:14 am 2010 |
| ydlydlydl | (No subject)
Hello
Perhaps, Alan Stern could answer this question.
I just got some glasses with camera and here is my problem.
When I plug this device with Windows all is fine: I can see the videos (the device acts as a storage device).
When I plug it with Linux, I get a "USB disconnect, address n".
I have already read Alan's answer "http://www.spinics.net/lists/linux-usb/msg29298.html" but without any success ("options usb-storage delay_use=different values").
Any suggestion?
Thanks in ...
| Aug 16, 12:39 am 2010 |
| Tao Ma | Re: [PATCH] CMWQ: Set workqueue name before we process o ...
Hi Tejun,
Thanks for the quick response.
OK, let me find other ways ocfs2 can use to trace the real callers of
some functions in runtime.
Regards,
Tao
--
| Aug 16, 1:03 am 2010 |
| Tejun Heo | Re: [PATCH] CMWQ: Set workqueue name before we process o ...
I thought about the same thing but this doesn't provide any more
information than stack traces for debugging and for run time tracking
implementing tracing API (scheduled to be added in this devel cycle)
is the right approach. Also, I don't think it's wise to constantly
change program name. It will confuse more than help. So, unless
there are other reasons for doing this, I don't think I'm gonna take
this one.
Thanks.
--
tejun
--
| Aug 16, 12:44 am 2010 |
| Tao Ma | [PATCH] CMWQ: Set workqueue name before we process one work.
Now in CMWQ, workqueue threads are named as 'kworker/*'. So it is
a little boring to see in the 'top'(below) and actually it isn't
meaningful for the users.
12606 root 20 0 0 0 0 S 2 0.0 0:03.22 kworker/u:0
12607 root 20 0 0 0 0 S 1 0.0 0:03.69 kworker/u:4
So this patch just try to set the proper workqueue name if it does
exist. Yes, workqueue now is a thread pool and the data may be not
accurate but I think it is better(below) than the 'kworker*' ...
| Aug 16, 12:39 am 2010 |
| Tejun Heo | Re: [PATCH] CMWQ: Set workqueue name before we process o ...
Hello,
Oh, it's just on top of cmwq todo list. fscache needs it too so it
will definitely happen sooner than later. I'll try to remember to cc
eyou when I post patches.
Thanks.
--
tejun
--
| Aug 16, 1:03 am 2010 |
| Nick Bowler | Re: nfs regression 2.6.35+
Apparently this breaks NFS file locks as well:
fetchmail: starting fetchmail 6.3.17 daemon
/home/nbowler/.fetchmail.pid: Bad file descriptor
and this fixes all the problems for me.
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
--
| Aug 16, 11:17 am 2010 |
| Bill Davidsen | Re: nfs regression 2.6.35+
--
Bill Davidsen <davidsen@tmr.com>
"We have more to fear from the bungling of the incompetent than from
the machinations of the wicked." - from Slashdot
--
| Aug 16, 9:35 am 2010 |
| Takashi Iwai | Re: nfs regression 2.6.35+
[Added linux-nfs to Cc]
At Mon, 16 Aug 2010 15:06:26 +0800,
This hits me, too. Reverting it cures the problem.
(BTW, the correct commit id of the affecting patch is
af7fa16506bf9b6323e862a61e14c20555152bb3
"NFS: Fix up the fsync code")
Reproduced on 2.6.36-rc1.
Looking at strace output,
open("afo", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 4
write(4, "#!/bin\n", 7) = 7
fsync(4) = 1
stat("afo", {st_mode=S_IFREG|0644, st_size=7, ...}) ...
| Aug 16, 3:09 am 2010 |
| Takashi Iwai | Re: nfs regression 2.6.35+
How about a band-aid fix below?
Takashi
From c75eab5ac47f5ce27a0d450423f8c46824f832f0 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 16 Aug 2010 12:25:19 +0200
Subject: [PATCH] NFS: fix fsync return code
With the commit af7fa16506bf9b6323e862a61e14c20555152bb3
NFS: Fix up the fsync code
fsync returns a postive number for success incorrectly because now it
calls nfs_commit_inode() which returns the number of pages.
This patch makes fsync simply ignore a ...
| Aug 16, 3:40 am 2010 |
| Shaohua Li | nfs regression 2.6.35+
NFS client runs latest git. At client side, use vim to edit a file located at
NFS server. If I save the file, vim always reports 'E667: Fsync failed'. If I
revert f7fa16506bf9b6323e862a61e14c20555152bb3, vim works. No kernel errors
reported.
Thanks,
Shaohua
--
| Aug 16, 12:06 am 2010 |
| Trond Myklebust | Re: nfs regression 2.6.35+
There is already a fix for this in the linux-next tree and in the
'bugfixes' branch of
git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git: see commit
0702099bd86c33c2dcdbd3963433a61f3f503901 (NFS: fix the return value of
nfs_file_fsync()).
I haven't pushed it to Linus yet due to excessive travel this past week.
Will do so soon.
Cheers
Trond
----------------------------------------------------------------------------------------
commit ...
| Aug 16, 3:47 pm 2010 |
| Mr. Teo En Ming (Zha ... | Re: [Xen-devel] Xen patches merged to upstream Linux 2.6 ...
Good news! Good news! Xen pv-ops dom0 is finally just starting to get
merged into upstream Linux...
Starting with Linux 2.6.36....
Yours sincerely,
Mr. Teo En Ming (Zhang Enming)
Citizenship: Singapore Citizen/Singaporean
Facebook account: Teo En Ming (Zhang Enming)
Facebook link:http://www.facebook.com/profile.php?id=100000750083982
Facebook photos:
http://www.facebook.com/profile.php?id=100000750083982#!/profile.php?id=100000750083982&v=photos ...
| Aug 15, 10:29 pm 2010 |
| Randy Dunlap | Re: linux-next: Tree for August 16 (ceph)
linux-next-20100816/net/ceph/debugfs.c:255: error: conflicting types for 'ceph_debugfs_client_init'
linux-next-20100816/include/linux/ceph/debugfs.h:29: note: previous declaration of 'ceph_debugfs_client_init' was here
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
| Aug 16, 10:08 am 2010 |
| Stephen Rothwell | linux-next: Tree for August 16
Hi all,
As the merge window has closed, let the flood commence. :-)
Changes since 20100813:
New tree; florian-viafb
My fixes tree contains:
spi: update for of_device to platform_device replacement
The sh tree gained a conflict against Linus' tree.
The ocfs2 tree lost its conflict.
The v4l-dvb tree lost its conflicts.
The acpi tree lost its build failure.
The rr tree lost its conflicts.
The alacrity tree gained a conflict against Linus' tree.
The spi tree lost its ...
| Aug 15, 10:04 pm 2010 |
| Stephen Rothwell | linux-next: manual merge of the alacrity tree with Linus' tree
Hi Gregory,
Today's linux-next merge of the alacrity tree got a conflict in
include/linux/Kbuild between commit
60641aa1f379820e99ac7f45a38b43795670c741 ("include: replace unifdef-y
with header-y") from Linus' tree and several commits from the alacrity
tree.
I fixed it up (see below) and can carry the fix for a while.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc include/linux/Kbuild
index 626b629,1a31099..0000000
--- a/include/linux/Kbuild
+++ ...
| Aug 15, 9:19 pm 2010 |
| Nikanth Karthikesan | [RFC][PATCH] Per file dirty limit throttling
When the total dirty pages exceed vm_dirty_ratio, the dirtier is made to do
the writeback. But this dirtier may not be the one who took the system to this
state. Instead, if we can track the dirty count per-file, we could throttle
the dirtier of a file, when the file's dirty pages exceed a certain limit.
Even though this dirtier may not be the one who dirtied the other pages of
this file, it is fair to throttle this process, as it uses that file.
This patch
1. Adds dirty page accounting ...
| Aug 15, 9:19 pm 2010 |
| Peter Zijlstra | Re: [RFC][PATCH] Per file dirty limit throttling
I'm not really charmed by this.. it adds another random variable to prod
at. Nor does it really tell me why you're wanting to do this. We already
have per-task invluence on the dirty limits, a task that sporadically
dirties pages (your vi) will already end up with a higher dirty limit
This seems wrong, wth are you doing it here and not in the generic
Idem, replicating that code at every site that can dirty a page is just
wrong, hook into the regular ...
| Aug 16, 4:05 am 2010 |
| Bill Davidsen | Re: [RFC][PATCH] Per file dirty limit throttling
I agree with your problem description, a single program which writes a single
large file can make an interactive system suck. Creating a 25+GB Blu-Ray image
will often saturate the buffer space. I played with per-fd limiting during
2.5.xx development and I had an app writing 5-10GB files. While I wanted to get
I found that the effect was about the same as forcing the application to use
O_DIRECT, and since it was our application I could do that. Not all
badly-behaved programs are open source, ...
| Aug 16, 9:53 am 2010 |
| Stephen Rothwell | linux-next: build warning in Linus' tree
Hi all,
After merging the slab tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:
/scratch/sfr/next/drivers/hwmon/coretemp.c: In function 'coretemp_init':
/scratch/sfr/next/drivers/hwmon/coretemp.c:521: warning: unused variable 'n'
/scratch/sfr/next/drivers/hwmon/coretemp.c:521: warning: unused variable 'p'
Introduced by commit 851b29cb3b196cb66452ec964ab5f66c9c9cd1ed ("hwmon:
coretemp: enable coretemp device add operation failure").
--
Cheers,
Stephen ...
| Aug 15, 9:00 pm 2010 |
| Stephen Rothwell | linux-next: manual merge of the sh tree with the tree
Hi Paul,
Today's linux-next merge of the sh tree got a conflict in
arch/sh/include/asm/Kbuild between commit
bf56fba6703592149e1bcd19220c60eb42dff9b7 ("archs: replace unifdef-y with
header-y") from Linus' tree and commit
da28c597996a964a195529595c37f7aacd6dad09 ("sh: split out ptrace header
for _32/_64 variants") from the sh tree.
I fixed it up (see below) and can carry the fix for a while.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc ...
| Aug 15, 8:00 pm 2010 |
| Adam Jackson | Re: [Intel-gfx] Intel graphics CPU usage - SDVO detect b ...
SDVO can generate interrupts, although a particular SDVO output type
might not. (The G45 docs are missing this section, but the 965 docs are
applicable.) We don't have that turned on, of course, because that
would be entirely too sensible.
You'd probably need to uncomment the #if 0'd intel_sdvo_set_hotplug() in
intel_sdvo.c, and call that from the appropriate bit of
intel_sdvo_init(). For pre-gen4 you'd probably also need to set
SDVO_INTERRUPT_ENABLE in the appropriate SDVOx register, but ...
| Aug 16, 8:13 am 2010 |
| Linus Torvalds | Re: Intel graphics CPU usage - SDVO detect bogosity?
How precise does the timing have to be? I think i2c is self-clocking,
so it's ok to see big skews? Becuase msleep() can be off by quite a
bit (mdelay can too, but it's _way_ more rare, and requires either a
Sure. That results in a truncated dmesg (with a 128k buffer). The
thing seems to spew out something every ten seconds:
...
[ 232.610044] [drm:intel_sdvo_debug_write], SDVOB: W: 0B
(SDVO_CMD_GET_ATTACHED_DISPLAYS)
[ 232.624504] [drm:intel_sdvo_debug_response], SDVOB: ...
| Aug 15, 9:01 pm 2010 |
| Dave Airlie | Re: Intel graphics CPU usage - SDVO detect bogosity?
In this case it definitely doesn't matter, I expect msleep to be a much
nicer to the system in general idea esp in routines we can all at
Oh wierd, so not where I thought it was, I expect then the SDVO HDMI
detection is completely insane,
intel_sdvo_hdmi_sink_detect looks to contain some really uninspiring
code. Might be worth adding some debug in there to see if it sinks a lot
of time.
Dave.
--
| Aug 15, 9:29 pm 2010 |
| Andy Lutomirski | Re: Intel graphics CPU usage - SDVO detect bogosity?
You might be hitting the infamous hotplug storm [1]. The symptoms vary
by kernel version.
2.6.34 and before: udevadm --monitor shows craploads of events and, as
long as X is running, X keeps reprobing the outputs which (depending on
the particular bug) can suck cpu in the i2c code or cause more hotplug
events. It also makes X oddly laggy.
2.6.35 and newer: The kernel is smart enough to probe outputs itself
before telling X, so the events never hit userspace. But things still
can ...
| Aug 15, 9:06 pm 2010 |
| Dave Airlie | Re: Intel graphics CPU usage - SDVO detect bogosity?
At least we should replace mdelay with msleep in those functions.
Can you get a boot with drm.debug=4?
I wonder are we picking up a bad SDVO, the insane code retries 50 times
with a hard loop delay.
Dave.
--
| Aug 15, 8:30 pm 2010 |
| Linus Torvalds | Intel graphics CPU usage - SDVO detect bogosity?
I started wondering why 'top' was showing an otherwise idle system as
having a load average of 0.5+, and worker threads constantly using the
CPU.
So I did a system-wide profile, and got the attached output (look at
it in a really wide terminal).
There seems to be something _seriously_ wrong with i915 SDVO detect.
This is on an Apple Mac Mini (hey, your favorite problem child!), and
apparently it spends 20% of its non-idle CPU time just doing udelay's
for the i2c SDVO connection ...
| Aug 15, 7:32 pm 2010 |
| Markus Trippelsdorf | Re: Intel graphics CPU usage - SDVO detect bogosity?
You're not alone. I'm seeing similar things on my machine (AMD,Radeon).
The monitor outputs are polled every 10 sec in drivers/gpu/drm/drm_crtc_helper.c.
There is a patch attached to the following bug report that disables
polling and solves the problem for me:
http://bugs.freedesktop.org/show_bug.cgi?id=29536
--
»A man who doesn't know he is in prison can never escape.«
William S. Burroughs
--
| Aug 15, 7:51 pm 2010 |
| Linus Torvalds | Re: Intel graphics CPU usage - SDVO detect bogosity?
Hmm. I don't think it's a storm. The drm.debug=4 thing shows things
just every 10 seconds. That seems pretty controlled.
Of course, it seems to be several milliseconds worth of work then, so
My version of intel-gpu-tools must be old (fedora 12). It has
intel_gpu_dump and intel_reg_write and some other apps, but not the
bios-dumper/reader.
# intel_reg_write 0x61110 0x0
Value before: 0x4000220
Value after: 0x0
but it doesn't seem to change any behavior. Still that sdvo ...
| Aug 15, 9:27 pm 2010 |
| Andy Lutomirski | Re: Intel graphics CPU usage - SDVO detect bogosity?
[cc: intel-gfx]
Linus Torvalds wrote:
> On Sun, Aug 15, 2010 at 9:06 PM, Andy Lutomirski <luto@myrealbox.com> wrote:
>> You might be hitting the infamous hotplug storm [1]. The symptoms vary by
>> kernel version.
>
> Hmm. I don't think it's a storm. The drm.debug=4 thing shows things
> just every 10 seconds. That seems pretty controlled.
OK, probably not the hotplug storm. That's always been at least once per
second and sometimes several for me.
>
> Of course, it seems to be ...
| Aug 16, 7:27 am 2010 |
| Axel Lin | [PATCH] hwmon: (ads7871) Fix ads7871_probe error path
We need to call hwmon_device_unregister() if an error is detected after
sucessfully register hwmon device.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/hwmon/ads7871.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
index b300a20..303db92 100644
--- a/drivers/hwmon/ads7871.c
+++ b/drivers/hwmon/ads7871.c
@@ -201,11 +201,13 @@ static int __devinit ads7871_probe(struct spi_device *spi)
we need to ...
| Aug 15, 6:31 pm 2010 |
| Dave Airlie | Re: headers_check warnings in drm headers
At a minimum please fix the checker to work.
It doesn't recurse, all of the .h files include drm.h, which includes
linux/types.h, this is how its meant to work. If the checker does
recurse then doesn't define __linux__ then fix that. This isn't a bug in
the drm header files.
We copy these files as is into a userspace that is shared with FreeBSD,
the ifdef is the minimum down from about 10 ifdefs 2-3 years ago
concession we've made.
Dave.
--
| Aug 16, 3:45 pm 2010 |
| Randy Dunlap | Re: spi.h: missing kernel-doc notation, please fix
Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
| Aug 16, 8:36 am 2010 |
| Ernst Schwab | Re: spi.h: missing kernel-doc notation, please fix
Added comments in kernel-doc notation for previously added struct fields.
Signed-off-by: Ernst Schwab <eschwab@online.de>
---
On Sun, 15 Aug 2010 10:31:56 -0700
diff a/include/linux/spi/spi.h b/include/linux/spi/spi.h
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -213,6 +213,9 @@ static inline void spi_unregister_driver
* @dma_alignment: SPI controller constraint on DMA buffers alignment.
* @mode_bits: flags understood by this controller driver
* @flags: other ...
| Aug 16, 6:10 am 2010 |
| Grant Likely | Aug 16, 2:09 pm 2010 | |
| Stephen Rothwell | Re: [git pull request] ACPI patches for 2.6.36.merge
Yeah, it turned up in Len's tree that I fetch over the weekend.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
| Aug 15, 7:43 pm 2010 |
| Andrew Morton | Re: [git pull request] ACPI patches for 2.6.36.merge
That code compiled OK in -mm which includes linux-next. I assume that
some last-minute merging broke things.
--
| Aug 15, 6:21 pm 2010 |
| Linus Torvalds | Re: [git pull request] ACPI patches for 2.6.36.merge
On Sun, Aug 15, 2010 at 6:21 PM, Andrew Morton
Not tested at all. They were apparently just applied from some other
source. And not even safely, but with "they can apply with fuzz",
which is downright dangerous. And then the result saw neither a
There are _zero_ merge errors there. Go take a look at Len's tree.
It's a linear progression of patches AND THE PATCH IN LEN'S TREE IS
BUGGY.
It's that simple. It clearly never ever saw -next, because it _cannot_
have seen next. That particular ...
| Aug 15, 6:35 pm 2010 |
| Arnd Bergmann | Re: [PATCH] init/main.c: remove __releases(kernel_lock) ...
Acked-by: Arnd Bergmann <arnd@arndb.de>
--
| Aug 15, 11:59 pm 2010 |
| Mark Brown | Re: [linux-pm] Notes from the Boston Linux Power Managem ...
FWIW this applies to a bunch of other embedded processors too - OMAP
isn't particularly unique here, though it's one of the furthest along in
terms of exploting this in mainline Linux.
--
| Aug 16, 7:49 am 2010 |
| jovi zhang | Re: [PATCH] mm: code improvement of check_stack_guard_page
On Mon, Aug 16, 2010 at 1:58 AM, Linus Torvalds
That's fine. I havn't consider gcc optimization.
--
| Aug 15, 6:32 pm 2010 |
| Jeff Garzik | Re: [PATCH] 2.6.35 libata support for > 512 byte sectors ...
The main question is whether the size of a DRQ block changes, when LBA
logical size changes? I need to review the ATA8 specs in this area, but
I would think some interfaces that return 512-byte pages for things like
SMART info would be unchanged. How do the drives behave for
PIO-Data-{In,Out} commands that are not reading/writing user data, but
rather drive metadata?
Jeff
--
| Aug 16, 12:41 pm 2010 |
| Grant Grundler | Re: [PATCH] 2.6.35 libata support for > 512 byte sectors ...
On Mon, Aug 16, 2010 at 12:41 PM, Jeff Garzik <jgarzik@pobox.com> wrote:
SMART Info/Logs are meta data and as you noted unchanged.
Two other meta-data PIO commands I can think of:
o FW update: I'm not going to risk bricking this drive to find that out.
o Vendor specific selftest/diagnostic commands (I don't know if any
exist - just a guess)
If someone from Hitachi cares to respond publicly regarding the
behavior of this "Engineering Sample", that would be appreciated and
helpful. But ...
| Aug 16, 1:24 pm 2010 |
| Grant Grundler | Re: [PATCH] 2.6.35 libata support for > 512 byte sectors ...
On Sat, Aug 14, 2010 at 9:37 PM, Wilcox, Matthew R
The switch probably sucks unless we could weight the order of the
tests. E.g. common cases first. But it's just an implementation detail
that is relatively easy to replace with the bitmap you had implemented
I have no idea. If it's tricky, I probably have it wrong.
This could also be added as a separate patch. I didn't run into this
problem so I can't say which controllers would have problems.
thanks for the helpful feedback!
I'll ...
| Aug 16, 12:17 pm 2010 |
| Matthew Garrett | Re: [PATCH] platform/x86: move rfkill for Dell Mini 1012 ...
Merged, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
--
| Aug 16, 9:10 am 2010 |
| Arnd Bergmann | Re: ioctl definition - has it changed recently?
Just take a look at all the other patches that went into the
kernel to do this for other drivers. You only really
need to change the line with .ioctl=... to .unlocked_ioctl=
and change the prototype of the referenced function to
static long foo_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
Arnd
--
| Aug 16, 12:17 am 2010 |
| Piotr Hosowicz | Re: ioctl definition - has it changed recently?
This I do not know. Can You help me?
Regards,
Piotr Hosowicz
--
"[Oleksy] dotknął naszych domów, naszych żon, naszych dzieci,
naszych psów, naszych ŚWINEK MORSKICH, on po prostu wkroczył
swoim głupim gadaniem w sferę prywatną, która musi być chro-
niona dla dobra każdego z nas" - powiedział Kwaśniewski.
NP: Patrick O'Hearn - Night Becomes Her
NB: 2.6.35-git16
--
| Aug 16, 12:11 am 2010 |
| Piotr Hosowicz | Re: ioctl definition - has it changed recently?
int nv_kern_ioctl(struct inode *, struct file *, unsigned int,
unsigned long);
It seems different. How to change it? Now it works, I built it without
your remarks, exactly how I described on my blog:
http://phosowicz.jogger.pl/2010/08/15/nvidia-graphics-in-fresh-kernels/
Regards,
Piotr Hosowicz
--
Polsat: oglądasz z rodzinką reklamy, a tu nagle - trach! - film!
NP: Patrick O'Hearn - Chance
NB: 2.6.36-rc1
--
| Aug 16, 12:59 am 2010 |
| Arnd Bergmann | Re: ioctl definition - has it changed recently?
Just fix your driver code to no longer rely on the big kernel lock
and then make it use the unlocked_ioctl operation.
Arnd
--
| Aug 15, 11:58 pm 2010 |
| Ingo Molnar | Re: [PATCH] x86: Don't write io_apic ID if it is not changed
Just guessing, but if other OSs dont do it we might surprise buggy hardware
[and trigger erratas in them], so this would be a standard 'dont touch the hw
unless necessary' defensive move.
Similar bugs are not unprecedented.
Thanks,
Ingo
--
| Aug 16, 12:28 am 2010 |
| Cyrill Gorcunov | Re: [PATCH] x86: Don't write io_apic ID if it is not changed
Thinking a bit more I guess there might be a sence to write io-apic id
unconditionally, io-apic id is not latched on reset but set to 0 (at least
for old apics) so if we hit id match -- this will be once, but the same
time we will have additional if() for every cycle iteration, not sure
it worth it. Right?
-- Cyrill
--
| Aug 16, 2:06 am 2010 |
| Jiri Kosina | Re: [PATCH 2/2]include/video/vga.h update web address.
Seems reasonable. Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
| Aug 16, 6:15 am 2010 |
| Jiri Kosina | Re: [PATCH 1/2]drivers/video/vesafb.c Fix a typo.
Applied, thanks.
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
| Aug 16, 6:14 am 2010 |
| Justin P. Mattock | Re: [PATCH 2/2]include/video/vga.h update web address.
alright..
Justin P. Mattock
--
| Aug 16, 9:13 am 2010 |
| Justin P. Mattock | Re: [PATCH 1/2]drivers/video/vesafb.c Fix a typo.
cool... there's another web address that I can send to you, but need to
look through and find the original e-mail first before...
Justin P. Mattock
--
| Aug 16, 9:16 am 2010 |
| Darius Augulis | Re: [PULL] Please pull bjdooks' for-linus/samsung-2636
Probably you would like to merge v2 of these patches.
I sent v2 to ML in 08/06/2010.
As v1 is already in main line, should I prepare new patch containing
fixes which are in v2? These fixes mostly are coding style related also
--
| Aug 16, 10:21 am 2010 |
| Dan Williams | Re: [PATCH] missing inline keyword for static function i ...
On Sat, Aug 14, 2010 at 6:02 AM, Mathieu Lacage
Applied, thanks.
--
Dan
--
| Aug 16, 1:47 am 2010 |
| Dan Williams | Re: [patch] dma/shdma: move dereference below the NULL check
Thanks, applied as obviously correct.
--
Dan
--
| Aug 16, 1:46 am 2010 |
| Andreas Hartmann | Re: rt61pci - bad performance
Wel, I did some tests. I tried to get same conditions (what is not as
easy). I will show here some results, which seem to be typical to me.
downstream
==========
netperf -t TCP_SENDFILE -H client
TCP SENDFILE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to client port 0
AF_INET
Recv Send Send
Socket Socket Message Elapsed
Size Size Size Time Throughput
bytes bytes bytes secs. 10^6bits/sec
87380 16384 16384 10.36 ...
| Aug 16, 10:04 am 2010 |
| Andreas | Re: [rt2x00-users] rt61pci - bad performance
Well, this path doesn't exist - even the crypto-file can't be found.
lsmod | grep rt61
rt61pci 19584 0
rt2x00pci 5646 1 rt61pci
rt2x00lib 31738 2 rt61pci,rt2x00pci
eeprom_93cx6 1429 1 rt61pci
crc_itu_t 1435 2 rt61pci,firewire_core
notebook1:/sys/kernel/debug/ieee80211/phy0 # find -name crypto
notebook1:/sys/kernel/debug/ieee80211/phy0 #
notebook1:/sys/kernel/debug/ieee80211/phy0 # mount | grep debugfs
debugfs on ...
| Aug 16, 9:33 am 2010 |
| Helmut Schaa | Re: [rt2x00-users] rt61pci - bad performance
Good, looks like hw crypto is working then ...
Helmut
--
| Aug 16, 9:48 am 2010 |
| Michal Simek | Re: [PATCH] microblaze: use asm-generic/pci-dma-compat.h
Applied.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
--
| Aug 16, 1:32 am 2010 |
| Ingo Molnar | Re: [PATCH][GIT PULL] tracing: Sanitize value returned f ...
Pulled, thanks a lot Steve!
Ingo
--
| Aug 16, 10:30 am 2010 |
| Peter Zijlstra | Re: [patch 1/3] sched: init rt_avg stat whenever rq come ...
ARGH, so i[357] westmere mobile stops TSC on some power state?
Why don't we sync it back to the other CPUs instead?
Or does it simply mark TSCs unstable and leaves it at that?
In any case, this needs to be fixed at the clock level, not like this.
--
| Aug 16, 12:47 am 2010 |
| Peter Zijlstra | Re: [patch 3/3] sched: move sched_avg_update() to update ...
Right, but I think it doesn't need to, as its never accessed cross CPU
(except maybe for /proc/sched_debug, and who cares about that).
The (other) odd case is NO_HZ idle balancing, but there the actual CPU
won't be updating the fields, so the remote CPU doing NO_HZ idle
Right, except it breaks things a bit, at the very least you really need
that update right before reading it, otherwise you can end up with >100%
fractions, which are odd indeed ;-)
--
| Aug 16, 1:00 am 2010 |
| Peter Zijlstra | Re: [patch 2/3] sched: fix minimum power returned by upd ...
smt_power freq_power rt_power
power = SCHED_LOAD_SCALE * ---------- * ---------- * ----------
LOAD_SCALE LOAD_SCALE LOAD_SCALE
Which, in the above case ends up being 0, so how does resetting it back
to LOAD_SCALE make sense?
--
| Aug 16, 12:50 am 2010 |
| Suresh Siddha | Re: [patch 3/3] sched: move sched_avg_update() to update ...
There is no guarantee that the original cpu won't be doing this in
with the patch, the update always happens before reading it. isn't it?
update now happens during the scheduler tick (or during nohz load
balancing tick). And the load balancer gets triggered with the tick.
So the update (at the tick) should happen before reading it (used by
load balancing triggered by the tick). Am I missing something?
thanks,
suresh
--
| Aug 16, 10:46 am 2010 |
| Suresh Siddha | Re: [patch 1/3] sched: init rt_avg stat whenever rq come ...
WSM has working TSC with constant rate across P/C/T-states. This issue
All the cpu's entered suspend state and during resume it gets reset for
TSCs are stable and in sync after resume aswell. If we want to do SW
sync, we need to keep track of the time we spent in the suspend state
and do a SW sync (during resume) that can potentially disturb the HW
If we have more such dependencies on TSC then we may need to address the
issue at clock level aswell. Nevertheless, across cpu ...
| Aug 16, 10:36 am 2010 |
| Suresh Siddha | Re: [patch 2/3] sched: fix minimum power returned by upd ...
hmm, true, but I thought I saw some load balancing code which was
depending on SCHED_LOAD_SCALE value. Ignore this for now. Will get back
to you if this indeed is a problem.
thanks,
suresh
--
| Aug 16, 10:37 am 2010 |
| Peter Zijlstra | Re: [patch 1/3] sched: init rt_avg stat whenever rq come ...
Nah, no need to track the time spend in S-states, simply not going
backwards would be enough, save before entering S, restore after coming
out.
You can use something like:
suspend:
__get_cpu_var(cyc2ns_suspend) = sched_clock();
resume:
for_each_possible_cpu(i)
per_cpu(cyc2ns_offset, i) += per_cpu(cyc2ns_suspend);
or something like that to keep sched_clock() stable, which is exactly
what most (all?) its users expect when we report the TSC is usable.
Not sure how to arrange ...
| Aug 16, 12:25 pm 2010 |
| Peter Zijlstra | Re: [patch 3/3] sched: move sched_avg_update() to update ...
We run the load-balancer in softirq context, on -rt that's a task, and
we could have ran other (more important) RT tasks between the hardirq
and the softirq running, which would increase the rt_avg and could thus
result in >100%.
But I think we can simply retain the sched_avg_update(rq) in
sched_rt_avg_update(), that is ran with rq->lock held and should be
enough to avoid that case.
We can retain the other bit of you patch, moving sched_avg_update() from
scale_rt_power() to ...
| Aug 16, 12:31 pm 2010 |
| Ira W. Snyder | Re: BISECTED: 2.6.35 (and -git) fail to boot: APIC problems
Thanks Eric!
Commit 5989cd6a1cbf86 fixes my problem. It looks like Linus pulled this
patch very soon after I had updated my -git tree. I guess this was just
a case of bad timing. :)
Thanks again for responding so quickly!
Ira
--
| Aug 16, 8:42 am 2010 |
| H. Peter Anvin | Re: [PATCH][EFI] Run EFI in physical mode
No, it should not be dynamic; rather we should unify all the users who need a 1:1 map and just keep that page table set around.
--
Sent from my mobile phone. Please pardon any lack of formatting.
--
| Aug 15, 8:27 pm 2010 |
| huang ying | Re: [PATCH][EFI] Run EFI in physical mode
Agree. One known issue of global 1:1 map is that we need to make at
least part of page table PAGE_KERNEL_EXEC for EFI runtime code, and
change_page_attr can not be used before page allocator is available.
Best Regards,
Huang Ying
--
| Aug 15, 9:58 pm 2010 |
| Simon Horman | Re: [PATCH][EFI] Run EFI in physical mode
I proposed something similar to this for ia64 at one point to solve the
problem of kexecing to Xen - which at that time mapped EFI to a different
location to Linux.
As I recall, the idea was shot-down by SGI Altix people on the basis
potential performance problems. I don't recall any reasons more specific
than that being given (and to be honest I was less than happy about
it at the time).
In the end I moved EFI in Xen to match Linux and have been able to ignore
the problem ever since. ...
| Aug 15, 6:31 pm 2010 |
| huang ying | Re: [PATCH][EFI] Run EFI in physical mode
efi_flags and save_cr3 should be per-CPU, because they now will be
used after SMP is enabled.
efi_pgd should be dynamically allocated instead of statically
allocated, because EFI may be not enabled on some platform.
And I think it is better to unify early physical mode with run-time
physical mode. Just allocate the page table with early page allocator
(lmb?).
Best Regards,
Huang Ying
--
| Aug 15, 6:43 pm 2010 |
| H. Peter Anvin | Re: [PATCH][EFI] Run EFI in physical mode
For the 1:1 map we probably should make all pages executable; other things need it too, but we shouldn't have it mapped in except when needed.
--
Sent from my mobile phone. Please pardon any lack of formatting.
--
| Aug 15, 10:08 pm 2010 |
| Eric W. Biederman | Re: [PATCH][EFI] Run EFI in physical mode
We still want to restore cr3 from the local task structure as soon
as is reasonable, as an identity mapped page table will have page 0
We need to be careful in the setup of the global page table so that
we are in sync with the pat structure for the attributes pages
are mapped so that we don't map a page as cached and uncached
at the same time. Otherwise we could accidentally get cache
corruption. To do that would seem to mean change_page_attr
is relevant at least after we switch from our ...
| Aug 16, 4:39 pm 2010 |
| Takao Indoh | Re: [PATCH][EFI] Run EFI in physical mode
Unfortunately I don't have a machine to test. The machine I'm using does
not support EFI on x86_32:-( I'd appreciate it if anyone try it...
Thanks,
--
| Aug 16, 12:30 pm 2010 |
| H. Peter Anvin | Re: [PATCH][EFI] Run EFI in physical mode
Quite, which is yet another reason to have a common global page table
for all the 1:1 users... right now this is all ad hoc.
-hpa
--
| Aug 16, 4:54 pm 2010 |
| Thomas Habets | Re: BUG: IPv6 stops working after a while, needs ip ne d ...
Copy/paste error, sorry.
advmss 1440, and no "unreachable"
Complete (correct) line:
2a00:800:752:1::5c:0/112 dev eth0 proto kernel metric 256 mtu 1500 advmss
Yes, that's where the "unreachable" belonged.
unreachable 2a00:800:1000:64::1 dev lo proto kernel metric 256 error
-101 mtu 1500 advmss 1440 hoplimit 4294967295
Am I not allowed to add addresses to lo? That I've deconfigured this
But at first it works perfectly, and then it doesn't work at all. The link
is ~idle ...
| Aug 16, 3:59 am 2010 |
| Eric Dumazet | Re: BUG: IPv6 stops working after a while, needs ip ne d ...
advmss 14 ? or is it a copy/paste error ?
unreachable ?
Sollicitation comes from fe80::224:81ff:fea3:4424 instead of
I am wondering if you have some lowlevel problem, say lost frames in an
otherwise idle link, maybe a full/half duplex mismatch ?
--
| Aug 16, 3:19 am 2010 |
| Jeff Chua | Re: [dm-devel] [lvm-devel] linux-2.6.35+ causes LVM to f ...
I'm not using module. It's all built-in to the kernel. Hopefully this
would be taken care of as well. That's why I had it in rc.S just
before the lvm filesystems are mounted.
Thanks,
Jeff.
--
| Aug 16, 9:10 am 2010 |
| Zdenek Kabelac | Re: [dm-devel] linux-2.6.35+ causes LVM to fail with " d ...
Well error is usually error - so some harm under certain circumstances could
happen (low memory situation)...
But in this case I assume it's related to this kernel commit which should fix
this problem ?
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d78243...
Zdenek
--
| Aug 16, 6:56 am 2010 |
| Alasdair G Kergon | Re: [lvm-devel] [dm-devel] linux-2.6.35+ causes LVM to f ...
The latest LVM package made an assumption that it would be set up
correctly by udev (or manually in your case). We are updating
the userspace libdevmapper code to handle your circumstances
For those interested, originally we used mlockall() but in non-C locales
on some distributions glibc is configured to map 80MB+ of locale data
into memory without offering any way to unmap it. We don't need
that data locked and it increased the minimum memory required to install
a distribution as well as ...
| Aug 16, 7:22 am 2010 |
| Jeff Chua | Re: [lvm-devel] [dm-devel] linux-2.6.35+ causes LVM to f ...
It'll be nice if lvm returns a more meanful message like "ioctl
failed. Check /proc/misc to ensure the device is mapped correctly."
To take care of it automatically with udev, I'm doing this in rc.S
if [ -f /sys/devices/virtual/misc/device-mapper/dev ]
then
NODE=$(</sys/devices/virtual/misc/device-mapper/dev)
rm -f /dev/mapper/control
mknod /dev/mapper/control c ${NODE/:/ }
I see that now it's fixed with that commit.
Thanks,
Jeff
--
| Aug 16, 8:32 am 2010 |
| Alasdair G Kergon | Re: [dm-devel] [lvm-devel] linux-2.6.35+ causes LVM to f ...
The whole point of this change was to trigger the loading of dm-mod
automatically for people using it as a module, based on using a known
major/minor number instead of a dynamic one only known after the module
has been loaded. That needs to happen regardless of whether someone is
using udev or not.
This can all be fixed easily enough in userspace.
Alasdair
--
| Aug 16, 8:55 am 2010 |
| Micha Nelissen | Re: [PATCH 2/9] RapidIO, powerpc/85xx: modify RIO port- ...
I don't understand this comment: you still schedule work to read the
port-write queue; so how is this message buffering performed as soon as
Magic value.
Micha
--
| Aug 16, 5:12 am 2010 |
| Bounine, Alexandre | RE: [PATCH 0/9] RapidIO: Set of patches to add Gen2 switches
Correct. EM extensions exist since v1.3. But implementation before Gen2
switches relied
on proprietary device specific mechanism (tsi57x). Addition of Gen2
switches just
pushed forward the standard implementation. The RIO standard methods may
be used on 1.3 switches
(tested on tsi57x) as well as the standard routing table operations that
have been added
Alex.
--
| Aug 16, 11:18 am 2010 |
| Micha Nelissen | Re: [PATCH 9/9] RapidIO: Add support for IDT CPS Gen2 switches
The 0x80000000 is that an autoincrement bit? If so, it only needs to do
this once I think? If so please call it like that, and loop the 'i'
variable through the destination IDs.
Micha
--
| Aug 16, 5:36 am 2010 |
| Micha Nelissen | Re: [PATCH 7/9] RapidIO: Add handling for PW message fro ...
I am not quite sure what the point is of this patch. What do you need to
Do you mean if port-writes are dropped? Then they did not reach you in
the first place. If a link in between is broken, the associated switch
will 'complain' and send port-writes, no?
Micha
--
| Aug 16, 5:29 am 2010 |
| Micha Nelissen | Re: [PATCH 4/9] RapidIO: Add relation links between RIO ...
As RapidIO is a switched network, the concept of 'previous' and 'next'
devices is invalid. Perhaps it's just the way they were
discovered/enumerated, but that does not matter any more at runtime. Or
This can be extracted from the swpinfo field (which you removed in
another patch)?
Micha
--
| Aug 16, 5:18 am 2010 |
| Micha Nelissen | Re: [PATCH 5/9] RapidIO: Add default handler for error_s ...
Perhaps this whole part of operating the MNT_RSP registers (sending
link-request symbol is the only useful action IIRC?) can be put in a
separate function for readability.
Micha
--
| Aug 16, 5:21 am 2010 |
| Bounine, Alexandre | RE: [PATCH 2/9] RapidIO, powerpc/85xx: modify RIO port- ...
Compared to the original code, I rearranged order of checking interrupt
status bits to check the queue status first. The 85xx PW controller is
capable to receive and keep only one PW message. Therefore, I copy it
into the driver's FIFO and re-enable HW Rx queue (it is called queue but
can accept only one entry) ASAP. I have a test setup that is capable
generate multiple PW messages and see many messages discarded by PW
controller
Agree. Will correct.
--
| Aug 16, 8:27 am 2010 |
| Micha Nelissen | Re: [PATCH 0/9] RapidIO: Set of patches to add Gen2 switches
This is not 'Gen2' specific, as these error management extensions also
exist in v1.2/1.3 (?) of the specification? E.g. tsi56x and tsi57x could
support this functionality?
Micha
--
| Aug 16, 5:30 am 2010 |
| Bounine, Alexandre | RE: [PATCH 7/9] RapidIO: Add handling for PW message fro ...
From failed maintenance read. In the previous version PW handler had
troubles if maintenance
read request fails. Now I am trying to detect lost or remover devices as
Situation that I am trying to resolve is mostly applicable to larger
systems that have multiple complex boards (or chassis/domains) connected
together. Power down sequence on the board (chassis) combined with
switch hierarchy may allow switch to send PW message to the host before
its power is off. This will create an orphaned PW ...
| Aug 16, 11:02 am 2010 |
| Micha Nelissen | Re: [PATCH 6/9] RapidIO: Add switch-specific sysfs initi ...
Why not make a sw_sysfs_create and sw_sysfs_remove? Is better for
readability. Now you call 'sw_sysfs(dev, 0)' or 'sw_sysfs(dev, 1)';
Micha
--
| Aug 16, 5:25 am 2010 |
| Bounine, Alexandre | RE: [PATCH 4/9] RapidIO: Add relation links between RIO ...
Yes, the "previous" and "next" have to be considered in context of
enumeration/discovery.
At runtime, it does not matter for data traffic, but is valuable
information for error recovery
And hot-swap. This provides snapshot of device connections. For example,
when servicing
error-stopped state of link between two switches you need to know
ingress port of far switch on
the link. It may be a problem to read it directly from the device.
Searching through the device list
Agreed in response for ...
| Aug 16, 7:00 am 2010 |
| Bounine, Alexandre | RE: [PATCH 5/9] RapidIO: Add default handler for error_s ...
I was on the fence with this one. Now I have an extra vote in favor of a
separate function ;)
Will do.
--
| Aug 16, 7:47 am 2010 |
| Bounine, Alexandre | RE: [PATCH 9/9] RapidIO: Add support for IDT CPS Gen2 switches
No. This is EXTENDED_CONFIGURATION_ENABLE bit defined in Part 3 of RIO
spec (v.2.1, sect.3.5.4).
Anyway, I should add definition for this bit. Will do now.
Alex.
--
| Aug 16, 11:30 am 2010 |
| Bounine, Alexandre | RE: [PATCH 6/9] RapidIO: Add switch-specific sysfs initi ...
Yes. Because end-points should not have the "routes" attribute at all
I assume that your question was "Why do not make it separate?"
Both changes are specific to switches, both address sysfs and both are
not big enough to justify
a separate patch.
I agree that make separate patches would give more clarity, so would do
better description.
Because there are changes that should be made to other patches in this
I just do not want to have an extra member here. Not every switch will
require own ...
| Aug 16, 10:10 am 2010 |
| Bounine, Alexandre | RE: [PATCH 3/9] RapidIO: Add the ingress port number int ...
Agree. I missed the Multiport bit introduced in RIO spec 2.1. Now it is
justified to be as it was before.
I will rework this and next patches.
--
| Aug 16, 6:40 am 2010 |
| Micha Nelissen | Re: [PATCH 3/9] RapidIO: Add the ingress port number int ...
Why not keep using the swpinfo field, as you can extract it from there?
And your code actually does this.
Also processor devices can have multiple ports (not only switches), it
would be good to be ready for that use case.
Micha
--
| Aug 16, 5:14 am 2010 |
| Jon E | RE: Problems with Recent Patches to IDE Driver
Could you elaborate a bit please? Are you suggesting that the old driver was better at "supporting oddities" or that the new driver model is (better)?
I cannot post our code (not only because it's proprietary but it's also spread out amongst several files) but the snips I included in the original note illustrate the points of use.
The board is an addon board with an ide interface, a RF-in port and an optional smartcard interface. It starts out initializing itself as a network device ...
| Aug 16, 7:50 am 2010 |
| Uwe Kleine-König | Re: undefined reference to `mmc_pm_notify' when selected ...
Hello,
For those who care:
http://mid.gmane.org/1281691473-15481-1-git-send-email-u.kleine-koenig@pengutronix.de
Kgene, do you care to ack this change as it may prod akpm in taking the
fix a bit earlier?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
| Aug 15, 10:17 pm 2010 |
| Kukjin Kim | RE: undefined reference to `mmc_pm_notify' when selected ...
Sure, I did it.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
| Aug 15, 10:29 pm 2010 |
| Randy Dunlap | Re: undefined reference to `mmc_pm_notify' when selected ...
or this one from earlier:
http://lkml.org/lkml/2010/8/12/207
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
| Aug 16, 8:12 am 2010 |
| Tejun Heo | Re: [PATCH] workqueue: free rescuer on destroy_workqueue
Applied to wq#for-linus. Thanks.
--
tejun
--
| Aug 16, 12:55 am 2010 |
| Don Zickus | Re: fix BUG: using smp_processor_id() in touch_nmi_watch ...
I don't recall any requirement to have preemption disabled when using
those functions. It seems sensible to put it in the
touch_{softlockup|nmi}_watchdog code.
I assume the reason for having preemption disabled when using
smp_processor_id() is that the code could migrate to another cpu when
rescheduled?
I don't see a problem with the patch, but my low level understanding of
the __get_cpu_var vs. per_cpu isn't very strong.
Cheers,
--
| Aug 16, 6:34 am 2010 |
| Don Zickus | Re: fix BUG: using smp_processor_id() in touch_nmi_watch ...
Well I know that much. :-) It seems that __get_cpu_var depends on
preemption being disabled whereas per_cpu does not? Though for some
reason I thought __get_cpu_var would be more atomic when it grabbed the
current cpu such that you wouldn't need to disable preemption. Guess not.
Cheers,
Don
--
| Aug 16, 7:12 am 2010 |
| Peter Zijlstra | Re: fix BUG: using smp_processor_id() in touch_nmi_watch ...
Which could mean two things, either ACPI got funny on us, or Don's new
These other two really are about assumptions we make on the call sites,
which at the very least are violated by ACPI.
Don/Ingo, remember if we require touch_*_watchdog callers to have
preemption disabled? Or is the proposed patch sensible?
--
| Aug 16, 1:22 am 2010 |
| Peter Zijlstra | Re: fix BUG: using smp_processor_id() in touch_nmi_watch ...
Indeed, it can't be implemented atomically on all smp systems, hence its
really nothing other than a 'convenient' short for per_cpu(foo,
smp_processor_id()).
--
| Aug 16, 7:29 am 2010 |
| Yong Zhang | Re: fix BUG: using smp_processor_id() in touch_nmi_watch ...
Isn't that implicit? I mean the caller of touch_{softlockup|nmi}_watchdog
I don't think so. Such as:
...
preempt_disable() <===A
touch_{softlockup|nmi}_watchdog <===B
preempt_enable() <===C
...
You just scroll A and C into B, but what will happen before preempt
If the migration could happen, then we could touch the wrong cpu-data,
Maybe we should use __raw_get_cpu_var() instead.
Thanks,
Yong
--
| Aug 16, 7:06 am 2010 |
| Don Zickus | Re: [PATCH] fix BUG using smp_processor_id() in touch_nm ...
cc'ing Frederic
--
| Aug 16, 7:30 am 2010 |
| Sergey Senozhatsky | [PATCH] fix BUG using smp_processor_id() in touch_nmi_wa ...
Fix: acpi_os_stall calls touch_nmi_watchdog and touch_softlockup_watchdog
with preemption enabled causing 'BUG: using smp_processor_id() in preemptible
code'.
Patch also removes double smp_processor_id call (smp_processor_id itself and in
__get_cpu_var) in __touch_watchdog.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 613bc1f..8822f1e 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -116,13 ...
| Aug 16, 7:08 am 2010 |
| Peter Zijlstra | Re: fix BUG: using smp_processor_id() in touch_nmi_watch ...
Right, if you can freely schedule, you can get migrated, which means you
can get migrated between having determined the return value and using
__get_cpu_var() gets you the value on the current cpu, per_cpu() takes a
cpu argument.
--
| Aug 16, 6:46 am 2010 |
| Uwe Kleine-König | Re: [PATCH v2] ARM: imx: fix build failure concerning otg/ulpi
Hello Igor,
I assume this is an Ack?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
| Aug 15, 9:53 pm 2010 |
| Igor Grinberg | Re: [PATCH v2] ARM: imx: fix build failure concerning otg/ulpi
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Greg,
Can you, please, add this as a fix (maybe urgent) for build failure?
--
Regards,
Igor.
--
| Aug 15, 11:09 pm 2010 |
| Dries Van Puymbroeck | RE: [PATCH] USB: Gadget: g_multi: added INF file for gad ...
Hi, sorry for the delay in answering;
FROM: Xiaofan Chen [mailto:xiaofanc@gmail.com]
SENT: vrijdag 13 augustus 2010 15:32
TO: Dries Van Puymbroeck
CC: linux-usb@vger.kernel.org; Greg KH; Michał Nazarewicz; Michał Nazarewicz; Dries Van Puymbroeck; linux-kernel@vger.kernel.org
This is actually what I based my INF file on. Maybe I should mention that in the comments in the INF?
FROM: Xiaofan Chen [mailto:xiaofanc@gmail.com]
SENT: zaterdag 14 augustus 2010 3:28
TO: Michal ...
| Aug 16, 1:07 am 2010 |
| Matthew Garrett | Re: [PATCH] Support MSI Poulsbo netbook U110/U115
I've thought about this a bit more and now lean towards thinking that
putting the PCI IDs in the ACPI video driver is the best way to go. The
alternative is to only fix it for MSI, which isn't the best option. On
the other hand, I looked at adding support to the Poulsbo driver and it
actually seems pretty easy, so to be honest I'd prefer it if that got
done instead.
--
Matthew Garrett | mjg59@srcf.ucam.org
--
| Aug 16, 8:56 am 2010 |
| Peter Zijlstra | Re: [PATCH] Fixed a mismatch between the users of radix_ ...
Your changelog fails to mention how you fixed it..
It also reminds me how much I hate that height hack, I really should get
path-compression working some day...
http://programming.kicks-ass.net/kernel-patches/concurrent-pagecache/23-rc1-rt/radix-t...
--
| Aug 16, 4:25 am 2010 |
| Joe Perches | RE: [PATCH v2 1/3] libcxgbi: common library for cxgb3i a ...
I meant more like this:
Use #define pr_fmt(fmt) KBUILD_MODNAME ":s: " fmt, __func__
Use pr_<level>
Correct mismatches of "%lu", sizeof to "%u", sizeof
Standardize message to remove trailing ".", some had, some hadn't.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 122 +++++++-------
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 153 +++++++++---------
drivers/scsi/cxgbi/libcxgbi.c | 312 ++++++++++++++++++------------------
...
| Aug 16, 9:48 am 2010 |
| David Miller | Re: [GIT] Networking
From: Eric Dumazet <eric.dumazet@gmail.com>
I'm hesistent to say that we should put this kind of patch in.
It will shut up lockdep for this specific case, but it also means
that if we do any other kinds of locking in this sequence we will
not validate it.
The valuable of this is open for debate I guess.
But locking is hard so I would say that disabling lockdep to kill a
warning it generates should be an absolute last resort.
I also don't think making the locking mechanics conditional ...
| Aug 16, 12:36 pm 2010 |
| David Miller | Re: [GIT] Networking
From: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
--
| Aug 16, 1:57 pm 2010 |
| Eric Dumazet | Re: [GIT] Networking
Hmm, maybe just disable BH, not for whole duration, but for each cpu.
Its a bit late here and I prefer to close this problem before whole
earth shout on me.
Thanks
[PATCH] netfilter: {ip,ip6,arp}_tables: avoid lockdep false positive
After commit 24b36f019 (netfilter: {ip,ip6,arp}_tables: dont block
bottom half more than necessary), lockdep can raise a warning
because we attempt to lock a spinlock with BH enabled, while
the same lock is usually locked by another cpu in a softirq ...
| Aug 16, 1:22 pm 2010 |
| Peter Zijlstra | Re: [PATCH/RFC 2/5] [PATCH] sched: pass sched_domain_lev ...
Ah, so the plan is to reduce the number of knobs, not create more.
Sysadmins really aren't interested in having a powersavings knob per
topology level.
--
| Aug 16, 1:29 am 2010 |
| Peter Zijlstra | Re: [PATCH/RFC 3/5] [PATCH] sched: add book scheduling domain
http://lkml.org/lkml/2009/8/18/169
More information in this thread: http://lkml.org/lkml/2009/8/20/190
--
| Aug 16, 1:48 am 2010 |
| Tejun Heo | [PATCH UPDATED 10/11] fs, block: propagate REQ_FLUSH/FUA ...
Propagate deprecation of REQ_HARDBARRIER and new REQ_FLUSH/FUA
interface to upper layers.
* WRITE_BARRIER is marked deprecated and WRITE_FLUSH, WRITE_FUA and
WRITE_FLUSH_FUA are added.
* REQ_COMMON_MASK now includes REQ_FLUSH | REQ_FUA so that they are
copied from bio to request.
* BH_Ordered and BH_Eopnotsupp are marked deprecated. BH_Flush/FUA
are _NOT_ added as they can and should be specified when calling
submit_bh() as @rw parameter as suggested by Jan Kara.
Signed-off-by: ...
| Aug 16, 9:33 am 2010 |
| Bernd Petrovitsch | Re: Attempted summary of suspend-blockers LKML thread, t ...
Not that I´m as "valuable" as the others quoted above: I have the same
That basically sums it up as far as I see.
Bernd
--
Bernd Petrovitsch Email : bernd@petrovitsch.priv.at
LUGA : http://www.luga.at
--
| Aug 16, 4:36 am 2010 |
| Jesse Barnes | Re: Attempted summary of suspend-blockers LKML thread, t ...
On Sat, 14 Aug 2010 09:50:00 +0200
Pavel, you should know better than this. You've been working on Linux
long enough to know that development doesn't happen this way.
It's far more common (and prudent, business-wise) for companies to
develop changes against upstream Linux, ship them, and then try to get
them or something like them integrated upstream. This often works
fine, but big problems arise when either the company in question
doesn't bother to ever push upstream (Linux loses out on ...
| Aug 16, 8:16 am 2010 |
| H. Peter Anvin | Re: [PATCH] kvm: fix poison overwritten caused by using ...
Feel free to add my ack.
--
Sent from my mobile phone. Please pardon any lack of formatting.
--
| Aug 15, 9:12 pm 2010 |
| Daniel Kiper | Re: [PATCH] GSoC 2010 - Memory hotplug support for Xen g ...
Hi,
I took all relevant addresses (sorry if I missed somebody) from MAINTAINERS
Small reminder: make CONFIG_DEBUG_SECTION_MISMATCH=y
I reviewed kernel source code once again. It is OK. Normaly it is
not allowed to reference code/data tagged as .init.* because
that sections are freed at the end of kernel boot sequence and
they do not exists any more in memory. However it is sometimes
required to use code/data marked .init.*. To allow that __ref
tag is used and then referenced objects ...
| Aug 16, 8:44 am 2010 |
| Paul E. McKenney | Re: mmotm 2010-08-11 - RCU whinge during very early boot
Hello, Valdis!
Interesting! My first thought was that this is a false positive, given
that lockdep_is_held(&task_rq(p)->lock) is one of the arguments to
task_subsys_state_check() and thus to rcu_dereference_check(). However...
Given the "lockdep: fixing up alternatives" above, we know that cpu==1,
and that the code is running on CPU 0.
So init_idle() acquires the specified CPU's runqueue lock:
struct rq *rq = cpu_rq(cpu);
...
raw_spin_lock_irqsave(&rq->lock, flags);
Then ...
| Aug 16, 10:23 am 2010 |
| Jeff Moyer | Re: [PATCH 1/5] cfq-iosched: Do not idle if slice_idle=0
Hm, I submitted a similar patch that was supposed to make .35. Oh well,
--
| Aug 16, 11:37 am 2010 |
| Jeff Moyer | Aug 16, 11:53 am 2010 | |
| Jeff Moyer | Aug 16, 11:45 am 2010 | |
| Jeff Moyer | Re: [PATCH 5/5] cfq-iosched: Documentation help for new ...
In general, I've resisted the urge to correct grammar. Comments below.
'seeky' is not a property of the media. I think you meant on storage
I'm not sure we need documentation of this tunable twice. Why not just
give guidance on when it should be set to 0 in the next section
supported.
Looks like something is amiss. Your text was truncated somewhere.
Cheers,
Jeff
--
| Aug 16, 12:00 pm 2010 |
| Helge Deller | Re: [PATCH][RFC] Fix up rss/swap usage of shm segments i ...
Hugh, thanks for the good and comprehensive summary!
Seems that I have to live with the /proc/sysvipc/shm overview then :-(
Thanks,
Helge
--
| Aug 16, 1:21 pm 2010 |
| Jiri Kosina | Re: [PATCH] paravirt: noreplace-paravirt is implemented ...
Thanks. As I haven't found the patch in linux-next as of today, I'll be
taking it through trivial queue.
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
| Aug 16, 6:04 am 2010 |
| Jeremy Fitzhardinge | Re: [PATCH] paravirt: noreplace-paravirt is implemented ...
Yes, thanks. I didn't pick it up.
J
--
| Aug 16, 12:40 pm 2010 |
| Moffett, Kyle D | Re: [PATCH 2/2] platform: Facilitate the creation of pse ...
Hmm...
To me this seems like a really painful implementation of what the OpenFirmware-esque "Flattened Device Tree" does on many embedded systems.
For example, to build an equivalent device tree using an OpenFirmware FDT file, I'd just use this:
/dts-v1/;
/ {
#address-cells = <1>;
#size-cells = <1>;
[...snip...]
soc-bus-1@fc000000 {
/* of_platform driver matches against this: */
compatible = "my-company-name,soc-bus-type";
/* Define base address and size of the bus ...
| Aug 15, 6:38 pm 2010 |
| Grant Likely | Re: [PATCH 2/2] platform: Facilitate the creation of pse ...
Patrick and Kevin have been trying to solve a different problem. The
FDT is really good at describing the topology and interconnections of
the system, but it doesn't solve the problem of how the different bus
behaviour is implemented in the kernel. They need a method of
registering devices that have subtly different behaviour from the
plain-vanilla platform bus. Whether or not the device data originates
from the FDT is irrelevant, and the problem remains the same.
I'm not convinced (yet) ...
| Aug 15, 11:43 pm 2010 |
| Patrick Pannuto | Re: [PATCH 2/2] platform: Facilitate the creation of pse ...
Yes, this makes sense. Originally, I was trying to avoid this due
to a misguided notion of backwards compatibility - namely that
devices could register themselves conditionally via
.bus = HAVE_FOO_BUS,
and always call the same platform_[device|driver]_register, but
thinking about this more, such a compile (or run)-time decision can
just as easily be made in the foo_[device|driver]_register. The
impact on legacy code is the same either way, but your suggested
interface is much ...
| Aug 16, 11:47 am 2010 |
| Grant Likely | Re: [PATCH 2/2] platform: Facilitate the creation of pse ...
On Mon, Aug 16, 2010 at 12:47 PM, Patrick Pannuto
Actually, I also made a kerneldoc style error here because the braces
are missing. This should be:
+/**
+ * pseudo_platform_bus_register() - register an "almost platform bus"
See Documentation/kernel-doc-nano-HOWTO.txt for details.
I'm also not fond of the "pseudo" name. It isn't really a pseudo bus,
but rather a different bus type that happens to inherit most of the
platform_bus infrastructure. It may be better just to expose ...
| Aug 16, 1:25 pm 2010 |
| MichaÅ MirosÅaw | Re: [PATCH 2/2] platform: Facilitate the creation of pse ...
Actually you can do:
const struct dev_pm_ops test = {
DEFAULT_PLATFORM_PM_OPS,
.prepare = my_func,
...
};
where:
#define DEFAULT_PLATFORM_PM_OPS \
.prepare = platform_pm_prepare, \
.complete = platform_pm_complete, \
...
In case of repeated field assignments, gcc uses the last value (as per
http://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html).
Best Regards,
Michał Mirosław
--
| Aug 16, 4:58 pm 2010 |
| Krzysztof Halasa | Re: ARM: 2.6.3[45] PCI regression (IXP4xx and PXA?)
Hi,
This patch fixes the problem on my IXP425.
--
Krzysztof Halasa
--
| Aug 16, 4:29 pm 2010 |
| Konrad Rzeszutek Wilk | Re: [PATCH v4] arm: msm: Add MSM IOMMU support.
Does it make sense to define say:
#define MASK_XX (x) x & 0xFFFFFC00
and
#define MASK_XY (x) x & 0xFFFF0000
Hmm, PAGE_SHIFT can't be used? Or some other #define?
--
| Aug 16, 11:32 am 2010 |
| Christoph Lameter | Re: [PATCH 0/9] Hugepage migration (v2)
With a single page there is the check of the refcount during migration
after all the references have been removed (at that point the page is no
longer mapped by any process and direct iO can no longer be
initiated without a page fault.
I see that you are running try_to_unmap() from unmap_and_move_huge_page().
I dont see a patch adding huge page support to try_to_unmap though. How
does this work?
--
| Aug 16, 5:19 am 2010 |
| Naoya Horiguchi | Re: [RFC] [PATCH 2/4] dio: add page locking for direct I/O
Hi,
Here is the result of my direct I/O benchmarck, which mesures the time
it takes to do direct I/O for 20000 pages on 2MB buffer for four types
of I/O. Each I/O is issued for one page unit and each number below is
the average of 25 runs.
with patchset 2.6.35-rc3
Buffer I/O type average(s) STD(s) average(s) STD(s) diff(s)
hugepage Sequential Read 3.87 0.16 3.88 0.20 -0.01
Sequential ...
| Aug 15, 7:07 pm 2010 |
| Naoya Horiguchi | Re: [PATCH 0/9] Hugepage migration (v2)
In my understanding, in current code "other processors increasing refcount
during migration" can happen both in non-hugepage direct I/O and in hugepage
direct I/O in the similar way (i.e. get_user_pages_fast() from dio_refill_pages()).
So I think there is no specific problem to hugepage.
Yes.
Thanks,
Naoya Horiguchi
--
| Aug 16, 2:19 am 2010 |
| Andi Kleen | Re: [RFC] [PATCH 2/4] dio: add page locking for direct I/O
I would try it with some of the fio workfiles that use O_DIRECT,
especially the parallel ones. Perhaps people can share their favourite one.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
| Aug 16, 12:21 am 2010 |
| Jeff Moyer | Re: [RFC] [PATCH 2/4] dio: add page locking for direct I/O
Well, as distasteful as this sounds, I think a benchmark that does I/O
to partial pages would show the problem best. And yes, this does happen
in the real world. ;-) So, sequential 512 byte or 1k or 2k I/Os, or
just misalign larger I/Os so that two sequential I/Os will hit the same
page.
I believe you can use fio to generate such a workload; see iomem_align
in the man page. Something like the below *might* work. If not, then
simply changing the bs=4k to bs=2k and getting rid of ...
| Aug 16, 6:20 am 2010 |
| Paul E. McKenney | Re: [PATCH tip/core/rcu 09/10] rcu: update obsolete rcu_ ...
Thank you for looking this over!
I am updating the srcu_read_lock() docbook comments to call out the
potential for this problem, given that SRCU read-side critical sections
can acquire mutexes, which can be held across both synchronize_srcu()
and synchronize_srcu_expedited().
Seem reasonable?
Thanx, Paul
diff --git a/include/linux/srcu.h b/include/linux/srcu.h
index 6f456a7..58971e8 100644
--- a/include/linux/srcu.h
+++ b/include/linux/srcu.h
@@ -139,7 +139,12 @@ static ...
| Aug 16, 10:55 am 2010 |
| Mathieu Desnoyers | Re: [PATCH tip/core/rcu 08/10] rcu: Add a TINY_PREEMPT_RCU
Hrm, --t->rcu_read_lock_nesting does not have any globally visible
side-effect, so the compiler is free to reorder the memory access across
the rcu_read_unlock_special access. I think we need the ACCESS_ONCE()
This seem to work because we have:
volatile access (read/update t->rcu_read_lock_nesting)
&& (sequence point)
volatile access (t->rcu_read_unlock_special)
The C standard seems to forbid reordering of volatile accesses across
sequence points, so this should be fine. But it would ...
| Aug 16, 12:19 pm 2010 |
| Mathieu Desnoyers | Re: [PATCH tip/core/rcu 08/10] rcu: Add a TINY_PREEMPT_RCU
* Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote:
Hrm I think we discussed this in a past life, but would the following
sequence be possible and correct ?
CPU 0
read t->rcu_read_unlock_special
interrupt comes in, preempts. sets t->rcu_read_unlock_special
<preempted>
<scheduled back>
iret
decrement and read t->rcu_read_lock_nesting
test both old "special" value (which we have locally on the stack) and
detect that rcu_read_lock_nesting is 0.
We actually missed a ...
| Aug 16, 8:07 am 2010 |
| Paul E. McKenney | Re: [PATCH tip/core/rcu 08/10] rcu: Add a TINY_PREEMPT_RCU
Indeed, it is free to reorder that access. This has the effect of
extending the scope of the RCU read-side critical section, which is
I should probably review commenting globally, and this might be one
Long ago on the first RCU priority-boosting implementation I tried doing
the rcu_read_unlock() by hand. The unhappy lessons learned caused me
to just use rcu_read_unlock() when I encountered similar situations
later on. ;-)
Thanx, Paul
--
| Aug 16, 2:32 pm 2010 |
| Mathieu Desnoyers | Re: [PATCH tip/core/rcu 08/10] rcu: Add a TINY_PREEMPT_RCU
Hrm, I'm not quite convinced yet. I am not concerned about gcc moving
the volatile access prior to the sequence point (as you say, this is
forbidden by the C standard), but rather that:
--(t->rcu_read_lock_nesting)
could be split in two distinct operations:
read t->rcu_read_lock_nesting
decrement t->rcu_read_lock_nesting
Note that in order to know the result required to pass the sequence
point "&&" (the test), we only need to perform the read, not the
decrement. AFAIU, gcc would be in ...
| Aug 16, 3:07 pm 2010 |
| Mathieu Desnoyers | Re: [PATCH tip/core/rcu 09/10] rcu: update obsolete rcu_ ...
It might be good to add a note about locking chain dependency that is
created in the RT case, e.g., the lock we are sharing with another
context in preempt RT is subject to the same rules as the RCU C.S.. It
should never call synchronize_rcu(); this would cause a RCU+lock-induced
deadlock.
I must admit, however, that because calling synchronize_rcu() from
spinlocks is already forbidden, this is already implied.
Thanks,
--
Mathieu Desnoyers
Operating System Efficiency R&D ...
| Aug 16, 7:45 am 2010 |
| Paul E. McKenney | Re: [PATCH tip/core/rcu 08/10] rcu: Add a TINY_PREEMPT_RCU
I will run this by some compiler experts.
Thanx, Paul
--
| Aug 16, 3:24 pm 2010 |
| Paul E. McKenney | Re: [PATCH tip/core/rcu 08/10] rcu: Add a TINY_PREEMPT_RCU
You are correct -- I got too aggressive in eliminating synchronization.
Good catch!!!
I added an ACCESS_ONCE() to the second term of the "if" condition so
that it now reads:
if (--t->rcu_read_lock_nesting == 0 &&
unlikely((ACCESS_ONCE(t->rcu_read_unlock_special)))
This prevents the compiler from reordering because the ACCESS_ONCE()
prohibits accessing t->rcu_read_unlock_special unless the value of
The version of __rcu_read_unlock() in kernel/rcutree_plugin.h is ...
| Aug 16, 11:33 am 2010 |
| Mathieu Desnoyers | Re: [PATCH tip/core/rcu 09/10] rcu: update obsolete rcu_ ...
Yep, thanks!
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
| Aug 16, 11:24 am 2010 |
| Mathieu Desnoyers | Re: [PATCH tip/core/rcu 08/10] rcu: Add a TINY_PREEMPT_RCU
So what happens if we get:
CPU 0
read t->rcu_read_lock_nesting
check if equals to 1
read t->rcu_read_unlock_special
interrupt comes in, preempts. sets t->rcu_read_unlock_special
<preempted>
<scheduled back>
iret
decrement t->rcu_read_lock_nesting
test rcu_read_unlock_special value (read prior to interrupt)
-> fails to notice the preemption that came in after the
rcu_read_unlock_special read.
Thanks,
Mathieu
--
Mathieu Desnoyers
Operating System Efficiency R&D ...
| Aug 16, 2:41 pm 2010 |
| Paul E. McKenney | Re: [PATCH tip/core/rcu 08/10] rcu: Add a TINY_PREEMPT_RCU
Moving this down past the check of t->rcu_read_lock_special (which is
now covered by ACCESS_ONCE()) would violate the C standard, as it would
be equivalent to moving a volatile up past a sequence point.
--
| Aug 16, 2:55 pm 2010 |
| Nathan Fontenot | Re: [PATCH 0/8] v5 De-couple sysfs memory directories fr ...
Yes, those hours are spent creating the sysfs directories for each
This shouldn't break existing installations, unless an architecture chooses
to do so. With my patch only the powerpc/pseries arch is updated such that
what is seen in userspace is different.
The default behavior is maintained for all architectures unless they define
their own version of memory_block_size_bytes(). The default definition of
this routine (defined as __weak in Patch 5/8) sets the memory block size
to the same ...
| Aug 16, 7:34 am 2010 |
| Paul E. McKenney | Re: 2.6.35 - INFO: kernel/exit.c:1387 invoked rcu_derefe ...
Hello, Miles!
Could you please try David Howells's patch? It may be found at:
http://lkml.org/lkml/2010/8/16/333
It should address this one.
--
| Aug 16, 3:57 pm 2010 |
| Miles Lane | Re: 2.6.35 - INFO: kernel/exit.c:1387 invoked rcu_derefe ...
Hi Paul and friends,
Now in 2.6.36-rc1:
[ 7.295797] ===================================================
[ 7.295801] [ INFO: suspicious rcu_dereference_check() usage. ]
[ 7.295805] ---------------------------------------------------
[ 7.295810] kernel/exit.c:1390 invoked rcu_dereference_check()
without protection!
[ 7.295813]
[ 7.295814] other info that might help us debug this:
[ 7.295816]
[ 7.295819]
[ 7.295820] rcu_scheduler_active = 1, debug_locks = 1
[ ...
| Aug 16, 3:37 pm 2010 |
| Dmitry Eremin-Solenikov | Re: [PATCH 1/2] tty: add tty_struct->dev pointer to corr ...
Hello,
Greg, what about these two patches? Can I expect for them to be pulled
into your patch queue for 2.6.37?
--
With best wishes
Dmitry
--
| Aug 16, 3:57 am 2010 |
| Greg KH | Re: [PATCH 1/2] tty: add tty_struct->dev pointer to corr ...
Yes, I will queue them up to my -next branch soon and will go to Linus
for .37.
thanks,
greg k-h
--
| Aug 16, 8:01 am 2010 |
| Gururaja Hebbar K R | RE: Query: Patches break with Microsoft exchange server.
Hi,
Hope this helps
http://support.microsoft.com/?id=823921
Regards
--
| Aug 15, 6:02 pm 2010 |
| David Miller | Re: [PATCH 2/3] sparc: make driver/of/pdt no longer spar ...
From: Andres Salomon <dilinger@queued.net>
We could put just phandle into linux/types.h
--
| Aug 15, 11:17 pm 2010 |
| Andres Salomon | Re: [PATCH 2/3] sparc: make driver/of/pdt no longer spar ...
On Sun, 08 Aug 2010 22:34:44 -0700 (PDT)
You're saying to convert the sparc code to use phandles? Doing so has
caused phandles to show up in asm/openprom.h (linux_dev_v2_funcs's
v2_inst2pkg returns a phandle, and linux_nodeops use phandles). This
is fine, except asm/openprom.h is an exported kernel header, and
linux/of.h is not.
I'm tempted to break the phandle/device_node/property stuff out into a
separate header (that gets exported), and include that from linux/of.h
and ...
| Aug 15, 9:22 pm 2010 |
| Stephen Rothwell | [PATCH] spi: update for of_device to platform_device rep ...
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/ata/sata_dwc_460ex.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Hi Grant,
This patch now is needed in Linus' tree. I will add it to my fixes tree
for today. Linus, can you take this, please?
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index ea24c1e..2673a3d 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -1588,7 +1588,7 @@ static const ...
| Aug 15, 7:20 pm 2010 |
| Grant Likely | Re: [PATCH] spi: update for of_device to platform_device ...
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--
| Aug 15, 10:22 pm 2010 |
| Grant Likely | Re: [PATCH] spi: update for of_device to platform_device ...
On Sun, Aug 15, 2010 at 11:22 PM, Grant Likely
Linus, I'm collecting a number of OF-related fixup patches anyway, so
I'll pick this up into my tree, make sure I haven't broken anything,
and send you a pull req this afternoon.
Cheers,
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
| Aug 16, 2:19 pm 2010 |
| Steffen Klassert | Re: [PATCH resend] padata: add missing __percpu markup i ...
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Thanks,
Steffen
--
| Aug 16, 12:13 am 2010 |
| Andreas Gruenbacher | Re: [GIT PULL] notification tree - try 37!
Oh yes.
This introduces two new syscalls which will be impossible to fix up after the
fact, and those system calls are poorly documented: commits 2a3edf86 and
52c923dd document the initial versions (in the commit message!), but
subsequent commits then extend that interface. The interface for replying to
events is not documented at all beyond the example code [1]. There is no
documentation in Documentation/filesystems/, either.
[1] http://people.redhat.com/~eparis/fanotify/
Q: ...
| Aug 16, 1:32 pm 2010 |
| David Woodhouse | Re: [GIT PULL] block/IO bits for 2.6.36-rc1
Hm? I do that whenever you pull from me -- I'll pull the merge commit
into my own tree. So the mtd-2.6.git tree you pulled last night, for
example, was based on some "random daily thing" half-way between 2.6.35
and 2.6.26-rc1, which happened to be entitled 'Merge git://...mtd-2.6'.
I try to avoid having to *merge* such a thing, but it certainly does end
up in linux-next as the *base* for maintainers' tree. It's difficult to
see how that could be avoided.
--
David Woodhouse ...
| Aug 16, 1:48 pm 2010 |
| tip-bot for Mike Fry ... | [tip:perf/urgent] tracing: Extend recordmcount to better ...
Commit-ID: 465c6cca2668a2db2a4ffce3dca5714017873f2b
Gitweb: http://git.kernel.org/tip/465c6cca2668a2db2a4ffce3dca5714017873f2b
Author: Mike Frysinger <vapier@gentoo.org>
AuthorDate: Fri, 6 Aug 2010 03:26:24 -0400
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Thu, 12 Aug 2010 10:06:51 -0400
tracing: Extend recordmcount to better support Blackfin mcount
The mcount call on Blackfin systems includes some stack manipulation
around the actual call site, so extend the build ...
| Aug 16, 10:31 am 2010 |
| Robert Hancock | Re: bios kernel HD swap
Depending on the configuration the distribution has used it's likely
expected that ata_piix (which I assume is the driver in question) is
running that drive in current kernel versions. You likely need to update
your boot configuration to point to the correct device. (The kernel
device ordering is not related to what boot order you selected in the BIOS.)
--
| Aug 15, 8:27 pm 2010 |
| Shaohua Li | Re: [patch]x86: avoid unnecessary tlb flush
this name is better.
In x86, access and dirty bits are set automatically by CPU when CPU accesses
memory. When we go into the code path of below flush_tlb_fix_spurious_fault(),
we already set dirty bit for pte and don't need flush tlb. This might mean
tlb entry in some CPUs hasn't dirty bit set, but this doesn't matter. When
the CPUs do page write, they will automatically check the bit and no software
involved.
On the other hand, flush tlb in below position is harmful. Test creates ...
| Aug 15, 6:16 pm 2010 |
| Matthew Garrett | Re: [PATCH 0/5] Convert x86 platform drivers to use spar ...
I'll queue these for -next. Thanks!
--
Matthew Garrett | mjg59@srcf.ucam.org
--
| Aug 16, 8:57 am 2010 |
| Borislav Petkov | Re: [PATCH 1/2] x86-32: Fix crashes with CPU hotplug on ...
From: Borislav Petkov <bp@amd64.org>
Updated versions survived almost 48h of uninterrupted hammering, I'm
sending them as a reply to this message...
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
| Aug 16, 5:19 am 2010 |
| Borislav Petkov | [PATCH -v2 1/2] x86-32: Fix crashes with CPU hotplug on ...
From: Joerg Roedel <joerg.roedel@amd.com>
This patch fixes machine crashes which occur when heavily exercising the
CPU hotplug codepaths on a 32-bit kernel. These crashes are caused by
AMD Erratum 383 and result in a fatal machine check exception. Here's
the scenario:
1. On 32-bit, the swapper_pg_dir page table is used as the initial page
table for booting a secondary CPU.
2. To make this work, swapper_pg_dir needs a direct mapping of physical
memory in it (the low mappings). By adding ...
| Aug 16, 5:38 am 2010 |
| Borislav Petkov | [PATCH -v2 2/2] x86, cpu hotplug: Fix cpu bringup concur ...
When testing cpu hotplug code on 32-bit we kept hitting the "CPU%d:
Stuck ??" message due to multiple cores concurrently accessing the
cpu_callin_mask, among others.
Since these codepaths are not protected from concurrent access due to
the fact that there's no sane reason for making an already complex
code unnecessarily more complex - we hit the issue only when insanely
switching cores off- and online - serialize hotplugging cores on the
sysfs level and be done with it.
Signed-off-by: ...
| Aug 16, 5:39 am 2010 |
| Robert Richter | Re: [PATCH -v2] perf, x86: try to handle unknown nmis wi ...
Peter, I will rip out the timestamp code from the -v2 patch. My first
patch does not deal with a 2-1-0 sequence, so it has false positives.
We do not necessarily need the timestamps if back-to-back nmis are
rare. Without using timestamps the statistically lost ratio for
unknown nmis will be as the ratio for back-to-back nmis, with
timestamps we could catch almost every unknown nmi. So if we encounter
As said, I think with timestamps we could be able to detect 100% of
the unknown nmis. I guess ...
| Aug 16, 10:16 am 2010 |
| Robert Richter | Re: [PATCH -v2] perf, x86: try to handle unknown nmis wi ...
Yes, that's true, but before you have to enable your Infinite
Improbability Drive.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
--
| Aug 16, 3:55 pm 2010 |
| Peter Zijlstra | Re: [PATCH -v2] perf, x86: try to handle unknown nmis wi ...
I liked the one without funny timestamps in better, the whole timestamps
thing just feels too fragile.
Relying on handled > 1 to arm the back-to-back filter seems doable.
(Also, you didn't deal with the TSC going backwards..)
--
| Aug 16, 7:48 am 2010 |
| Cyrill Gorcunov | Re: [PATCH -v2] perf, x86: try to handle unknown nmis wi ...
On Mon, Aug 16, 2010 at 04:48:36PM +0200, Peter Zijlstra wrote:
Me too, the former Roberts patch (if I'm not missing something) looks good
It's doable _but_ I think there is nothing we can do, there is no
way (at least I known of) to check if there is latched nmi from
perf counters. We only can assume that if there multiple counters
overflowed most probably the next unknown nmi has the same nature,
ie it came from perf. Yes, we can loose real unknown nmi in this
case but I think this is ...
| Aug 16, 9:27 am 2010 |
| Peter Zijlstra | Re: [PATCH] perf, x86: try to handle unknown nmis with r ...
Long running SMIs aren't nearly as rare as you'd want them to be.
Hitting one in exactly the right spot will be, but given the numbers its
going to happen and make us scratch our heads..
--
| Aug 16, 7:37 am 2010 |
| Robert Richter | Re: [PATCH -v2] perf, x86: try to handle unknown nmis wi ...
You put load on all cpus and then start something like the following:
perf record -e cycles -e instructions -e cache-references \
-e cache-misses -e branch-misses -a -- sleep 10
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
--
| Aug 16, 12:37 am 2010 |
| Cyrill Gorcunov | Re: [PATCH -v2] perf, x86: try to handle unknown nmis wi ...
Robert, I think we still may miss unknown irq, consider the case when
unknown nmi is latched while you handle nmi from perf and what is
more interesting several counters may be overflowed. So you set
delta small enough and second (unknown nmi) will be in range and
-- Cyrill
--
| Aug 16, 12:06 pm 2010 |
| Cyrill Gorcunov | Re: [PATCH -v2] perf, x86: try to handle unknown nmis wi ...
ok, good to know, thanks!
-- Cyrill
--
| Aug 16, 12:18 pm 2010 |
| Peter Zijlstra | Re: [PATCH -v2] perf, x86: try to handle unknown nmis wi ...
Its not supposed to happen, but then there's BIOS failure-add that frobs
the TSC from SMIs and fun TSC artifacts around CPU frequency changes and
people resetting TSC in S-states etc..
In short, never trust the TSC to be even remotely sane.
--
| Aug 16, 12:13 pm 2010 |
| Tim Pepper | Re: [PATCH] kvm: make mmu_shrink() fit shrinker's requirement
Dave's out on vacation now so it's probably best to assume he wont get
those fixups done very quickly. Marcelo's comment on patch 3 is
simple. The conversation regarding patch 4 back in June though
doesn't read like it clearly concluded...I'd be happy to work
something up, but if you've got strong preferences on which route to
use for protecting the count maybe I should leave it to you?
Tim
--
| Aug 16, 4:55 pm 2010 |
| Xiao Guangrong | Re: [PATCH v6 3/3] KVM: MMU: prefetch ptes when intercep ...
Hi Marcelo,
Thanks for your review and sorry for the delay reply.
We disable prefetch the writable pages since 'pte prefetch' will hurt slot's
dirty page tracking that it set the dirty_bitmap bit but the corresponding page
Since it should disable 'prefetch' for the writable pages, so i'm not put these
operations into a common function and define it in kvm_main.c file.
OK, i'll separate it.
--
| Aug 15, 6:37 pm 2010 |
| Marcelo Tosatti | Re: [PATCH v6 3/3] KVM: MMU: prefetch ptes when intercep ...
Yes, please have it as a common function in kvm_main.c.
--
| Aug 16, 8:43 am 2010 |
| Bartlomiej Zolnierki ... | Re: [patch] pata_winbond: fix module init
Hi Dan,
You might like to pick up
http://patchwork.ozlabs.org/patch/39358/
instead..
Thanks.
--
Bartlomiej Zolnierkiewicz
--
| Aug 16, 12:23 pm 2010 |
| Matthew Garrett | Re: Attempted summary of suspend-blockers LKML thread, t ...
Really? I thought the TSC stopped in suspend. Does having a package go
into C6 mean that the RAM goes into self-refresh?
--
Matthew Garrett | mjg59@srcf.ucam.org
--
| Aug 16, 9:09 am 2010 |
| Rafael J. Wysocki | Re: [linux-pm] Attempted summary of suspend-blockers LKM ...
In fact, we (which means basically Alan Stern and me at this point) are working
with Arve on this right now.
Thanks,
Rafael
--
| Aug 16, 2:11 pm 2010 |
| Robert Hancock | Re: Driver: PCIe: 'pci_map_sg' returning invalid bus address?
That should be safe as far as x86-32 goes - pci_alloc_consistent will
The situation kind of sucks with that combination, yes. The block and
network subsystems have their own workarounds but other drivers just
have to sort of hack something together.
--
| Aug 15, 8:31 pm 2010 |
| tip-bot for Huang Ying | [tip:perf/urgent] tracing: Fix ring_buffer_read_page rea ...
Commit-ID: 18fab912d4fa70133df164d2dcf3310be0c38c34
Gitweb: http://git.kernel.org/tip/18fab912d4fa70133df164d2dcf3310be0c38c34
Author: Huang Ying <ying.huang@intel.com>
AuthorDate: Wed, 28 Jul 2010 14:14:01 +0800
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Fri, 6 Aug 2010 14:34:45 -0400
tracing: Fix ring_buffer_read_page reading out of page boundary
With the configuration: CONFIG_DEBUG_PAGEALLOC=y and Shaohua's patch:
[PATCH]x86: make spurious_fault check correct ...
| Aug 16, 10:31 am 2010 |
| tip-bot for Marcin S ... | [tip:perf/urgent] tracing: Sanitize value returned from ...
Commit-ID: 1aa54bca6ee0d07ebcafb8ca8074b624d80724aa
Gitweb: http://git.kernel.org/tip/1aa54bca6ee0d07ebcafb8ca8074b624d80724aa
Author: Marcin Slusarz <marcin.slusarz@gmail.com>
AuthorDate: Wed, 28 Jul 2010 01:18:01 +0200
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Fri, 13 Aug 2010 15:23:16 -0400
tracing: Sanitize value returned from write(trace_marker, "...", len)
When userspace code writes non-new-line-terminated string to trace_marker
file, write handler appends ...
| Aug 16, 10:31 am 2010 |
| tip-bot for Shaohua Li | [tip:perf/urgent] tracing: Fix an unallocated memory acc ...
Commit-ID: 575570f02761bd680ba5731c1dfd4701062e7fb2
Gitweb: http://git.kernel.org/tip/575570f02761bd680ba5731c1dfd4701062e7fb2
Author: Shaohua Li <shaohua.li@intel.com>
AuthorDate: Tue, 27 Jul 2010 16:06:34 +0800
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Fri, 6 Aug 2010 12:19:15 -0400
tracing: Fix an unallocated memory access in function_graph
With CONFIG_DEBUG_PAGEALLOC, I observed an unallocated memory access in
function_graph trace. It appears we find a small ...
| Aug 16, 10:30 am 2010 |
| J. Bruce Fields | Re: [PATCH 02/18] xstat: Add a pair of system calls to m ...
I was curious whether you can support that with any data (or even just
anecdotes) about real-world sysadmins.
The NT-style ACLs give me a headache, honestly. But that may just be
because I've been involved with the implementation. Admins may have the
luxury of using only the subset that they're comfortable with.
--b.
--
| Aug 16, 11:08 am 2010 |
| Jeremy Allison | Re: [PATCH 02/18] xstat: Add a pair of system calls to m ...
Just an anecdote, but I remember giving a talk to a room full
of admins, all of whom told me it was essential for Samba to
implement "full Windows ACL compatibility" (we were in the process
of coding it up at the time). I asked them to tell me the difference
between object inherit, container inherit, and inherit only. Only
one hand remained up (out of a room containing a couple of hundred
Windows admins). I asked him where he worked, and the reply was
Yeah. I think most sites set a group as ...
| Aug 16, 12:07 pm 2010 |
| J. Bruce Fields | Re: [PATCH 02/18] xstat: Add a pair of system calls to m ...
Yeah. There's some explanation here:
http://tools.ietf.org/search/rfc5661#section-6.4.3.2
What NT-style ACLs provide is a few bits that help a setfacl-like
application decide how to propagate the change. But it's still up to
the application to do the recursive traversal.
--b.
--
| Aug 16, 11:04 am 2010 |
| Avi Kivity | Re: [patch 1/2] x86_64 page fault NMI-safe
The cache miss would not be avoided if the TLB was hit, so it should not
be accounted as part of the costs (though a TLB miss will increase cache
pressure). Also, your test does not allow the cpu to pipeline anything;
in reality, different workloads have different TLB miss costs:
- random reads (pointer chasing) incur almost the full impact since the
processor is stalled
- sequential writes can be completely pipelined and suffer almost no impact
Let's say this doubles the impact. So ...
| Aug 16, 3:49 am 2010 |
| Avi Kivity | Re: [patch 1/2] x86_64 page fault NMI-safe
Forgot to comment about the i386 issue - that really is a blocker if you
absolutely need to support large trace buffers on 32-bit machines. I
would urge all those people to move to x86_64 and be done with it, but I
don't know all the use cases.
It's possible to hack this to work by having a private mm_struct and
switching to it temporarily, but it will be horribly slow.
--
error compiling committee.c: too many arguments to function
--
| Aug 16, 4:29 am 2010 |
| Kukjin Kim | RE: [PATCH] mmc: build fix: mmc_pm_notify is only availa ...
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
| Aug 15, 10:28 pm 2010 |
| Maxim Levitsky | Re: [PATCH] mmc: build fix: mmc_pm_notify is only availa ...
Hi folks,
If you need it,
Acked-by: Maxim Levitsky <maximlevitsky@gmail.com>
Best regards,
Maxim Levitsky
--
| Aug 16, 12:51 am 2010 |
| Michal Marek | Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config
CONFIG_CROSS_COMPILE is a string option, leave it empty if you are not
cross compiling.
Michal.
--
| Aug 16, 5:40 am 2010 |
| Andrew Hendry | Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config
This gives some errors on my ubuntu build for -rc1, reverting lets it
build normally. Am I missing something?
ahendry@ubuntu:~/linux/linux-2.6$ make
make: ngcc: Command not found
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CC kernel/bounds.s
/bin/sh: ngcc: not found
make[1]: *** [kernel/bounds.s] Error 127
make: *** [prepare0] Error 2
.config has CONFIG_CROSS_COMPILE="n"
--
| Aug 16, 5:35 am 2010 |
| Andrew Hendry | Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config
Thanks Michal, can see the problem now.
Not sure how the "n" got there, i didn't set it manually.
Was at 2.6.35-rc6 then updated to 2.6.36-rc1 taking the defaults for
all the new config options that popped up.
--
| Aug 16, 5:51 am 2010 |
| Alan Ott | [PATCH v4 1/2] HID: Add Support for Setting and Getting ...
Per the HID Specification, Feature reports must be sent and received on
the Configuration endpoint (EP 0) through the Set_Report/Get_Report
interfaces. This patch adds two ioctls to hidraw to set and get feature
reports to and from the device. Modifications were made to hidraw and
usbhid.
New hidraw ioctls:
HIDIOCSFEATURE - Perform a Set_Report transfer of a Feature report.
HIDIOCGFEATURE - Perform a Get_Report transfer of a Feature report.
Signed-off-by: Alan Ott ...
| Aug 16, 1:20 pm 2010 |
| Alan Ott | [PATCH v4 2/2] Bluetooth: hidp: Add support for hidraw ...
This patch adds support or getting and setting feature reports for bluetooth
HID devices from HIDRAW.
Signed-off-by: Alan Ott <alan@signal11.us>
---
net/bluetooth/hidp/core.c | 114 +++++++++++++++++++++++++++++++++++++++++++--
net/bluetooth/hidp/hidp.h | 8 +++
2 files changed, 118 insertions(+), 4 deletions(-)
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index bfe641b..0e4880e 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -36,6 ...
| Aug 16, 1:20 pm 2010 |
| Alan Ott | [PATCH v4 0/2] Get and Set Feature Reports on HIDRAW (US ...
This is version 4. Built against 2.6.35+ revision 320b2b8de12698 .
Alan Ott (2):
HID: Add Support for Setting and Getting Feature Reports from hidraw
Bluetooth: hidp: Add support for hidraw HIDIOCGFEATURE and
HIDIOCSFEATURE
drivers/hid/hidraw.c | 105 ++++++++++++++++++++++++++++++++++++--
drivers/hid/usbhid/hid-core.c | 37 +++++++++++++-
include/linux/hid.h | 3 +
include/linux/hidraw.h | 3 +
net/bluetooth/hidp/core.c | 114 ...
| Aug 16, 1:20 pm 2010 |
| James Bottomley | RE: [PATCH 1/12] scsi: megaraid_sas - Online Controller ...
Yes, they'll go in the next merge window.
James
--
| Aug 16, 8:06 am 2010 |
| Yang, Bo | RE: [PATCH 1/12] scsi: megaraid_sas - Online Controller ...
James,
We submitted the patches on 8/11. Do you get the chances to update those patches to main tree?
Thanks,
Bo Yang
-----Original Message-----
From: Yang, Bo
Sent: Thursday, August 12, 2010 11:21 AM
To: 'James Bottomley'
Cc: Yinghai Lu; linux-scsi@vger.kernel.org; akpm@osdl.org; linux-kernel@vger.kernel.org; Maharana, Parag; Daftardar, Jayant
Subject: RE: [PATCH 1/12] scsi: megaraid_sas - Online Controller Reset - I: Enable Online Controller Reset Bit in register related ...
| Aug 16, 7:22 am 2010 |
| Hemanth V | RE: [RFC] [PATCH V2 1/2] input: CMA3000 Accelerometer driver
I belive this is already discussed and agreed upon in the previous thread of discussion.
Its the user space code that can modify the grange if required, so I suppose it will need to check
Are u sure u are referring to threaded irq, all the processing is being done in thread
This is currently not implemented, since I am not aware of any boards with this configuration. A polling method could be added
in future if the need arises.
--
| Aug 16, 2:45 am 2010 |
| Darrick J. Wong | Re: [RFC v3] ext4: Combine barrier requests coming from fsync
Indeed it does! The barrier count increases to about 21000, but I also see
much higher throughput, about 830 transactions per second (versus 12000 and 760
respectively before Tejun's patch).
--D
--
| Aug 16, 9:14 am 2010 |
| Serge Belyshev | Re: [PATCH 23/42] KVM: Activate Virtualization On Demand
I tested a bit different hack keeping rdmsrl but removing the if() and
it works fine for me:
Index: linux/arch/x86/kvm/svm.c
===================================================================
--- linux.orig/arch/x86/kvm/svm.c
+++ linux/arch/x86/kvm/svm.c
@@ -429,8 +429,7 @@ static int svm_hardware_enable(void *gar
int me = raw_smp_processor_id();
rdmsrl(MSR_EFER, efer);
- if (efer & EFER_SVME)
- return -EBUSY;
+ printk(KERN_DEBUG "svm_hardware_enable: efer %x on %d\n", efer, ...
| Aug 16, 6:49 am 2010 |
| Alexander Graf | Re: [PATCH 23/42] KVM: Activate Virtualization On Demand
Happy broken BIOS fun. Oh well, I guess you can live with the patched version and normal end-users will just update their BIOSes.
Alex
--
| Aug 16, 7:13 am 2010 |
| Alexander Graf | Re: [PATCH 23/42] KVM: Activate Virtualization On Demand
Hrm - try to use the following (probably whitespace broken and 100% untested) hacky patch:
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 56c9b6b..bde9ee3 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -429,9 +429,11 @@ static int svm_hardware_enable(void *garbage)
struct desc_struct *gdt;
int me = raw_smp_processor_id();
+#if 0
rdmsrl(MSR_EFER, efer);
if (efer & EFER_SVME)
return -EBUSY;
+#endif
if ...
| Aug 16, 6:24 am 2010 |
| previous day | today | next day |
|---|---|---|
| August 15, 2010 | August 16, 2010 | August 17, 2010 |
