[RFC PATCH 1/6] perf: Drop unappropriate tests on arch callchains

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Frederic Weisbecker
Date: Monday, August 16, 2010 - 1:48 pm

Drop the TASK_RUNNING test on user tasks for callchains as
this check doesn't seem to make any sense.

Also remove the tests for !current that is not supposed to
happen and current->pid as this should be handled at the
generic level, with exclude_idle attribute.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: David Miller <davem@davemloft.net>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Borislav Petkov <bp@amd64.org>
---
 arch/arm/kernel/perf_event.c     |    6 ------
 arch/sh/kernel/perf_callchain.c  |    3 ---
 arch/x86/kernel/cpu/perf_event.c |    3 ---
 3 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
index 417c392..fdcb0be 100644
--- a/arch/arm/kernel/perf_event.c
+++ b/arch/arm/kernel/perf_event.c
@@ -3107,12 +3107,6 @@ perf_do_callchain(struct pt_regs *regs,
 
 	is_user = user_mode(regs);
 
-	if (!current || !current->pid)
-		return;
-
-	if (is_user && current->state != TASK_RUNNING)
-		return;
-
 	if (!is_user)
 		perf_callchain_kernel(regs, entry);
 
diff --git a/arch/sh/kernel/perf_callchain.c b/arch/sh/kernel/perf_callchain.c
index a9dd3ab..1d6dbce 100644
--- a/arch/sh/kernel/perf_callchain.c
+++ b/arch/sh/kernel/perf_callchain.c
@@ -68,9 +68,6 @@ perf_do_callchain(struct pt_regs *regs, struct perf_callchain_entry *entry)
 
 	is_user = user_mode(regs);
 
-	if (is_user && current->state != TASK_RUNNING)
-		return;
-
 	/*
 	 * Only the kernel side is implemented for now.
 	 */
diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c
index f2da20f..4a4d191 100644
--- a/arch/x86/kernel/cpu/perf_event.c
+++ b/arch/x86/kernel/cpu/perf_event.c
@@ -1703,9 +1703,6 @@ perf_do_callchain(struct pt_regs *regs, struct perf_callchain_entry *entry)
 
 	is_user = user_mode(regs);
 
-	if (is_user && current->state != TASK_RUNNING)
-		return;
-
 	if (!is_user)
 		perf_callchain_kernel(regs, entry);
 
-- 
1.6.2.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC PATCH 0/0 v3] callchain fixes and cleanups , Frederic Weisbecker, (Mon Aug 16, 1:48 pm)
[RFC PATCH 1/6] perf: Drop unappropriate tests on arch cal ..., Frederic Weisbecker, (Mon Aug 16, 1:48 pm)
[RFC PATCH 2/6] perf: Generalize callchain_store(), Frederic Weisbecker, (Mon Aug 16, 1:48 pm)
[RFC PATCH 3/6] perf: Generalize some arch callchain code, Frederic Weisbecker, (Mon Aug 16, 1:48 pm)
[RFC PATCH 4/6] perf: Factorize callchain context handling, Frederic Weisbecker, (Mon Aug 16, 1:48 pm)
[RFC PATCH 5/6] perf: Fix race in callchains, Frederic Weisbecker, (Mon Aug 16, 1:48 pm)
[RFC PATCH 6/6] perf: Humanize the number of contexts, Frederic Weisbecker, (Mon Aug 16, 1:48 pm)
[RFC PATCH 5/6 v4] perf: Fix race in callchains, Frederic Weisbecker, (Mon Aug 16, 6:34 pm)
Re: [RFC PATCH 2/6] perf: Generalize callchain_store(), Paul Mackerras, (Mon Aug 16, 9:37 pm)
Re: [RFC PATCH 5/6 v4] perf: Fix race in callchains, Paul Mackerras, (Mon Aug 16, 9:53 pm)
Re: [RFC PATCH 0/0 v3] callchain fixes and cleanups, Borislav Petkov, (Mon Aug 16, 9:58 pm)
Re: [RFC PATCH 0/0 v3] callchain fixes and cleanups, Will Deacon, (Tue Aug 17, 3:32 am)
Re: [RFC PATCH 5/6 v4] perf: Fix race in callchains, Frederic Weisbecker, (Tue Aug 17, 8:49 pm)
Re: [RFC PATCH 3/6] perf: Generalize some arch callchain code, Frederic Weisbecker, (Tue Aug 17, 8:51 pm)
Re: [RFC PATCH 0/0 v3] callchain fixes and cleanups, Frederic Weisbecker, (Tue Aug 17, 8:53 pm)
Re: [RFC PATCH 0/0 v3] callchain fixes and cleanups, Frederic Weisbecker, (Tue Aug 17, 8:55 pm)
Re: [RFC PATCH 0/0 v3] callchain fixes and cleanups, Will Deacon, (Wed Aug 18, 2:08 am)
Re: [RFC PATCH 0/0 v3] callchain fixes and cleanups, Ingo Molnar, (Wed Aug 18, 9:15 am)