[PATCH] spi: update for of_device to platform_device replacement

Previous thread: [PATCH] staging: Pushdown bkl to easycap ioctl handlers by Frederic Weisbecker on Sunday, August 8, 2010 - 6:45 pm. (1 message)

Next thread: Re: [net-2.6 PATCH v2 1/2] igb.txt: Add igb documentation by David Miller on Sunday, August 8, 2010 - 8:03 pm. (1 message)
From: Stephen Rothwell
Date: Sunday, August 8, 2010 - 7:05 pm

Hi Grant,

Today's linux-next merge of the spi tree got a conflict in
drivers/spi/mpc512x_psc_spi.c between commit
2dc11581376829303b98eadb2de253bee065a56a ("of/device: Replace struct
of_device with struct platform_device") from the devicetree tree and
commit cf40f082f8d3a98e28af02af20d00d2500eb6a65 ("spi/mpc5121: change
annotations for probe and remove functions") from the spi tree.

I fixed it up (as suggested by you - see below) and can carry the fix as
necessary.

I also added this merge fix patch (as suggest by you):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 9 Aug 2010 12:02:19 +1000
Subject: [PATCH] spi: update for of_device to platform_device replacement

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/ata/sata_dwc_460ex.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index ea24c1e..2673a3d 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -1588,7 +1588,7 @@ static const struct ata_port_info sata_dwc_port_info[] = {
 	},
 };
 
-static int sata_dwc_probe(struct of_device *ofdev,
+static int sata_dwc_probe(struct platform_device *ofdev,
 			const struct of_device_id *match)
 {
 	struct sata_dwc_device *hsdev;
@@ -1702,7 +1702,7 @@ error_out:
 	return err;
 }
 
-static int sata_dwc_remove(struct of_device *ofdev)
+static int sata_dwc_remove(struct platform_device *ofdev)
 {
 	struct device *dev = &ofdev->dev;
 	struct ata_host *host = dev_get_drvdata(dev);
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc drivers/spi/mpc512x_psc_spi.c
index cddbfce,c8d69fc..0000000
--- a/drivers/spi/mpc512x_psc_spi.c
+++ b/drivers/spi/mpc512x_psc_spi.c
@@@ -507,8 -505,8 +507,8 @@@ static int __devexit mpc512x_psc_spi_do
  	return 0;
  }
  
- static int __init mpc512x_psc_spi_of_probe(struct platform_device *op,
 -static int __devinit mpc512x_psc_spi_of_probe(struct ...
From: Grant Likely
Date: Sunday, August 8, 2010 - 7:59 pm

Thanks Stephen.


-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--

From: Stephen Rothwell
Date: Sunday, August 15, 2010 - 7:20 pm

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/ata/sata_dwc_460ex.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Hi Grant,


This patch now is needed in Linus' tree.  I will add it to my fixes tree
for today.  Linus, can you take this, please?

diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index ea24c1e..2673a3d 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -1588,7 +1588,7 @@ static const struct ata_port_info sata_dwc_port_info[] = {
 	},
 };
 
-static int sata_dwc_probe(struct of_device *ofdev,
+static int sata_dwc_probe(struct platform_device *ofdev,
 			const struct of_device_id *match)
 {
 	struct sata_dwc_device *hsdev;
@@ -1702,7 +1702,7 @@ error_out:
 	return err;
 }
 
-static int sata_dwc_remove(struct of_device *ofdev)
+static int sata_dwc_remove(struct platform_device *ofdev)
 {
 	struct device *dev = &ofdev->dev;
 	struct ata_host *host = dev_get_drvdata(dev);
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
--

From: Grant Likely
Date: Sunday, August 15, 2010 - 10:22 pm

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--

From: Grant Likely
Date: Monday, August 16, 2010 - 2:19 pm

On Sun, Aug 15, 2010 at 11:22 PM, Grant Likely

Linus, I'm collecting a number of OF-related fixup patches anyway, so
I'll pick this up into my tree, make sure I haven't broken anything,
and send you a pull req this afternoon.

Cheers,



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--

Previous thread: [PATCH] staging: Pushdown bkl to easycap ioctl handlers by Frederic Weisbecker on Sunday, August 8, 2010 - 6:45 pm. (1 message)

Next thread: Re: [net-2.6 PATCH v2 1/2] igb.txt: Add igb documentation by David Miller on Sunday, August 8, 2010 - 8:03 pm. (1 message)