Home » Mailing list archives » linux-kernel » 2010 » August » 14

Re: [patch] regulator/ab8500: move dereference below the check for NULL

Previous thread: [patch] dma/shdma: move dereference below the NULL check by Dan Carpenter on Saturday, August 14, 2010 - 2:01 am. (2 messages)

Next thread: [PATCH] fix ARCH_IXP4XX compile error by FUJITA Tomonori on Saturday, August 14, 2010 - 2:30 am. (1 message)
[view original message]
From: Dan Carpenter
Subject: [patch] regulator/ab8500: move dereference below the check for NULL
Date: Saturday, August 14, 2010 - 2:03 am

I moved the dereference of "ab8500" below the check for NULL.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index dc3f1a4..cc7cbaf 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -344,13 +344,14 @@ static inline struct ab8500_regulator_info *find_regulator_info(int id)
 static __devinit int ab8500_regulator_probe(struct platform_device *pdev)
 {
 	struct ab8500 *ab8500 = dev_get_drvdata(pdev->dev.parent);
-	struct ab8500_platform_data *pdata = dev_get_platdata(ab8500->dev);
+	struct ab8500_platform_data *pdata;
 	int i, err;
 
 	if (!ab8500) {
 		dev_err(&pdev->dev, "null mfd parent\n");
 		return -EINVAL;
 	}
+	pdata = dev_get_platdata(ab8500->dev);
 
 	/* register all regulators */
 	for (i = 0; i < ARRAY_SIZE(ab8500_regulator_info); i++) {
--


[ message continues ]
[view original message]
From: Mark Brown
Subject: Re: [patch] regulator/ab8500: move dereference below the check for NULL
Date: Saturday, August 14, 2010 - 2:36 am

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
--


[ message continues ]
[view original message]
From: Sundar R IYER
Subject: Re: [patch] regulator/ab8500: move dereference below the check for NULL
Date: Saturday, August 14, 2010 - 2:57 am

Thanx!

Regards,
Sundar
--


[ message continues ]
[view original message]
From: Liam Girdwood
Subject: Re: [patch] regulator/ab8500: move dereference below the check for NULL
Date: Saturday, August 14, 2010 - 4:15 am

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--


[ message continues ]
Previous thread: [patch] dma/shdma: move dereference below the NULL check by Dan Carpenter on Saturday, August 14, 2010 - 2:01 am. (2 messages)

Next thread: [PATCH] fix ARCH_IXP4XX compile error by FUJITA Tomonori on Saturday, August 14, 2010 - 2:30 am. (1 message)