Re: [PATCH 8/8] rbd: introduce rados block device (rbd), based on libceph

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Sage Weil
Date: Friday, August 13, 2010 - 8:29 pm

On Fri, 13 Aug 2010, Randy Dunlap wrote:

I see the problem: BLK_DEV_RBD and CEPH_FS both have 'select CEPH_LIB' and 
CEPH_LIB depends on INET and selects LIBCRC32C, but kconfig doesn't 
propagate those backward dependencies for you.  It looks like CEPH_FS and 
BLK_DEV_RBD should then depend on/select CEPH_LIB _and_ its dependencies.  
Patching that (and the BLOCK dependency) up now...

Unless there is a better way to do it?

Thanks!
sage


diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index 708104b..4a6e1b7 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -490,7 +490,10 @@ config BLK_DEV_HD
 
 config BLK_DEV_RBD
 	tristate "Rados block device (RBD)"
+	depends on INET && EXPERIMENTAL && BLOCK
 	select CEPH_LIB
+	select LIBCRC32C
+	select CRYPTO_AES
 	default n
 	help
 	  Say Y here if you want include the Rados block device, which stripes
diff --git a/fs/ceph/Kconfig b/fs/ceph/Kconfig
index 89f9718..73a7b31 100644
--- a/fs/ceph/Kconfig
+++ b/fs/ceph/Kconfig
@@ -1,9 +1,9 @@
 config CEPH_FS
         tristate "Ceph distributed file system (EXPERIMENTAL)"
 	depends on INET && EXPERIMENTAL
+	select CEPH_LIB
 	select LIBCRC32C
 	select CRYPTO_AES
-	select CEPH_LIB
 	default n
 	help
 	  Choose Y or M here to include support for mounting the
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 8/8] rbd: introduce rados block device (rbd), b ..., Sage Weil, (Fri Aug 13, 8:29 pm)