Re: [PATCH][EFI] Run EFI in physical mode

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eric W. Biederman
Date: Friday, August 13, 2010 - 3:19 pm

Takao Indoh <indou.takao@jp.fujitsu.com> writes:


Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

There is what appears to be unneeded redundancy (we need two
implementations of physciall calls into efi?), but that is confined to
the weird efi state.

It is a shame you haven't done the little bit extra to get
efi_pagetable_init working on x86_32.

Overall this seems sane and confined to the x86 efi, and it looks
like further improvements could easily be layered on top of this one.

Eric
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH][EFI] Run EFI in physical mode, Takao Indoh, (Fri Aug 13, 12:18 pm)
Re: [PATCH][EFI] Run EFI in physical mode, Eric W. Biederman, (Fri Aug 13, 3:19 pm)
Re: [PATCH][EFI] Run EFI in physical mode, H. Peter Anvin, (Fri Aug 13, 3:24 pm)
Re: [PATCH][EFI] Run EFI in physical mode, H. Peter Anvin, (Fri Aug 13, 3:28 pm)
RE: [PATCH][EFI] Run EFI in physical mode, Luck, Tony, (Fri Aug 13, 3:33 pm)
Re: [PATCH][EFI] Run EFI in physical mode, Eric W. Biederman, (Fri Aug 13, 4:11 pm)
Re: [PATCH][EFI] Run EFI in physical mode, H. Peter Anvin, (Fri Aug 13, 4:16 pm)
Re: [PATCH][EFI] Run EFI in physical mode, Tony Luck, (Fri Aug 13, 4:36 pm)
Re: [PATCH][EFI] Run EFI in physical mode, Simon Horman, (Sun Aug 15, 6:31 pm)
Re: [PATCH][EFI] Run EFI in physical mode, huang ying, (Sun Aug 15, 6:43 pm)
Re: [PATCH][EFI] Run EFI in physical mode, H. Peter Anvin, (Sun Aug 15, 8:27 pm)
Re: [PATCH][EFI] Run EFI in physical mode, huang ying, (Sun Aug 15, 9:58 pm)
Re: [PATCH][EFI] Run EFI in physical mode, H. Peter Anvin, (Sun Aug 15, 10:08 pm)
Re: [PATCH][EFI] Run EFI in physical mode, Takao Indoh, (Mon Aug 16, 12:30 pm)
Re: [PATCH][EFI] Run EFI in physical mode, Eric W. Biederman, (Mon Aug 16, 4:39 pm)
Re: [PATCH][EFI] Run EFI in physical mode, H. Peter Anvin, (Mon Aug 16, 4:54 pm)