Home » Mailing list archives » linux-kernel » 2010 » August » 13

Fwd: setlocalversion changes trigger regression if build scripts in git

Previous thread: [PATCH] ipc/shm.c: add RSS and swap size information to /proc/sysvipc/shm (v2) by Helge Deller on Friday, August 13, 2010 - 7:59 am. (1 message)

Next thread: Re: [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite by Alan Stern on Friday, August 13, 2010 - 8:15 am. (1 message)
[view original message]
From: Dan McGee
Subject: Fwd: setlocalversion changes trigger regression if build scripts in git
Date: Friday, August 13, 2010 - 8:00 am

commit 09155120cf0ffe6f0c8aba3aa625831405b65996
Author: Michal Marek <mmarek@suse.cz>
Date:   Thu Jun 17 15:14:58 2010 +0200

   kbuild: Clean up and speed up the localversion logic

This commit causes a regression if you have some of your kernel
building and packaging scripts in git. It can be triggered with
LOCALVERSION_AUTO being enabled or disabled. An example that hopefully
illustrates the situation. The source is simply an extracted tarball
with the 2.6.35.1 patch applied.

dmcgee@dublin ~/projects/eee/kernel-eee/src/linux-2.6.35 (master)
$ grep LOCALVERSION .config
CONFIG_LOCALVERSION="eee"
# CONFIG_LOCALVERSION_AUTO is not set
dmcgee@dublin ~/projects/eee/kernel-eee/src/linux-2.6.35 (master)
$ ./scripts/setlocalversion
eee+
dmcgee@dublin ~/projects/eee/kernel-eee/src/linux-2.6.35 (master)
$ cp -ar . /tmp/not-in-git
dmcgee@dublin ~/projects/eee/kernel-eee/src/linux-2.6.35 (master)
$ cd /tmp/foobar/
dmcgee@dublin /tmp/not-in-git
$ ./scripts/setlocalversion
eee

Note that when in git, you get the appended "+" sign. If
LOCALVERSION_AUTO is set, you will get something like
"eee-gb01b08c-dirty" (whereas the copy of the tree in /tmp still
returns "eee"). It doesn't matter whether the working tree is dirty or
clean.

Is there a way to disable this? I'm building from a clean tarball that
just happens to be unpacked inside a git repository. One would think
setting LOCALVERSION_AUTO to false would do it, but no such luck...

-Dan
--


[ message continues ]
Previous thread: [PATCH] ipc/shm.c: add RSS and swap size information to /proc/sysvipc/shm (v2) by Helge Deller on Friday, August 13, 2010 - 7:59 am. (1 message)

Next thread: Re: [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite by Alan Stern on Friday, August 13, 2010 - 8:15 am. (1 message)