Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work-on-i386.patch added to -mm tree

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: H. Peter Anvin

Subject: Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work-on-i386.patch added to -mm tree

Date: Wednesday, August 11, 2010 - 6:35 pm

On 08/11/2010 05:33 PM, Andrew Morton wrote:
quoted text> 
> Not very well.
> 
> +		rc = copy_from_user(&record_id, (void __user *)arg,
> +				    sizeof(u64));
> 
> better to use sizeof(record_id).
> 
> Where's Len??
> 
> Anyway, this should be fixed in x86 core, I suspect.

Agreed.  Looking at it now.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work- ..., Randy Dunlap, (Wed Aug 11, 4:43 pm)

Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work- ..., Andrew Morton, (Wed Aug 11, 5:33 pm)

Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work- ..., Huang Ying, (Wed Aug 11, 5:42 pm)

Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work- ..., H. Peter Anvin, (Wed Aug 11, 6:35 pm)

Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work- ..., H. Peter Anvin, (Wed Aug 11, 9:22 pm)

Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work- ..., Andrew Morton, (Wed Aug 11, 9:30 pm)

Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work- ..., H. Peter Anvin, (Wed Aug 11, 9:42 pm)

Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work- ..., H. Peter Anvin, (Wed Aug 11, 10:06 pm)

Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work- ..., Andrew Morton, (Wed Aug 11, 11:03 pm)

Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work- ..., H. Peter Anvin, (Wed Aug 11, 11:10 pm)


linux-kernel:
Adrian Bunk	[RFC: 2.6 patch] remove the broken SUN_AURORA driver
David Howells	Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp->msgq_txseq' may be un...
Francis Moreau	Re: Disk geometry from /sys
Eberhard Moenkeberg	Re: OT: character encodings (was: Linux 2.6.20-rc4)
Christoph Lameter	Re: [bug] SLUB + mm/slab.c boot crash in -rc9
git:
Mark Junker	git on MacOSX and files with decomposed utf-8 file names
Pat Thoyts	[PATCH] git-gui: use themed tk widgets with Tk 8.5
Michael Witten	Re: 'git gc --aggressive' effectively unusable
Lynn Lin	Re: clearcase migration to git
Petko Manolov	git and binary files
git-commits-head:
Linux Kernel Mailing List	[ARM] unconditionally define __virt_to_phys and __phys_to_virt
Linux Kernel Mailing List	ACPICA: Fix to allow zero-length ASL field declarations
Linux Kernel Mailing List	tracing: Simplify trace_option_write()
Linux Kernel Mailing List	ARM: Add Versatile Express SMP support
Linux Kernel Mailing List	ixgbe: fix automatic LRO/RSC settings for low latency
linux-netdev:
David Miller	Re: [PATCH 32/53] netns xfrm: finding policy in netns
William Allen Simpson	[net-next-2.6 PATCH v8 0/7] TCPCT part 1: cookie option exchange
David Miller	Re: [PATCH] IPv6: preferred lifetime of address not getting updated
Eric Dumazet	Re: [PATCH net-next-2.6] net: Introduce skb_orphan_try()
Mark McLoughlin	Re: [PATCH 2/3] virtio: fix delayed xmit of packet and freeing of old packets.
openbsd-misc:
Samuel Baldwin	Re: Forum engine
Robert	disklabel - cylinder rounding
nixlists	Re: Which laptops do the developers use?
Marcin	Re: 4.6 reboots x336 ibm server(s)
L. V. Lammert	OT, .. but has anyone seen a crontab editor