-----Original Message-----
From: Sam Ravnborg [mailto:sam@ravnborg.org] 
Sent: Wednesday, August 11, 2010 1:55 PM
To: Jacob Tanenbaum
Cc: linux@arm.linux.org.uk; linux-omap@vger.kernel.org;
linux-kernel@vger.kernel.org; rmk@arm.linux.org.uk; tony@atomide.com
Subject: Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM
andTORPEDO development kits

Hi Jacob.

Some quick comments.


Are the omap3_defconfig supposed to enable all omap board variants?
Otherwise leave this change out.

This is the default defconfig that enables most of the options

Some help would be beneficial.
URL's to product descriptions etc could be included there.
You may alos consider telling people this is a TI deriviate etc.


Fix this on the called site. There is zero reason
to sprinkle all user of omap2_gp_clockevent_set_gptimer()
with ifdef/endif.


Why do we have code that is not in use?

Taken out in the 4th patch made a mistake in rebasing 
Will fix
--

[ message continues ]

Hi Jacob.

Quick feedback!

You should teach your mailer better manners so it is

I noticed other users of omap2_gp_clockevent_set_gptimer()
does the same ifdef/endif.
You should take care of them when you have a proper way to do so.
Obviously in another patch.

	Sam
--

[ message continues ]