[PATCH 1/4] perf ui: Make SPACE work as PGDN in all browsers

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Arnaldo Carvalho de Melo
Date: Tuesday, August 10, 2010 - 2:53 pm

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Not just on the annotate one.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/ui/browser.c           |    1 +
 tools/perf/util/ui/browsers/annotate.c |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/ui/browser.c b/tools/perf/util/ui/browser.c
index edbb7dd..83d5748 100644
--- a/tools/perf/util/ui/browser.c
+++ b/tools/perf/util/ui/browser.c
@@ -169,6 +169,7 @@ int ui_browser__show(struct ui_browser *self, const char *title)
 	newtFormAddHotKey(self->form, NEWT_KEY_PGDN);
 	newtFormAddHotKey(self->form, NEWT_KEY_HOME);
 	newtFormAddHotKey(self->form, NEWT_KEY_END);
+	newtFormAddHotKey(self->form, ' ');
 	newtFormAddComponent(self->form, self->sb);
 	return 0;
 }
diff --git a/tools/perf/util/ui/browsers/annotate.c b/tools/perf/util/ui/browsers/annotate.c
index 763592b..d2156ae 100644
--- a/tools/perf/util/ui/browsers/annotate.c
+++ b/tools/perf/util/ui/browsers/annotate.c
@@ -178,7 +178,6 @@ int hist_entry__tui_annotate(struct hist_entry *self)
 
 	browser.b.width += 18; /* Percentage */
 	ui_browser__show(&browser.b, self->ms.sym->name);
-	newtFormAddHotKey(browser.b.form, ' ');
 	ret = ui_browser__run(&browser.b, &es);
 	newtFormDestroy(browser.b.form);
 	newtPopWindow();
-- 
1.6.2.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PULL 0/4] perf/core improvements, Arnaldo Carvalho de Melo, (Tue Aug 10, 2:53 pm)
[PATCH 1/4] perf ui: Make SPACE work as PGDN in all browsers, Arnaldo Carvalho de Melo, (Tue Aug 10, 2:53 pm)
[PATCH 2/4] perf annotate: Cycle thru sorted lines with sa ..., Arnaldo Carvalho de Melo, (Tue Aug 10, 2:53 pm)
[PATCH 3/4] perf ui browser: Add ui_browser__show counterp ..., Arnaldo Carvalho de Melo, (Tue Aug 10, 2:53 pm)
[PATCH 4/4] perf ui hist browser: Fixup key bindings, Arnaldo Carvalho de Melo, (Tue Aug 10, 2:53 pm)
Re: [GIT PULL 0/4] perf/core improvements, Ingo Molnar, (Tue Aug 10, 11:35 pm)